Commit Graph

409034 Commits

Author SHA1 Message Date
Stephan Bergmann
93d6a7ca51 Avoid -fsanitize=signed-integer-overflow
...in recently introduced basic/qa/basic_coverage/test_string_overflow_safe.vb
in CppunitTest_basic_macros

Change-Id: Ib33272afa26e90729617cb86ae979c0b35b45f62
2017-06-08 08:58:04 +02:00
Noel Grandin
0e2a6e8ea2 remove some unnecessary use of OUStringBuffer
Change-Id: Ia4e02589d2fe79a27b83200a0e7a528a2c806519
Reviewed-on: https://gerrit.libreoffice.org/38508
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-08 08:45:56 +02:00
Miklos Vajna
e3828e7bed oovbaapi: add Interior.PatternTintAndShade Property (Excel)
As documented at
<https://msdn.microsoft.com/en-us/library/office/ff192986.aspx>.

Change-Id: I390c22e75c8cfb41034287848f92578ad67e724f
Reviewed-on: https://gerrit.libreoffice.org/38524
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-08 08:06:47 +02:00
Miklos Vajna
d8a84e7df7 oovbaapi: add Interior.TintAndShade Property (Excel)
As documented at
<https://msdn.microsoft.com/en-us/library/office/ff197557.aspx>.

Change-Id: I4ffa74293978e4642e043a9cda80a7b4a9b5512c
Reviewed-on: https://gerrit.libreoffice.org/38523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-08 08:06:40 +02:00
Miklos Vajna
1365a9f95a oovbaapi: add XlThemeColor Enumeration (Excel)
As documented at
<https://msdn.microsoft.com/en-us/library/office/ff839402.aspx>.

And also extend ov::excel::XInterior with a ThemeColor property, as
documented at
<https://msdn.microsoft.com/en-us/library/office/ff820778.aspx>;
implementation is just a stub for now.

Change-Id: I05f1490cdc366f5db127d340cab5f51efcafa862
Reviewed-on: https://gerrit.libreoffice.org/38522
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-08 08:06:33 +02:00
Markus Mohrhard
4ec3a5e7c2 the custom target needs to depend on python
Change-Id: Ie9356a4922f7d01c674ec50bb30cd70e73469055
Reviewed-on: https://gerrit.libreoffice.org/38549
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-08 05:23:30 +02:00
Vasily Melenchuk
74d9b711d7 html import: kill ancient hack screwing up vertical table borders
HTML tables with border="1" were parsed and displayed incorrectly:
no vertical borders; invalid border width.

Also fixing problem with strange condition allowing setting right
border.

Change-Id: Ibe87e630ef9ef0a4352bbe659340f69c8ebc0d0d
Reviewed-on: https://gerrit.libreoffice.org/38454
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-08 03:39:34 +02:00
Justin Luth
cb444c17ca tdf#79571 sc FilterSelect: accept empty strings
If a drop-down list has a valid entry that is an empty string,
it should be acceptable as a data entry value, instead of just
ignoring it and leaving the old value in the cell.

Yes, the other simpler option is to just hit delete, but anyone using
the UI will get confused, and if not paying attention will have
incorrect data entry since it doesn't work as expected.

In the bug tested here, the selection dropdown was created with
data validation. Unsure of other times that create the grid...

Change-Id: I3b49c34d01079d4c1ec9e140e2c51123408b10a6
Reviewed-on: https://gerrit.libreoffice.org/38124
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-08 02:46:46 +02:00
Paul Trojahn
f1454b474d tdf#45904 Move java XCellSeries test to c++
Change-Id: Iedc1023b67138727061c2da13bebdb75af370ec6
Reviewed-on: https://gerrit.libreoffice.org/38105
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-08 02:45:54 +02:00
Markus Mohrhard
a87b001abd remove unused imports
Change-Id: I7efdbc1278d27ed75d8e48a35a9fac0358144214
Reviewed-on: https://gerrit.libreoffice.org/38548
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-08 02:24:04 +02:00
Jochen Nitschke
c9e08e1466 framework: remove unused macros
Change-Id: I10589a17b9c01998a54328ea290983de72067f5e
Reviewed-on: https://gerrit.libreoffice.org/38540
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-08 01:10:53 +02:00
Jochen Nitschke
442211903b framework: cleanup xserviceinfo.hxx includes
Change-Id: Ie5addc277fd47663726199dd7b94fb7299aa4d9c
Reviewed-on: https://gerrit.libreoffice.org/38539
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-08 01:10:32 +02:00
Jochen Nitschke
f95cb2841a framework: cleanup xinterface.hxx includes
Change-Id: I66b27e623e411c9ba9c5ba17c46c052336d031b8
Reviewed-on: https://gerrit.libreoffice.org/38503
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-08 01:10:13 +02:00
Markus Mohrhard
8af868e287 prepare publishing the libreoffice-connection python code
Change-Id: I730207465e185a0b942b5636cd7ba3bebe7856f5
2017-06-08 00:30:53 +02:00
Markus Mohrhard
839fd8215b fix memory leak and improve variable lifecycle
Change-Id: I88689f19d5a25e87a02d330ed4a3bc7d78dfdbe5
Reviewed-on: https://gerrit.libreoffice.org/38536
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-07 23:11:40 +02:00
Jaskaran Singh
631af1a5fa Add Test for dataprovider and modify the way we fetch and apply stream
Make FetchStreamFromURL::aBuffer a pointer to prevent the crash that
happens because of it.

Add ExternalDataMapper::StopImport() method.

Add a few member functions in CSVFetchThread that help in sync the
line fetch and writing.

Introduce a WriteToDoc() method that iterates over the the range to
apply whatever value or string needs to be applied.

Change-Id: I9baa053fa6d91bdf758a9b035888af50a40674eb
Reviewed-on: https://gerrit.libreoffice.org/32964
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-07 23:11:28 +02:00
Johnny_M
567fe6d351 Translate and fix the from-German translation of "UNO binding"
This is a follow-up on commit 905c0892a5
( https://gerrit.libreoffice.org/37917 ), for the same reason.

Change-Id: I0bdaeb1cf6d87f730558d15adb820cfbcaeed172
Reviewed-on: https://gerrit.libreoffice.org/38542
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-07 21:44:17 +02:00
Tor Lillqvist
30e27a9936 Take new FormulaTokenArrayPlainIterator into use in one more file
Change-Id: Ia2db1835e56d683769d8c3972fb0c73ba2eae2c6
2017-06-07 21:34:06 +03:00
Tor Lillqvist
2a29c792c2 Take new FormulaTokenArrayPlainIterator into use in one more file
Change-Id: I70988724367b0ee798ccfee35c94e280b1015b36
2017-06-07 21:34:06 +03:00
Tor Lillqvist
7f2fbc9215 Take new FormulaTokenArrayPlainIterator into use in one more file
Change-Id: I7134ce5c2d6d8fdc081410dcbc2b36c9db68839e
2017-06-07 21:34:06 +03:00
Tor Lillqvist
5b142483c1 Take new FormulaTokenArrayPlainIterator into use in one more file
Change-Id: I2d68513664200349574446e68efcfacda1604f86
2017-06-07 21:34:06 +03:00
Tor Lillqvist
1d0d7127db Take new FormulaTokenArrayPlainIterator into use in one more place
Change-Id: Id7f22d2d00e7c3ec79ec2dd886dce72be8692ac5
2017-06-07 21:34:05 +03:00
Tor Lillqvist
0505d3b22a Take new FormulaTokenArrayPlainIterator into use in one more place
Change-Id: I8af9204e93608d7f63a502ddcc0b05e6f191343f
2017-06-07 21:34:05 +03:00
Tor Lillqvist
468345765e Take new FormulaTokenArrayPlainIterator into use in one more place
Change-Id: Ieb807769c64d38d8100c6c4bf0e7a0a2913d8e7b
2017-06-07 21:34:05 +03:00
Tor Lillqvist
91a35c6a99 Take new FormulaTokenArrayPlainIterator into use in one more file
Change-Id: I5dfae10ec9df7e5b450c9a105ecc76c5d36970c3
2017-06-07 21:34:05 +03:00
Tor Lillqvist
74b1a89902 Take new FormulaTokenArrayPlainIterator into use in one more place
Change-Id: I53531cb2e0ecf5972cb6c016b4395ded66622e9a
2017-06-07 21:34:04 +03:00
Tor Lillqvist
60df53223b Take new FormulaTokenArrayPlainIterator into use in one more place
Change-Id: Idcbb0ebdf284568dc552c0edf5ae130ba7aaeafe
2017-06-07 21:34:04 +03:00
Tor Lillqvist
8f68e19356 Take new FormulaTokenArrayPlainIterator into use in a couple more places
Change-Id: Iaccbc7927943948136a56ba17f6bcff3a6971f31
2017-06-07 21:34:04 +03:00
Tor Lillqvist
1bb184b064 Take new FormulaTokenArrayPlainIterator into use in a couple more places
Change-Id: Ic1725c930bcb376a54acd9ba5d3dfd270d546cd8
2017-06-07 21:34:04 +03:00
Tor Lillqvist
0eefc9554b Take new FormulaTokenArrayPlainIterator into use in a couple more places
Change-Id: I49ddf780c0adee7123d985b1e343b8d248a46446
2017-06-07 21:34:03 +03:00
Tor Lillqvist
f01ff6b831 Take new FormulaTokenArrayPlainIterator into use in one more place
Change-Id: Idd92333d6c07748a2ae25f0124465d56b2302fbf
2017-06-07 21:34:03 +03:00
Tor Lillqvist
d08f91b9ac Take new FormulaTokenArrayPlainIterator into use in one more place
Change-Id: I22b57104cf603883b51bb0f16f2e71ede939f9f4
2017-06-07 21:34:03 +03:00
Tor Lillqvist
f1d4b0a9c8 Take new FormulaTokenArrayPlainIterator into use in one more place
Change-Id: I8c1ffdd725cc26f48722e09ba5c4d58551ce38a2
2017-06-07 21:34:02 +03:00
Tor Lillqvist
8b03c95958 Take new FormulaTokenArrayPlainIterator into use in one more place
Change-Id: Ia93b7759939bce42a4baf9ff55ec3c2b01840d9d
2017-06-07 21:34:02 +03:00
Tor Lillqvist
5abb8cc240 Take new FormulaTokenArrayPlainIterator into use in one simple place
Change-Id: Ib3e0b24ab2857a94ccce3efbac160b2d8dd910c7
2017-06-07 21:34:02 +03:00
Adolfo Jayme Barrientos
6ab249ea6a Updated core
Project: help  38734b7d4fc01bf584bc691370fc155d69ee50c9

Grammar: “let you to define” → “lets you define”

Change-Id: I93d9236704906fb91485610b85f7c694b7cc53e0
2017-06-07 19:21:26 +02:00
Miklos Vajna
0129c2cd9d Related: tdf#108269 DOCM filter: reuse oox code for VBA data preservation
Which means the DOCM-specific code to roundtrip VBA things (project,
data) can be removed. The oox part has to be extended a bit, as at least
for this DOCM bugdoc there is an XML relation of the binary data, while
existing shared code assumed the full VBA project is just a single OLE
blob.

Change-Id: I4085e4dba24475e6fd555e5f34fe7ad0f305c57d
Reviewed-on: https://gerrit.libreoffice.org/38504
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-06-07 19:08:20 +02:00
Gulsah Kose
57bdb06703 tdf#108098 Correct detection of MIXED state.
Change-Id: I212b908b8b7b2e8933dd5f923b0a2d8890bceed6
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/38310
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-07 18:36:20 +02:00
Michael Stahl
28d760e522 tdf#108305 sw: fix crash on fly "Position and Size"
Everything else in SwFrameShell::Execute() checks pArgs isn't null so do
the same here.

(regression from d02f75a8c3)

Change-Id: I73d85b111a5d2c088b9d888b8595ceb3979e8d2b
2017-06-07 17:49:39 +02:00
Michael Stahl
f9b665d969 configure: remove ENABLE_CRASHDUMP placeholder
It's called ENABLE_BREAKPAD now.

Change-Id: I757c4da415fb895d7cc24f13e201329111246367
2017-06-07 17:10:24 +02:00
Gulsah Kose
864f3d6d30 tdf#86119 Generalize number format control.
Change-Id: I3d657aee45533d4c2cafb0c6ea8aab7a77732d2d
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/38434
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-07 17:02:00 +02:00
Xisco Fauli
afb8a2f491 Fix uitest failure
It doesn't break for me locally

Change-Id: I61957fe4e7699937d17b74e8655efe2a6d1f6e6a
Reviewed-on: https://gerrit.libreoffice.org/38502
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2017-06-07 16:40:57 +02:00
Caolán McNamara
24d3d82411 remove some more qpw depends for the moment
Change-Id: Ia4a24d946921ec460a8fce567806e69372dad80a
2017-06-07 15:37:05 +01:00
Julien Nabet
39487b1495 tdf#37859: Odb data copied to Calc showed wrong encoding in Windows
Blind fix since I don't have Windows.
If it works, many thanks to:
- Urmas (see https://bugs.documentfoundation.org/show_bug.cgi?id=37859#c16)
- Himajin100000 (see https://bugs.documentfoundation.org/show_bug.cgi?id=37859#c35)

Change-Id: I9fd84977eab8410ec022b6e34f1a636326eaf56a
Reviewed-on: https://gerrit.libreoffice.org/38253
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-07 16:14:52 +02:00
Jens Carl
8b152f1aae tdf#39468 Translate German comments/terms
Translate German comments and terms in file
sw/source/filter/html/htmlforw.cxx

Change-Id: I5355b83c6068a7171fdac9d248c5fcf74b17e662
Reviewed-on: https://gerrit.libreoffice.org/38394
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-07 15:47:08 +02:00
Stephan Bergmann
681b4a49d7 external/graphite: Avoid -fsanitize=pointer-overflow
...that was recently introduced into Clang trunk with
<https://reviews.llvm.org/D33305> "[ubsan] Add a check for pointer overflow UB".

Here, _code is of type instr*, dist is of type ptrdiff_t, and sizeof(instr) is
something like 8.  My first impulse was to cast the result of the division (done
with arguments promoted to size_t) back to ptrdiff_t, but that wouldn't help:
When dist is a relatively small negative number (like
-3293184), the division expression will promote it to a large unsigned (size_t)
value (like 0xFFFF'FFFF'FFCD'C000), but the result (in our case,
0x1FFF'FFFF'FFF9'B800) would be small enough to fit into ptrdiff_t as a positive
value.  So assume that sizeof(instr) fits into int and ensure the division is
done on signed values.

(At least CppunitTest_sc_subsequent_filters_test started to fail with
"workdir/UnpackedTarball/graphite/src/inc/Code.h:165:15: runtime error: pointer
index expression with base 0x7fb90a3b4df0 overflowed to 0x7fb90a0a0df0".)

Change-Id: Ie6698e38d6abec80f2fa817c42ebf20618496109
2017-06-07 15:44:50 +02:00
Olivier Hallot
88d3c06783 Updated core
Project: help  0e7fce65904349f4d016592a68979f26e62c5bdd

Add screenshot to Pick-a-Color help page

fix grammar
Dialog -> window

Change-Id: Ie258bff777a51772f32e72ea0616f03e1351a833
Reviewed-on: https://gerrit.libreoffice.org/38236
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-06-07 15:16:49 +02:00
Varun Dhall
65f98346c2 EditEngine Creating SvXMLImportContext for ODF
Change-Id: I4083658db6068122b423fe5ec7a568fa222b4e80
Reviewed-on: https://gerrit.libreoffice.org/38358
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-07 14:50:04 +02:00
Varun Dhall
fec801d6d9 EditEngine Renamed InsertText to PasteText
The multiple overloads of InsertText cause pain in debugging

Change-Id: Icb5b40c23ae85e198d57f3054bc07a8c7eb05f55
Reviewed-on: https://gerrit.libreoffice.org/38286
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-07 14:49:43 +02:00
Varun Dhall
b863b1cb9c EditEngine Implementing Paste for XML from clipboard
Change-Id: Ia820a29bec8a6b102fb78cf325577b731a12c3c4
Reviewed-on: https://gerrit.libreoffice.org/38282
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-07 14:49:19 +02:00