Commit Graph

409034 Commits

Author SHA1 Message Date
Caolán McNamara
d8ea0efb03 coverity#1409892 silence Operands don't affect result
Change-Id: I283701880ea9e0a8485ef131afc93438c77451e1
2017-06-06 14:08:48 +01:00
Caolán McNamara
d97fba020b SID_ATTR_PATHGROUP isn't used anywhere, luckily
because it uses CONFIG_PATH_START + foo and all of the foo
strings are removed long ago, mostly since...

commit 35c86c4ad1
Date:   Wed Nov 3 08:57:12 2010 +0100

    undoapi: removed more dead resources

Change-Id: I2f2e34491de33ee4b0448f57eb458c182a41a64c
Reviewed-on: https://gerrit.libreoffice.org/38437
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-06 15:06:35 +02:00
Michael Meeks
7b91b815e9 White-list svx.
Change-Id: Idf3a17c7083e75ebd39887819bd230a913b8a0d5
2017-06-06 13:26:08 +01:00
Stephan Bergmann
7176800239 tdf#107231 Sort list of databases
Change-Id: I3271c205676de83ce3cad924b81e3b97ddb65f45
2017-06-06 14:25:05 +02:00
Caolán McNamara
d0069e5189 add COVERITY_NOEXCEPT_FALSE
to markup dtors that coverity warns might throw exceptions
which won't throw in practice, or where std::terminate is
an acceptable response if they do

Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4
Reviewed-on: https://gerrit.libreoffice.org/38318
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-06 14:15:43 +02:00
David Tardon
cc2db25645 libstaroffice: use correct loop index
Change-Id: I1b862ed2d69c41361bc8c26d96c5329473fe64aa
2017-06-06 14:13:00 +02:00
Justin Luth
707eb4db19 tdf#82173 writerfilter: charStyle XnoteReference->Xnote Characters
In MSWord, there is a single character style (Footnote Reference) that
affects both the in-text anchor number and the in-footnote number.
In Writer, that is split out into "Footnote anchor" for in-text and
"Footnote Characters" for in-footnote.

The biggest difference in LO is that Footnote Characters does NOT
default to superscript, while Footnote anchor does.
In order to handle the default situation, it is best to map
"Footnote Reference" to "Footnote Characters" so that the style
differences between the two will be removed. It seems
that WW8 also does the same thing.

The "regression" will come if someone has done custom formatting that
they prefer to show up in-text rather than in-footnote. Now it will be
reversed, where the custom formatting will show up in-footer and not
in-text. However, it is preferable to handle the default case and
"fix" the missing superscript problem.

(In WW8, the stiXnoteRef's are RES_POOLCHR_FOOTNOTE/ENDNOTE,
as mapped in sw/source/filter/ww8/writerwordglue.cxx,
which turns out to be "Xnote Characters" styles.)

Change-Id: I9152b4a85f6facf3f8192c943e66312988718b0d
Reviewed-on: https://gerrit.libreoffice.org/38306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-06 14:11:36 +02:00
Jens Carl
0c48e74732 tdf#39468 Translate German comments/terms in sw/source/filter/html/swhtml.cxx
Sixth set of translations.

Change-Id: I6ceaa1bd760028bebe26eb51a8bedf97238ed35c
Reviewed-on: https://gerrit.libreoffice.org/38397
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-06 14:10:35 +02:00
Miklos Vajna
1c768b9758 Related: tdf#108269 oox: ignore case when checking .docm extension
Also check for ".docm", not "docm" as a suffix.

Change-Id: Ib9d3474cfe3139ee1ea51210a5606cd52243fee5
Reviewed-on: https://gerrit.libreoffice.org/38430
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-06-06 14:09:02 +02:00
Johnny_M
c6f4fd1942 tdf#39468 Translate German comments and dbg strings (leftovers in h.. to i..)
Translates all (leftovers) found using a custom regex, in directories not shown by
/bin/find-german-comments and beginning with "h" to "i".

Additionally:
- Fixed a few spellings

Change-Id: I54ea06f8e0cf1bd4bd6c84b171bec1bd342a8df8
Reviewed-on: https://gerrit.libreoffice.org/38390
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-06 13:51:55 +02:00
Johnny_M
7f79316671 tdf#39674 Translate some German variable/function names
No functional change is intended.

Change-Id: Ib693d5f15bb279e8fe6771e3a64a976b53c6d13d
Reviewed-on: https://gerrit.libreoffice.org/38391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-06 13:48:24 +02:00
Caolán McNamara
097cb414ab pOldOuter etc couldn't be null
Change-Id: I0fb0168fa4199a21640e248ee3bb4b88608b1597
Reviewed-on: https://gerrit.libreoffice.org/38432
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-06 13:43:37 +02:00
Michael Stahl
9b50c4f63c scp2: package 64-bit MSVC runtimes for explorer extensions
... and add BUILD_X64 conditional.

Change-Id: Id512368dfd9dece583ead5aae1924db96f8a2a40
Reviewed-on: https://gerrit.libreoffice.org/38366
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-06 13:05:42 +02:00
Jean-Sebastien Bevilacqua
2a39dc7472 tdf#108259 Fix nested checkbox handling in autofilter popup
The regression breaks autofilter with hierarchy (date for example).

Commit id which introduces the regression 511fb8e80d

Change-Id: If15f32db6b8c1a90d96fefe9740173c2cbfb919a
Reviewed-on: https://gerrit.libreoffice.org/38343
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-06 12:23:11 +02:00
Vasily Melenchuk
a915f55c18 tdf#99680 unittest to ensure there are no empty clipping regions
Change-Id: Id4565858b0135b3177044558db87a68ef828955b
Reviewed-on: https://gerrit.libreoffice.org/38403
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-06 11:52:51 +02:00
Jochen Nitschke
2f5d1fc88f tdf#108287 perf regression changing background color
regression from commit 7c73c4605b
    tdf#48140 replace ApiCellRangeList in xlsx import (3)

also added two nitpicks: reuse reference and use simpler ScRange ctor

Change-Id: I8bda3932dd6c575e021e031ea0c14b6d9f253064
Reviewed-on: https://gerrit.libreoffice.org/38417
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-06 11:38:33 +02:00
Stephan Bergmann
35cd5805c3 One more test to suppress
Change-Id: I8ba67cc1d34ce25fe174887ab6cbca85e7ce8658
2017-06-06 11:35:30 +02:00
Miklos Vajna
b684f4e548 sw: prefix members of SwFootnoteBossFrame
Change-Id: I9e9b1eee71ced50a76cff8d641628e451e045030
Reviewed-on: https://gerrit.libreoffice.org/38428
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-06-06 11:31:30 +02:00
Stephan Bergmann
f239694560 Fix order of includes again
...after bfb978334c "osl: conditin.h and
conditin.hxx doxygen updates"

Change-Id: I63b6fefd2ed9a1c338e01f16c1efc1b6304103bc
2017-06-06 11:27:56 +02:00
Muhammet Kara
18cf495808 tdf#36019: Disable context menu entry for extension removal properly
When ExtensionSecurity::DisableExtensionRemoval is set in expert configurations,
context menu entry of 'remove' for installed extensions should also be
disabled along with the "Remove" button on the dialog.

Change-Id: I66e4a8aafbaa633ab5626844c8df9e036045cd09
Reviewed-on: https://gerrit.libreoffice.org/38283
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-06 10:37:48 +02:00
Noel Grandin
13f91bdc0c expand out FltError and eERR constants
they're just aliases for ErrCode and ERRCODE constants.
It's not like I can even convert them to an enum since the relevant
functions do not return only these constants, but also a variety of
other error constants.

This a cleanup commit prior to converting the ErrCode stuff to an
o3tl::strong_int

Change-Id: Ia9f506a24f6bd382d86b68e46bec36e4da7a4310
Reviewed-on: https://gerrit.libreoffice.org/38412
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-06 09:48:05 +02:00
Stephan Bergmann
fee8afc229 getBody() can be null for a defaulted dtor
Not sure why that started to pop up only now, maybe something changed with
recent Clang trunk.

Change-Id: Ib6587b66afbf3e43d92c78432c0bfd61c74ba6c5
2017-06-06 09:23:17 +02:00
Jochen Nitschke
16ce815df3 cppcheck: knownConditionTrueFalse
Change-Id: I231113eaf3117e13ed18de906e3787643abe9335
Reviewed-on: https://gerrit.libreoffice.org/38423
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-06 08:25:21 +02:00
Noel Grandin
e718817f0e simplify EasyFile::close
since it only ever returns one value - 0.

And once we've simplified all of those call-sites, we can do the same
thing to EasyFile::createFileName

Change-Id: I18dda80eb12cc6cf1c9ab0d3801084557e661dcc
Reviewed-on: https://gerrit.libreoffice.org/38413
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-06 08:16:55 +02:00
Noel Grandin
e4ffd93889 replace SCERR_NONE with ERRORCODE_NONE
since the first is #define'd to the second, and offers no extra value

Change-Id: I8268b4969ccdc090eeb8cd877e476bb32d2ddd1b
Reviewed-on: https://gerrit.libreoffice.org/38410
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-06 08:16:22 +02:00
Noel Grandin
86cefcf4df replace PRINTER_OK with ERRORCODE_NONE
since the first is #define'd to the second, and offers no extra value

Change-Id: Id3ce344e246d88b34d0e0fc2619da13f67587000
Reviewed-on: https://gerrit.libreoffice.org/38409
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-06 08:16:10 +02:00
Noel Grandin
de8caac6be replace SVSTREAM_OK with ERRCODE_NONE
since the first is #define'd to the second, and offers no extra value

Change-Id: I2c67e09ea3aa5361b8e7dfe7a20858c6ae054450
Reviewed-on: https://gerrit.libreoffice.org/38406
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-06 08:15:57 +02:00
Stephan Bergmann
690f2f5c46 Avoid loplugin:unreffun
Change-Id: I75ea46f257046bb42b2bfad3a5bd4450868e0d69
2017-06-06 08:04:06 +02:00
Kohei Yoshida
a078328e91 tdf#107945: prepare for future multi-threading of pivot cache...
It's disabled for now. We need to first make the edit engine and
a few other places thread-safe before we can parallelize this code.

Change-Id: Ie09536964ece42d43f505afc5e2611d469cc5c95
Reviewed-on: https://gerrit.libreoffice.org/38424
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-06-06 05:00:33 +02:00
Yousuf Philips
59c0682c46 tdf#94632 Enable sifr dark and set fallback
Change-Id: If77b33acf4f8d3e2e9c38b3e5ef359a1fc966910
Reviewed-on: https://gerrit.libreoffice.org/38387
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-06-06 04:26:33 +02:00
Olivier Hallot
200a566cf1 Updated core
Project: help  1ee48ef08e75e6e89b2f2166661d7fe97f60ba12

Improvement on help pages in browsers

Remove some debug info
Google search box in nice colors
Provision to place icons images in the right location

Change-Id: Ie3f33d52a48f3d8a60cbc4aaf89859a661538a8d
Reviewed-on: https://gerrit.libreoffice.org/38422
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-06-05 23:05:37 +02:00
Julien Nabet
f60603a2d7 typos
Change-Id: I3a28b5ce7464de724799997234925533d45f6121
Reviewed-on: https://gerrit.libreoffice.org/38420
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-05 21:29:27 +02:00
Stephan Bergmann
09f38f4df1 gb_SUPPRESS_TESTS to build tests but not run them
Change-Id: I390b97bbacfc123b952be2b54cf1333b4d5c24a7
2017-06-05 21:18:15 +02:00
Stephan Bergmann
2725f88465 Improved loplugin:cstylecast to reference types
Change-Id: Ie95ab6d588cfe40cc9748ce526b80d06fe825da5
2017-06-05 21:18:14 +02:00
Stephan Bergmann
3fdfbe68ba Improved loplugin:cstylecast to reference types: basic
Change-Id: Ib2159aef39d416905899fe91280d2234835e23e9
2017-06-05 21:18:14 +02:00
Stephan Bergmann
33451555e4 Improved loplugin:cstylecast to reference types: connectivity
Change-Id: I63c747efa2aacf4cb23de6fe9ab02af7abc107f9
2017-06-05 21:18:13 +02:00
Stephan Bergmann
7392e1326d Improved loplugin:cstylecast to reference types: cppuhelper
Change-Id: Id442b7a76072fb346d927a7dd8659a05bb491f9b
2017-06-05 21:18:13 +02:00
Stephan Bergmann
46baf01c24 Improved loplugin:cstylecast to reference types: cui
Change-Id: I3473b5d90b91f73e3bc30a7a7c6035f7de7657d6
2017-06-05 21:18:12 +02:00
Stephan Bergmann
f41eea8521 Improved loplugin:cstylecast to reference types: dbaccess
Change-Id: I298c4d8b8244488964ae1e63dabb8bf400c3fb32
2017-06-05 21:18:12 +02:00
Stephan Bergmann
256dfb9e78 Improved loplugin:cstylecast to reference types: editeng
Change-Id: I0a9321baf91ea0b460f4d1b6a638278275b184d3
2017-06-05 21:18:11 +02:00
Stephan Bergmann
c9e58c516e Improved loplugin:cstylecast to reference types: filter
Change-Id: I2db987556b4b4c7542edf40c7f839c2939e78e25
2017-06-05 21:18:10 +02:00
Stephan Bergmann
420a8de648 Improved loplugin:cstylecast to reference types: forms
Change-Id: Ide68579e892594875a5c38b3f62872d4eeae06cf
2017-06-05 21:18:09 +02:00
Stephan Bergmann
aed9c37e5a Improved loplugin:cstylecast to reference types: hwpfilter
Change-Id: Iab9d3845556b66341ca3298d6929502f50863f60
2017-06-05 21:18:08 +02:00
Stephan Bergmann
606dd77518 Improved loplugin:cstylecast to reference types: registry
Change-Id: I94070f7712604bcd4d118b94cb0f85e0146a9db1
2017-06-05 21:18:08 +02:00
Stephan Bergmann
ae75b0512f Improved loplugin:cstylecast to reference types: reportdesign
Change-Id: I63c951b4021db46d9cf6432dd56904a1b01a6c47
2017-06-05 21:18:07 +02:00
Stephan Bergmann
c03009c69d Improved loplugin:cstylecast to reference types: sc
Change-Id: I75bbb06a5dd7a458a8ddb605cd8d722b01da8f54
2017-06-05 21:18:06 +02:00
Stephan Bergmann
760cd5b67b Improved loplugin:cstylecast to reference types: sd
Change-Id: Icce4141f8aef688d85d219021606530839fb276f
2017-06-05 21:18:06 +02:00
Stephan Bergmann
03f2dbfabf Improved loplugin:cstylecast to reference types: sfx2
Change-Id: I0e5be42d78130c34e6ec39c32d463ed15d59b377
2017-06-05 21:18:05 +02:00
Stephan Bergmann
eaa689639f Improved loplugin:cstylecast to reference types: sot
Change-Id: I14135642998ef08dfb4aa4c7e10b327cf8d33de7
2017-06-05 21:18:05 +02:00
Stephan Bergmann
943a73ac84 Improved loplugin:cstylecast to reference types: stoc
Change-Id: I73909ff3bd5258d87d2a5f7d06d96ae447b13089
2017-06-05 21:18:04 +02:00