Commit Graph

337969 Commits

Author SHA1 Message Date
Caolán McNamara
cc79b16a75 ensure string accesses are in bounds
as demonstrated by ooo39541-3.rtf

Change-Id: I995f0250e98a68b1b56da877314c9fd24cf46221
2013-11-07 08:48:53 +00:00
Stephan Bergmann
eacb4a71ec Blind MSVC fix
Change-Id: I22c316cc82c40481fa1bf93412d97d67e1f95b41
2013-11-07 09:41:24 +01:00
Arnaud Versini
ebf5e56e20 Name threads for debug purpose
Change-Id: Id99ba394b898b7da0057d4a145ce8dce46122782
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-07 09:33:06 +01:00
Andrzej J.R. Hunt
117b24dbbd Add "New Database" button for Firebird file driver dialog.
Firebird is able to create new databases from within LO hence we need
to add a new property to database configration files.

This allows use of a db creation dialog (which is opened
by using the "New Database" button) in order to allow creating new
dialogs (in addition to being able to open existing databases using
the "Browse" button).

Conflicts:
	dbaccess/source/ui/dlg/ConnectionHelper.hxx

Change-Id: I6174f3b7d9032c48286b49b5ddf125cd3b428303
2013-11-07 08:15:27 +00:00
Andrzej J.R. Hunt
ee9bee5d46 $CPU no longer exists, use $CPUNAME for libatomic-ops.
Change-Id: Ic70214d5e875dc7672b5b9496f1d6a7d624d6ed6
2013-11-07 07:57:54 +00:00
Stephan Bergmann
e66d3da283 Use rtl::Reference
Change-Id: I7e3922ba635acdb14ca489bda2535a69249cb001
2013-11-07 08:19:21 +01:00
Andrzej J.R. Hunt
f479f62c14 Make libatomic_ops buildable and enable on non-X86.
Change-Id: Iec1d329f143ab76de7e8b4acd3da66efb6e0220c
Reviewed-on: https://gerrit.libreoffice.org/5812
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Reviewed-on: https://gerrit.libreoffice.org/6600
2013-11-07 01:05:55 -06:00
Noel Grandin
628a812db0 convert vcl/Edit::Impl* methods from xub_StrLen to sal_Int32
Change-Id: I009dd167d399d817689877a5e7e22dc4ab60ec61
2013-11-07 08:16:11 +02:00
Markus Mohrhard
95df39e382 we need to use ScDocumentImport for all calls
otherwise a reallocation of the cell vector will invalidate the
iterators for the position hint

e.g. fdo#35208-1.xls

Change-Id: I26e473c968633eb6e9cc3ecb1c8060105f5f47aa
2013-11-07 05:17:09 +01:00
Kohei Yoshida
7220b55f63 Correct reference count type.
Change-Id: Id7902c8d21d22a6d5f3740a6bd72e0c1213461e7
2013-11-06 20:56:46 -05:00
Kohei Yoshida
db65fff2aa Perform formula cell compilations in multiple threads during xlsx import.
One sheet per thread. Right now the thread count is set to 1 due to non
re-entrancy of a large portion of Calc core, and beyond. We need to fix
that first before setting the thread count to more than 1.

Change-Id: I6997c1e9540de939f1f00b1798e2b32059787ae5
2013-11-06 20:40:26 -05:00
Kohei Yoshida
1cefb146a8 Allow instantiation of more than one SvNumberFormatter from the document.
Change-Id: Ide6875e031268337bf6a21286176a38905c12691
2013-11-06 20:40:26 -05:00
Kohei Yoshida
db9a73d518 Allow non-pooled instance of SvNumberFormatter inside ScCompiler.
Change-Id: I645079254621c2f2684a69116b094e37e46f46f4
2013-11-06 20:40:26 -05:00
Kohei Yoshida
4efc5fa376 Protect those global symbols containers with mutex during initialization.
Change-Id: Id15b3e1a2bfebd2ea795fd412a259f125f5d9bab
2013-11-06 20:40:25 -05:00
Kohei Yoshida
88357ee6f4 Make TransformInput() a non-member function.
Change-Id: Ieb077b6ce661e2885d6010519f137235a048f9df
2013-11-06 20:40:25 -05:00
Kohei Yoshida
35a5999247 Guard cache access with mutex & a new method just to check for range name.
Change-Id: Id24b5ba72362f9d878b4878c1e807bed3e596b20
2013-11-06 20:40:25 -05:00
Kohei Yoshida
719c3fb46b Add mutex for external source document meta-data container.
These get updated from reference parser code (ScAddress, ScRange etc)
which may be run from multiple threads.

Change-Id: I5a1aaa4b51d9b9fb032458eb5e89f0652887184e
2013-11-06 20:40:25 -05:00
Kohei Yoshida
112fb38129 Make this method private as it is used only internally.
Change-Id: I752c9a6bcd7f5b057cd517a9630a975009d6fb0d
2013-11-06 20:40:24 -05:00
Kohei Yoshida
7d2619c9ad Set mutex for external ref cache content.
Change-Id: Id00c0e553e08740df8d9b7eef19407e1b0d3f022
2013-11-06 20:40:24 -05:00
Kohei Yoshida
29d1303e23 Use atomic increment and decrement for thread-safe reference count.
Change-Id: I630298b1c37a6d23c1aa17aabc1c9b2dcb48608a
2013-11-06 20:40:23 -05:00
Kohei Yoshida
1d996cee76 Keep the integer type in sync and remove unused data members.
Change-Id: Iaaf1ebddd3b946b3211952729d41b01f0967f374
2013-11-06 20:40:23 -05:00
Kohei Yoshida
7045802f27 Add mutex to guard the shared string pool content.
Change-Id: I0eb97d0fbeaefd8a1c86d240ed8bd7f208fb662e
2013-11-06 20:40:22 -05:00
Kohei Yoshida
9611851a53 Avoid using an extra buffer when the name doesn't contain double-quotes.
Change-Id: Idc76ccad114e5964f80c5a3c8c8da2a64c1a2b86
2013-11-06 20:40:22 -05:00
Kohei Yoshida
dd9b59ef18 Add new test for parsing OOo A1 style single references.
Change-Id: I7644338bd536d16777d330a64764eb26ecda5da5
2013-11-06 20:40:22 -05:00
Kohei Yoshida
eced6da745 Using OUStringBuffer is faster than chained += operator.
Change-Id: I9991028ddd8ab6e2e43fe9a19428c9fdfbd38db6
2013-11-06 20:40:22 -05:00
Kohei Yoshida
04532617c7 Avoid duplication of ScTokenArray during formula cell construction.
For slightly less overhead.

Change-Id: Ie5861d585d6e22fbd19dfd57edfebae4f4504839
2013-11-06 20:40:21 -05:00
Kohei Yoshida
a09f7fddb4 Modify ScFormulaCell's ctor to take a const reference to ScTokenArray.
Instead of a pointer to ScTokenArray, and then clone its instance.  If
the token array gets cloned in ctor, take a const reference.

Change-Id: I280fd7eb9eaea9905dbf954a1ace904ab0814dfe
2013-11-06 20:40:21 -05:00
Kohei Yoshida
df8257faf6 Check all call sites of CompileString() and make sure we don't leak.
We *were* leaking quite a bit.

Change-Id: I3f53eff22beab27b34a055a4452311f2e2f771db
2013-11-06 20:40:21 -05:00
Kohei Yoshida
55107688ea This method is now unused.
Change-Id: I22b1089ee99ad041d567fdac8714c2e7fa774056
2013-11-06 20:40:20 -05:00
Kohei Yoshida
7a3b8b1a5a Compile formulas using internal API directly...
rather than via UNO API which does triple conversion per formula expression.

Change-Id: Ib397c7976c06b98ce036caa7bfe2748e868299d9
2013-11-06 20:40:20 -05:00
Michael Stahl
518f404db7 installer: remove some special-casing of obsolete "common.pro" dirs
Change-Id: I8e79bb278759c3d6c5c782c6f2e0df8758e801c8
2013-11-07 01:34:45 +01:00
Michael Stahl
19b2933c6d installer: stop using PROEXT
Remove "productextension" from installer.

There is some "common" cruft here that needs more cleanup..

Change-Id: Ia4ef306009f0c4952792d096bb335f834b0f8262
2013-11-07 01:34:44 +01:00
Michael Stahl
eca3dec204 fdo#42783: remove CPU variable from environment
Replace uses with CPUNAME instead, and get rid of the horrible
postgresql patch that worked around environment leakage.

Change-Id: I38ccabfc438360524a272901bb9332ea708e274c
2013-11-07 01:34:43 +01:00
Michael Stahl
9487456637 configure: add vars for Solaris/SPARC64 (already checked in vcl)
Change-Id: Ic27986d8d45f61facedf2400b77334aaf1da7c1e
2013-11-07 01:34:42 +01:00
Michael Stahl
8c85ae050f configure: stop adding dmake location to PATH
Change-Id: I06c85f064a478ead6cecbe1c2d666ba3d947a177
2013-11-07 01:34:41 +01:00
Michael Stahl
fadadbdd35 remove unused gb_smoketest_instset
Change-Id: I73739639be5aac39e50cf6cbe6dc576f350d07fa
2013-11-07 01:34:41 +01:00
Michael Stahl
e832d717ec config_host.mk: remove unused use_shl_version
Change-Id: Ic829f1966cafa7c7680b95600ef071417ee9b9f7
2013-11-07 01:34:40 +01:00
Michael Stahl
323123337d configure: WORDS_BIGENDIAN is unused
Change-Id: I81b268d06c66860982b4d2443a1126e787f4190b
2013-11-07 01:34:39 +01:00
Michael Stahl
94d31d9ad1 vcl: WORDS_BIGENDIAN is never defined, use OSL_BIGENDIAN
Change-Id: I5186904b9703d6c9c49ca4c3b4a62f83423b1ae1
2013-11-07 01:34:38 +01:00
Michael Stahl
1e7f995214 configure: no need to put OSVERSION in environment
... since it's only used inside configure.

Change-Id: Iaf88239a5e8eb7215406b9948ca2599bd1468a8b
2013-11-07 01:34:37 +01:00
Michael Stahl
dc920c16de gbuild: add BUILDTOOLTRACE to debug build tools more easily
Can be set like the CPPUNITTRACE variable to run build tools in gdb when
they crash, like so (but beware that it will run _every_ build tool in
gdb...):

 make PARALLELISM=1 BUILDTOOLTRACE="gdb --args"

Change-Id: I64bd92f77c091c72cbabd07aa449882e78bdfc95
2013-11-07 01:34:36 +01:00
Michael Stahl
7a273a59f7 OUString::operator[] silence -Werror=strict-overflow warnings
GCC 4.8.2 warns when index is a subtraction expression; the real
problems in that case will be found by the "index >= 0" check.

Change-Id: Iac2796badf88b7bdf6c273ddb800a8af0d3eaa6a
2013-11-07 01:34:35 +01:00
Michael Stahl
b5aa7f71e6 OString::operator[]: make this consistent with OUString
Change-Id: If63362aba058bbcc0cc6bb1fae1c76005f1291d4
2013-11-07 01:34:35 +01:00
Michael Stahl
5effaa90f3 idl: fix out of bounds string accesses
Change-Id: Id0d07ff9bcd4858cb74458eaf13fb9386387f455
2013-11-07 01:34:34 +01:00
Michael Stahl
614e04019a codemaker: fix invalid string index access
Change-Id: Icca819484e751864d146a893fe78e8ef2c36363b
2013-11-07 01:34:33 +01:00
Michael Stahl
10dc66052a vcl: PPDParser: fix out of bounds string accesses
Change-Id: I1793a58fa107b190f8412bbc3376009f3b85c6b0
2013-11-07 01:34:32 +01:00
Michael Stahl
c98fc675df scp2: fix extra_fonts
Change-Id: I9fcb88dd50dbd0f4145bf83dea27e414e6fb3aff
2013-11-07 01:33:39 +01:00
Stephan Bergmann
107c2c7c7b Remove #ifdef TIMELOG'ed SAL_INFOs
...the code doesn't make much sense that way.

Change-Id: I506e37b44924701255431f6d20d4610f7f52287d
2013-11-06 20:55:58 +01:00
Andrzej J.R. Hunt
31fd531b27 Revert "Make libatomic_ops buildable and enable on non-X86."
(Pushed from wrong branch -- incomplete/broken.)

This reverts commit 0351eaf42f.
2013-11-06 19:41:30 +00:00
Andrzej J.R. Hunt
0351eaf42f Make libatomic_ops buildable and enable on non-X86.
Change-Id: I9423672b03caa4d500d44155bc47d4a8fa10c3cb
Reviewed-on: https://gerrit.libreoffice.org/5812
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
2013-11-06 13:20:34 -06:00