Commit Graph

411965 Commits

Author SHA1 Message Date
Stephan Bergmann
cda4cea7cd tdf#100501: Fix thinko
...in previous 52ffad9bb7 "tdf#100501: Adapt to
Java 9 (at least on Linux x86-64)"

Change-Id: I4d6bc31e0a7051a2657bb3d1ffc20c7a03d69038
2017-08-28 18:18:12 +02:00
Justin Luth
d21f67fa7f tdf#111895 writerfilter: avoid hiding shapes behind background
In MSO, page background is "in hell" zOrder, however
in LO, page background is at the same zOrder as the text,
so avoid hiding shapes behind the page background unless
doing so would hide text.

When importing gradients/pattern/hatch backgrounds are supported,
HasPageBackground will need to be expanded to include those as well.

Change-Id: I4496fd3f4c644ac9ac1854090658017078ce3e88
Reviewed-on: https://gerrit.libreoffice.org/41486
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-28 17:53:41 +02:00
Miklos Vajna
4b8214414b sw: prefix members of SwFootnoteFrame
Change-Id: Ie98687b331d6e7d99d4d3ee673dfc45bbc354ccc
Reviewed-on: https://gerrit.libreoffice.org/41615
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-28 17:48:39 +02:00
Michael Stahl
90b4225163 svx: fix assert in SdrEdgeObj::ConnectToNode()
When loading ooo68143-1.sxw we get an assert:

Assertion `!(bListeningAlready && !bPreventDuplicates) && "duplicate
listener, try building with DBG_UTIL to find the other insert site."'

The connector is connected to the same SdrObject on both ends:

<draw:connector ...
 draw:start-shape="id13" draw:start-glue-point="2"
 draw:end-shape="id13" draw:end-glue-point="2">

Change-Id: Ia0dd140b7c2ca948ace3fbf93d8c4abd4331399d
2017-08-28 17:30:11 +02:00
Caolán McNamara
efa8e32389 ofz#3160 Direct-leak
Change-Id: I6dcc35aaa06c2599a4524194e5e633cd4e36474e
Reviewed-on: https://gerrit.libreoffice.org/41634
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-28 16:58:12 +02:00
Caolán McNamara
474178acd1 ofz#3174 disallow header in header
Change-Id: I509fbfe5d7c319f0515896ecfca4183113eef764
Reviewed-on: https://gerrit.libreoffice.org/41635
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-28 16:57:48 +02:00
Stephan Bergmann
32e07ada19 Replace use of oslInterlockedCount with std::atomic, ORowSet::m_nInAppend
Change-Id: I9040034d358e1f32ab052b70185a77da82f29ee4
2017-08-28 15:49:36 +02:00
Stephan Bergmann
4ecc655587 Replace use of oslInterlockedCount with std::atomic in bridges
Change-Id: Iad47a01fd283345a2461eaaea50633bf840e5201
2017-08-28 15:47:32 +02:00
Stephan Bergmann
52ffad9bb7 tdf#100501: Adapt to Java 9 (at least on Linux x86-64)
Checking with both jdk-9+181_linux-x64_bin.tar.gz and
jre-9+181_linux-x64_bin.tar.gz as currently available at
<http://jdk.java.net/9/> "JDK 9 Early-Access Builds":

For one, make SunVersion::init understand <http://openjdk.java.net/jeps/223>
"JEP 223: New Version-String Scheme" at least insofar as to accept strings like
"9" with less than three dot-separated segments (where the missing segments are
treated like "0").

For another, at least for Linux x86-64, libjvm.so is now apparently located in a
path without an "amd64" architecture segment, "lib/server/libjvm.so".  (But
could that also be "client"?)  Other platforms may need further adjustments.

Change-Id: Idcebc833472c81a1dc74dcdd481b0a37274a8713
2017-08-28 15:43:31 +02:00
David Tardon
f33cf53c28 disable EPUB export test with system libepubgen
... because it tests mainly stuff that is not in any released version
yet.

Change-Id: I39503061e6d5b5116a83a5e299fb2de77a5e7e33
2017-08-28 14:54:38 +02:00
Noel Grandin
d23f1c3846 remove unused header file
ever since

    commit 678dbe8f81
    Date:   Thu Oct 13 09:50:03 2016 +0100
    unused src file

Change-Id: I648f5b22d6d717404ec14f7775dfa0502295c2eb
Reviewed-on: https://gerrit.libreoffice.org/41616
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-08-28 13:41:09 +02:00
Johnny_M
06c07c0dc1 Translate German comments/debug strings (leftovers in dirs starmath to sysui)
Translates leftovers found using a custom regex.

Additionally translated:
- One randomly found comment in /reportdesign
- Test strings in /stoc/test (let's see if it works)

Change-Id: I5f893c194c4b56b5365700928a3b8b63936d03e2
Reviewed-on: https://gerrit.libreoffice.org/41583
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-28 12:03:56 +02:00
Caolán McNamara
9bd3482c93 ofz#3092 Direct-leak
Change-Id: Ib10bd9bd2e6e712cb0a9c1906600543f786d7f53
Reviewed-on: https://gerrit.libreoffice.org/41618
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-28 11:20:20 +02:00
Stephan Bergmann
4e298b48d5 Consistently use oslInterlockedCount for SvImpLBox::s_nImageRefCount
Change-Id: I40eb4a09a8b5461fca4ac01662cb88156d2ff37d
2017-08-28 11:16:27 +02:00
Tor Lillqvist
5921306259 Log also the elapsed time of each zone, in milliseconds
Why not let the computer do it, instead of having to do it by eyeball?
It is not fun to look at numbers like 1503910660.06171 and
1503910665.5169 and try to see whether their difference is larger than
that of 1503910824.20391 and 1503910828.43125.

Change-Id: If20882e97959e65b8518b66c4ae965e1b3cc3b51
2017-08-28 12:08:05 +03:00
Dennis Francis
8c8edfabde tdf#62363: When pie chart sector is too small do "Outside" placement
...of its label when "Best fit" label placement setting is used.

Change-Id: Id201d922505de0e134286f4772abe282bb0722bc
Reviewed-on: https://gerrit.libreoffice.org/41572
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-28 10:43:03 +02:00
Juergen Funk
a4b88947e5 tdf#106931 - LibreOffice 5.3 installer doesn't honor UI_LANGS property
The patch 0a76a41ae7 disable the CustomAction
"SelectLanguage" when the MSI-Property ADDLOCAL is set,
This patch set the the CustomAction when the Property
"UI_LANGS" is set, then the CustomAction execute

Change-Id: I254a44909e32fb7969a6e9f71adf4659d376523c
Reviewed-on: https://gerrit.libreoffice.org/39379
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-28 10:26:37 +02:00
Miklos Vajna
c6c6a7091f libqxp: work around Android build
Till we can't switch to a proper standard C++ library there.

Change-Id: Ida62af07d9f843426d875f93c6795dc6cdecc303
2017-08-28 10:26:19 +02:00
Stephan Bergmann
8b63825dc2 Fix type of errno/WSAGetLastError()
...as got broken with 3d5be8cd31 "osl: give
warning on socket error (win32), move Flag definition (unx)"

Change-Id: Ib68540596b0bc2cda3e809e765c7d41ca45dda71
2017-08-28 10:17:35 +02:00
andreas kainz
722e3cee97 add icons to calc functions needed for grouped notebookbar
Change-Id: Iabfa0cd633570ff6a6f3116e73844e0c7badfc52
Reviewed-on: https://gerrit.libreoffice.org/41597
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-08-28 10:10:44 +02:00
David Tardon
2539d5b39a blind attempt to fix windows build error
Change-Id: I88b32543af58dc6f917348b19a0d0d3d50fc8ffe
2017-08-28 09:00:14 +02:00
Aleksas Pantechovskis
e59b5b1fc7 integrate libqxp
Change-Id: Ic7479b82d09c1e36d28267434a77bf4bc158adfa
Reviewed-on: https://gerrit.libreoffice.org/41612
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
2017-08-28 08:20:47 +02:00
Ashod Nakashian
c8777a1879 sw: don't undo paragraph signatures
Change-Id: I188ab9dfebd5abd24f4e404bda13d40be022b7c4
Reviewed-on: https://gerrit.libreoffice.org/41596
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28 06:02:48 +02:00
Ashod Nakashian
8d912300ad sw: insert paragraph signature field
Change-Id: Ibf062c19b9896841df765bc39716cddad8bc12f2
Reviewed-on: https://gerrit.libreoffice.org/41602
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28 05:01:16 +02:00
Ashod Nakashian
3daf54cb80 sw: validate paragraph signatures on load
Change-Id: I5ce2587d15c3f0d47cbc0f06e96246cf4dd984cb
Reviewed-on: https://gerrit.libreoffice.org/41595
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28 03:55:31 +02:00
Ashod Nakashian
af69465976 sw: remove signature metadata on deleting signature field
Change-Id: I1f82b2d59889c1ba84d91880df13d12d3e5b796c
Reviewed-on: https://gerrit.libreoffice.org/41594
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28 03:51:32 +02:00
Ashod Nakashian
2c3dfd9d3b sw: invalidate paragraph signature on edit
Change-Id: I7267b1492f2eff043058a9322286f742338a2335
Reviewed-on: https://gerrit.libreoffice.org/41593
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28 03:50:54 +02:00
Ashod Nakashian
3eb31b506a sw: sign paragraphs and validate
Change-Id: I917ad1460c89183eec38d50de8a0de2d76239ea6
Reviewed-on: https://gerrit.libreoffice.org/41592
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28 03:50:15 +02:00
Ashod Nakashian
6d8598acb2 svl: populate subject and date-time when verifying signature
Change-Id: I50eeabf3e18176cac383f48797daa771ee9dc7e4
Reviewed-on: https://gerrit.libreoffice.org/41591
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28 03:49:01 +02:00
Manfred Blume
9600f51797 fix tdf#112025 insert docx into existing document
Change-Id: I41f694bf3c2aa4edcad19a05d5dda6e87456d08f
Reviewed-on: https://gerrit.libreoffice.org/41469
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-08-28 00:48:59 +02:00
Chris Sherlock
e002de40ca osl: rearrange socket.h sections
Change-Id: I4a288699f2b313d7519554d7a66dc5f591c8767b
Reviewed-on: https://gerrit.libreoffice.org/41613
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-08-28 00:00:04 +02:00
Caolán McNamara
3c74c8be06 coverity#1416667 Unchecked dynamic_cast
Change-Id: I562f7b41da67b65609d3eb156f52e2fa0adc9fd4
Reviewed-on: https://gerrit.libreoffice.org/41604
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-27 21:44:08 +02:00
Caolán McNamara
7e134b66ec coverity#1416883 Useless call
Change-Id: Icf2dae3e69a84368a69f954276286483e3714aa0
Reviewed-on: https://gerrit.libreoffice.org/41605
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-27 21:43:05 +02:00
Caolán McNamara
6b8e3ab384 coverity#1416886 Unchecked dynamic_cast
Change-Id: I5a6a4ec99449d70d2dd812cf5520900e4d0d3d14
Reviewed-on: https://gerrit.libreoffice.org/41603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-27 21:42:41 +02:00
Noel Grandin
ae8e1ad2e3 convert code-class in ErrCode to scoped enum
Change-Id: I9aa8703921308d6fee8bae9ee2d7b29e19181cc7
Reviewed-on: https://gerrit.libreoffice.org/41601
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-27 21:24:16 +02:00
Chris Sherlock
d96b243c5d osl: cleanup osl_(acquire|release|close)Socket
Change-Id: Ifc0b88963bcd28e5709accdf892b2cb16b2b55eb
2017-08-28 05:09:04 +10:00
Ximeng Zu
218ea87508 [Android] Clean up util func with Calc dev
Removed redundant util functions addProperty
and twipToPixel in several Calc related classes.

Change-Id: I169be2edf74e662d5c3e3fcbd80265e9a694598d
Reviewed-on: https://gerrit.libreoffice.org/41372
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-08-27 20:37:26 +02:00
Chris Sherlock
534a156c16 osl: rename win32 socket internal function names
Change-Id: Ie58189e254f31d77cb4adafe599c48e64ef6a1a3
Reviewed-on: https://gerrit.libreoffice.org/41611
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-08-27 20:29:19 +02:00
Ximeng Zu
43f5161991 [Android Viewer] Password support
Added password support for documents.

Change-Id: Ifd9cf86894ddaf2fd5ad97510d2ac1b5850611ad
Reviewed-on: https://gerrit.libreoffice.org/40458
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-08-27 20:12:52 +02:00
Andrea Gelmini
c4bc382229 Fix typos
Change-Id: I3097ef16912f72b59f0759d8826068cbb9b00ec2
Reviewed-on: https://gerrit.libreoffice.org/41606
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-27 19:48:10 +02:00
Chris Sherlock
0876a6f05d osl: fix socket.h doxygen param
Change-Id: I4299433ec30ee5d102750b41e8cc6e82e4530a59
2017-08-28 03:39:59 +10:00
Chris Sherlock
3d5be8cd31 osl: give warning on socket error (win32), move Flag definition (unx)
Change-Id: I34b773f32a055dfe85ec9c42e72a9f51ee8fea10
Reviewed-on: https://gerrit.libreoffice.org/41610
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-08-27 19:38:39 +02:00
Chris Sherlock
bbf3da220e osl: remove commented out reversemap functions
Change-Id: I0354cf98ba3804505970e881dfff45a4d9a227da
Reviewed-on: https://gerrit.libreoffice.org/41609
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-08-27 18:10:33 +02:00
Chris Sherlock
8233349b6d osl: remove extraneous comment cruft from socket.cxx
Change-Id: I6979493a629874ab38629b655c47c299b24abdcd
Reviewed-on: https://gerrit.libreoffice.org/41608
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-08-27 18:09:31 +02:00
Rene Engelhard
2651df5a65 sccomp_lpsolver -> sccomp_solver
This test also tests the CoinMP solver, no _lpsolver is misleading

Change-Id: If56de3aa84ec80b1888aadeb940e08e65083c9e9
Reviewed-on: https://gerrit.libreoffice.org/41607
Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>
2017-08-27 17:33:41 +02:00
Caolán McNamara
20b7b15038 fix build
Change-Id: I6064cef802aac56e99b1bc053bd2612a87038e3d
2017-08-27 15:00:03 +01:00
Damjan Jovanovic
920b5ac7e8 If called on an empty collection, don't let OEnumerationByIndex.nextElement()
call XIndexAccess.getByIndex() with an invalid index, just like
OEnumerationByName.nextElement() doesn't.

Patch by: me

(cherry picked from commit efa52a41051df84e03fc38aaeae0f6312eb2df4c)

Change-Id: Id49e45c18ed00de499cfd93e0945cecaed788ae4
Reviewed-on: https://gerrit.libreoffice.org/41574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-27 15:00:39 +02:00
Noel Grandin
243c371b77 remove some unused svx error codes
which seem to be unused ever since initial import

Change-Id: I19460961876c73a0754c54b1a5c0ff8cc6311e4e
Reviewed-on: https://gerrit.libreoffice.org/41490
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-27 14:45:43 +02:00
Matteo Casalin
b312834555 OUString: constify, avoid unnecessary assignments
Change-Id: I697e19196b7d3ab9febafc05b07eb8c2aa218248
2017-08-27 14:10:52 +02:00
Matteo Casalin
9786bc48e3 OUString: reduce temporaries and constify
Change-Id: Ic4d5e26b16414625dfb507ecf37d87efe171ceab
2017-08-27 14:10:52 +02:00