Noel Grandin
ce3e78b6a0
java: dead code
...
Change-Id: Ief2bf7d3e98186a2268b873c4c5f7114057bd10f
2014-12-19 10:41:57 +02:00
Noel Grandin
35da4ec559
java: unused imports
...
Change-Id: I7866959b9ea36c81003259cd387a001e9f34f26a
2014-12-19 10:41:57 +02:00
Noel Grandin
e747737ad3
java: synching on an interned String object not good
...
Just remove this field altogether, it was not being used for
anything other than synchronisation.
Change-Id: I982385f9eb7aed3fff0adf85d2a37bfe003d937b
2014-12-19 10:41:56 +02:00
Noel Grandin
52d8444858
java: synching on a global object is not very useful
...
when you're using it as a local lock
Change-Id: Ie7f42176f7b582c6dad426d9f8eb0a846a3519c2
2014-12-19 10:41:56 +02:00
Noel Grandin
567592c9e2
java: don't synch on an object and also assign to it
...
Change-Id: Ie0a098e935e640f10b77d259c96bbd1c604d701e
2014-12-19 10:41:55 +02:00
Noel Grandin
41f4417ba4
java: dodgy synchronisation around clear
...
if we want to synchronize access to this datastructure, and we want
to use it as a lock object, creating a new one is not a good idea
Change-Id: I99c2f665242ef16611bc15a0690b8da222085efb
2014-12-19 10:41:55 +02:00
Noel Grandin
126eea88e6
java: nlpsolver: getPropertyByName was checking the wrong datastructure
...
Found by PMD
Change-Id: I76d38d71a3379416fe7e5078ef8b121915b26b6b
2014-12-19 10:41:55 +02:00
Noel Grandin
cba3956750
java: this does not need to be a Thread
...
It is just being used as a Runnable
Change-Id: I1e652ab0f3b0450d3a85384b9dd513419e2f8046
2014-12-19 10:41:54 +02:00
Noel Grandin
e92d3e9007
java: scripting: fix bug in removing model from map
...
found by PMD
Change-Id: I4bd35dd30f6c77aad96932216d8459b812004a88
2014-12-19 10:41:54 +02:00
Noel Grandin
3090d96f73
xmerge: store the original exception in the cause field properly
...
Change-Id: I154b8b80aabd824edc62a7fdd831074fcf5cb21b
2014-12-19 10:41:53 +02:00
Noel Grandin
a96c308e52
java: these fields can be converted to local variables
...
Change-Id: Ifefb5de196a3e5cbaa8945759da42886c69daacf
2014-12-19 10:41:53 +02:00
Miklos Vajna
0897aae2c7
android doc browser: hide Calc filter, add Draw filter
...
Hide Calc filter, as ATM Calc documents are not supported. Draw filter
was just missing, add it.
Change-Id: I88b9e48319e584f1c86de1b970badcdd695f30ed
2014-12-19 09:40:18 +01:00
Renato Ferreira
7524621ba4
Adjusted CppunitTest_sw_ooxmlexport for Mac Retina 13"
...
Change-Id: I208064aef57e0ef4b149183869f0908580e189f1
Reviewed-on: https://gerrit.libreoffice.org/13528
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk >
2014-12-19 08:36:44 +00:00
Miklos Vajna
9071c5070c
Factor out SwFmtCntnt::dumpAsXml() from nodedump
...
Change-Id: I6adcaa8534efefa474d489125d3fb95f150e3e89
2014-12-19 09:05:09 +01:00
Miklos Vajna
93bb210119
Let MetafileXmlDump::dumpAndParse() take a const GDIMetaFile
...
So the const_cast<> in CppunitTest_sw_uiwriter can go away.
Change-Id: Id7d4234154cd6bed43cb5270b50208061038dcf7
2014-12-19 09:05:09 +01:00
Stephan Bergmann
9c92897116
Blind attempt to fix PCH
...
...after 86ba184394
"Introduce
gb_*_set_external_code"
Change-Id: I6ed9652c6157b7cb2196f044f62c606968ef1807
2014-12-19 08:51:55 +01:00
Stephan Bergmann
27e76ead71
Consistently define plain string literals here, no OUStrings
...
cf. ef3fb92797
"svx: Use appropriate OUString
functions on string constants," 897f35006e
"fix
build," 3f66df9805
"Work around GCC bug"
Change-Id: Ifdfaad30cb59d54ac71bfe9347d29fb853551fd4
2014-12-19 08:43:02 +01:00
Noel Grandin
9315ccc397
remove operator>> methods
...
in favour of ReadXXX methods
Change-Id: I50a97c1855366dc14c6864da2fb91d1759d4d4db
2014-12-19 08:50:31 +02:00
Noel Grandin
ae5d78d605
remove operator>> and operator<< methods
...
in favour of ReadXXX/WriteXXX methods
Change-Id: I75fcb04cb9e2981a10146a96de27916ca7f6bc57
2014-12-19 08:50:30 +02:00
Noel Grandin
4cbba98601
remove operator>> and operator<< methods
...
in favour of ReadXXX/WriteXXX methods
Change-Id: I849fd10c689fb9834ae9974e430dc337adc68755
2014-12-19 08:50:29 +02:00
Michael Weghorn
a3181adc11
fdo#39468 translate German comments
...
Change-Id: I87ba3ac7aabbb297785eff5da6a5d498fdefd80c
Reviewed-on: https://gerrit.libreoffice.org/13534
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-19 06:40:42 +00:00
Christian Lohmaier
2116f1cfb3
libmspub depends on zlib
...
Change-Id: I3024693698f85ef1c2bbb7fb6ee968a0d5ba6359
2014-12-19 04:16:02 +01:00
Kohei Yoshida
b7e61384f1
Update mdds to 0.11.2.
...
Change-Id: I1c331863df2b1e560ba8a3d5b7dde67cce59b2df
2014-12-18 20:46:13 -05:00
Kohei Yoshida
62de3d17a1
Build fix for gcc 4.7.
...
Change-Id: I9b971928fa2737d21c225406bf2a86c088be5b9c
2014-12-18 20:46:06 -05:00
Michael Stahl
fc93c17a2e
sw: prefix SwTabFrm members
...
Change-Id: If2de38d23c5753e703517b5ef82d0f00070c2f34
2014-12-18 23:09:12 +01:00
Michael Stahl
8599b29b5c
sw: prefix SwRowFrm members
...
Change-Id: I262efe47d8a28d1462cf35314a99c4404ffa2200
2014-12-18 23:09:12 +01:00
Michael Stahl
217c09adcc
sw: prefix SwCellFrm members
...
Change-Id: Ia38bdf402595dc0b7e6dabd80a4e93e53142b719
2014-12-18 23:09:12 +01:00
Michael Stahl
ef342691eb
sw: prefix SwLayoutFrm members
...
Change-Id: If961ecfe27c6f478f030bab746278b885482b229
2014-12-18 23:09:11 +01:00
Michael Stahl
296e8b597c
fdo#87199: sw: fix root cause of a11y crash when merging cells
...
Commit f9eff2a402
is not quite right
because it will leave the mpNext chain unreachable; that could perhaps
be imporoved by calling RemoveFromLayout(), but...
Actually the problem is basically that one of the deleted SwCellFrms
points to a SwTableBox with getRowSpan() -1 (because it has been merged)
and thus IsInCoveredCell() returns true and that causes ~SwCellFrm() to
skip disposing the SwAccessible stuff, so the SwCellFrm is still
contained in the SwAccessibleMap.
Because it's rather hard to prevent this sort of thing in general,
better change SwAccessibleMap::Dispose() to assume that if it found its
way into the SwAccessibleMap it should be disposed and removed.
Change-Id: Ib4cec6924cb026ae30bdac6857957adf237b4d70
2014-12-18 23:09:11 +01:00
Michael Stahl
59c92736ab
sw: rename SwFrm::Remove to something unique
...
Change-Id: I4daf01450a4aa8f1d2bc6eae731a735d0d38a074
2014-12-18 23:09:11 +01:00
Stephan Bergmann
7e624c9820
Fix MSVC build
...
Change-Id: I64a9a2933b38e48c4531564ab4082e3c924c4959
2014-12-18 23:00:42 +01:00
Julien Nabet
24dab5d51a
cppcheck: Same expression on both sides of '||'
...
Change-Id: Ibdadac46483ca3b17a12e3d1ae31f75a869b8dbc
2014-12-18 21:58:55 +01:00
Eike Rathke
d249282d51
line-break that into something slightly more readable within 120 columns
...
Change-Id: I3b97cc4b0f108c0cc6e0aa1397cf6243b7c734b0
2014-12-18 21:56:40 +01:00
Jan Holesovsky
72ee6012b0
Typo: .uno:*TracedChange -> .uno:*TrackedChange.
...
Change-Id: I173728b9f800b6a9c6e81d496a268b4e42cf4db9
2014-12-18 21:50:09 +01:00
Jan Holesovsky
08e0a79aeb
spell dialog: Make [Close] work in protected documents with editable fields.
...
We have to call ToggleChildWindow directly; calling SfxDispatcher's Execute()
does not work here when we are in a document with protected section - in that
case, the cursor can move from the editable field to the protected area, and
the slots get disabled because of SW_DISABLE_ON_PROTECTED_CURSOR (see
FN_SPELL_GRAMMAR_DIALOG in .sdi).
Change-Id: I1c310c028aaaf774431d0b1e6bba10e901a8166d
2014-12-18 21:49:54 +01:00
Stephan Bergmann
7ac1522d9e
Fix MSVC build
...
Change-Id: I14f9b8e7b7e2cdcbdc60de17471b1a3a381d83f0
2014-12-18 21:42:31 +01:00
Julien Nabet
5a4c549d32
Some cppcheck cleanings: Prefer prefix ++/-- operators for non-primitive types
...
Change-Id: I899164412ad90653b4228423283f9fbd4cb5fccc
2014-12-18 21:14:10 +01:00
Eike Rathke
f2ac9fab26
fdo#68385 update references only if cut originates from the same document
...
Change-Id: Ia7b27309251cf9e47505c58d8ed0172d134280f4
2014-12-18 20:11:14 +01:00
Kohei Yoshida
64c479e9da
Unmap memory object right after the buffer is read.
...
Change-Id: Ic7c355dc005b8071a3b5db347f51882d89d2160f
2014-12-18 13:57:10 -05:00
Miklos Vajna
20f8006e21
fdo#87448 EnhancedCustomShape2d: fix handling of scaled ARCANGLETO commands
...
Change-Id: I7daf52a60e3fac8d9f86b464e86af60e0495fcb1
2014-12-18 19:28:19 +01:00
Miklos Vajna
4423637d4e
CppunitTest_sw_uiwriter: use gb_CppunitTest_use_rdb
...
I can't easily see what component is missing for SVM saving, and we do
the same in CppunitTest_sw_htmlimport already, so why bother.
Change-Id: Iba917e211fc721f8e275b3ce04a0e02c0759485b
2014-12-18 19:28:19 +01:00
Caolán McNamara
62e08e2230
Related: coverity#1202743 Bad bit shift operation
...
Change-Id: Ia2fe4abd17e09aecaef6d929dbd9b393f33c9de6
2014-12-18 17:11:17 +00:00
Stephan Bergmann
9de415945a
vcl: Use appropriate OUString functions on string constants
...
Change-Id: I169624820cd7d25eab18a6b90482e075ebfebcc6
2014-12-18 17:58:17 +01:00
Stephan Bergmann
11f2099904
test: Use appropriate OUString functions on string constants
...
Change-Id: Idbdc5c9aab8fa65df39d66da2461337db6350e52
2014-12-18 17:57:46 +01:00
Stephan Bergmann
09e071fddd
tools: Use appropriate OUString functions on string constants
...
Change-Id: Idbca92ee8d38fe5839ec0aeb8ee02af3e326549d
2014-12-18 17:36:14 +01:00
Stephan Bergmann
a349a4763f
loplugin:saloverride does not make sense for external code
...
...where SAL_OVERRIDE is not available
Change-Id: I49d447ba90516f4f744c21302607bff97ad3c4d5
2014-12-18 17:29:31 +01:00
Caolán McNamara
df35af4168
fix build
...
Change-Id: I920227cd175dace306ebb16a8e476f483cf11a7a
2014-12-18 16:00:58 +00:00
Juan Picca
82aa4dbd83
Fraction: rewrite 'GetDenominator()==0' conditions
...
Change-Id: Ie42972db98da48b60b3f5314e019046b2a2ee0e7
Reviewed-on: https://gerrit.libreoffice.org/12238
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-12-18 15:58:42 +00:00
Stephan Bergmann
3f66df9805
Work around GCC bug
...
Change-Id: Ib53fd467cb270908846f8f613d9f085aeccdff01
2014-12-18 16:55:34 +01:00
Stephan Bergmann
e17be13daa
Work around MSVC bug
...
Change-Id: I592eb027f4c13cf75f1f0a443696d4d4e8e50e04
2014-12-18 16:44:06 +01:00