Caolán McNamara
cf4159e16c
exception on div by 0
...
Change-Id: Id33d6a5e3df5812babd28ebfc65b95ce97219ad3
2015-07-16 10:25:20 +01:00
Matthew Pottage
091f6c3823
Removed singleton PropertyNameSupplier and replaced it with single function.
...
Measurements showed that the "optimisation" of caching PropertyIds and their
string equivalent leads to an increase of approx. 6 times in the total overall
time spent in PropertyNameSupplier::getName(eId), when running the unit tests.
PropertyNameSupplier was the only PropertyNameSupplier (no derived classes).
This means that getPropertyName can easily provide the same functionality.
Change-Id: I933b67c11d4cc35395a0c70e15f1c24ac9842ab0
Reviewed-on: https://gerrit.libreoffice.org/16665
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-16 09:11:55 +00:00
Stephan Bergmann
4439e5f689
loplugin:vclwidgets
...
Change-Id: I43f8530026261138585eb530b2bc83d3d9be704f
2015-07-16 10:54:10 +02:00
Stephan Bergmann
9edaebe651
Remove unused modelInvalid
...
Change-Id: I18701b367dcca36afb8e6f28645453294881683f
2015-07-16 10:52:54 +02:00
Stephan Bergmann
379e07eae7
-Werror,-Wunused-private-field
...
Change-Id: I16094fbe0f6455f373ae7ed300563a94df6436dc
2015-07-16 10:44:32 +02:00
Noel Grandin
7ab881a57d
loplugin:unusedmethods editeng
...
Change-Id: I15b2be5a9cd6e72447b674a65eabe9f89cb6ff12
Reviewed-on: https://gerrit.libreoffice.org/17115
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-16 08:37:25 +00:00
Stephan Bergmann
795ac5bc53
loplugin:stringconstant
...
Change-Id: I59da081fc90ffb96c438ed755266f5a69fbd199d
2015-07-16 10:29:46 +02:00
Stephan Bergmann
78d73a51bf
loplugin:vclwidgets
...
Change-Id: I8671f8540da2e86eedb4cdc7a248ebb1d6caa376
2015-07-16 10:29:46 +02:00
Stephan Bergmann
79dafc7af0
loplugin:simplifybool
...
Change-Id: Id079a6cc2841f42b0dc10ed2be596cc8f7db4e25
2015-07-16 10:29:45 +02:00
Stephan Bergmann
53bf91d66e
loplugin:passstuffbyref
...
Change-Id: I37c254bd1fdb3cfb05d513f87fa4f4a468466bb0
2015-07-16 10:29:45 +02:00
Stephan Bergmann
5e090212b1
-Werror,-Winconsistent-missing-override
...
Change-Id: I5f7ab4c7eb106fc7bc0d93abc78ab9168c6867a6
2015-07-16 10:29:45 +02:00
Michael Meeks
9e2e8bb5e6
tdf#92706 - avoid dbaccess wizard crash.
...
Hold a VclPtr on the window, make reset cleaner, and don't crash
removing listeners from disposed windows.
Change-Id: I3efb71117fc45562d5c740578f5e33dabb2684fe
Reviewed-on: https://gerrit.libreoffice.org/17037
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2015-07-16 08:21:45 +00:00
Stephan Bergmann
b3ade2609d
loplugin:cstylecast
...
Change-Id: I365b43f0327219f5ccd74984ec907088a8769785
2015-07-16 10:18:27 +02:00
Stephan Bergmann
c6d73d24a7
-Werror,-Wunused-private-field
...
Change-Id: I14e28c966a0d792eeaff9012616bd83de87f2abd
2015-07-16 10:15:30 +02:00
Stephan Bergmann
f1fbd6af4f
loplugin:stringconstant
...
Change-Id: Ifd9517672252cdbf4957cd23dbd9177aed8631da
2015-07-16 10:13:45 +02:00
Stephan Bergmann
21b8cb7ff4
loplugin:loopvartoosmall
...
Change-Id: Ia314ea7e924b2096c121d9cfda2c64e6d523a987
2015-07-16 10:13:14 +02:00
Stephan Bergmann
97a3ea0a2d
loplugin:saloverride
...
Change-Id: Ia3f3fbc7a0cd936b9cb6e89a15dd08fb4b73332e
2015-07-16 10:12:09 +02:00
Stephan Bergmann
109ca5b630
loplugin:loopvartoosmall
...
Change-Id: Iaeb3e12f9e83328c9ffd4718e7907bd7c7a39910
2015-07-16 10:11:22 +02:00
Stephan Bergmann
a9c4476cbb
loplugin:saloverride
...
Change-Id: Id6e434c0261dbba88b1ec1b98534e4f63db6dcda
2015-07-16 10:10:30 +02:00
Stephan Bergmann
ef6d7c50e0
loplugin:passstuffbyref
...
Change-Id: Iddd06dcc2bf4744ae9d70b54e4c58a9a468c1461
2015-07-16 10:09:57 +02:00
Stephan Bergmann
b65c6c84a2
loplugin:passstuffbyref
...
Change-Id: I61656dc160a716ddd2cdec2a630e6868703f4428
2015-07-16 10:08:51 +02:00
Stephan Bergmann
e373d3cd63
-Werror,-Winconsistent-missing-override
...
Change-Id: Ic26b03153d856f460a2e6c90b64a670541ec5af0
2015-07-16 10:06:26 +02:00
Stephan Bergmann
f013178f07
Remove unused SfxViewEventHint
...
Change-Id: I42200260b98f90978d2c214fd9ea77376ab8cd8d
2015-07-16 10:02:08 +02:00
Szymon Kłos
c09512c30b
question about overwriting the file only in the save mode
...
Change-Id: Iabb3bc12a8efae65a1c3d221a31c2214de8f6c90
2015-07-16 09:53:58 +02:00
Szymon Kłos
84e8159ada
FilePickerLastService as a string, not string-list 2
...
Change-Id: If100617ef968fde94178528327135e15f64c1542
2015-07-16 09:53:57 +02:00
Szymon Kłos
f587314d8d
FilePickerLastService as a string, not string-list
...
Change-Id: I7c379e797250be2f61791f5f3260d23ad24d26b3
2015-07-16 09:53:56 +02:00
Szymon Kłos
84d266fa83
RemoteFilesDialog: remember last used service
...
Change-Id: I494b1d43d28d8e6c37ce9d391b37580be6a9be31
2015-07-16 09:53:55 +02:00
Szymon Kłos
871d770378
Separators between services types
...
Change-Id: Ibd26abdb83b86256197311bc7a120b4b025ae814
2015-07-16 09:53:54 +02:00
Szymon Kłos
289eb8a70d
removed comment
...
Change-Id: Ia74226be5f7d0776d60f04945c23a5b94cdc11b6
2015-07-16 09:53:53 +02:00
Szymon Kłos
2239b486bf
RemoteFilesDialog moved to fpicker
...
Change-Id: I8e978d40ee022d15f482aec4567c3171b75b9720
2015-07-16 09:53:52 +02:00
Szymon Kłos
1abade4f92
moved the FolderTree class
...
Change-Id: I3231b32d3e3ade7dc3b366f03d6e189f5bc4d431
2015-07-16 09:53:50 +02:00
Szymon Kłos
1c25093f8a
tree settings moved inside class
...
Change-Id: I1cf0eb30f143e311a6a8c731f6dcc8e7ad7e4e5d
2015-07-16 09:53:49 +02:00
Szymon Kłos
1ccb11bc32
don't expand last url level in the tree
...
Change-Id: Iea4f650374921f1c50d8edeac384841113640d5e
2015-07-16 09:53:48 +02:00
Szymon Kłos
353a8cf59c
Open/Save button should be the default button
...
Change-Id: If2dc98beaff9cefcaf87be8773077524e2f5cb90
2015-07-16 09:53:47 +02:00
Szymon Kłos
35e3defe9a
Container should be disposed before childs
...
Change-Id: Ia6feb9c57ce574236e4763c61484fb5a14e55ff4
2015-07-16 09:53:46 +02:00
Szymon Kłos
0207ef8930
If user cancels authorization, don't show login dialog again
...
Change-Id: I4b110c041f1b8908fdfeeec3b4544f8607f23ddb
2015-07-16 09:53:46 +02:00
Szymon Kłos
bfbfdc95c6
PlaceEditDialog: only one error after failed auth
...
Change-Id: I215de03282b3692ebfdc6a7a0e9fd02ecc04f722
2015-07-16 09:53:45 +02:00
Szymon Kłos
331c1633b4
Check if OK button should be enabled after changing service type
...
Change-Id: I64ce981846f4107c8f38e413f1e6eb9e5616ef87
2015-07-16 09:53:44 +02:00
Szymon Kłos
d58582a6ce
Add prefix to the name after editing service
...
Change-Id: Icca2436e5a3782829971bf9e672bbddab81cc97f
2015-07-16 09:53:43 +02:00
Szymon Kłos
e211999cdf
PlaceEditDialog: Remember the repository id if wasn't changed
...
Change-Id: Ib5e63bec0b6b3c2d7d0dc2c114656737979ef6d0
2015-07-16 09:53:42 +02:00
Szymon Kłos
c7079800dd
RemoteFilesDialog: safe doubleclick on file view
...
Change-Id: I651c8274dfb2776e63c32f0b45d9daf57e5970c6
2015-07-16 09:53:41 +02:00
Szymon Kłos
31664660b2
RemoteFilesDialog: auto file extension in the save mode
...
Change-Id: I7b1dd5cc330de0c1ad713d68d93e7d12375033c6
2015-07-16 09:53:41 +02:00
Szymon Kłos
16ba8ede0a
RemoteFilesDialog: fixes needed for saving documents
...
Change-Id: I3134f82d81ed2c2de7d6197fbec5610b53814e1e
2015-07-16 09:53:40 +02:00
Szymon Kłos
2a6cec2caa
Default focus on filename field after selecting service
...
Change-Id: I1c1d2855925b3d04b18a0401156b0a8c6e38d8dd
2015-07-16 09:53:39 +02:00
Szymon Kłos
1fbe4809e0
RemoteFilesDialog: enable controls in one place
...
Change-Id: I21aab300a71c96308bc335ea4ac641f02ec2a4fc
2015-07-16 09:53:38 +02:00
Szymon Kłos
37928c2a5e
RemoteFilesDialog: enable OK button when file name isn't empty
...
Change-Id: Idf84d4d46a72c3fb339e28c1f3923cd2f0f3c12d
2015-07-16 09:53:37 +02:00
Szymon Kłos
6f694a6d3b
RemoteFilesDialog: set default filename in the save mode
...
Change-Id: I4739c101ac6b57e5c17e912515b1c8bccce33b68
2015-07-16 09:53:37 +02:00
Szymon Kłos
c984022706
RemoteFilesDialog: handled save button
...
Change-Id: Iec9129eac618d21370b8e5ecb331eb9518ecf082
2015-07-16 09:53:36 +02:00
Szymon Kłos
a26defa1e5
removed warning: 'Unknown item detected'
...
Change-Id: I36b2faca9205aba870aa993214d0c062ae4f83d9
2015-07-16 09:53:35 +02:00
Szymon Kłos
d9fcfef998
SaveAsRemote: corresponding dialog type
...
Change-Id: I5face9064bafc3c99b9a7af7809bd40a105b11bd
2015-07-16 09:53:35 +02:00