mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
350,631 Commits 1 Branch 0 Tags
cfddda092b0c105b5be7942a94cbbd88d55677f1
Commit Graph

115 Commits

Author SHA1 Message Date
Caolán McNamara
652c9faec7 coverity#708393 Uninitialized scalar field 
Change-Id: Ief5553eb76c09fe2ed2a05ab2b2f67d03837517e
 2014-04-10 21:07:57 +01:00
Stephan Bergmann
8f703221a0 Clean up function declarations and some unused functions 
Change-Id: Ic720aa7b30bbe56d67e0b65f3e047ad3ae521a97
 2014-04-10 11:24:39 +02:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Noel Grandin
13bc4094da svx: sal_Bool->bool 
Change-Id: I673d022c01b7d076120c026b236a37735b5043b0
 2014-03-14 07:50:32 +02:00
Andras Timar
360c7e573f fdo#71622 compress svg files in ODF 
Change-Id: I7d3bcff12a8f24d4d63851f578f9703bfaa25278
 2014-03-12 14:54:32 +01:00
Armin Le Grand
af63727b9f Resolves: #i15508# Added support for BMP file type 
(cherry picked from commit 9956ed1303545cd61901e33b110698c4e5e224c4)

Conflicts:
	filter/source/msfilter/escherex.cxx
	include/vcl/gfxlink.hxx
	svx/source/xml/xmlgrhlp.cxx
	sw/source/ui/docvw/romenu.cxx
	vcl/source/filter/graphicfilter.cxx

Change-Id: Ibcbb69b9c57cd8a438788e9a9c95744e99b6fcdd
 2014-02-27 19:30:40 +00:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Stephan Bergmann
973b47a336 unotools: sal_Bool -> bool 
Change-Id: I8051c0756e0474a5b4f748e0aa15a9922e82ea97
 2014-02-19 12:47:07 +01:00
Stephan Bergmann
0d957046f1 bool improvements 
Change-Id: Ic32faa81bfbb66a9d8632fb3db187e33c31188ed
 2014-01-28 20:26:17 +01:00
Jan Holesovsky
c2c530da69 Introduce static inline cppu::acquire(), and make use of that. 
This is much better approach compared to the callback function, as it allows
passing arguments to the c++ constructor directly, while still allowing some
additional initialization after having acquired the instance.

Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
 2014-01-22 15:09:28 +01:00
Jan Holesovsky
f278397787 Change _get_implementation()'s not to do initialization directly. 
Many of the initalizations (in eg. framework) have to be done on an
acquire()'d object, so instead of doing the initialization directly, return
the initialization member function back to the createInstance() /
createInstanceWithContext() / ... and perform the initialization there.

As a sideeffect, I belive the calling initialize() from servicemanager is not
that much a hack any more - whoever converts the implementation to be
constructor-base has the choice to provide the callback, or still initialize
through XInitialization, where the callback is preferred by servicemanager
when it exists.

Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
 2014-01-21 21:25:22 +01:00
Jan Holesovsky
306efefe22 Minimize the constructor functions to a bare minimum. 
Most of the constructors are supposed to be only a call of

  new TheInstance(arguments)

or an equivalent; so let's just change the constructor caller accordingly, to
accept unacquired new instance.

If there are exceptions that need to do more heavy lifting, they do not have
to use the constructor feature, or there can be a wrapper for the real
implementation, doing the additional work in their (C++) constructor.

Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
 2014-01-20 17:37:40 +01:00
Matúš Kukan
73eca35b0a Unify ctor functions for component implementations. 
There is no need to use different styles for writing the same thing.
It also makes it easier in future to use search & replace.
But of course, there are also some more complicated functions.

Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
 2014-01-18 17:02:40 +01:00
Matúš Kukan
a700ce8e2b Unify ctor functions to have _get_implementation suffix. 
Change-Id: I07fe0671d0633ef9480a4f3431df6a64c7902db8
 2014-01-15 15:12:01 +01:00
Matúš Kukan
4337a0664f Use const& arguments parameter for ctor functions. 
Change-Id: I19ce8bd1a23123ac9a62a7fc95cd54fea5315221
 2014-01-15 08:51:27 +01:00
Matúš Kukan
bdeb57c239 Initialize constructor based implementations in one place. 
Change-Id: I324f25bb5ec7d792c3e015815f2a11b08f519764
 2014-01-15 08:51:25 +01:00
Matúš Kukan
6d564bac02 svx: Use constructor feature for SvXMLGraphicImportExportHelper. 
Change-Id: Icc281ece80b81cdd95b6660c6a82077d283f5a62
 2013-12-31 13:25:47 +01:00
Matúš Kukan
09af884e7b Revert "svx: split into direct implementation getFactories" 
Also reverts "These services are in fact implemented in svxcore library."
This reverts commit 090674dcb0
and commit 4a969ac351.

This is embarrassing; needs more work.
 2013-12-20 22:58:29 +01:00
Matúš Kukan
4a969ac351 svx: split into direct implementation getFactories 
Change-Id: I888f10a923dc2b97247b2a66cc6bd116eee280a7
 2013-12-20 16:26:35 +01:00
Noel Grandin
6eac9deadd remove unnecessary RTL_CONSTASCII_STRINGPARAM in OUString::equalsL 
Convert code like this:
    if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aStr == "rem")
which compiles down to the same code.

Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
 2013-11-21 13:29:29 +02:00
Noel Grandin
d454834895 Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls" 
This reverts commit acebbee971.

I mistakenly converted OUString::equalsL calls to OUString::startsWith
calls.
 2013-11-20 16:38:28 +02:00
Noel Grandin
acebbee971 remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls 
Convert code like:
    if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aByteStr.startsWith("rem"))

Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
 2013-11-20 13:56:08 +02:00
Noel Grandin
1730df0127 remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::append 
Convert code like:
   aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") );
to:
   aOStringBuf.append( " is missing )" );
which compiles down to the same code.

Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
 2013-11-20 10:07:32 +02:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Marcos Paulo de Souza
2b01553fa5 fdo#54938: Convert svx to use cppu::supportsService 
Change-Id: I3ab178924cb1c4240511f08625f244dac54e3913
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-30 18:17:11 +01:00
Noel Grandin
9dc41e228d convert remnants of String in SVX to String 
Change-Id: I66fd6387c3fcd33c6ae0b431810abf6679345767
 2013-10-01 10:08:36 +02:00
Noel Grandin
b46236f54e convert svx/source/xml/*.cxx from String to OUString 
Change-Id: Id300414c0b34af4cc8c8a5cd49d1a17ba56f9b57
 2013-09-05 08:55:02 +02:00
Noel Grandin
447b92760d convert include/svx/xmlgrhlp.hxx from String to OUString 
also fix the string comparison in
  SvXMLGraphicHelper::ImplGetGraphicMimeType
which was previously comparing pointers.

Change-Id: Icd1e76bcf60ec3af5b10cb48adfc97548a2bf4f1
 2013-09-05 08:54:10 +02:00
Takeshi Abe
be8aee9158 Mark as const 
Change-Id: I24f04c541af1b93115781b4f4be4f01f137c481b
 2013-07-04 09:46:35 +09:00
Noel Grandin
95c0d568fd use uno::Reference#clear() method... 
...instead of assigning an empty value. Reduces code noise.

Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
 2013-06-05 08:13:23 +02:00
Takeshi Abe
550546a2fc sal_Bool to bool 
Change-Id: Ibaa2a843e16c22b6e2fb7e53da335b9b35b70a96
 2013-04-22 09:29:41 +09:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00
Julien Nabet
89789bfd53 Simplify iterators stuff 
Change-Id: I6cd97ea5056596122a8ae6cb0c5cd6525ce6b302
 2013-03-30 17:25:59 +01:00
Tor Lillqvist
2976b53ff8 Bin more pointless comments and ASCII graphics 
Suggested Easy Hack: Replace all instances of // -------- comments
including surrounding newlines with a single newline.

Another Easy Hack, slightly harder to automate: Remove all the
pointless comments that just tell the class name right before the
declaration of that class.

Change-Id: Ia890ed613b53c5d719988697e20a983d62334123
 2013-03-16 22:40:42 +02:00
Jan Holesovsky
0c22f3eadd Make LO buildable again after the GraphicFilter move. 
Change-Id: I3455a7294b136400f32163626d5a7a7f2bfa898c
 2013-01-04 22:02:51 +01:00
Michael Meeks
44cfc7cb65 re-base on ALv2 code. Includes (at least) relevant parts of: 
linecap: Reintegrating finished LineCap feature
    Patch contributed by Regina Henschel
    http://svn.apache.org/viewvc?view=revision&revision=1232507

    Patches contributed by Sven Jacobi
    impress212: #i81610# fixed animation export
    http://svn.apache.org/viewvc?view=revision&revision=1167620
    impress212: drawinglayer gbuild environment changes
    http://svn.apache.org/viewvc?view=revision&revision=1167627
    http://svn.apache.org/viewvc?view=revision&revision=1167628
    impress212: DffPropSet -> minor code improvements, removing table
    http://svn.apache.org/viewvc?view=revision&revision=1167634
    impress212: #158494# fixed excel import (text rotation)
    http://svn.apache.org/viewvc?view=revision&revision=1167638

    Patches contributed by Armin Le Grand
    Svg: Reintegrated Svg replacement from /branches/alg/svgreplavement
    http://svn.apache.org/viewvc?view=revision&revision=1220836
    #118728# changed indentifying definitions for Svg file detection
    http://svn.apache.org/viewvc?view=revision&revision=1229961
    #118838# LineGeometry creation for complicated cases optimized to
	create single Polygons
    http://svn.apache.org/viewvc?view=revision&revision=1236232
    #119176# corrected file type detection for SVG for svg files
	without xml header
    http://svn.apache.org/viewvc?view=revision&revision=1309445
    #118728# Extended Svg file detection
    http://svn.apache.org/viewvc?view=revision&revision=1230531
    #118529# solve break converters and convert commands for OLEs and images
    http://svn.apache.org/viewvc?view=revision&revision=1186168
    svg: added WaE changes from branch svgreplacement to trunc
    http://svn.apache.org/viewvc?view=revision&revision=1222974
    svg: corrected missing member initialization
    http://svn.apache.org/viewvc?view=revision&revision=1226134
    fix for #118525#: Using primitives for chart sub-geometry visualisation
    http://svn.apache.org/viewvc?view=revision&revision=1226879
    #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert
	metafiles to bitmapEx ...
    http://svn.apache.org/viewvc?view=revision&revision=1293316
    fix for #118525#: removed no longer used variable maOriginalMapMode, one
    more exception eliminated
    http://svn.apache.org/viewvc?view=revision&revision=1227097
    #16758# Added buffering to the VDev usages of the VclProcessor2D derivates...
    http://svn.apache.org/viewvc?view=revision&revision=1229521
    #116758# Secured VDev buffer device to Vcl deinit
    http://svn.apache.org/viewvc?view=revision&revision=1230574
    #116758# added remembering allocated VDevs for VDevBuffer to be able to also
    delete these when vcl goes down; it should never happen, but You never know
    http://svn.apache.org/viewvc?view=revision&revision=1230927
    #118730# Changed SvgClipPathNode to use MaskPrimitive2D for primitive
	representation instead of TransparencePrimitive2D
    http://svn.apache.org/viewvc?view=revision&revision=1231198
    #118822# secured 3D geometry creation (slices) by subdividing the 2D
    source polyPolygon early
    http://svn.apache.org/viewvc?view=revision&revision=1234749
    #118829# enhanced Svg gradient quality, obstacles avoided
    http://svn.apache.org/viewvc?view=revision&revision=1235361
    #118834# Unified usage of TextBreakupHelper as single tooling class
    for i18n text primitive breakup
    http://svn.apache.org/viewvc?view=revision&revision=1236110
    #118853# added square pixel size limit to conversion of
    TransparencePrimitive2D to Metafile action
    http://svn.apache.org/viewvc?view=revision&revision=1237656
    #118824# coreccted mirroring and boundrect when the graphicmanager
    is used for bitmap output
    http://svn.apache.org/viewvc?view=revision&revision=1240097
    #115092# Corrected VclProcessor2D::RenderPolygonStrokePrimitive2D for
    various optimization scenarios
    http://svn.apache.org/viewvc?view=revision&revision=1241434
    #118783# Corrected errors in ID strings, corrected Svg line/fill export,
    corrected polygon close state
    http://svn.apache.org/viewvc?view=revision&revision=1232006
    #118796# corrected null-pointer usage in SVG text exporter
    http://svn.apache.org/viewvc?view=revision&revision=1240262
    #118729# Use GraphicStreamUrl and GraphicUrl to allow multi image
    import with linked graphics, too
    http://svn.apache.org/viewvc?view=revision&revision=1229962
    #118898# corrected error in GDIMetaFile::GetBoundRect in handling
    MetaFloatTransparentAction
    http://svn.apache.org/viewvc?view=revision&revision=1293349
    #118855# Corrected handling of possibly created empty clipRegions
    after PolyPolygon clipping
    http://svn.apache.org/viewvc?view=revision&revision=1237725
	#115962# Better (but not yet optimal, see comments in task) handling
	of MetaFloatTransparentAction in PDF export
	http://svn.apache.org/viewvc?view=revision&revision=1241078
    IP clearance: #118466# This patch removes librsvg, libcroco, libgsf, ...
    http://svn.apache.org/viewvc?view=revision&revision=1200879
    118779# Added svg content streaming in/out to ImpGraphic stream operators
    http://svn.apache.org/viewvc?view=revision&revision=1231908
    linecap: correctons for WaE and mac drawing
    http://svn.apache.org/viewvc?view=revision&revision=1232793
    svg: uses current system Dpi for Svg replacement image creation
    http://svn.apache.org/viewvc?view=revision&revision=1233948

    Patches contributed by Mathias Bauer (and others)
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    http://svn.apache.org/viewvc?view=revision&revision=1396797
    http://svn.apache.org/viewvc?view=revision&revision=1397315
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    Remove duplicate header includes.
    cws mba34issues01: #i117720#: convert assertion into warning
    http://svn.apache.org/viewvc?view=revision&revision=1172352
    118485 - Styles for OLEs are not saved. Submitted by Armin Le Grand.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    cws mba34issues01: #i117714#: remove assertion
    http://svn.apache.org/viewvc?view=revision&revision=1172357

    Patch contributed by Jurgen Schmidt
    add some additional checks to ensure proper reading operations
    http://svn.apache.org/viewvc?view=revision&revision=1209022
    mostly prefer our stream / bounds checking work.

    Patches contributed by Herbert Duerr
    #i118816# add clarifying comment regarding Font::*Color*() methods
    http://svn.apache.org/viewvc?view=revision&revision=1233833
    extend macro->string handling for empty strings
    http://svn.apache.org/viewvc?view=revision&revision=1175801
    avoid magic constants for SALCOLOR_NONE
    http://svn.apache.org/viewvc?view=revision&revision=1177543
    initialize slant properly in ImplFontMetricData constructor (author=iorsh)
    http://svn.apache.org/viewvc?view=revision&revision=1177551
    #i118675# make check for extension updates more stable
    http://svn.apache.org/viewvc?view=revision&revision=1214797
    #a118617# remove VBasicEventListener.dll binary
    There are no known users depending on its CLSID
    http://svn.apache.org/viewvc?view=revision&revision=1203697

    Patches contributed by Ariel Constenla-Haile
    Fix build breaker on Linux/gcc
    http://svn.apache.org/viewvc?view=revision&revision=1221104
    Fix crash when trying to instantiate css.graphic.GraphicRasterizer_RSVG
    http://svn.apache.org/viewvc?view=revision&revision=1215559

    Patches contributed by Oliver-Rainer Wittmann
    sw34bf06: #i117962# - method <SwFlyFrm::IsPaint(..)> - consider
    instances of <SwFlyDrawObj>
    http://svn.apache.org/viewvc?view=revision&revision=1172120
    sw34bf06: #i117783# - Writer's implementation of XPagePrintable -
    apply print settings to new printing routines
    http://svn.apache.org/viewvc?view=revision&revision=1172115

    gnumake4 work variously from Hans-Joachim Lankenau
    http://svn.apache.org/viewvc?view=revision&revision=1397315
    http://svn.apache.org/viewvc?view=revision&revision=1396797
    http://svn.apache.org/viewvc?view=revision&revision=1396782
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    plus some amount of re-splitting of legacy headers.

    Patch contributed by Pavel Janik
    WaE: Remove unused variables.
    http://svn.apache.org/viewvc?view=revision&revision=1230697

    Patches contributed by Takashi Ono
    mingwport35: i#117795: MinGW port fix for vcl2gnumake
    http://svn.apache.org/viewvc?view=revision&revision=1172091
    mingwport35: i#117795: MinGW port fix for vcl2gnumake
    http://svn.apache.org/viewvc?view=revision&revision=1172091

    Patch contributed by Christian Lippka
    impress212: #i98044# re enable Text menu for outline and title shapes
    http://svn.apache.org/viewvc?view=revision&revision=1167639

    Patch contributed by Andre Fischer
    118674: Made category B code optional and disabled by default.
    http://svn.apache.org/viewvc?view=revision&revision=1215131
    118881: Ignore empty paragraphs after bullets.
    http://svn.apache.org/viewvc?view=revision&revision=1296205

    Patches contributed by Philipp Lohmann
    ooo340fixes: #i117780# use rtl allocator
    http://svn.apache.org/viewvc?view=revision&revision=1172087
    ooo34gsl02: #i117807# fix an off by one error (index actually
    inside the pfb section header)
    http://svn.apache.org/viewvc?view=revision&revision=1167576

various cleanups, related compilation fixes, warning cleanups, re-working
of obsolete stl template pieces to use boost instead, changed string
classes, re-adapt KDE about data, about dialog, fixing warnings,
and other fixes & improvements.
Disable svg import / render for about/ branding code-paths for now.
Restore full icon theme set.
Remove OS/2 conditionals and sources.
Remove conflicting gtk/full-screen monitors support.
Retain existing svg rasterizer files - temporarily disabled.
Standardize stringificaiton and fixup dllpostfix issues.
Rename SvgGradientHelper::== to equalTo to avoid overloading issues.
Use the flat GdiPlus API for LineCaps calls.
 2012-11-06 11:58:16 +00:00
Norbert Thiebaud
b854de954f deprecate oustringostreaminserter.hxx 
the intent of this header has canged over time. now it is already
systematically included with ustring.hxx and the operator overload it
provide fit nicely there...

Just to be safe, since that include as been added to the api during the
3.5 timeframe and therefore is already in 'production'
the header remain and simply attempt to include ustring.hxx
but a warning is issued indicating that this header should not be used
anymore... in a couple of major release we will thenr emove it completely

All internal users of that header are converted.

Change-Id: I8934c55f089e29d78c0f5649b7c87b2ecf024bad
Reviewed-on: https://gerrit.libreoffice.org/634
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2012-09-18 10:10:06 +00:00
Norbert Thiebaud
6d8cd96939 targeted string re-work 
Change-Id: I91a8a1410fc9a3a48b77f980c01b51bdacf6b02b
 2012-06-01 15:36:25 -05:00
Michael Meeks
6e6d81e9cf targetted SAL_N_ELEMENTS reversion. 
Change-Id: I30be93ccaeb1f9fd17cbe9e3ed3165e094810b2e
 2012-05-29 18:03:34 +01:00
Takeshi Abe
46dde25760 removed unused defines 2012-04-27 00:53:17 +09:00
Szabolcs Dezsi
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
Takeshi Abe
660e4481a4 Avoid temporary rtl::OUString 
in scripting / sdext / starmath / stoc / svtools / svx
 2012-02-28 01:55:00 +09:00
Michael Meeks
fdb9d721c1 revert slew of debug code committed in error 2012-02-22 14:25:33 +00:00
Greggory Hernandez
aff6db7024 fdo#37210 - UI: Calc usability improvement: Merge cells on right mouse click 2012-02-22 14:09:45 +00:00
Olivier Hallot
dc04d67e94 Fix for fdo43460 Part XXXVIII getLength() to isEmpty() 
Part XXXVIII
Modules
svx
 2012-01-14 12:11:48 -02:00
Caolán McNamara
ef17be8b00 Resolves: fdo#43867 collection of problems causing loss of ole2 previews 
a) factor out part of SvXMLEmbeddedObjectHelper::ImplGetStorageNames as
splitObjectURL to reuse in SvXMLGraphicHelper::ImplGetStreamNames to get better
url splitting logic to handle "./ObjectReplacements/foo"

b) FN_UNO_REPLACEMENT_GRAPHIC_URL and FN_UNO_GRAPHIC ids collide
urls incorrectly treated as graphics

c) imported preview images for objects set on a temporary
svt::EmbeddedObjectRef *copy* of the object, not the real object.
 2012-01-05 09:18:21 +00:00
Caolán McNamara
06580064d7 don't make it a secret what the invalid url was 2012-01-05 09:18:19 +00:00
Caolán McNamara
bacfd2dc4c add a comphelper::string::getTokenCount 
suitable for conversion from [Byte]String::GetTokenCount
converted low-hanging variants to rtl::O[UString]::getToken loops
added unit test
 2012-01-05 09:18:19 +00:00
Julien Nabet
eba2e6a9c3 Remove ByteString 2011-12-11 14:48:16 +01:00