Once the signing key is taken from the matching SfxViewShell (not yet
done), signing with a certificate specified via initializeForRendering()
failed with:
warn:xmlsecurity.xmlsec:13020:13005:xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx:330: X509Certificate_NssImpl::getPrivateKey() cannot find private key
warn:xmlsecurity.xmlsec:13020:13005:xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx:812: Can't get the private key from the certificate.
warn:xmlsecurity.xmlsec:13020:13005:xmlsecurity/source/xmlsec/errorcallback.cxx:53: keys.c:1347: xmlSecKeysMngrGetKey() '' '' 45 'details=NULL'
warn:xmlsecurity.xmlsec:13020:13005:xmlsecurity/source/xmlsec/errorcallback.cxx:53: xmldsig.c:822: xmlSecDSigCtxProcessKeyInfoNode() '' '' 45 'details=NULL'
warn:xmlsecurity.xmlsec:13020:13005:xmlsecurity/source/xmlsec/errorcallback.cxx:53: xmldsig.c:537: xmlSecDSigCtxProcessSignatureNode() '' 'xmlSecDSigCtxProcessKeyInfoNode' 1 ' '
warn:xmlsecurity.xmlsec:13020:13005:xmlsecurity/source/xmlsec/errorcallback.cxx:53: xmldsig.c:301: xmlSecDSigCtxSign() '' 'xmlSecDSigCtxProcessSignatureNode' 1 ' '
The trouble was that we wanted to keep the private key in-memory,
presumably because initially the whole NSS database was in-memory for
the LOK case. This was changed in commit
87eec1b90b (NSS: create a temporary
database instead of in-memory, 2018-12-31), so there is no problem with
a not-in-memory private key anymore.
Note that the problematic codepath was only triggered when first the
certificate chooser was ran and only then we signed. So the testcase
also gets the cert flags before signing, otherwise the test would
succeed even without the fix.
Change-Id: I5086b205c91b630ddd343c0eb91bd9e63b3ea238
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173892
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Added BColorModifierStack to SVG linear and radial
gradient direct support, was missing.
Change-Id: I1405ea0653180fa695b40082bf8b8520441d0620
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173871
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
I have stumbled over the GDB integration in vscode hanging
when there is a BP and *below* a declaration of e.g. a
basegfx::B2DPolygon. This seems to happen due to the
instance not yet being incarnated, but the variable view
already listing it and triggering methods in basegfx.py
to evalualte stuff.
It just hangs/loops, I guess it's fetching the PointCount
from a random mem ptr'ed Polygon, then tries to evaluate
something with the Points.
I do not really know about what to do here, but I figured
out that testing 'if self.exists()' where the instance
gets accessed (using gdb.parse_and_eval) helps.
Thus this solves the problem for me and - after stepping
over the incarnation of the object I can see it's true
content.
I hope someone who might have more knowledge about that
GDB and python stuff can have a look and maybe tell if
tis is OK or should be done in a different way.
Change-Id: Ia844b0aded97220df7f4605fdcffeac5e2270db3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173826
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Tested-by: Jenkins
When moving to the left, the RowInfo may have e.g. cells 21 to 41,
and rParam.mnX may be 15, which is outside of the RowInfo data.
It seems that in this case, when we handle the data outside of
the visible area, setting clip marks may be safely skipped anyway.
Change-Id: I2f507dc166468c44e34645bc34c827456f1ab1ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173857
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Small tweak to the kashida insertion rules to restore some previous
behavior. Kashida should not be inserted after a final Yeh, but should
be inserted after an initial or medial Seen, even if it is followed by a
final Yeh.
Change-Id: I1fef2d32961c6f55006b2df456827588f62af40b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173889
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tested-by: Jenkins
This change partially reverts the fix for tdf#65344, to allow more
candidate kashida insertion positions.
The final position fallback from the original ruleset has been restored.
Instead, tdf#65344 is now fixed by explicitly prohibiting kashida under
a final-position Yeh.
Change-Id: I9fe8c656768777c160205ad9892f2fe916a2a926
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173887
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tihs change updates Writer kashida justification to include some
whitespace expansion, mirroring the behavior of Edit Engine and other
word processor programs.
Each kashida and space character are given 1 unit each of extra space.
Change-Id: I8c9031a0d51844e532b9d1f7e3619c2c9ba23f6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173884
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
The field command "TOC \n 2-2" means that
level 2 entries should not display the page number,
so in LO just exclude those portions from the definitions.
The impact only becomes noticable when you update the TOC,
because the initial content is just read from document.xml.
The export part was already handled at LO initial import,
since DOC format needed the proper sFieldCmd string.
DOC format already imports this just fine.
Note that the unit test also specifies 'TOC \o "2-3"'
which means that the first level should not show,
but I don't think LO supports skipping earlier levels.
make CppunitTest_sw_ooxmlexport10 \
CPPUNIT_TEST_NAME=testTdf162916_nastyTOC
Change-Id: I9661c56c84bcd28bf1664d808a0e9c38051cf67b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173885
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
The kashida candidate position selection logic was copied-and-pasted
from Writer into Edit Engine. This change consolidates the shared code
into a library. This change also adds some minimal characteristic tests,
which previously did not exist.
Change-Id: I2bfbfa79858347803474b754566436f3e74d1a54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173883
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tested-by: Jenkins
Starting in macOS Sonoma, a warning is printed at launch that complains
that -[NSApplicationDelegate applicationSupportsSecureRestorableState:]
is not implemented so implement that selector.
Change-Id: Idfb62c271af5256270361efdd458f2ef9ea4c40b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173882
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
This enhancement patch for the quick find panel makes the document
order index of the match entry selected in the finds list be shown in
the found times label at the bottom of the panel. For example,
selecting the 6th entry in the finds list for a search that has 25
matches will display "Match 6 of 25 matches."
Change-Id: Iea39e754b0cd75d3ca446781a4b8d2e8651e7d08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173835
Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
This changes the rendering of the main slide layer content to also
render the master page and the background. This is needed because
of the issue with the white background (instead of transaprent).
(cherry picked from commit 99f9d663a26da00bebd8595f1e0819ebc6c3e4f0)
Change-Id: I88b6f0287482ad1ee498b0bbda8e19d015649879
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173853
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
otherwise, the pointer calculations mean that we will start searching
inside data that does not belong to the character array.
which flushes out a couple of problem cases
Change-Id: Ide9edf23900289343077c406d95614057c1d1a6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173807
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
In case signing certificate would be stored in the model (like it
happens on the desktop), then the certificate viewer would show all
signing certs of the currently editing users, which is far from
expected.
At the same time, there is just one NSS database per process, so it's
hard to not have them in the same database.
Fix the problem by storing a reference to the signing key in the view
shell, then we can show only that in xmlsecurity/ in LOK mode, and thing
else.
This is just the sfx2/ side of things, the xmlsecurity/ part still needs
implementing.
Change-Id: Id7a56f28598ec60217c6bac095c2ff350f39bc3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173837
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
* The change in schema/odf1.4/OpenDocument-v1.4-schema.rng
is the same as 56d8007a19
"tdf#134734 tdf#141059 tdf#122508 cui,sw,xmloff: BackgroundFullSize"
Change-Id: I79bdebbee4d250af9c5822bf2f205ef386f1b97d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172392
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
