Commit Graph

423135 Commits

Author SHA1 Message Date
andreas kainz
dd84c23bf6 Colibre: Hamburger icon for NB is now well aligned
Change-Id: Ie6ef7f2ca68b9f158e166a62b9cec8adfc91f006
Reviewed-on: https://gerrit.libreoffice.org/54376
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-05-15 17:42:49 +02:00
Tomaž Vajngerl
3c6b0eb0f1 tdf#117427 need to check originURL when ReRead is called
Previously we checked the originURL of Graphic for SwGrfNode in
constructor which then called ReRead. This is OK for linked
graphic when they are loaded from the document, but when we change
the Graphic through API, only the ReRead method is called. So to
get this to work we need to move checking of originURL into the
ReRead method.

Change-Id: Iaa4a332459baab656740ff209b997c48b7287e16
Reviewed-on: https://gerrit.libreoffice.org/54362
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-15 17:30:59 +02:00
andreas kainz
92ca8dfeb3 NB Implementations: update for better maintenance and sync
Change-Id: I024d597f218824d8618d113a5aaae2fd314ec807
Reviewed-on: https://gerrit.libreoffice.org/54367
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-05-15 17:29:24 +02:00
Zdeněk Crhonek
e29eacbb6a Calc -print range + tdf#33341
Change-Id: I486dd0cffb4173530ee78d3971865df3bac2818b
Reviewed-on: https://gerrit.libreoffice.org/54341
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-15 16:56:59 +02:00
Rene Engelhard
fe4bc1c09d CppunitTest_svl_qa_cppunit: fix system-libnumbertext build
libnumbertext_numbertext package doesn't exist...

Change-Id: I5fc7c9c2386c10a10f2980655292ab12beb1a977
2018-05-15 16:24:43 +02:00
Samuel Mehrbrodt
86e8cfdd54 Sign Signature Line
This adds a new context menu entry "Sign Signature Line" to signature lines.
You can directly sign the document from there.

Still missing is the updating of the graphic to reflect the valid/invalid
signature state.

Change-Id: Ib8bc8c57f9d5370a10e379f86f9e41e57c715e3f
Reviewed-on: https://gerrit.libreoffice.org/53778
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-15 16:16:22 +02:00
Noel Grandin
863d2485e6 loplugin:useuniqueptr in ParagraphList
Change-Id: I042fb945b0585a0409d76a509c7f9287aa220b68
Reviewed-on: https://gerrit.libreoffice.org/54180
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-15 15:56:14 +02:00
Rene Engelhard
9411936399 fix build
Change-Id: I71238209b4819f256045487f1db83d79f6fe49ba
2018-05-15 14:51:01 +02:00
Eike Rathke
fb34539769 Guard static variables, tdf#115007 tdf#117171 follow-up
Change-Id: Ib8f73ceefb8278b6233d46d86a34a3869622239f
2018-05-15 14:35:27 +02:00
Caolán McNamara
9aff7f3c49 weld ScSolverNoSolutionDialog
Change-Id: I403e39e0f5cd642c5996a49f50cc7ee7bbdfbd02
Reviewed-on: https://gerrit.libreoffice.org/54354
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 13:45:20 +02:00
Caolán McNamara
932c96e158 weld ScSolverSuccessDialog
Change-Id: I29bf7b59fbac8f969e5a61963d65b626ac03b0fa
Reviewed-on: https://gerrit.libreoffice.org/54355
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 13:25:31 +02:00
Caolán McNamara
5f170e6972 weld WPFTEncodingDialog
and pass in parent window for dialog

Change-Id: Ibe9f576a74dfbbee3e568c8d3454440700cb0405
Reviewed-on: https://gerrit.libreoffice.org/54328
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 13:05:35 +02:00
Caolán McNamara
d15c240434 OSL_ENSURE->assert
Change-Id: I6b93a221bc00fd92ef01135727c7e50560fb4517
Reviewed-on: https://gerrit.libreoffice.org/54357
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 12:55:40 +02:00
Caolán McNamara
a09888adcd weld ScSolverIntegerDialog
Change-Id: I4d7196ead0dd60fe4b40af72a1c7ec64c5a2315a
Reviewed-on: https://gerrit.libreoffice.org/54352
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 12:53:00 +02:00
Caolán McNamara
f7048e9b79 weld ScColOrRowDlg
Change-Id: I475974fc54910da88064779ceae6586bd71a3865
Reviewed-on: https://gerrit.libreoffice.org/54356
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 12:46:28 +02:00
Caolán McNamara
d735ffde2d weld ScSolverValueDialog
Change-Id: I1c55d184052482fc472d66069ea8722cd27d1543
Reviewed-on: https://gerrit.libreoffice.org/54353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 12:46:11 +02:00
Stephan Bergmann
135cbec440 Adapt solenv/flatpak-manifest.in to recent download.lst changes
Change-Id: Ic8f4afe8f46b5f0c36eeffdbb04b3cc652884ab4
2018-05-15 12:14:19 +02:00
Mike Kaganski
56a7f308cf tdf#115007: add NatNum codes for cardinal/ordinal number names/indicators
... based on libnumbertext integrated since commit
f1579d3d6c.

[NatNum12] gives cardinal number names (one, two, three, ...)
[NatNum13] gives ordinal number names (first, second, third, ...)
[NatNum14] gives ordinal indicators (1st, 2nd, 3rd, ...)

Change-Id: Ie2afdeeb82da1b36e9755c02d7b2276c77be9c72
Reviewed-on: https://gerrit.libreoffice.org/54186
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-15 11:42:36 +02:00
Michael Stahl
5193d7fc00 sw: these SwRedlineItr members index into the SwRedlineTable, not the node
Change-Id: Idb04fcb46a72d63d4f35b61eb0333ebd6abaaf0c
Reviewed-on: https://gerrit.libreoffice.org/54309
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-15 10:09:23 +02:00
Caolán McNamara
881636aed7 ofz#8255 check multiply
Change-Id: I3b125aba227e46c92510f7388aff4fff1478c78e
Reviewed-on: https://gerrit.libreoffice.org/54329
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 09:52:25 +02:00
Caolán McNamara
d9f4c8ded4 weld ScFillSeriesDlg
Change-Id: I1b4c6777d3334813c6bfe47efbb67f065efa555c
Reviewed-on: https://gerrit.libreoffice.org/54338
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 09:51:59 +02:00
Caolán McNamara
0e4f93e88b weld ScRetypePassInputDlg
Change-Id: Ie57f3fdaeed5b15f2ce7a1825debdc92788b4e94
Reviewed-on: https://gerrit.libreoffice.org/54343
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 09:51:44 +02:00
Stephan Bergmann
bff6751413 loplugin:unnecessaryoverride, loplugin:cstylecast (clang-cl)
Change-Id: I316965219f70a87b59b731e4d5e6b67d2010c2b9
Reviewed-on: https://gerrit.libreoffice.org/54350
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-15 09:44:23 +02:00
Stephan Bergmann
8e8c4da188 loplugin:stringconcat, loplugin:sallogareas (clang-cl)
("bridges.win64" isn't more useful than plain "bridges" here, as each platform
uses only one bridges/source/cpp_uno/ sub-dir, anyway)

Change-Id: Ic8c2af892cdfad98e10d43532b3bf3c892555446
Reviewed-on: https://gerrit.libreoffice.org/54351
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-15 09:44:03 +02:00
Gabor Kelemen
8713c1ffd8 tdf#42949 Fix IWYU warnings in sc/inc/e*
Found with bin/find-unneeded-includes
Only removal proposals/trivial replacements are dealt with here.

Change-Id: I0ad6772012c771e8ab3f3f42af26f9ac05615771
Reviewed-on: https://gerrit.libreoffice.org/54147
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-15 09:09:01 +02:00
Gabor Kelemen
1c2d8e870c tdf#42949 Fix IWYU warnings in sc/inc/columniterator.hxx
Found with bin/find-unneeded-includes
Here IWYU suggested to remove the column.hxx, but that does not compile.
Instead IWYUs complete suggestion list is applied

Change-Id: I815bcda467ebe698ce673d055e0ff3ad8f4b2aa3
Reviewed-on: https://gerrit.libreoffice.org/53952
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-15 09:08:31 +02:00
Miklos Vajna
c167620444 tdf#117225 sfx2: fix leftover temp file when saving doc with embedded objects
Regression from 27938e1bbd (sfx2 store:
create temp files next to local files (storage case), 2018-01-17), the
optimization to store temp files during save next to the destination
document (so that it can be renamed and not copied after writing the
data successfully) causes problems when we have embedded objects.

Avoid the problem by disabling this new optimization when the document
has embedded objects.

How to fix the actual root cause is not clear to me, I see that:

- the SfxMedium::GetOutputStorage() call in
  SfxObjectShell::SaveTo_Impl() create a temp file
- the SfxMedium::Commit() call in SfxObjectShell::SaveTo_Impl() tries to
  remove the file, which fails on Windows as there is an open file
  handle to that file
- SfxObjectShell::SwitchChildrenPersistance() would close the storage,
  owning that open file handle, but it's too late

So just go back to the previous behavior for now.

Change-Id: I37259100d1ddf963c1f2d3b7bd9f460bc995815c
Reviewed-on: https://gerrit.libreoffice.org/54340
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-15 09:06:59 +02:00
Mike Kaganski
b64ef8d113 Remove "Toggle Design Mode" from Writer's Edit menu
... since it exists in Form menu

Change-Id: I3eaa2c6295242e776990fa3935b1346c130b1247
Reviewed-on: https://gerrit.libreoffice.org/54200
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-15 08:50:46 +02:00
heiko tietze
8ab79071d8 tdf#117186 - Sidebar: Shapes deck should fill the whole sidebar
Change-Id: Ib4ddab03b3b001523f3e819e5bdac7fbefc17f24
Reviewed-on: https://gerrit.libreoffice.org/54339
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-15 08:45:58 +02:00
Stephan Bergmann
c074abd484 Merge in Flatpak improvements
...from <https://github.com/flathub/org.libreoffice.LibreOffice/>:

Author: Stephan Bergmann <sbergman@redhat.com>
Date:   Mon May 14 16:51:37 2018 +0200

    Find flatpak'ed Java installation via JAVA_HOME

    ...instead of via PATH, so that a JAVA_HOME inherited from the environment
    doesn't accidentally select a different Java installation.  Fixes
    <https://github.com/flathub/org.libreoffice.LibreOffice/issues/37> "undefined
    symbol: FT_Done_MM_Var".

Change-Id: I2b4c3a55c92f0ef5c5925f0a9909b7b061eedeeb
Reviewed-on: https://gerrit.libreoffice.org/54330
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-15 08:39:05 +02:00
Justin Luth
d2c85c671d cleanup my asserts before branching - they served their purpose
Change-Id: I933ac25dac8d7a20d62535af9690b17503fc159d
Reviewed-on: https://gerrit.libreoffice.org/54086
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-05-15 06:13:37 +02:00
Aron Budea
1511412793 Updated core
Project: dictionaries  dbcea2a5cdfabea90420fa292e66cc647814b824

English dictionaries: add ref to package-description.txt

Change-Id: Ie63941f519f43a5e632816b696bd174f033c4991
Reviewed-on: https://gerrit.libreoffice.org/53953
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
2018-05-15 00:49:14 +02:00
andreas kainz
6523c16275 Add icon option for ObjectTitleDescription
Change-Id: Ie1a2792d8c1c6696b6ac2ee89a8cce6482d3a662
Reviewed-on: https://gerrit.libreoffice.org/54337
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-05-14 23:33:08 +02:00
andreas kainz
bc782ae7b4 Colibre icons: add ObjectTitleDescription to colibre
Change-Id: Id39458b364d2fe74909a8ef8fd8f3969db5cac6a
Reviewed-on: https://gerrit.libreoffice.org/54336
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-05-14 23:32:41 +02:00
Caolán McNamara
90875893fb ofz#7322 lcl_MarkEqualByStart sort logic differs from that of operator==
when it encounters a SwPosition with a SwIndex nContent whose m_pIndexReg is
null and compares to one whose m_pIndexReg is not null, where both have an
m_nIndex of 0.

operator== considers them different, while lcl_MarkEqualByStart doesn't care
and sorts them as equal

Change-Id: I29920b98c9e6f395487de1b9cafa6b1282b2b1b6
Reviewed-on: https://gerrit.libreoffice.org/54334
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14 22:11:31 +02:00
Caolán McNamara
2eedf1dc71 weld ExportDialog
Change-Id: Ie799f429d3121426b90bdd62cf0758da38b0beb4
Reviewed-on: https://gerrit.libreoffice.org/54335
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14 22:10:51 +02:00
Rene Engelhard
fddc55cc89 fix typo
the header is already ParameterSubstitution.hxx...

Change-Id: I13239681fbdee6d79aae67f7b7291fe5f7ee78ee
Reviewed-on: https://gerrit.libreoffice.org/54333
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rene Engelhard <rene@debian.org>
2018-05-14 21:03:10 +02:00
Caolán McNamara
7b85567296 weld GalleryIdDialog
Change-Id: I214afef7668eaf5082683f1c77b08aa0c5107619
Reviewed-on: https://gerrit.libreoffice.org/54317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14 18:25:19 +02:00
Luboš Luňák
a9a0601e2a use optional ScInterpreterContext if possible
Avoids assertion with threaded cell computations for tdf#100811/2.

Change-Id: I2dc0fd80595ccec1824c8675fc97cfc763b88659
Reviewed-on: https://gerrit.libreoffice.org/54080
Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-05-14 17:32:48 +02:00
Luboš Luňák
6154d04d90 remove page count check in a test (irrelevant and fragile)
If I load this document in LO, either my build or distro build, it has only
one page, so the test fails for me only because of the 2-page check.
The commit causing this, b904d639a8, has been in for quite a while,
so it's apparently something special about my setup, but a) the test
doesn't actually require 2 pages for anything, b) the commit mentions that
the test is fragile, c) if I manually inspect the .rtf, there's an extra page
that I do not see even in Word2013, so the document is possibly a bit broken.
One way or another, the page check seems pointless.

Change-Id: I18bdf25f71e8eb9225acd667e60f426fca008ee4
Reviewed-on: https://gerrit.libreoffice.org/53380
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-05-14 17:31:58 +02:00
Eike Rathke
f72bd4f02b Related: tdf#116939 Disable <cols><col> overflow detection due to excess ...
... custom column widths.

It's probably just confusing to users, even if technically
correct. Live with truncation of a "layout form" if no content is
present.

Change-Id: I43d77c3e019badd053cb21d92aacd64c7bbcf0e6
Reviewed-on: https://gerrit.libreoffice.org/54319
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2018-05-14 17:14:57 +02:00
Noel Grandin
7ebb57228f loplugin:useuniqueptr in FormulaTokenArray
Change-Id: I5716295d2f0c88c6daf0570941d5dd4c5ff03a33
Reviewed-on: https://gerrit.libreoffice.org/54168
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-14 17:12:51 +02:00
Caolán McNamara
38fa68b90a weld TitleDialog
Change-Id: I009da829e2b866844e67f976582e2a9d99bd22c0
Reviewed-on: https://gerrit.libreoffice.org/54316
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14 16:28:38 +02:00
Tomaž Vajngerl
76f3045057 [API-CHANGE] revert reordering of Graphic properties
This reverts the reordering of properties and adds new properties
to the end and marks them as optional so we break API as little as
possible.

Change-Id: I422d882d1d1c721dd3ff7ad289329a9df58beb42
Reviewed-on: https://gerrit.libreoffice.org/54322
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2018-05-14 16:21:52 +02:00
Caolán McNamara
209f95d914 weld ProfileExportedDialog
Change-Id: Ie360699c167cbee0be6d890ad686d351d64707cd
Reviewed-on: https://gerrit.libreoffice.org/54315
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14 16:05:35 +02:00
Stephan Bergmann
2bd48ad3bc loplugin:redundantfcast
Change-Id: I412eb9530e4b10281c505c07f0c18a4220e2cba9
2018-05-14 15:21:49 +02:00
Caolán McNamara
2cc5db6244 weld AddModelDialog
Change-Id: Ia12069f966c93ad7700b7a068dd7660284a40130
Reviewed-on: https://gerrit.libreoffice.org/54314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14 15:04:11 +02:00
Caolán McNamara
881bb00dc3 weld AddInstanceDialog
Change-Id: I69bcb7fb9c18922a5de03e6f2dedd915a5851712
Reviewed-on: https://gerrit.libreoffice.org/54313
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14 15:03:50 +02:00
Caolán McNamara
f645481d29 weld ManageNamespaceDialog
Change-Id: Ieb5605fcab285de26e4fab64b8178d4d7818eb2d
Reviewed-on: https://gerrit.libreoffice.org/54311
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14 15:03:35 +02:00
Caolán McNamara
6f2bbb3641 weld ExtrusionDepthDialog
Change-Id: I5905fea310a7f29574d94eaf61c80b6ca09a7467
Reviewed-on: https://gerrit.libreoffice.org/54310
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14 14:07:06 +02:00