Commit Graph

365940 Commits

Author SHA1 Message Date
Caolán McNamara
dde94c7348 coverity#1257110 Big parameter passed by value
and

coverity#1186125 Big parameter passed by value

Change-Id: I6cb6863645647edf4fba114059195582679c30c4
2014-12-08 17:10:45 +00:00
Stephan Bergmann
322ca1cea2 No idea why this would need to be an archaic LibMain
Change-Id: I4a41a2975f670b06159de5c94ab9a66ab204c725
2014-12-08 17:59:03 +01:00
Caolán McNamara
af64f43018 writer won't allow us to enter multiple CrossRefBookmarks on the same node
e.g. fdo63164-1.docx and loads more like that, and the .docx genuinely has
multiple bookmarks at the same place, so just allow the first one and discard
the following ones

Change-Id: Ida2f5d79fdef4ed3e2d8c1e96ca6a086004f6c7d
2014-12-08 16:24:27 +00:00
Caolán McNamara
93913ce2a7 coverity#735379 annotate to dismiss Copy-paste error
on the basis that it doesn't look obviously wrong to the original author after
a once-over

Change-Id: If333a17a2a9954d33ebefc6846e40e0e1e29c857
2014-12-08 16:24:27 +00:00
Caolán McNamara
ad56f8de7b coverity#1257114 Result is not floating-point
Change-Id: I420fa77d52ca72a4c4609b4610572b8735911b4b
2014-12-08 16:24:26 +00:00
Caolán McNamara
d9ae37a3cc coverity#1257109 Unchecked dynamic_cast
and

coverity#1257108 Unchecked dynamic_cast

Change-Id: Ib0d42b7fcd3b2b87a95301b111cebe80f54dd13f
2014-12-08 16:24:26 +00:00
Kohei Yoshida
ab61d71c8b Build fix (for gcc 4.7).
Change-Id: Ib52cfc8ba45361277ef8e0b6021a03c3ff8ae668
2014-12-08 10:47:59 -05:00
Miklos Vajna
1256809ba2 README.Android: mention ndk-gdb --start
Change-Id: Ib131c480b53665fc9e9a38388e3cc179eac249c2
2014-12-08 16:27:32 +01:00
Tor Lillqvist
8ab56d5973 WaE: Unreferenced function definition
Change-Id: I2e405a8a02ef81b82b4762bd826769c2491b3aec
2014-12-08 17:12:14 +02:00
Zolnai Tamás
9ff7aac6c8 Test for Writer import / export of graphic shapes
Graphic shapes are those images which are created not in
Writer (but e.g. Impress, Calc) and moved to Writer later
(e.g. copy&paste).

Embedded image is ok, but MS filters broke the linked
graphic shape.

Change-Id: I0c86a5d09afb3e40f7d9e5986c05801457d4c13f
2014-12-08 15:56:35 +01:00
Zolnai Tamás
3650b66c36 Copying linked graphic between components is broken
IsLinkedGraphic() is better to use here.

Reproducer steps:
-Insert an image to Impress as a link.
-Copy this image (CTRL+C & CTRL+V) to Writer.
Result: Image is not displayed.

Change-Id: Iaf9b686b5c87caf5a0cc15425f8c5988f857bfe6
2014-12-08 15:56:35 +01:00
Zolnai Tamás
5b3166ffd3 Test also Calc export / import of images with special ID
Change-Id: I6c47c4b78a1dcd76287cdca16265d3170d2794f5
2014-12-08 15:56:34 +01:00
Zolnai Tamás
2264171e4c Test also Impress export / import of images with special ID
Change-Id: If040bb32bb5289a282f315cd6ca90cbed76f9b8f
2014-12-08 15:56:34 +01:00
Zolnai Tamás
614d2f062f Generalize this test for other Writer filters
Change-Id: I17bc641373eafc49367d5605072270db6f7fe77b
2014-12-08 15:56:34 +01:00
Mattias Põldaru
27d006e512 fdo#87042 Add Ctrl+Shift+R as toggle for ruler
Remove RefreshView (redraw) from some components, as it's supposedly little
used. Components which would have this shortcut are DrawingDocument,
GlobalDocument, PresentationDocument, WebDocument, FormDesign,
TextReportDesign, TextDocument, XMLFormDocument.

Change-Id: Ic730d390b4e4a1e6bcc76b18888932b198e5b82c
2014-12-08 15:48:47 +01:00
Bjoern Michaelsen
8e00e0056e coverity#1257107: handle these consistently
Change-Id: I5f432eea235bdca05132cf553d9bc15e2b825509
2014-12-08 15:01:01 +01:00
Bjoern Michaelsen
df87cec5ad deque is never used
Change-Id: I223c85999a0ed1a62aece67f0d730b8e2e097ac9
2014-12-08 15:00:51 +01:00
Bjoern Michaelsen
23c802b85a make InsertRedline() non-static again
Change-Id: I2eda267b56bc1548930add9c5ef83ad268f881a4
2014-12-08 14:52:16 +01:00
Bjoern Michaelsen
a71fb1c911 rename to simple SaveMergeRedline and put in namespace
Change-Id: Ibc36dcde1778ee02b9ac173d9da8419b69854af6
2014-12-08 14:52:16 +01:00
Bjoern Michaelsen
a7afdad2bf remove inheritance from Ring<>
Change-Id: Ie1a958b3f3fb5797ec2eb49f6a5fc72da23ca553
2014-12-08 14:52:15 +01:00
Bjoern Michaelsen
9d2642d29f use a std::list<> instead of a Ring<>
Change-Id: Ibc1d2deae5b0c7841ec83de880380170eadbd509
2014-12-08 14:52:15 +01:00
Bjoern Michaelsen
29a4edaee6 use unique
Change-Id: I49b9b69b66f4d8835078056b5681a1bf3760ffc9
2014-12-08 14:52:15 +01:00
Bjoern Michaelsen
01896d465a make InsertRedline a static function
Change-Id: I80c7750f88f9b20e3a2be7306c53676d373654df
2014-12-08 14:52:14 +01:00
Bjoern Michaelsen
6091274708 test for document merge
Change-Id: Ic6d10a611d9e9351eb9403e1405ec7b17293e816
2014-12-08 14:52:14 +01:00
Caolán McNamara
9215ab0347 coverity#1257107 Unchecked dynamic_cast
Change-Id: Ica45049aa7e6656c0882484ffa4ff80b6d699373
2014-12-08 13:49:04 +00:00
Caolán McNamara
32e38e1ec7 coverity#1257111 Uninitialized pointer field
Change-Id: I82c771f0ca7d2593a6f34dd84689cf055f9cf3f3
2014-12-08 13:49:03 +00:00
Caolán McNamara
d15d0ec6de coverity#1257112 Uninitialized scalar field
Change-Id: I79063c103707e91f04c22a284f7af035fef6d21d
2014-12-08 13:49:03 +00:00
Caolán McNamara
f137588d0d coverity#1257113 Uninitialized scalar field
Change-Id: Ie813165995df47d466eaef09720901a33362fd23
2014-12-08 13:49:03 +00:00
Noel Grandin
2979ff295c fdo#38835 strip out OUString globals
Change-Id: I1a435214af102461e02217f7d95248dac14e5f1a
2014-12-08 14:13:17 +02:00
Caolán McNamara
eae0dda3e2 Resolves: fdo#86820 executing toolbar menu entry can destroy menu
Change-Id: Ide0ea8f8ff145d487e409b0091918b59f1f83405
2014-12-08 12:11:18 +00:00
Matúš Kukan
848adf433a fastparser: Redundant check after assert
Change-Id: Ibc56102831d4d36392bea4e4e088e207cef99429
2014-12-08 12:28:40 +01:00
Caolán McNamara
6d10a42d5b Resolves: fdo#86931 wrong offsets used to set language
after Chinese conversion. the _aOldSel is the one
that has the start and end index set to the end of the
replacement text and so the calculation only makes
sense on that selection

Change-Id: I152067550d7741579bfc6ca026072b16ac7c2dd6
2014-12-08 10:38:10 +00:00
Caolán McNamara
f3c24b4883 kater->later
Change-Id: If9eaf54c2d706144e2b7c34a3004ad9604dd420f
2014-12-08 10:38:10 +00:00
Stephan Bergmann
147ff66242 Typo "mehtod" -> "method"
Change-Id: I49f3f59c76bd4dd078f7014b6a0450241214db7f
2014-12-08 11:11:43 +01:00
Caolán McNamara
cca2e7be89 Related: rhbz#1164614 better default size for no xslt entries case
Change-Id: I75dd1210b4e8e5e7cb2c2ce1e83e085a9c480b91
2014-12-08 10:09:01 +00:00
Caolán McNamara
6d8b06224c callcatcher: update unused code
Change-Id: I3cd65d112339fa9c67ed462fe39acbbef91d4d8d
2014-12-08 10:09:01 +00:00
Stephan Bergmann
9d5e53b67c protected -> private
Change-Id: I807b31eaa0b0cd68e0ca018b6df4269c1aab5763
2014-12-08 10:34:37 +01:00
Tor Lillqvist
bf6544c0ab Don't treat clew as part of an "external" clcc module
There is no obvious authoritative upstream for clew anyway, so it causes
philosophical problems for distros. For a while, we used to use a zip archive
from the "clcc" project on SourceForge that included clew.c and
clew.h. (Before that we also just had clew.c and clew.h in our source repo.)

So, drop the external/clcc module and have clew.c and clew.h in the source
repo again. But this time clew is in a module of its own, not in sc.

This re-introduces "No need to have OpenCL optional at configure-time"

This reverts commit 764836cb00.

Change-Id: I413142f4f9f8399489f9c3e5327132822f07a454
Reviewed-on: https://gerrit.libreoffice.org/13368
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-12-08 09:07:27 +00:00
Miklos Vajna
4517c94000 fdo#86750 RTF import: fix table of contents links
Change-Id: I0f3d35a0e64c9ce5646fa63eda317bee42de5540
2014-12-08 09:17:56 +01:00
Miklos Vajna
193c7ba9be Factor out SvxWeightItem::dumpAsXml() from sw
Change-Id: I97ccc04190b1f75c54e725e0612724a2ef62fe3e
2014-12-08 09:17:56 +01:00
Stephan Bergmann
2ecec9d08c Mark classes as noncopyable
Change-Id: I4262fb56d681c70a089638b876dc07b1f472f583
2014-12-08 09:17:04 +01:00
Michael Weghorn
3338f47918 reduce scope of local variables
This eliminates some of the warnings from Cppcheck report of
2014-11-29.

Change-Id: Id5bf885de12a6de262d2cca9fa71627ac67f50d9
Reviewed-on: https://gerrit.libreoffice.org/13330
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-08 08:01:58 +00:00
Markus Mohrhard
664e64a190 add test for fdo#85304
Change-Id: I35692a4a4ccfd1aa5938078bdf32a3eaff082453
2014-12-08 08:30:01 +01:00
Markus Mohrhard
1de372de21 don't update range name if ref not in update range, fdo#85304
Change-Id: I1ccfacd98bd10f6ae1d4eaf7a705fe8863045697
2014-12-08 08:26:07 +01:00
Markus Mohrhard
b45e1b5870 we need the SdrPage for deleting the notes, fdo#86166
The SdrPage that contains the shapes for the note captions is deleted
before the notes. Prevent that case by deleting the notes before
deleting the SdrPage.

Change-Id: I13727cea7df0b033fb386a6a8e20dcadec743335
2014-12-08 07:47:54 +01:00
David Tardon
235f3cbc18 fix library name
Change-Id: Ia3914b0dbe56d517c23ace5ce36ab8610c44509c
2014-12-08 00:18:00 +01:00
David Tardon
764836cb00 Revert "No need to have OpenCL optional at configure-time"
As long as this requires bundling clcc, not allowing to disable it is
unacceptable.

This reverts commit 3b0b76462a.

Conflicts:
	configure.ac

Change-Id: I12b3d5e3325bbd03cd98e1fb5139705d694493c2
2014-12-08 00:01:35 +01:00
Zolnai Tamás
b19fefa01c Build fix
Change-Id: I91b343da5b73aa960f7447135f93dedd76e81527
2014-12-07 23:57:30 +01:00
Julien Nabet
c2d8fed349 We need to call decode method considering this:
java.lang.NumberFormatException: For input string: "#FF9966"
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.lang.Integer.parseInt(Integer.java:481)
	at java.lang.Integer.parseInt(Integer.java:527)
	at com.sun.star.wizards.form.StyleApplier.getStyleColor(StyleApplier.java:321)

When creating form with wizard

Partly reverts http://cgit.freedesktop.org/libreoffice/core/commit/?id=10e8e10605b9c52bd7fd8a0665dd4d358c733a66

Change-Id: Ide85566244e0dce1d30f6369d1f5d8d30534a01a
2014-12-07 22:39:27 +01:00
Eike Rathke
413a0655ad umm.. row is row and col is col
Change-Id: I26c62fa1fc97aa0dd4eda1102422e5f012a126eb
2014-12-07 19:59:39 +01:00