Commit Graph

398369 Commits

Author SHA1 Message Date
Noel Grandin
e140e40c12 loplugin:expandablemethodds in lotuswordpro..package
Change-Id: Id33d88edc4be00f4238792d885e392cc08e72386
Reviewed-on: https://gerrit.libreoffice.org/30017
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:33:41 +00:00
Noel Grandin
0aa24916cb loplugin:expandablemethodds in filter..forms
Change-Id: Ic1f64f804acc10b1a48d82de9fc6a2b39af465a0
Reviewed-on: https://gerrit.libreoffice.org/30014
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:32:58 +00:00
Miklos Vajna
365f2e9054 cid#1374076 uncaught exception
Change-Id: Ifdbfc9f905f2ed7778830a0f2cc114d27feb36da
2016-10-19 08:32:23 +02:00
Miklos Vajna
90717e7d36 cid#1374075 uncaught exception
Change-Id: I1c95efb37e62c5e600607d23e4e80bf430854cae
2016-10-19 08:32:23 +02:00
Miklos Vajna
6947962b08 cid#1374074 uncaught exception
Change-Id: Ibb734d394b49a032fab1dc1255376d6b7bb3632d
2016-10-19 08:32:23 +02:00
Noel Grandin
6f96e86dae loplugin:expandablemethodds in editeng..extensions
Change-Id: Ibe1929d74ff460955e39f2ccce3056b2051ddf08
Reviewed-on: https://gerrit.libreoffice.org/30013
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:31:43 +00:00
Noel Grandin
ef637a1c4e loplugin:expandablemethodds in dbaccess..drawinglayer
Change-Id: Iee9143999f5c94040dadd378006f2a429ca0edb5
Reviewed-on: https://gerrit.libreoffice.org/30012
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:30:48 +00:00
Luke Deller
834809dbbe Avoid AskConfig when setting font family
Avoid calling the expensive ImplFont::AskConfig from Font::SetFamily
as we are just going to overwrite the font family anyway.

It looks like this crept in accidentally in the recent refactor
commit e418d1a9c8

Change-Id: I12a9bde77ffcc81f03c37ce400c59ea3a9acac31
Reviewed-on: https://gerrit.libreoffice.org/28901
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-10-19 06:30:22 +00:00
Noel Grandin
dcb1fbef20 loplugin:expandablemethodds in cui
Change-Id: I7b2321d45171f9b73965efea32832a3789f0dee7
Reviewed-on: https://gerrit.libreoffice.org/30011
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:26:00 +00:00
Noel Grandin
98b77ad1e6 loplugin:expandablemethods in UnoControls..vbahelper
Change-Id: Iec2c5e13119d97c9ca87e083c0f7cb00227e5231
Reviewed-on: https://gerrit.libreoffice.org/29997
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:24:23 +00:00
Noel Grandin
7e48876799 tdf#103083 - EDITING: Cut and Paste changes bullet point formatting
The bug is that, on paste, the incorrect stylesheet is set on a paragraph
node, leading to the loss of bullet formatting information.

There are two copies of this style-resetting code, one in
   sd::View::OnEndPasteOrDrop
and the other in
    Outliner::ImplSetLevelDependendStyleSheet.

The first one was introduced by:
    commit 8aa3d1214b
    Author: Rüdiger Timm <rt@openoffice.org>
    Date:   Fri Jun 6 11:11:54 2008 +0000
    INTEGRATION: CWS impressodf12 (1.62.4); FILE MERGED

And the second one by:
   commit a6b3e8c149
   Author: Rüdiger Timm <rt@openoffice.org>
   Date:   Fri Jun 6 11:30:58 2008 +0000
   INTEGRATION: CWS impressodf12 (1.70.350); FILE MERGED

The second one appears to do the right thing, and fixes this bug,
so I am deleting the first one.

Change-Id: I5eede7fe7bd3aa24696b495e740d1a4df124bd3a
Reviewed-on: https://gerrit.libreoffice.org/30009
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:23:38 +00:00
Jochen Nitschke
930f0242a1 replace <<= with assign for <<= with rhs Any
queryAggregation and queryInterface return Any

Change-Id: Ib8e3e742bd66f7419cad583988b247bb628f7b4a
Reviewed-on: https://gerrit.libreoffice.org/29912
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-19 05:28:29 +00:00
Kohei Yoshida
42062d99f1 tdf#93894: Write a new test case for column and row labels combined.
Change-Id: I76e1f6f3c3aed9d940e4433026f752f3630f2373
2016-10-18 20:27:45 -04:00
Kohei Yoshida
2b32042294 tdf#93894: These assumptions no longer hold.
Since we've switched to not grouping formulas with column / row
labels.

Change-Id: I0097a5103b5dfaa5b021ee76545beb9f24ac7bd3
2016-10-18 20:27:36 -04:00
Kohei Yoshida
e944d95104 tdf#93894: Prohibit grouping when certain token types are present.
For instance, column / row label tokens don't work correctly in
grouped cells with the current implementation.

Change-Id: Idf86312ef15fbfd4382aa90ee6d131c671a80683
2016-10-18 20:27:16 -04:00
Tomaž Vajngerl
baeb3b43fb opencl: convert to C++11 for loop
Change-Id: Id96a3816eb7ef2241f5a6a57b164e1e366eb357a
Reviewed-on: https://gerrit.libreoffice.org/29693
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-18 22:13:24 +00:00
Krunoslav Šebetić
c01b15514e Update autocorrect for Croatian
Change-Id: I23254c546ddffc080a4239be103618c4b4514095
Reviewed-on: https://gerrit.libreoffice.org/29985
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-18 21:41:14 +00:00
Giuseppe Castagno
71dfc1113e tdf#103274 (8): Add default XCommandEnvironment reference
Change-Id: I583ed0714c0bf543c44c098613e1aab9d3b31452
Reviewed-on: https://gerrit.libreoffice.org/30007
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-18 19:36:16 +00:00
Jochen Nitschke
d1ea6ecda6 replace <<= with assign for <<= with rhs Any
found by deleting specialization of '<<=' template

Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c
Reviewed-on: https://gerrit.libreoffice.org/29956
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18 19:16:44 +00:00
Jochen Nitschke
55bcb865ee ucb: fix handling of >>= with rhs Any
>>= for rhs Any is always true, check result with hasValue() instead.

bool convert<uno::Any>(...) always returns false and assigns
the 3rd parameter to the 4th.
do the assign directly and check result with hasValue().

Change-Id: I0ae985cc0837abf1108930d593edae69de2ae549
Reviewed-on: https://gerrit.libreoffice.org/29977
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-18 19:14:57 +00:00
Eike Rathke
5cfbab03f9 unit test for tdf#101583, named expression reference expansion
Change-Id: I40dc157ebb33da59e436214b703800dfabc11a23
2016-10-18 21:00:17 +02:00
Khaled Hosny
8b9ec421ac Fix debug build and few cleanups
Change-Id: I805962667c3ef2dcaf07a0acebeacca74c74892a
2016-10-18 20:41:34 +02:00
Martin Hosken
970db61951 Add feature support to CommonLayout
Change-Id: I19a0e26cefa5e4185df961ae0f6f2f37811ae5bb
Reviewed-on: https://gerrit.libreoffice.org/29978
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-18 20:41:34 +02:00
Khaled Hosny
3a304a4e75 Rewrite AquaSalGraphics::DrawSalLayout()
Slightly cleaner code and now handles glyph rotation for vertical text.

Change-Id: I98cc8fd7df5e73068294e4d7dd6b38a71dcbdcc7
2016-10-18 20:41:34 +02:00
Khaled Hosny
8f054454bf Support vertical text in CommonSalLayout
Change-Id: I52a71c9c21ad75c7cb9c8574e5e7e3b7c1c0c0c3
2016-10-18 20:41:34 +02:00
Khaled Hosny
2bfd8391d1 Support font fallback on macOS for CommonSalLayout
Change-Id: Ifd26b7f14ed77a3aa2a38e5961cac5f9bbb6d796
2016-10-18 20:41:33 +02:00
Khaled Hosny
9cea34ee83 Check SAL_USE_COMMON_LAYOUT envar in one place
Makes it easier to flip the switch in the future (or even do something
more fancy other than checking envvar).

Change-Id: Ie42ca012c167b2108f0fca1ce9ff7beee95f1be7
2016-10-18 20:41:33 +02:00
Khaled Hosny
e3429c5068 Just call ICU directly and cut the middle layers
Change-Id: I7603d03fef8ca227c3e6fe25239281d18801522a
2016-10-18 20:41:33 +02:00
Khaled Hosny
f353cf9dad Use range loop
Change-Id: I5ce49e57ed57378b4b9e16c8bb020048644252a9
2016-10-18 20:41:33 +02:00
Khaled Hosny
9d0c701024 Use const reference
Change-Id: I0f632f3a8b480f785608aa081add1b1d2fefd312
2016-10-18 20:41:33 +02:00
Khaled Hosny
9de76cb136 Make sure HarfBuzz module depends on Graphite
Change-Id: I9c1cc9c679ceebeb4e5cd898876aaa7b61c18f17
2016-10-18 20:41:32 +02:00
Khaled Hosny
6ded1bd548 Build HarfBuzz with Core Text on Mac
To enable support for AAT fonts.

Change-Id: Ifcc7d1672e98f8c067482400b7e45226bed4dbf1
2016-10-18 20:41:32 +02:00
Khaled Hosny
8f94aa7631 Always pass BCP 47 tags to HarfBuzz
This is what it is expecting anyway, no need to special case it for
Chinese.

Change-Id: I6732412375d19816b599005d78abd796f67599ee
2016-10-18 20:41:32 +02:00
Khaled Hosny
3a543f1f57 Validate Kashida positions in CommonSalLayout
Currently checks only for ligatures, but that is a big improvement over
al code that didn’t do any validation except on Windows.

Change-Id: I035248f4ccc23134ea27b40c2dd6197130749f14
2016-10-18 20:41:32 +02:00
Khaled Hosny
df5e67e380 Re-enable Kashida insertion in CommonSalLayout
We now do Kashida insertion in ApplyDXArray(), no need for a separate
step. This simplifies the code greatly (old code is in
GenericSalLayout::KashidaJustify()).

Change-Id: Ie31c8969e26f1f293820f1e90f963a5ba1fc9eb1
2016-10-18 20:41:32 +02:00
Khaled Hosny
15f6a97d9f Fix applying DX adjustments in CommonSalLayout
By overriding GetCharWidths() and ApplyDXArray() with a simpler and
saner implementation.

This fixes rendering of Awami Nastaliq, as well as subtending marks in
Amiri and potentially other bugs.

Breaks Kashida justification, will need to rewrite that one as well.

Change-Id: I843679e937f2881e77df61f5cbd9516b6df1b3b6
2016-10-18 20:41:31 +02:00
Khaled Hosny
66104ff985 Don’t check glyph class unnecessarily
Don’t call hb_ot_layout_get_glyph_class() unless the glyph advance width
is zero, as we really do not use its result otherwise.

Change-Id: Id02238abef91b9343931f1886d54d966d7157f25
2016-10-18 20:41:31 +02:00
Khaled Hosny
26e799a3f7 Cache HarfBuzz font
We now create it only once per physical font, saves us few percents from
the all over time spent on layout.

Change-Id: I8de582cb20a168c93d72921e539c2477fa97fb54
2016-10-18 20:41:31 +02:00
Khaled Hosny
b285eaf5f8 Always build Graphite everywhere
It is no longer an optional feature on any platform. The
--enable-graphite stuff is kept as it controls the old Graphite
integration code and it should be removed without.

Change-Id: Ib4d76bba782a1439f02f93411b22d237a1987ea5
2016-10-18 20:41:31 +02:00
Khaled Hosny
610eceb035 Always build HarfBuzz everywhere
It is no longer an optional feature on any platform.

Change-Id: I70cdcd2c0df69d961ecc5f36b4e8d035d251ef16
2016-10-18 20:41:31 +02:00
Akash Jain
5e65efcaa3 GSoC: Speed up CommonSalLayout by caching hb_face
Cache hb_face so it is not created again and again.
Switch from GDI to DirectWrite on Windows to obtain SFNT table data.

Change-Id: I9c532cd72e1f6b57313f3b7d42a6b9b0633eb0ef
2016-10-18 20:41:30 +02:00
Akash Jain
3eda74cf7e GSoC: Move TextOutRenderer definition to winlayout.hxx
Change-Id: I705f92d5ad55d7612c6413436c801de13f5352a6
2016-10-18 20:41:30 +02:00
Akash Jain
ce320a0ab1 GSoC: Add Graphite support for CommonSalLayout
Enable Graphite font rendering in CommonSalLayout through Harfbuzz

Change-Id: Ia6a00a1bb6ea1a7bd705ed91d4f4f6cb9803e062
2016-10-18 20:41:30 +02:00
Akash Jain
69c40bbebd GSoC: Enable building Harfbuzz with Graphite
Harfbuzz will now need to be built with Graphite support. This allows
Harfbuzz to handle Graphite fonts. In case we all building with
system Harfbuzz, then it should be built with Graphite support else
we error out.

Change-Id: I156ec08b9e5ad7ce87cc15e4b5852d9c57c98f7f
2016-10-18 20:41:30 +02:00
Akash Jain
f099f3d3bd GSoC: Integrate new CommonSalLayout in quartz/ code
Change-Id: I07a9c956f09be5d43ee58ff0784ba0f81f52cd9a
2016-10-18 20:41:30 +02:00
Akash Jain
f6db8af1eb GSoC: Integrate new CommonSalLayout in win/ code
Change-Id: Ifeb2fa7ca9e2cd0da1c504d4e770aa0bb1b0b0de
2016-10-18 20:41:29 +02:00
Akash Jain
828b8cf4d2 GSoC: Integrate new CommonSalLayout in unx/ code
Change-Id: I991cb5cbd2adad4f4c9f62f807990b9fde2a5133
2016-10-18 20:41:29 +02:00
Akash Jain
07492d483b GSoC: Modify DrawServerFontLayout and add DrawSalLayout
Modify the definiton of the DrawServerFontLayout method.
Add new DrawSalLayout method which will be used for drawing text
independent of the platform.

Change-Id: Ie3eefb172b1781c685def1ef549db2538f672a62
2016-10-18 20:41:29 +02:00
Akash Jain
8f70e847a1 GSoC: Modify HARFBUZZ_LIBS flag if compiling with MSVC
MSVC has a different format for specifying libs to be linked.
Therefore, modify libs flag accordingly.

Change-Id: Ib919c4b6b0cdac47a8a6ad6730d20e19bc05b0d4
2016-10-18 20:41:29 +02:00
Akash Jain
2b12f247ff GSoC: Add new CommonSalLayout class
Change-Id: Ic11e573da2f5fd6ef931f53ab674f8894815c3b4
2016-10-18 20:41:29 +02:00