375379 Commits

Author SHA1 Message Date
Mox Soini
e4d55e8045 Cleanup crossplatform cairo
Mac / Win cairo is not built / used, this cairo code can be removed to
reduce code bloat.

Change-Id: I758d674291e25e0722f5c66a0096295e903786b1
Reviewed-on: https://gerrit.libreoffice.org/16049
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-06-04 21:31:58 +00:00
Zsolt Bölöny
8854643a0a Removed getNormal() from polygontools, it just calls B3DPolygon::getNormal()
Change-Id: I5a59ff8e0db1aee52d0b683c9c64e4b18b64e66b
Reviewed-on: https://gerrit.libreoffice.org/16077
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-04 20:08:04 +00:00
Caolán McNamara
4e96b27896 Resolves: tdf#91637 avoid -1 string index
Change-Id: I006040f4589065141310fe2a89b8d2ba3e54ad2c
2015-06-04 21:00:45 +01:00
Caolán McNamara
4cc2fb2db3 coverity#1302607 Logically dead code
also

coverity#1302606 Logically dead code

Change-Id: I510f17e93f7caf5f1c35becdf6b7d626c0160b66
2015-06-04 20:58:33 +01:00
Caolán McNamara
a6b6bb2aac coverity#1302656 Unchecked dynamic_cast
Change-Id: If84fc54892bbe65799b3bc344c700bb43bedc0cd
2015-06-04 20:58:33 +01:00
Michael Stahl
56763e94bf get-bugzilla-attachments: actually use the fdo bugzilla
bugs.libreoffice.org redirects to bugs.documentfoundation.org,
which isn't very helpful as it just causes duplicate downloads.

Arguably freedesktop.org could be removed; the are just ~5 interesing
attachments since the TDF bugzilla migration.

Change-Id: I26d2667848582209e382226108c47549e99cee97
2015-06-04 21:53:38 +02:00
Michael Stahl
e5f9ee1847 get-bugzilla-attachments: avoid writing incomplete files
Change-Id: I7d1139ddf8c88626dd716aa537a305c31b5be5d9
2015-06-04 21:51:25 +02:00
Michael Stahl
bd2eee0bd4 get-bugzilla-attachments: avoid FDO-TDF duplicates...
... by checking that a file with "fdo" already exists for bugs older
than the migration, instead of just ignoring the old bugs on TDF.

There are > 300 additional attachments not on freedesktop.org.

Change-Id: Ib7ee63041109071cc1241a875ef2cccbddfc699d
2015-06-04 21:51:25 +02:00
Michael Stahl
0cfe2c8c89 get-bugzilla-attachments: fix the multi-threading
The queue was limited to an arbitrary maximum size, causing half of the
jobs to be droppend on the floor.  Also it didn't run on Python 3.

Change-Id: I90bfba448291d901c5a7c83389d17c6acdd919c8
2015-06-04 21:51:25 +02:00
David Tardon
edb38d702d update to liborcus 0.9.1
Includes switching to dynamic libs.

Change-Id: I959c4e9430f8cf95f50d48e1b01d8323dba4af81
2015-06-04 21:45:12 +02:00
Andrzej Hunt
a3afa22ba4 Fix using /opt/lo/bin/nasm on windows/cygwin
Change-Id: Ib3755598bfccffc2efd67816ae5fa5dc8903553e
Reviewed-on: https://gerrit.libreoffice.org/16083
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-04 19:31:33 +00:00
Takeshi Abe
2d3517d853 Fix a regression introduced at 3d30077af27c8a6e91fb91175e6d2ea9a6f03d11
Change-Id: I245bff2ac179381b7eef7c276bbade15b0a57938
Reviewed-on: https://gerrit.libreoffice.org/16082
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-04 19:30:37 +00:00
Caolán McNamara
85e926ff2e coverity#1304135 Missing break in switch
from

commit 0e2ef262bea4cbc7cb04cfcd1d47f2a9d6092398
Date:   Thu May 21 13:58:52 2015 +0200

    tdf#88276: Add background colour toolbar and sidebar buttons

    but they do nothing yet, follow-up commit(s) add real functionality
    to them

I take it that bNeedTextSpacing = true where it used to be mpToolBoxSpacing->Enable()
so fall-through that happens anyway also sets bNeedTextSpacing so presumably
everything is ok here

Change-Id: I8f1d4137a74fcc2c7ba6959e5b5c4b1f7464643c
2015-06-04 20:23:34 +01:00
László Németh
2f779fc046 tdf#91260: cleanup - textboxes extending beyond the page
Storing Undo data is unnecessary here, because shrinking is applied
only on the  text frame of the textbox. The shape component of the
textbox isn't modified.

Change-Id: Iaff64ff4953adbfa830832da146343cef2734547
2015-06-04 18:21:51 +02:00
Yousuf Philips
76a9afc9da tdf#91781 Changes based on discussion of heiko suggestions
Change-Id: I6d70e40c829e125205516d894e4fd1a36e7882fa
Reviewed-on: https://gerrit.libreoffice.org/16067
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-04 16:13:43 +00:00
László Németh
177f8e8bbd fix rendercontext rendering of standard toolbar icons
Change-Id: I6e0399c16d3e900fbca56fc757f342ea893d0ad4
2015-06-04 18:10:43 +02:00
Stephan Bergmann
cd17c9f96a Don't downcast this to derived in base ctor
Change-Id: I1a0a6a7f0ac2292a7824bd35967140a20ee93f89
2015-06-04 18:06:35 +02:00
Miklos Vajna
3705cf8212 abpilot: refer embedded data source from doc settings
So that even if the address book data source wizard creates the embedded
data source, next time the document is loaded, we can find it.

Change-Id: Ibb11fa119fb27976437e54bed1d590cfd9863236
2015-06-04 17:49:43 +02:00
Mike Kaganski
a977937927 tdf#90996: don't overwrite comments in ScTable::FillFormulaVertical
IDF_CONTENTS includes IDF_NOTE, which should not be used here

Change-Id: I904fbdbfcb97865a5682d9073e0ce2d5a2c694fb
Reviewed-on: https://gerrit.libreoffice.org/16085
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-04 15:37:15 +00:00
Mike Kaganski
b89f112f16 DomainMapper::lcl_attribute: fix missing break
Change-Id: Ibf0bd1c8bf2799ffbe5254ae11998a58d927b592
Reviewed-on: https://gerrit.libreoffice.org/16074
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-06-04 15:25:38 +00:00
Caolán McNamara
4bf829ba2a GetWin seen as NULL sometimes
Change-Id: I08974e3a8a3f34e2c1f0843c536e72ca0eb4b29d
2015-06-04 16:22:40 +01:00
Stephan Bergmann
d8439ca1b4 Match basicide_choose_macro in basctl/source/basicide/basobj2.cxx
Change-Id: I9add8be1c20c2529edf8d8616fe5e372938cd355
2015-06-04 17:20:51 +02:00
Stephan Bergmann
588591d948 Match basicide_macro_organizer in basctl/source/basicide/basobj2.cxx
Change-Id: Ib185645e84f8792d3ed29e7d5e674e5e7cc39fc5
2015-06-04 17:00:24 +02:00
Stephan Bergmann
530ebc516b unused
Change-Id: Ie11bf740c0ae672e7e1b14652f93bb6222bf45b7
2015-06-04 17:00:24 +02:00
Katarina Behrens
42f4a65103 tdf#91840: Default to transparent text background
(+ label the button)

Change-Id: Icc6a0c5e3e715bcfe1392496bef2514fd1bdb62b
2015-06-04 15:17:38 +02:00
Katarina Behrens
0deb0326b3 Use switch-case instead of overly long 'if (a || b || ...)'
they were growing a bit out of control

Change-Id: I80441179b4d4aacc57c469fc8f3a3937866ceae8
2015-06-04 15:17:14 +02:00
Miklos Vajna
b3f5ab7765 abpilot: embed the data source definition, if possible + requested
Change-Id: I0e70459e331995388b36c77c351bff89ece004a6
2015-06-04 15:14:23 +02:00
Miklos Vajna
b2117c98ed abpilot: store embedding preference in AddressSettings
Change-Id: I83235f79d30e5f573fee95a525b4cfe1211a24b7
2015-06-04 15:14:22 +02:00
Miklos Vajna
ef0217f24e abpilot: add checkbox to embed data source in datasourcepage
Change-Id: Iea9984af3f08ed214815b9477019695f2339a7f3
2015-06-04 15:14:22 +02:00
Caolán McNamara
eea5ac7910 Resolves: tdf#84483 postit layout not available in print preview mode
for the moment don't crash anyway, maybe we can rearrange matters
to make this possible.

Change-Id: I2dc9831e5b026004b2f7603e618330154dbd6d1b
2015-06-04 14:03:16 +01:00
Takeshi Abe
1ba1cbe48c tdf#91425 CRASH - Calc Insert Columns Left
This fix is a SCCOL variant of:

commit c66d1b9fcc2244b4fd8940f17ebf4e772f09c84e
Author: Kohei Yoshida <kyoshida@novell.com>
Date:   Thu May 5 00:23:25 2011 -0400

    fdo#36406: Let's not use invalidated iterators.

    std::set::erase(iterator) call invalidates the iterator of the erased
    element.  We better not use it after the erase() call.  Since the number
    of manual breaks should not be high enough to cause a performance
    bottleneck under normal usage, a safer linear copy should just be fine.

    Now, I'm not sure if this indeed is the cause of the erroneous amount
    of manual breaks in the test document, but I didn't see any other likely
    spot.

Change-Id: I0c2e8f738949776aa7f8ea5528e2c0eeb9351c16
Reviewed-on: https://gerrit.libreoffice.org/16063
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-06-04 12:14:17 +00:00
Stephan Bergmann
57e7f48633 loplugin:simplifybool
Change-Id: I19e96b882a5cc8991035a8275aebd4ff586bf9f3
2015-06-04 14:13:38 +02:00
Tomaž Vajngerl
656d9046a2 disable off-screen drawing of statusbar items (for now)
Change-Id: I5deac9924b99ac1b3e1440623364004b0b44aaf5
2015-06-04 21:09:06 +09:00
Zsolt Bölöny
d67f4ed258 Fix typo in .gitignore
Change-Id: Ibecee87ffe3ec6990e36952488668b790a8e54eb
Reviewed-on: https://gerrit.libreoffice.org/16076
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org>
2015-06-04 11:00:05 +00:00
Caolán McNamara
3f69547397 Resolves: tdf#46440 SIGSEGV on toolkit bootstrap without running instance
Change-Id: I9a78a75b3d72586b1702ed6fa63bb0b62ce6cd72
2015-06-04 11:10:10 +01:00
Noel Grandin
407c6c871e replace FLYPROTECT with scoped enum
Change-Id: I665d2944f5d24b4ec5015274c1b95b106a028291
Reviewed-on: https://gerrit.libreoffice.org/16072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04 08:29:44 +00:00
Stephan Bergmann
bf98e6acde Revert "disable JunitTest_dbaccess_complex part RowSet"
This reverts commit 217dbf61ece9318f4430780d10cef60920086de7, the test should
work now reliably after the preceeding "Finalizers must not access UNO objects"
commit.
2015-06-04 10:04:21 +02:00
Stephan Bergmann
3766f2a0d3 Finalizers must not access UNO objects
If the object being finalized (A) has the last reference to the UNO object (B),
and B is actually a proxy for a remote UNO object, then A and B become eligible
for finalization in parallel, and the finalizer of B may already have run when
the finalizer for A runs.  That means that B may already have been removed from
the remote bridge, causing an "unknown OID" error from the remote end when the
finalizer of A now tries to make a call on B.

(We try to assert that close() has actually been called before finalize() calls
delete(), but the corresponding exception may be silently swallowed by the JVM
finalization machinery.)

This caused spurious "URP: queryInterface request message with unknown OID
received" failures during JunitTest_dbaccess_unoapi.

Change-Id: Ia47c3ef2c22a6adc75b1b8271eb4b3140accebe7
2015-06-04 10:04:21 +02:00
Stephan Bergmann
1d7220d034 More informative exception message
Change-Id: If168a3be2630170636c333e177c5db0d40092cbe
2015-06-04 10:04:20 +02:00
Stephan Bergmann
4dd0ac6285 Let JUnit take care of exceptions
Change-Id: Ic628e4eccab59dce5d6d5e77656cac1f0006a491
2015-06-04 10:04:20 +02:00
Tomaž Vajngerl
aca61aa5ff tdf#91529 hopefully fixes the issue by painting immediately
Change-Id: I0c97e489150cd65d1ab1dbff4ee9f1699f89ac2e
2015-06-04 16:51:27 +09:00
Noel Grandin
3d30077af2 convert GOTOOBJ constants to scoped enum
Change-Id: I2f44e780c7250cdbf40fde8779beb81f29498f8b
Reviewed-on: https://gerrit.libreoffice.org/16071
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04 07:13:15 +00:00
Miklos Vajna
849278b952 svl: prefix remaining members of SvxSearchItem
Change-Id: Id538ee368de6cd63f08618e6284bca97e20bf7a3
2015-06-04 09:00:12 +02:00
Noel Grandin
7980055926 convert MT_ constants to scoped enum
Change-Id: I21e253ed9dccdab84be4838b5beee9385467ed37
Reviewed-on: https://gerrit.libreoffice.org/16068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04 06:52:47 +00:00
Noel Grandin
81610561ed uno::Sequence provides now begin and end
use begin() and end() when calling std::copy on an uno::Sequence

Inspired by commit b34b648fc3262c5d9aa295f621e8fe9c97d4c6b2
"uno::Sequence provides now begin and end"

Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b
Reviewed-on: https://gerrit.libreoffice.org/16057
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04 06:35:44 +00:00
Noel Grandin
a9a2375a74 convert SW_DB_SELECT constants to scoped enum
Change-Id: I03387e8e90891b3477c9c15200acc127262170bc
Reviewed-on: https://gerrit.libreoffice.org/16070
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04 06:33:47 +00:00
Noel Grandin
68577e5a90 convert SP_EXTEND_RANGE constants to scoped enum
Change-Id: I4d6ed976f4df63c7c51dd110b45787f2396518e4
Reviewed-on: https://gerrit.libreoffice.org/16069
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04 06:32:41 +00:00
Noel Grandin
623445aa0e convert PropertyMode to scoped enum
Change-Id: I9b0bbf6273aa18ae918d1d69af5dcc7652181f5c
2015-06-04 08:30:24 +02:00
Noel Grandin
42f771d6e9 convert B2DLineJoin to scoped enum
Change-Id: I4fb8f2c9e2080e3aa542d2ccf838e6784baa8429
2015-06-04 08:30:24 +02:00
Noel Grandin
1d92933d96 convert B2VectorContinuity to scoped enum
Change-Id: Ifa401dd0d2d1bef8c0ae2987d2aee86100b59816
2015-06-04 08:30:24 +02:00