Commit Graph

377346 Commits

Author SHA1 Message Date
Noel Grandin
e51fa14358 create a macro to tidy up the declaration sites of o3tl::typed_flags_set
Change-Id: Ifb8fd4fd5128188420f1dfda6b6f695160d5e77a
Reviewed-on: https://gerrit.libreoffice.org/15865
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-15 23:40:19 +00:00
Justin Luth
e1b123896d tdf#87437 exclude CR/cell break from redline deletions
The marker used in Word to identify table cell division was being
included in the track-changes deletion from the following cell if
the deletion was the first node in the cell.  This would cause the
two table cells to merge into one when changes were accepted by
Word.  (Problem not seen in LibreOffice itself.)

Change-Id: Ia98017cbba7d3a43b67764ae0fa6447b7e90ca86
Reviewed-on: https://gerrit.libreoffice.org/15340
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-15 23:23:38 +00:00
Mike Kaganski
7ef02ac0ad tdf#89007: Fix ShouldRowKeepWithNext condition
KeepWithNext shouldn't be applied to nested tables

Change-Id: I6df002ae7b00afa0fcf82aab584f85d9a47315eb
Reviewed-on: https://gerrit.libreoffice.org/15794
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-15 23:15:14 +00:00
Michael Stahl
7068b56ba9 vcl: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I11bd73ff134895d05c7ce054b5ef26829a3bf8c3
2015-07-16 00:06:22 +02:00
Michael Stahl
218be53fe0 tools: replace boost::ptr_vector with std::unordered_map
Change-Id: I530c5f95dda9aa80654e3a2a20a2e236221e7305
2015-07-16 00:06:21 +02:00
Caolán McNamara
5c83253258 don't hang if at end of stream
Change-Id: I497a30041ec667237c2aa64963dcefb67753e87c
2015-07-15 21:16:33 +01:00
Caolán McNamara
8547c336b3 WaE: C2220
Change-Id: Ibf9fa7ffc3beb237a470952c265fb1bce313a08a
2015-07-15 21:16:08 +01:00
Caolán McNamara
1a3eedccd3 cppcheck: noExplicitConstructor
Change-Id: Ia86c6a2ce6c1f2501d0b18181966b61d9ef78746
2015-07-15 20:44:10 +01:00
Caolán McNamara
dc71a72753 bump size type
Change-Id: I2c32c253499a3efb22a3312ed1f0a608649ce124
2015-07-15 20:44:10 +01:00
Caolán McNamara
89857aacac tools polygons limited to 16bit indexes
Change-Id: Ib0f727a3681492c15b807ca159d8bf7675ee8f29
2015-07-15 20:33:08 +01:00
Michael Meeks
e1d78e123b tdf#92764 - make configmgr write less noisy.
Re-factor the TempFile abstraction and add a trivial OStringBuffer to
avoid emitting so many system calls - for writing small fragments of
configuration XML.

Change-Id: Ifbf5982ddb44845b2316087cafab4175a40e03cc
2015-07-15 20:39:50 +01:00
Caolán McNamara
d6790de07f cppcheck: noExplicitConstructor
Change-Id: Id438b987f72ae57bd4fa882e01fba17d3fa5b95b
2015-07-15 20:03:35 +01:00
Caolán McNamara
15dfcb7f46 don't hang with 0 len causing no progression
Change-Id: Ie553dab291c7bfbde033d89b84159aff6b42a160
2015-07-15 20:03:34 +01:00
Caolán McNamara
b8637e67d6 avoid hang in short pbm
Change-Id: I9b7f0832a4dc231e1e8f963858c155e3cd392667
2015-07-15 19:46:48 +01:00
Lionel Elie Mamane
7ba160cecf Remove harmful ill-timed CellController disable on mouse button down
This disable will be done, in a better way, by the call to
BrowseBox::MouseButtonDown below, *after* the destination of the mouse
click has grabbed the focus, by a call to DeactivateCell().

If this is done here, while the "source" controller still has the
focus, then the window's Disable() method will try to pass the focus
the the "next control". However, the "next" control may belong to
another form, and this will do a (premature!) save to the database of
the modifications. This may lead to a database error, when the data is
not in a shape to be written to the database, e.g. when on an
insertion row and not all mandatory fields have been filled in.
This then pops up an error message to the user.

Change-Id: I38b1850319691b34232e51f131f8d099dc4a9114
2015-07-15 19:52:50 +02:00
Michael Stahl
bcb1f81668 svx, sd, sw: GetPoolDefaultItem() can actually return nullptr
...if you call ResetPoolDefaultItem() first. Crash found by Varun Dhall.

Change-Id: I409484c172fb5843270aee2425844076a008b4df
2015-07-15 18:38:38 +02:00
Andrea Gelmini
9fb8b39686 xmloff: ODF import: fix spelling of "extrusion-first-light-level"
The attribute is not imported currently due to the typo, but is exported
with the correct spelling from shapeexport.cxx:4377 with
XML_EXTRUSION_FIRST_LIGHT_LEVEL.

Change-Id: I83d77e7eabbbc961fa4f7faf8e20b47601ba071b
Reviewed-on: https://gerrit.libreoffice.org/16641
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-15 16:23:38 +00:00
Vasily Melenchuk
76772c8016 cmis: allow http authentication even when password is empty
Test environment for CMIS server using Apache Chemistry and by
default it has just username without password for authentication.
But libcmis uses authentication only if both username and password
are given.

Corresponding patch is already applied to libcmis master.

Using default patch level 1 for libcmis patches, updated existing patches.

Change-Id: Id77b59324002e47258b6315d7383496fa1e9c6ae
Reviewed-on: https://gerrit.libreoffice.org/17070
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-15 16:03:52 +00:00
Michael Stahl
fdd391f54e xmloff: document that AOO 4.1 has fixed the svg:d 'z' relative bug
Change-Id: I0f62101b7bc9de2281ade3eaaa0a38b16f4ccede
2015-07-15 16:34:29 +02:00
Katarina Behrens
0789a1f8d6 Make SvxFillAttrBox available outside svx too
Change-Id: I44a4d59cdccaa3bc42e14ca95984f7334e269ea8
2015-07-15 15:40:10 +02:00
Stephan Bergmann
6de7d32df1 -Werror,-Wunused-private-field
Change-Id: I7dc6c1db75d38d0fe5ee333d4f6a8697abf59e4b
2015-07-15 15:18:57 +02:00
Michael Stahl
f466347a5a sw: remove unused SwUnoTableCrsr::Clone()
Change-Id: Ic41c9fb96bf0d3dc429f1de18b8ce93c50885827
2015-07-15 14:59:33 +02:00
Noel Grandin
a111044bab loplugin:unusedmethods linguistic
Change-Id: I0a2aac4965c444dbd868515549dcc9b1571166cb
Reviewed-on: https://gerrit.libreoffice.org/17067
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15 13:03:34 +00:00
Caolán McNamara
d1046e7c3f Resolves: tdf#63955 clip 19km long line to some sane limit
Change-Id: If9757a5fa2bb93b56b9cf9f566972f687a4a3a45
Reviewed-on: https://gerrit.libreoffice.org/17036
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-15 12:11:14 +00:00
Noel Grandin
536051f886 fix Windows build
after commit 22b094f5d8
"loplugin:unusedmethods basic"

Change-Id: I7586d2487e47731db93335c3d9969626bf2eb6ab
2015-07-15 14:04:59 +02:00
Tor Lillqvist
dffb58131f WaE: 'HAVE_FEATURE_GLTF' is not defined, evaluates to 0
Change-Id: I8fec50dcd380fd6bb77672a898c107483298c027
2015-07-15 15:03:17 +03:00
Julien Nabet
5325c5b2bd getFiles refactoring: kde4 part
before:
getFiles retrieves all files with their url
getSelectedFiles just returns getFiles result

after:
getSelectedFiles retrieves all files with their url
getFiles uses getSelectedFiles and truncates to 1 entry if necessary

See http://nabble.documentfoundation.org/Dev-f1639786.html for discussion

Conflicts:
	vcl/unx/kde4/KDE4FilePicker.cxx

Change-Id: I56a0e2bc877f93e28f08d5ebaafd1826a92cef8b
Reviewed-on: https://gerrit.libreoffice.org/17025
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-15 12:02:35 +00:00
Caolán McNamara
adfa89b5ff check stream state more often for failures
Change-Id: Ie45d858021c3123ec21829cbf4742cf30ce46665
2015-07-15 13:01:38 +01:00
Tor Lillqvist
23a0fe7873 Clarify documentation of (mis)features of osl_getExecutableFile()
Change-Id: I106b14a8ce2709c11f23eb1d49924c9c5ab51b50
2015-07-15 14:54:28 +03:00
Noel Grandin
d009000971 fix Android build
I removed the method in commit
a62129aa63
"loplugin:unusedmethods xmloff"

Change-Id: I0e543b4b9b572f843f68023396d9344c455c2bc1
2015-07-15 13:52:08 +02:00
Noel Grandin
b303f274ab loplugin:unusedmethods drawinglayer
Change-Id: If28de80a09fbc8e72df9e919cce66cf425134d4c
Reviewed-on: https://gerrit.libreoffice.org/17062
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15 11:33:46 +00:00
Noel Grandin
269bf161e6 loplugin:unusedmethods framework
Change-Id: Ibfeb0ef753a083f458c84f446f0729f05c73e2d6
Reviewed-on: https://gerrit.libreoffice.org/17060
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15 11:33:21 +00:00
Noel Grandin
a62129aa63 loplugin:unusedmethods xmloff
Change-Id: I9d15d8edcc6746c055336bf31e5b0c15cb971ffe
Reviewed-on: https://gerrit.libreoffice.org/17061
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15 10:36:25 +00:00
Tor Lillqvist
8474e8260a Log the actual string, not the rtl_uString pointer value
Change-Id: I51938f4801436aff31b51fd36c89582062f83b9a
2015-07-15 13:12:55 +03:00
Caolán McNamara
8a60e78769 file format documentation states these are signed
Change-Id: Iaca58dda19d24a767333ff642759414951a03e6d
2015-07-15 11:04:16 +01:00
Caolán McNamara
83b3349bb9 refactor ensuring polygon has at least a line in it
just split that out into a standalone function, no logic
change

Change-Id: I061d5d716b3fc2a9fb6385e7fb249ce300752130
2015-07-15 10:36:37 +01:00
Noel Grandin
8d5f471706 loplugin:unusedmethods configmgr
Change-Id: Ie0338860717630633752a39814057c736d1faee8
Reviewed-on: https://gerrit.libreoffice.org/17059
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15 09:33:55 +00:00
Noel Grandin
04b472af1e loplugin:unusedmethods accessibility,fpicker,uui
Change-Id: I106a0be06c4b9fe1313bbd8d4c62472c4b0a4b4f
Reviewed-on: https://gerrit.libreoffice.org/17045
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15 09:31:13 +00:00
Noel Grandin
22b094f5d8 loplugin:unusedmethods basic
Change-Id: Iddfbde451088750f8c74f3ac72c35b5ccfbe0ab1
Reviewed-on: https://gerrit.libreoffice.org/17044
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15 09:07:05 +00:00
Stephan Bergmann
ba562acdf2 Remove pointless check for well-formed sal_Bool value
Change-Id: I69cd54f6fddc93f0cdf87651401fedb60aeeb1f4
2015-07-15 10:42:28 +02:00
Ashod Nakashian
b0fde7a912 tdf#38837 Reduce power consumption by minimizing idle timers
Both the document statistics- and state-manager have their
own modified flags. There is a cyclic dependency between the
the two in that updating the document's statistics also marks
the document as modified. Of course when a document is edited
the statistics modified flag is set to trigger an update.

To avoid a perpetual cycle, the statistics manager resets the
document's modified state to that before setting the new
statistics. However, this doesn't reset the statistics
modified flag, which was set when the document was modified
by setting the new statistics. Hence, the statistics thinks
there are modifications in the document when there isn't.

This patch is to make DocumentStateManager::ResetModified()
symmetrical to DocumentStateManager::SetModified() by
reseting the modified flag of the statistics manager.

The idle CPU drops to nil on unmodified documents after this.
However, for modified documents the statistics is recalculated
perpetually until the document is saved. This will need a
different patch to fix.

Change-Id: Ib5936bc1acbda34fcac6a00ec46eaa31e4363885
Reviewed-on: https://gerrit.libreoffice.org/16774
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-15 07:46:01 +00:00
Noel Grandin
82da70787a loplugin:unusedmethods connectivity
Change-Id: Ie9f3daa49b02dddc7b56d1f5fb58a229f53d4513
Reviewed-on: https://gerrit.libreoffice.org/17043
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15 07:45:23 +00:00
Dennis Roczek
880e3af2b5 removing additional colons from the commit msg
Change-Id: Ie35ee8c392e3e8ebc4a42d20e76813c8d29d387b
Reviewed-on: https://gerrit.libreoffice.org/17028
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-07-15 02:12:00 +00:00
Maxim Monastirsky
a3050f6325 Convert filters button to the generic controller
Change-Id: I6d3c76c0aafe0ad77b597a2cb8331e6f8219e2d2
2015-07-15 01:26:23 +03:00
Maxim Monastirsky
d311b65f27 Convert optimize table button to the generic controller
Change-Id: I6b9089daaa2bb7d0dfc1072296fc51401e5fc88a
2015-07-15 01:26:23 +03:00
Maxim Monastirsky
489af4ed79 Convert insert buttons to the generic controller
Change-Id: If7c6c1c5000893fca4205162526b4b4035637c11
2015-07-15 01:26:22 +03:00
Michael Stahl
dac1be92f2 sfx2: remove pointless GenLink class
Change-Id: I82df7b89c598c3c7903dee865f899862902a0d86
2015-07-14 23:06:40 +02:00
Michael Stahl
8fdf12f79e sfx2: an almost unnoticable tweak to comment translation
Change-Id: I7089b09c4497a2fc4cf8ca13ab098c747e565721
2015-07-14 23:06:40 +02:00
Michael Meeks
097292feab Add HKEY_CURRENT_USER registry integration.
It seems rather odd that we dump this to a file and parse again to me.

Change-Id: Ia32ba9ff3e7878d40032bd7d10fba2c143d11757
Reviewed-on: https://gerrit.libreoffice.org/17033
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2015-07-14 20:20:32 +00:00
Michael Meeks
0a7375e372 tdf#91715: lock SolarMutex from dbaui::~ODatabaseAdministrationDialog()
Change-Id: I91b78ec3a19b6f09ae6e9ff723ebda41d656f2fc
2015-07-14 19:39:40 +02:00