381226 Commits

Author SHA1 Message Date
Stephan Bergmann
e8233e1510 clang-analyzer-deadcode.DeadStores
Change-Id: I03769bd4105e4e1d140b2885978ea9da9ef866de
2015-10-06 15:31:16 +02:00
Stephan Bergmann
5e02785ff1 clang-analyzer-deadcode.DeadStores
Change-Id: Ib26cbbc839040c49288606f588cb7400d7e40b83
2015-10-06 15:31:15 +02:00
Stephan Bergmann
66ef464799 clang-analyzer-deadcode.DeadStores
Change-Id: I2ef946572a61eb766454d2df0cb2ff523050ed7e
2015-10-06 15:31:15 +02:00
Samuel Mehrbrodt
70b72e8705 Emscripten: Add patch to build ICU
Change-Id: If5924054b53fd2b5acf2ec903cd1acf710cc2ef1
2015-10-06 15:16:46 +02:00
Michael Stahl
0ca6d934b3 libreofficekit: -Werror=unused-macros
Change-Id: I154bd2c101819669d43ab475144ae400454df4d0
2015-10-06 14:24:17 +02:00
Yousuf Philips
cd1c867cd2 tdf#75256 Correct incorrectly named page setup icon for impress
Change-Id: I6a1f4e5d98b26e8019d22b1e302191f3d7ae4f34
Reviewed-on: https://gerrit.libreoffice.org/19171
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-06 12:24:38 +00:00
Miklos Vajna
58c38e7ea5 sw tiled rendering: emit LOK_CALLBACK_SEARCH_RESULT* for normal search
We used to emit these for find-all only, for no good reason.

Change-Id: Id07dc7649f9a8528b9d4ec16d5f7c651fd607111
2015-10-06 14:18:12 +02:00
Miklos Vajna
ca8016c3a3 sw: extract lcl_emitSearchResultCallbacks() from SwView::ExecSearch()
Change-Id: I9c6b7540bcae85d6529e5cc195a7e86f58ee5713
2015-10-06 14:18:11 +02:00
Douglas Mencken
85b1f91779 vba: convert to variadic InheritedHelperInterfaceImpl&WeakImpl etc
Variadic templates ~-i.e. templates, which can take an arbitrary
number of arguments of any type-~ is new C++11 feature

note that uno::Reference and cppu::UnoType can only take one parameter
thus leave XNamedObjectCollectionHelper non-variadic in vbacollectionimpl.hxx

Change-Id: I22e60fa050ee31d39ae8bb7cac06cf243c4587b1
Reviewed-on: https://gerrit.libreoffice.org/19145
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-10-06 12:13:54 +00:00
andreas kainz
8e7a2a62d1 Breeze Icons: link icons
Change-Id: I9ffddefd11b673ae1c8f4300cd1b96d121318116
Reviewed-on: https://gerrit.libreoffice.org/19177
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2015-10-06 11:49:57 +00:00
Stephan Bergmann
e41fad1944 Replace some OSL_ENSURE with assert
...at least in the !IsEmpty() branch of XclExpString::WriteBufferToMem, pnMem is
used in ways were being null would be undefined behavior, and the only place
from which WriteHeaderToMem, WriteBufferToMem are called (lclAppend in
sc/source/filter/excel/xeformula.cxx, via WriteToMem) will always pass a non-
null argument anyway

Change-Id: Iabc06b53ae6059246c5c222d43a789c6bdc440d5
2015-10-06 12:48:18 +02:00
Stephan Bergmann
f94d4952dc Commit loplugin:returnunique to store/, for reference
Change-Id: I359d8ab47276e5c801522251d5e141946d94ca5d
2015-10-06 12:44:37 +02:00
Stephan Bergmann
7f37d443cf Return SdrObjectPtr from some XclImpDrawObjBase::Create... etc. functions
Change-Id: Ia68b68aaca7feaacd2245254b2f2d110e669aaef
2015-10-06 12:44:37 +02:00
Stephan Bergmann
baa9c806e8 Return std::unique_ptr from some XclEscherEx::Create... functions
...even if, for now, the return values are directly release()'ed anyway at the
call sites

Change-Id: I118c74787260b1ec7eabf5e300580aa5a16b2cfa
2015-10-06 12:44:36 +02:00
Yousuf Philips
051667ec91 tdf#94477 Make Format > Character accessible for customization
Change-Id: I45d02a6a24986175de2283c09e097f73d90cef73
Reviewed-on: https://gerrit.libreoffice.org/19187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-06 10:25:27 +00:00
Miklos Vajna
c92ebc8503 Disable spellcheck when LOK is active
It's not useful when viewing, and for editing probably a dedicated
overlay would be better (like the one we have for cursor/selections
already).

Disable for sw/sd explicitly, sc had it disabled implicitly already.

Change-Id: I7134f5d1a1546787c22019e6b1abdc0dd887f888
2015-10-06 12:05:14 +02:00
Miklos Vajna
0cf63ba224 sw: outline SwViewOption::SetOnlineSpell()
Change-Id: Ic81b039e9a1b592ca52ab684ddb45ee44c7714df
2015-10-06 12:03:34 +02:00
Miklos Vajna
23ac7f2fb5 lokdocview: log paintTile() arguments
Change-Id: I8015c8030c1c7f53ae1de053fe268a33464834ad
2015-10-06 12:03:34 +02:00
Stephan Bergmann
78697c7956 pthread_mutex_lock/unlock must not be called with null argument
...so these OSL_PRECOND should really be assert

Change-Id: I61ebd16e14be81c579cd71f3cd6cd68afb95778d
2015-10-06 11:51:19 +02:00
Andras Timar
9942defff7 Info.plist: removed deprecated stuff, added cdr, visio, mspub formats
Change-Id: I24a83ba15591aca8787726f9fabf12b56ed323b2
Reviewed-on: https://gerrit.libreoffice.org/19148
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2015-10-06 09:29:15 +00:00
Oliver Specht
f9157d1a21 tdf#94811: Crash in Open Remote File dialog fixed
Edit control needed a disposeAndClear instead of a clear

Change-Id: I24f4ec8c391080cb83574949cc141c883b43cfb9
Reviewed-on: https://gerrit.libreoffice.org/19185
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-06 09:17:22 +00:00
Stephan Bergmann
9d7f03f2ab -Werror,-Wunused-private-field
Change-Id: Ifb599354720369458a43d8e1e7bca9ceb24d7c7d
2015-10-06 11:07:59 +02:00
Caolán McNamara
a2aed0e866 revert executable perm change
from 89d39bc100aabf5dccbe77c0b5c0c85736e85b39

Change-Id: Ia98ffdf9d0ffdb6c5037c9cbe911cb9d2212107c
2015-10-06 09:36:16 +01:00
Stephan Bergmann
f52449e43b -Werror,-Wnull-conversion
...presumably this is what was meant in 89d39bc100aabf5dccbe77c0b5c0c85736e85b39
"tdf#94559: 4th step to remove rtti.hxx"

Change-Id: I844939fe4cd1f452747ac3cf3410659bba748efb
2015-10-06 10:21:53 +02:00
Miklos Vajna
a7b86140d7 CppunitTest_sw_tiledrendering: CALLBACK_SEARCH_RESULT_SELECTION testcase
Change-Id: I66a8d73581641c71f2dce2d1992070f3ccce08c2
2015-10-06 10:18:43 +02:00
Miklos Vajna
2b6060d6c5 gtktiledviewer: recognize LOK_CALLBACK_SEARCH_RESULT_SELECTION
Change-Id: Ib932ee36e41afcb53d15a6362b998cc673d474f2
2015-10-06 10:18:43 +02:00
Miklos Vajna
94752d5970 LOK: add CALLBACK_SEARCH_RESULT_SELECTION and implement it in sw
Change-Id: I4c2a5418101976e1cb38c0fa71dbd66fc883f905
2015-10-06 10:18:42 +02:00
Noel Grandin
7e776c0027 loplugin:unusedmethods
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
2015-10-06 10:17:02 +02:00
Stephan Bergmann
d7f2db4b9c Hold some objects by rtl::Reference
Change-Id: If42b0fea8417f5e8ce2cb68d79e92e628c77d9e5
2015-10-06 10:02:52 +02:00
Stephan Bergmann
6b9b38fed9 Hold ScAccessibleDocumentPagePreview::mpTable by rtl::Reference
Change-Id: I808f406c6c6c46c0a72e6e02503899e78ba7f7e4
2015-10-06 10:02:17 +02:00
Stephan Bergmann
f9fe7235e1 Hold ScAccessibleDocument::mpAccessibleSpreadsheet by rtl::Reference
Change-Id: If5b0c7603bb69697a53954b6adfd5ff91d196503
2015-10-06 10:01:45 +02:00
Oliver Specht
89d39bc100 tdf#94559: 4th step to remove rtti.hxx
replaced use of PTR_CAST, IS_TYPE, ISA in
    idl, editeng, sc, sd, sw, sfx2, sot, starmath

Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653
Reviewed-on: https://gerrit.libreoffice.org/19132
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-06 07:29:37 +00:00
Noel Grandin
32b9901dae need <numeric> for std::accumulate
Change-Id: Ic7d237ab5e4a7925bf265b8ab495ad3e0c128735
2015-10-06 09:26:14 +02:00
Noel Grandin
8a248d69cc loplugin:mergeclasses
in this case, just rename the baseclass so that it matches the
other places we do this

Change-Id: I21704db7352f72e43636dde9e92c8bef61b7e251
2015-10-06 09:26:14 +02:00
David Tardon
eed51624b3 astyle
Change-Id: Ib3d4456edf72347e27616d13c89978075c324d63
2015-10-06 09:11:04 +02:00
Noel Grandin
eb6381435f loplugin:loopvartoosmall
Change-Id: I502a7b8b2d18c9bd5c82e8abd8e3d98f21e8c446
2015-10-06 08:49:33 +02:00
Noel Grandin
946b9a04c4 loplugin:mergeclasses
and move the boost-depending code inside the module, no need to expose
that dependency and include that header in all client code.

Change-Id: Ib991572d7a54a9ad16825d688e76f8e3a824803c
2015-10-06 08:41:58 +02:00
Noel Grandin
d451de7f08 loplugin:mergeclasses
Change-Id: I592eef7503bd0b492f73ea5216f436302ad79ca8
2015-10-06 08:41:58 +02:00
Noel Grandin
4e2a8b78be loplugin:mergeclasses
Change-Id: I7c8c60aab31517d595a7e37c3789fa1e515ec3ee
2015-10-06 08:41:58 +02:00
Oliver Specht
501e757649 tdf#91417: import hyperlink with history flag correctly
ignore '\h' flag in hyperlinks imported from docx
including import test

Change-Id: I512e811050704f118bf9b2c786378f99e5d04378
Reviewed-on: https://gerrit.libreoffice.org/19154
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-06 05:49:40 +00:00
Miklos Vajna
b1a6a99b9a presenter console: add 'Restart Timer' button
Use case is that the presentation is started a few minutes in advance,
so the audience can check if they are at the correct room, seeing the
title side. Then previously the presentation had to be stopped and
started again, so the presenter had an idea how much time the talk took
so far. The side effect of this workaround was that the audience saw a
short flash while the presentation was not running.

Fix this by adding a button to just restart the timer, then it's not
needed to stop/start the presentation manually.

The two icons are just placeholders for now, real design is still
needed.

Change-Id: Id67e7e53a339ea5672dfb1c261f63d43466e9eff
2015-10-06 07:47:54 +02:00
Oliver Specht
cd5906358b tdf#93720: Interactive frame insertion is disabled if table is selected
Current implementation does not support interactive frame insertion
that moves the table into the frame

Change-Id: I57a69f680f1218bd3014da494d41542ad0b72dd1
Reviewed-on: https://gerrit.libreoffice.org/19157
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-06 05:44:21 +00:00
Oliver Specht
4d4bc508f0 tdf#93860: crash in table selection fixed
state method of FN_GROW/SHRINK_FONT_SIZE must not access invalid pointers

Change-Id: I0db539d735663561db84cf186a6ef31c8ad3de53
Reviewed-on: https://gerrit.libreoffice.org/19156
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-10-06 05:43:43 +00:00
Michael Stahl
3e5b53438d sw: try to fix the MSVC build
Change-Id: I5e3277e625004b30f0f05eef2b272736820a8836
2015-10-06 00:37:09 +02:00
Michael Stahl
f03417389e sw: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I1f77947b6f9fde4c949d32d524740be0951572af
2015-10-05 23:28:08 +02:00
Michael Stahl
6e3188efd5 sw: let's try to write a C++ program, stop using reserved identifiers
Change-Id: I8810ca647af7b376b1c2bb1c4d866eb081718145
2015-10-05 23:28:08 +02:00
Michael Stahl
3bcb74175b sw: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I1e6ccafea4c876b27e0a57e76c93f075f67a5f54
2015-10-05 23:28:08 +02:00
Michael Stahl
89ed0427bd sw: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: Iac4d1dcab229c3236d09af4e63d9e33bc038f23d
2015-10-05 23:28:07 +02:00
Michael Stahl
68daf1e8eb sw: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I44f3ff3779ea9c35fadc02ae6f2970d33aeb2f25
2015-10-05 23:28:07 +02:00
Michael Stahl
b6b3251683 sw: replace boost::ptr_vector with std::vector
Change-Id: If7b9251a1b3f953a7386d621da40b0c14bbf61be
2015-10-05 23:28:06 +02:00