Commit Graph

472708 Commits

Author SHA1 Message Date
Armin Le Grand (Allotropia)
eaaf5ef8f9 Advanced Diagram support: first additions/reorganizations
To allow advanced Diagram/SmartArt support in the future
this is a first step to organize imported SmartArt Data in
a way that will allow to re-layout loaded SmartArts, under
re-usage of the oox::Theme (held available).

It is designed to work without holding available the
original XML snippets defining the imported Diagram in any
way, also for performance reasons. It tries to re-use some
of the already basically added functionality, including
the systematic layouting using the generic layout
algorithm, plus some already available text extraction.

Before being sure that the former state can be completely
replaced this is optoinal and used when
SAL_ENABLE_ADVANCED_SMART_ART is defined. Some new stuff
is already done but e.g. the redefined reLayout method will
not (yet) be triggered. It works and reliably produces a
re-layouted identical version, also preserving
transformations.

Change-Id: I08cfbae04afa663d0589530aae549216d853128d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130171
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-02-22 18:09:24 +01:00
Stephan Bergmann
8187737a78 Restrict the converting rtl::isAscii* overloads
...to types that can be converted to sal_uInt32 without loss

Change-Id: Iad83591c6b70bf5efe1b6b14bacf1b6e9a225295
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130348
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-22 17:09:48 +01:00
Xisco Fauli
aa12351db4 CppunitTest_sc_subsequent_filters_test: do not inherit from test::FiltersTest
Change-Id: Id7e01ae7f087c6f1a981173aa840b169ec7d8799
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130351
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-22 16:01:02 +01:00
Rene Engelhard
19b0ba55ea add system-dragonbox
Missed in 9eb9083ff2

Change-Id: I1d001b39f55c8504a76bfbdadd1423b414adc9c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130209
Tested-by: René Engelhard <rene@debian.org>
Reviewed-by: René Engelhard <rene@debian.org>
2022-02-22 15:53:59 +01:00
Xisco Fauli
2ac21c47d0 CppunitTest_sc_jumbosheets_test: do not inherit from test::FiltersTest
Change-Id: I7a2e2bb29aa776f2b83af00329182ca4d7edae49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130350
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-22 15:44:21 +01:00
Heiko Tietze
dc54d2477c Resolves tdf#101179 - Correct menu entry for View > HTML Source
.uno:SourceView disables the other view options and is rather a toggle

Change-Id: I6be34bfbb5715db7fcd6458dccc1a99ca5885390
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130344
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-02-22 15:10:23 +01:00
Rizal Muttaqin
0a43965bf6 elementary: tdf#138400 General Number Format icons
Change-Id: Ica0e26b766358cba97c76f8ba91c08514283d356
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130343
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-22 14:45:10 +01:00
Stephan Bergmann
79c2398b80 Replace some fprintf with SAL_WARN
Change-Id: I3f31f223b6e906c6b40415a8d5c66c27e3c7cff5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130338
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-22 13:53:44 +01:00
Caolán McNamara
ff66c1d82b sort these alphabetically
Change-Id: I03f89dd78908d08534413c0fe6a753e3346b3738
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130336
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-22 13:40:46 +01:00
Stephan Bergmann
14a8eecaa4 Remove a debug-style fprintf
...that had been added in 811de66d7f "First
attempt at getting access to the Java VM on Android", together with another

  fprintf(stderr, "Got lo_get_javavm = %p", lo_get_javavm);

that had meanwhile been removed again in
5510127e89 "Android code refactorig and hacking"

Change-Id: I1a50563e2af1ea5a0ecbd2cc9d49d70c6e5bbbd3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130337
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Jenkins
2022-02-22 13:15:41 +01:00
Renwa Hiwa
0b0b1820d2 Better handling of msi
LIBREOFFICE-SK4E5D8N

Change-Id: I44f25a47ab6ffeb9d2b679874c8c96af1319eb2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130335
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-22 12:40:12 +01:00
Noel Grandin
27352b8163 Add XWeak constructor and operator= to uno::WeakReference
which is faster since we can skip the UNO_QUERY.

Change-Id: Id95ad9f3568213e974bd13659d92d4ea94dbfbd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130282
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-22 12:27:55 +01:00
Xisco Fauli
6ccdd0d164 CppunitTest_sc_tiledrendering: active LibreOfficeKit in the setUp
Change-Id: I7099540ce2939a45d50193e74d08be19995bb23c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130286
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-22 12:08:53 +01:00
Noel Grandin
06b7f930a5 tdf#64914 small improvements
(1) do not read the config inside a hot loop

(2) do not create a SvxShapeGroup only to remove it

Change-Id: I8ff3840d0972d2f617a326a67d18260e44220f56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130331
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-22 11:39:19 +01:00
Xisco Fauli
9b341bc420 tdf#147509: sc_jumbosheets: Add unittest
Change-Id: I464d2ce3e79a9e79d034e4cce86d63355e0b5a81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130290
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-22 11:06:42 +01:00
Luboš Luňák
827b218b94 merge poolio.cxx into itempool.cxx
It doesn't make sense to have few SfxItemPool functions in a separate
source file, and without LTO those tiny functions do not get inlined,
which is confusing when profiling.

Change-Id: I0ba891ba51c7d8dd3eba3f4cae0f7819f9b033e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130327
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-22 10:37:56 +01:00
Michael Weghorn
2ab735df69 gtk3 a11y: Make a11y role mapping more explicit
Use switch-case instead of an array that uses
the numerical value of the accessibility::AccessibleRole
as an index.

Change-Id: Id7fbc31c058d0db716d2b60a4a7eb7e7e954af95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130330
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-02-22 10:19:27 +01:00
Michael Weghorn
b910044514 gtk3 a11y: Just use ATK constants for roles
The ATK role used here that was added to ATK latest is
ATK_ROLE_FOOTNOTE, which was added in ATK 2.26.
With a minimum ATK version of ATK 2.28.1 (s.a.
Change-Id: Id7084366d2359deb60948b8969c1d3dcc68ddb47
"gtk3 a11y: Require atk >= 2.28.1, drop code for < 2.15.2"),
all constants can simply be used as is, so drop the special
handling that was there for older ATK versions which involved
calling 'atk_role_register' that was deprecated in ATK 2.12 [1]:

> Deprecated since:
> Since 2.12. If your application/toolkit doesn’t find a suitable
> role for a specific object defined at AtkRole, please submit a
> bug in order to add a new role to the specification.

[1] https://docs.gtk.org/atk/type_func.Role.register.html

Change-Id: I93579e84576feb1bcae8cecf2dc8b264e8be3153
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130329
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-02-22 10:19:12 +01:00
Michael Weghorn
c688fd1393 gtk3 a11y: Require atk >= 2.28.1, drop code for < 2.15.2
README.md lists RHEL 7 or CentOS 7 as runtime baseline,
which has ATK 2.28.1 [1].

Therefore, check for that version in configure.ac
and drop some code for versions < 2.15.2.
Requiring 2.28.1 as minimum ATK version will allow for
further cleanup in follow-up commits.

[1] https://centos.pkgs.org/7/centos-x86_64/atk-2.28.1-2.el7.x86_64.rpm.html

Change-Id: Id7084366d2359deb60948b8969c1d3dcc68ddb47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130328
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-02-22 10:18:46 +01:00
Ramreiso Kashung
bcaf132050 tdf#147132: Flatten Basic function implementations
Some SbRtl_* functions have been flattened at basic/source/runtime/methods.cxx

Change-Id: Id56485ddfaa972133c9b199d22b141d93df475f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130206
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2022-02-22 09:34:20 +01:00
Noel Grandin
b77e806f93 eliminate a layer of conversion in createSymbol2D
speeds up loading large charts

Change-Id: I935971e21dd5384d8f3e04e0022fd81c2c1c8232
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130301
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-22 09:14:19 +01:00
Miklos Vajna
775c75b8f3 sw: document SwNoTextNode
Also make it a bit more clear that GetCharRect() and
GetModelPositionForViewPoint() are the opposite of each other.

Change-Id: I1ec2b57c047522e98c2fde0a4b698d5816884dea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130304
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-22 08:54:04 +01:00
Tushar Jham
122ebe3ac7 tdf#143148 Use pragma once instead of include guards
Change-Id: If049cbcfc9b9a485c3be67e6111440662296b468
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130293
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-02-22 08:26:52 +01:00
Noel Grandin
56cd3b2b5d tdf#64914 slow opening large chart
shaves 2% off the load time by avoid the cost of
comphelper::getFromUnoTunnel

Change-Id: I9d0438bd0ad3cf753d34fe181481f3a57193651c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130284
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-22 08:07:23 +01:00
Stephan Bergmann
44c7cbd93f Adapt CustomTarget_postprocess/check_dynamic_objects to --enable-gtk4
> instdir/program/libavmediagtk.so has suspicious NEEDED: libgtk-4.so.1
> instdir/program/libavmediagtk.so has suspicious NEEDED: libpangocairo-1.0.so.0
> instdir/program/libavmediagtk.so has suspicious NEEDED: libpango-1.0.so.0
> instdir/program/libavmediagtk.so has suspicious NEEDED: libharfbuzz.so.0
> instdir/program/libavmediagtk.so has suspicious NEEDED: libgdk_pixbuf-2.0.so.0
> instdir/program/libavmediagtk.so has suspicious NEEDED: libcairo-gobject.so.2
> instdir/program/libavmediagtk.so has suspicious NEEDED: libgraphene-1.0.so.0
> instdir/program/libavmediagtk.so has suspicious NEEDED: libgio-2.0.so.0
> instdir/program/libavmediagtk.so has suspicious NEEDED: libgmodule-2.0.so.0
> instdir/program/libavmediagtk.so has suspicious NEEDED: libglib-2.0.so.0
> instdir/program/libavmediagtk.so has suspicious NEEDED: libatk-1.0.so.0
> instdir/program/libavmediagtk.so has suspicious NEEDED: libgobject-2.0.so.0
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgtk-4.so.1
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libpangocairo-1.0.so.0
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libpango-1.0.so.0
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgdk_pixbuf-2.0.so.0
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libcairo-gobject.so.2
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgraphene-1.0.so.0
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgio-2.0.so.0
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgmodule-2.0.so.0
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libglib-2.0.so.0
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libcairo.so.2
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libatk-1.0.so.0
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgobject-2.0.so.0
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libX11.so.6
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libXext.so.6
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libSM.so.6
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libICE.so.6
> instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libdbus-1.so.3

Change-Id: I686cdc5f21c9a730167e9efa120946f6d96eaed0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130305
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-22 07:56:24 +01:00
Andrea Gelmini
e2b4b08549 Removed executable bits on data files
Change-Id: Ifcdae0106380de978c608f46e82155c6c9eed20b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130292
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-22 07:04:45 +01:00
Rizal Muttaqin
c993d9e753 Colibre: tdf#147575 Open <DB Object> icons
Change-Id: Iccf074831a0fcccf071dda6ec6900ae315eb0ba5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130285
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-02-22 01:59:14 +01:00
Julien Nabet
4202ea2c93 cid#1500693 Resource leak
Change-Id: Ic560c2079be0b04ce382350390e03e0ec2d8abcc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130303
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-21 23:19:05 +01:00
Andreas Heinisch
3ba8b56b32 tdf#147089 - Round Integral Division (IDIV) literals to Integer values
Change-Id: Ia243c6117a437d0c6efb33a4e76c5e9ee539fbdc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130302
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-02-21 23:10:46 +01:00
Hossein
02e1be8883 Cleanup x509certificate_nssimpl.cxx
* Remove unused headers
* Remove 'using namespace'
* Use enum values in the condition

Change-Id: I45c20412db48ed1a3a4471db20193c2d9cde2f94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130214
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-21 20:55:45 +01:00
Luboš Luňák
db345bee73 use 64bit for window sizes (tdf#147458)
Change-Id: Iaa240aeae8bacbff6bccd9bf0721a02414b6f47d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130288
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-21 19:35:33 +01:00
Miklos Vajna
8c2607ae3c sw HTML export, XHTML mode: fix lost </li> when last list item is not numbered
This went wrong in 013a4f1f5c (sw XHTML
export: fix handling of list labels, 2021-05-13), where we started to
assume that in case the last paragraph of a list is not numbered, then
the entire list is not numbered. This lead to loosing the </li> for an
<li> in case the list starts with a numbered paragraph, but ends with a
non-numbered one.

Fix the problem by (if necessary) looking back till the start of the
list to see if any paragraph is numbered: that ensures that the <li> and
</li> is always in sync.

This fixes the new problem and keeps the old problem fixed at the same
time.

Change-Id: I7d347b37a40dcc727c2080bf8279e33c3ad147e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130287
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-02-21 19:14:41 +01:00
Caolán McNamara
97f4162158 cid#1500477 silence Explicit null dereferenced
Change-Id: Ic57c49ce1c65ecca4e87be970e76bf16ba234711
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130273
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21 18:47:05 +01:00
Caolán McNamara
ff215479a8 cid#1500515 Dereference after null check
Change-Id: I6483c3a036c5c56c8c6515b5b8f08720c8bd1a6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130269
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21 18:45:12 +01:00
Caolán McNamara
00866f35a9 cid#1500612 Dereference after null check
otherwise this doesn't make sense

Change-Id: I321a86cf8f9f05639b686a4c15b2e8fca2e10955
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130271
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21 18:44:48 +01:00
flywire
b0ebb2bf61 Update git submodules
* Update helpcontent2 from branch 'master'
  to 2dabe39b5600714274285d364cd0600bc7662267
  - Tweak ScriptForge GetDocument description to explicitly explain document must be open
    
    Change-Id: I9c2429de9114ed843215252803fa0118c113e41a
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130162
    Tested-by: Jenkins
    Reviewed-by: Alain Romedenne
2022-02-21 17:49:52 +01:00
Caolán McNamara
ae7e7b3eed cid#1500569 silence Explicit null dereferenced
likely silences it, an experiment

Change-Id: I095d2dad74331a08ed649cea9bef08b63f9ef1de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130279
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21 17:21:13 +01:00
Caolán McNamara
57c30e9f77 cid#1500621 silence Dereference after null check
Change-Id: Ib8d5eff6e2489e66754b73bc3a59f152e344d35f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130278
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21 17:20:52 +01:00
Caolán McNamara
877705230a upgrade to expat 2.4.6
Change-Id: Ibec5c6b2a321c48725e0888135c09d9b1835d0b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130238
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21 17:20:30 +01:00
Xisco Fauli
7a736a1cdc CppunitTest_sd_uiimpress: Remove duplicated dispatchCommand
SdUiImpressTest already inherits from unotest::MacrosTest

Change-Id: If9683cf6ddb9c56913e19d9c7d1ebbf09864b742
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130280
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-21 17:13:40 +01:00
Christian Lohmaier
3fd5ddb3d0 Update git submodules
* Update translations from branch 'master'
  to 149fb7cb5fbb3f555c66b2c93d057776f63e9ce3
  - update translations for master
    
    and force-fix errors using pocheck
    
    Change-Id: I84d3e51e5fc79ab4803b8df70e6522f9b34b8cc7
2022-02-21 16:22:06 +01:00
Caolán McNamara
8cb6bdf627 cid#1500584 Dereference before null check
Change-Id: I7d5c0ba027e94d3f085eaacf158a31c525fa7eb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130277
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21 16:21:16 +01:00
Caolán McNamara
c118de71bf cid#1500564 Dereference null return value
Change-Id: Ia3e0521a013c3226f2fd5fdfef4e67dc1d5a0374
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130276
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21 16:21:01 +01:00
Caolán McNamara
b55eca694b cid#1500563 silence Explicit null dereferenced
probably silences it, an experiment

Change-Id: I4bae3fb1d8907e6e02fa5e68a6fdb66e53e4f7b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130275
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21 16:20:48 +01:00
Xisco Fauli
846374f00e tdf#147164: vcl_pdfexport: Add unittest
Change-Id: I254e9d7fa3795ee56080b9f065ab5112677fb7d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130244
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-21 15:55:33 +01:00
Caolán McNamara
e48ebfd576 cid#1500559 silence Dereference before null check
Change-Id: I515c2ba2b1a258dd897f28b12a08f1d1f48106d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130274
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21 15:44:45 +01:00
Caolán McNamara
e73c1e127b cid#1500396 silence Dereference after null check
Change-Id: I284f256637a9e91a8cc5c431565a1ebe946a202c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130272
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21 15:39:35 +01:00
Stephan Bergmann
5e8f64e50f Avoid unnecessary empty -Djava.class.path=
Change-Id: Idcfe7321077b60381c0273910b1faeb444ef1fd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130242
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-21 15:37:27 +01:00
Noel Grandin
d39f886ea5 speed up SvxShape::_setPropertyValue
by using the Properties related code to create an SfxItemSet with the
correct ranges, instead of creating an empty SfxItemSet and updating it.
Shaves 2% off the load time of a large chart.

Change-Id: Ia1f8527fa52ab5b8c70e13e1e2ab8c8f25739b2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130270
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-21 15:12:29 +01:00
Caolán McNamara
e4aaf59f48 cid#1500465 Dereference after null check
Change-Id: I3a9b1195c1694d6160c44da152b3502cdd501b3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130268
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21 14:46:14 +01:00