regressions since...
commit 86ea64f216
Date: Fri Feb 15 13:14:32 2019 +0100
Support for native 32bit Bitmap in VCL and SVP (cairo) backend
32bit cairo data is premultiplied with alpha but not so 32bit XImages which
don't have alpha at all, so restore the pre-change 32bit accessors, which
effectively ignore their alpha channel, beside the post-change ones and
toggle which one to use depending on the back end capability
Change-Id: Ibfec18b4ddb6e93ab19e44e7127e7a16982e2f49
Reviewed-on: https://gerrit.libreoffice.org/78665
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Need to use a better null value for FillTransparenceGradient.
Use black-black which has equal effect than having no transparency at all.
XFillFloatTransparenceItem has also an enabled attribute, but it
can not be accessed via the UNO API. We can acces only the gradient object,
so with a better null value we can check whether the API attribute is
actually set or not.
Change-Id: I480489f588376582f80d5062145b7f398ef61ad7
Reviewed-on: https://gerrit.libreoffice.org/78657
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
... instead of filling the remainder of the selection with #NUM! errors.
Change-Id: I12f3943196878c7631f3dc6ac182631faab17323
Reviewed-on: https://gerrit.libreoffice.org/78675
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
As the table column and row resize and select when using it over
LOKit, are using the markers and the mouse border changes weren't
working at all, we can safely turn the mouse cursor changes off.
Change-Id: I4c898da1db39c91a9178115dcd1e0c43eb7c36bf
Reviewed-on: https://gerrit.libreoffice.org/78644
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Modality got lost for non-gtk3 VCL plugins when the dialog
was welded in commit 3963bab7c1
("weld SwCreateAddressListDialog").
Change-Id: I92cb706d7ff9033d4f5b6fe91837739d548a887f
Reviewed-on: https://gerrit.libreoffice.org/78631
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
...for reliable results across Clang versions. Also, there appears to be no
need to check for CXXTemporaryObjectExpr both before and after IgnoreImplicit.
Change-Id: Ib804591b6d50073c99680d0933e21f32bba29342
Reviewed-on: https://gerrit.libreoffice.org/78640
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
... when necessary; factor out MSWordExportBase::NumberingLevel() so it
can be called for this purpose.
Change-Id: I958210052b162c2b23f0162ffebbf5add1ed328c
Reviewed-on: https://gerrit.libreoffice.org/78608
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
I have added import and export of prstDash line styles, for OOXML
and for binary MS Office formats. This includes:
Corrected Dot <--> Dash confusion, corrected some wrong defaults,
added support for hairlines tdf#127267, take care of treating
length 0 as 100%.
tdf#108064 has introduced some mapping from our standard line styles
to OOXML prstDash. I have removed that and implemented to export
our styles as custDash and recover them back on import. That way the
dashing looks initially the same in MS Office. I have removed the now
wrong test.
Binary MS Office formats have no custom dash styles AFAIK, therefore
I have not changed the export of our styles there, but only added
support for prstDash styles.
Change-Id: Ia8cc8f90df6fdbe42adfc0236cc52becc670b333
Reviewed-on: https://gerrit.libreoffice.org/78372
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
...which appears to have been broken when
1382473505 "#81346# - Fix for unconverted
characters for DBCS encodings" moved that "if" out of surrounding "if" block.
(And, for consistency, write the "if" check in the same way as the preceding one
is written since 739cb04c36 "#97705# Fixed mapping
of Big5 EUDC points.")
Change-Id: I4324197c4eba671ab6313fb89f988da102b8ffa5
Reviewed-on: https://gerrit.libreoffice.org/78627
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Also transmit $(verbose) to the build so it's debuggable.
Change-Id: I8620fdcae2fcd34807b6b83b7c38aa5ca1ba2caa
Reviewed-on: https://gerrit.libreoffice.org/78596
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
The abstractNum needs to correspond to a SwList, not to a SwNumRule as
it is currently implemented.
Add a mapping to MSWordExportBase for "overriding" numbering
definitions; these are added to m_pUsedNumTable, which appears to be
necessary to interact with DuplicateNumRule(), but here we just add
nullpointers, because we don't need to modify the SwNumrule, and neither
do we want the vector to double-delete it.
The mapping is created while iterating over the document, in
AttributeOutputBase::ParaNumRule().
It turns out that this approach would work for WW8 too as
DuplicateNumRule() was originally added for that format but it won't
work easily for RTF; in the DOCX case the WriteNumbering() is called
after the main text and footnotes/endnotes, but with RTF it's the
other way around :(
Change-Id: Ia0409f5ad0b2e089005024ef7f61850a06d4dcbe
Reviewed-on: https://gerrit.libreoffice.org/78607
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
e.g. ctrl+shift+e type rabbit then space in writer and the len of underline
is 2 which should encompass the displayed e + 2 UTF-16 units
Change-Id: I424db7dd6cbcc5845922ac17208fed643e672dbd
Reviewed-on: https://gerrit.libreoffice.org/78615
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
