as the size to consider when trying to fit as many column widgets into
it. Not the size it is when the column page is inserted, which
is just that of the column page and preceeding pages
Change-Id: Id78085c92e9b5718e7282bf8ebd2bde1cdc50689
Reviewed-on: https://gerrit.libreoffice.org/78855
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
to avoid shape multiplication in a mixed environment.
MSO needs the special unescaped VML comment shape type
id "_x0000_t202" to avoid of generating also DrawingML
shapes from the VML ones. Calc export escaped the shape
type ids ("_x005F_x0000_t202"), keeping also the DrawingML
shapes, so every round trip between LO and MSO resulted
more and more broken shapes in the document.
See also commit ea7274259a211170ee9f5a8714a2f9acd8bed6d8
"tdf#114842 Fix comment shape export for Calc".
Change-Id: I55b29146ebcdc20cf4f53464bf318fb34bfc5934
Reviewed-on: https://gerrit.libreoffice.org/78831
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
CMIS tab hidden when not isCmisDocument(), ie. no elements
Change-Id: Ib682aa62ae5035a9ecb107fec709d243764346d9
Reviewed-on: https://gerrit.libreoffice.org/78625
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Change-Id: I52547defb0e7ba328ec20d41a955e545556ffd16
note: get the toplevel parent by getting it from the XInteractionHandler
Reviewed-on: https://gerrit.libreoffice.org/78751
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Looks like I forgot to add this in 43ddddb703bcdb9430752af63ae46527f737f874
Change-Id: I1aad5add0cbbc9baf72a4548fa33d57bb837707c
Reviewed-on: https://gerrit.libreoffice.org/78084
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I878a639eee26f543093f640cd10b8cb7bfbbd108
Reviewed-on: https://gerrit.libreoffice.org/78350
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Otherwise the virtual member function calls in the constructor would be
dangerous.
Change-Id: I2fece2ca5718deafe0b88a774208c553e630b411
Reviewed-on: https://gerrit.libreoffice.org/78824
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Without this, e.g. 'make clean; make CustomTarget_idlc/parser_test' may
fail on localized Windows, because the library is not built yet.
$ locale
LANG=en_US.UTF-8
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_ALL=en_US.UTF-8
(but what is relevant, is that on Windows, osl_getThreadTextEncoding
returns active codepage, independent on cygwin locale settings; in my
case, it's Win1251)
Backtrace:
ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28
at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28)
ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154
at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154)
ucrtbased.dll!abort() Line 61
at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(61)
sal3.dll!`anonymous namespace'::FullTextEncodingData::FullTextEncodingData() Line 389
at c:\lo\src\core\sal\textenc\textenc.cxx(389)
sal3.dll!rtl::Static<`anonymous namespace'::FullTextEncodingData,A0xa37698ef::FullTextEncodingDataSingleton>::get() Line 395
at c:\lo\src\core\include\rtl\instance.hxx(395)
sal3.dll!Impl_getTextEncodingData(unsigned short nEncoding) Line 434
at c:\lo\src\core\sal\textenc\textenc.cxx(434)
sal3.dll!rtl_createTextToUnicodeConverter(unsigned short eTextEncoding) Line 110
at c:\lo\src\core2\sal\textenc\textcvt.cxx(110)
sal3.dll!rtl_string2UString_status(_rtl_uString * * ppThis, const char * pStr, long nLen, unsigned short eTextEncoding, unsigned long nCvtFlags, unsigned long * pInfo) Line 807
at c:\lo\src\core\sal\rtl\ustring.cxx(807)
sal3.dll!rtl_string2UString(_rtl_uString * * ppThis, const char * pStr, long nLen, unsigned short eTextEncoding, unsigned long nCvtFlags) Line 887
at c:\lo\src\core\sal\rtl\ustring.cxx(887)
idlc.exe!rtl::OUString::OUString(const char * value, long length, unsigned short encoding, unsigned long convertFlags) Line 363
at c:\lo\src\core\include\rtl\ustring.hxx(363)
idlc.exe!convertToAbsoluteSystemPath(const rtl::OString & fileName) Line 62
at c:\lo\src\core\idlc\source\idlccompile.cxx(62)
idlc.exe!sal_main_with_args(int argc, char * * argv) Line 86
at c:\lo\src\core\idlc\source\idlcmain.cxx(86)
idlc.exe!main(int argc, char * * argv) Line 26
at c:\lo\src\core\idlc\source\idlcmain.cxx(26)
idlc.exe!invoke_main() Line 79
at d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(79)
idlc.exe!__scrt_common_main_seh() Line 288
at d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(288)
idlc.exe!__scrt_common_main() Line 331
at d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(331)
idlc.exe!mainCRTStartup() Line 17
at d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp(17)
kernel32.dll!BaseThreadInitThunk ()
ntdll.dll!RtlUserThreadStart ()
Change-Id: Ida88eca9d477c61870a8fb94aab043f894b16d10
Reviewed-on: https://gerrit.libreoffice.org/78580
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Replace with comphelper::getUnoTunnelImplementation.
Also use isUnoTunnelId().
Change-Id: I014d27fd985836e9232b7f4772696b946eec907e
Reviewed-on: https://gerrit.libreoffice.org/78745
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The patch implements getExportedKeys which was lacking.
Console logs:
warn:connectivity.firebird:13144:18512:connectivity/source/drivers/firebird/DatabaseMetaData.cxx:1468: Not yet implemented
warn:legacy.osl:13144:18512:connectivity/source/drivers/firebird/DatabaseMetaData.cxx:1469: Not implemented yet!
The only difference with getImportedKeys is the fact that :
- in getImportedKeys, table name of Where condition is the foreign key
- in getExportedKeys, table name of Where condition should be the primary key
Instead of duplicating the whole code of getImportedKeys,
I created a local function which contains the main part.
Change-Id: Ia4497524fecf098257eec27e44e016a7cbe23480
Reviewed-on: https://gerrit.libreoffice.org/78822
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
...very far, so that the list needs to scroll:
> ==1676==ERROR: AddressSanitizer: stack-use-after-return on address 0x7f039a1e6420 at pc 0x7f03c34e0658 bp 0x7ffede26b140 sp 0x7ffede26b138
> READ of size 8 at 0x7f039a1e6420 thread T0
> #0 in Point::X() const at include/tools/gen.hxx:78:44 (instdir/program/libvcllo.so +0x5cf6657)
> #1 in OutputDevice::PixelToLogic(Point const&) const at vcl/source/outdev/map.cxx:1191:47
> #2 in sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool) at sd/source/ui/slidesorter/controller/SlsDragAndDropContext.cxx:84:47
> #3 in sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0::operator()() const at sd/source/ui/slidesorter/controller/SlsDragAndDropContext.cxx:92:34
> #4 in void std::__invoke_impl<void, sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0&>(std::__invoke_other, sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0&) at gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/invoke.h:60:14
> #5 in std::enable_if<is_invocable_r_v<void, sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0&>, void>::type std::__invoke_r<void, sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0&>(sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0&) at gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/invoke.h:110:2
> #6 in std::_Function_handler<void (), sd::slidesorter::controller::DragAndDropContext::UpdatePosition(Point const&, sd::slidesorter::controller::InsertionIndicatorHandler::Mode, bool)::$_0>::_M_invoke(std::_Any_data const&) at gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/std_function.h:291:9
> #7 in std::function<void ()>::operator()() const at gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/std_function.h:622:14
> #8 in sd::slidesorter::controller::ScrollBarManager::RepeatAutoScroll() at sd/source/ui/slidesorter/controller/SlsScrollBarManager.cxx:518:17
> #9 in sd::slidesorter::controller::ScrollBarManager::AutoScrollTimeoutHandler(Timer*) at sd/source/ui/slidesorter/controller/SlsScrollBarManager.cxx:539:5
> #10 in sd::slidesorter::controller::ScrollBarManager::LinkStubAutoScrollTimeoutHandler(void*, Timer*) at sd/source/ui/slidesorter/controller/SlsScrollBarManager.cxx:537:1
> #11 in Link<Timer*, void>::Call(Timer*) const at include/tools/link.hxx:112:45
> #12 in Timer::Invoke() at vcl/source/app/timer.cxx:75:21
> #13 in Scheduler::ProcessTaskScheduling() at vcl/source/app/scheduler.cxx:479:20
> #14 in Scheduler::CallbackTaskScheduling() at vcl/source/app/scheduler.cxx:287:5
> #15 in SalTimer::CallCallback() at vcl/inc/saltimer.hxx:54:13
> #16 in sal_gtk_timeout_dispatch(_GSource*, int (*)(void*), void*) at vcl/unx/gtk3/gtk3gtkdata.cxx:761:45
> #17 in g_main_dispatch at ../glib/gmain.c:3189:28
> [...]
> Address 0x7f039a1e6420 is located in stack of thread T0 at offset 32 in frame
> #0 in sd::slidesorter::controller::SelectionFunction::MouseDragged(AcceptDropEvent const&, signed char) at sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx:630 (instdir/program/../program/libsdlo.so +0x5c22e1f)
> This frame has 1 object(s):
> [32, 104) 'aEventDescriptor' (line 631) <== Memory access at offset 32 is inside this variable
> HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
> (longjmp and C++ exceptions *are* supported)
Presumably a regression introduced with 26912eea7521dd2b84bfac56b322cf0f8b142450
"sd: replace boost::bind with C++11 lambdas and for loops", assuming that
boost::bind bound rMousePosition by value.
Change-Id: I4cefc5974b7377ff4918d59b51fc8cda41292702
Reviewed-on: https://gerrit.libreoffice.org/78774
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
These are MS932 extensions, and per
<https://www.unicode.org/Public/MAPPINGS/VENDORS/MICSFT/WINDOWS/CP932.TXT>
("Table version: 2.01", "Date: 04/15/98"), U+4F92 is a mapping for 0xFA6F (and
also for 0xED53, which is also an MS932 extension, and "loses" here), and
U+4F9A is a mapping for 0xFA71 (and also for 0xED55, which is also an MS932
extension, and "loses" here). (And neither U+4F92 nor U+4F9A appear as mappings
in <https://www.unicode.org/Public/MAPPINGS/OBSOLETE/EASTASIA/JIS/SHIFTJIS.TXT>,
"Table version: 2.0", "Date: 2011 October 14 (header updated: 2015
December 02)".)
This appears to be a typo dating back to
9399c662f36c385b0c705eb34e636a9aec450282 "initial import".
Change-Id: I0c699675355d839e62d6e4082355a2d67472533e
Reviewed-on: https://gerrit.libreoffice.org/78720
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Ic6f0627ac49a43e6bbfae8e07fbf110abfaba9ee
Reviewed-on: https://gerrit.libreoffice.org/78080
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Paragraph numbering was invisible in narrow cells
of Writer tables, when the paragraphs have a wider
indentation and an equivalent negative first line
indentation, too.
GetLeftMarginWithNum()==0 doesn't mean that the
paragraph is not numbered with the "new" numbering
style SvxNumberFormat::LABEL_ALIGNMENT.
Change-Id: I99f0a84404876db6cefdf0da845cd8b425860553
Reviewed-on: https://gerrit.libreoffice.org/78802
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
-1 isn't a problem.
The only pb was record length
This reverts commit f4f8bccbd4e2c3979a83d5b2f49e16a99a3a2016.
Change-Id: I3108e451bf10b2e96dff5eeb040e77feeb67875a
Reviewed-on: https://gerrit.libreoffice.org/78791
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Images as hyperlinks to internal bookmark targets didn't work after
export, because spaces were replaced only in bookmarks with underline
characters, now in hyperlinks, too.
Change-Id: I281b2cde276607aa93de92745cfa1ba887ba9976
Reviewed-on: https://gerrit.libreoffice.org/78782
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
The w32 implementation preserves all attributes of the destination
file, the unx one preserved none of them.
Bring the unx osl_replaceFile() closer to the w32 by preserving the gid
of the destination file as a start.
[ No testcase, we support building on systems where the user is part of
a single group only, and it's not possible to verify the effect of this
change in such environments. ]
Change-Id: I722d4802df34caf71a9dc0db1a3df8b76acb9de6
Reviewed-on: https://gerrit.libreoffice.org/78789
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
- Update too flat print related icons
- Add large and extra large autocorrect icons
- Fix some blurred icons (linetoolbox, word count,autosum)
- Update add and remove icons in sidebar's track changes section
- Add custom chevron (related to tdf#125296 enhancement)
Change-Id: Ia7ffa514d1ef02804a82afc701f175d2e2f94249
Reviewed-on: https://gerrit.libreoffice.org/78750
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
