Commit Graph

399086 Commits

Author SHA1 Message Date
Miklos Vajna
f0167eced7 Upgrade libxmlsec to 1.2.23
Obsoletes xmlsec1-win32-fix-undeclared.patch.1.

Change-Id: I11cd52aebbe5ab224de9ab00b74c02abb46296f6
Reviewed-on: https://gerrit.libreoffice.org/30539
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-04 08:10:23 +00:00
Julien Nabet
dc04de0481 loplugin:defaultparams
Change-Id: I3436df5ebfe0ef4bca6d44ba426f26911482bbcb
Reviewed-on: https://gerrit.libreoffice.org/30557
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-04 07:57:41 +00:00
melikeyurtoglu
02eaf40ba0 tdf#91222 VclBuilder constructor cleanup
Change-Id: I619cb50c3475519921ffd318b32875ae4ff2c0b8
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/30545
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04 07:18:19 +00:00
Noel Grandin
fc8f32adc2 loplugin:unnnecessaryvirtual in vcl
Change-Id: Ifa8bfafb2e527ce5976f3bd310d107cb2840a5f6
Reviewed-on: https://gerrit.libreoffice.org/30531
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04 07:16:25 +00:00
Noel Grandin
5f77e6e930 update loplugin:unnnecessaryvirtual to handler destructors
and update modules writerfilter..xmloff with the resulting changes

Change-Id: I54d19c22ddb0ff579b32e4934d266c925b19305c
Reviewed-on: https://gerrit.libreoffice.org/30530
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04 07:15:03 +00:00
Noel Grandin
7abd369964 loplugin:unusedmethods
Change-Id: Ie1f840c3ec9a2d5888f95cf05e531a8a9464bf2e
Reviewed-on: https://gerrit.libreoffice.org/30524
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04 07:13:58 +00:00
Khaled Hosny
fb82354446 Font features are not a Graphite-only feature
We parse features appended to font names in CommonSalLayout as well, so
code that takes care of their presence (striping them when searching,
hashing, etc.) should not be dependent on the old Graphite support or it
will not work when old Graphite is disabled (e.g. on macOS).

Change-Id: If040782a86ec76d3743baf4d2b1d7a194e8e13f2
2016-11-04 05:13:03 +02:00
Khaled Hosny
a6ce5d3914 Misplaced #endif
Change-Id: I199cf879c13cdd65ec9b6f1dbfef9b615bf8cefc
2016-11-04 01:27:54 +02:00
Eike Rathke
8d777f85ea Resolves: tdf#103684 calculate status bar functions across sheets
Also trigger recalculation when additional sheets are selected or deselected.

Change-Id: I259396a3e30c5653ac252b7bb2eb6a0a9405d6cc
2016-11-03 23:21:20 +01:00
Jan Holesovsky
84400eae86 tdf#88821: Implement support for <meta charset="..."> for HTML import.
The editengine HTML import was not handling it at all, and consequently not
setting the right encoding when importing HTML in Calc.

Change-Id: I3ca3dd20f36cfb579fb7ae4cd3da63a69d97601e
2016-11-03 22:55:34 +01:00
Jan Holesovsky
b297f7bbfe tdf#88821: Set the encoding correctly for HTML files with a BOM.
BOM (Byte Order Mark) in the HTML file changed the underlying eSrcEnc
encoding, but did not actually update the rtl_TextToUnicodeConverter hConv.

Subsequent changes of eSrcEnc in SetSrcEncoding() (triggered by
'content="application/xhtml+xml; charset=UTF-8"' in the HTML file) were then
ignored (eSrcEnc was already set to UTF-8), and the parser was happily using the
old (Windows-1250) hConv.

Change-Id: If432d59891d51c6abe3517e325ed73057d0f8610
2016-11-03 21:07:19 +01:00
Justin Luth
5d9d0f3c97 there is a function for that: CalcLineSpace(xx, bEvenIfNoLine)
Change-Id: Ideeb031f20611bd9d2a01343bc75e1d0510ad6e9
Reviewed-on: https://gerrit.libreoffice.org/30513
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
2016-11-03 19:02:41 +00:00
Tamás Zolnai
2a818a0aaf tdf#93825: Missing accessibility events when selecting/deselecting cells
Change-Id: I407f585354e78fb47a76561455ac67bb567c2771
2016-11-03 18:36:44 +00:00
Khaled Hosny
6324efd70d tdf#89870: Add config option for layout engine
The env variable takes precedence.

Change-Id: I273ec867725dd012b005d49fbfaa1dc27203c021
2016-11-03 19:22:52 +02:00
Michael Stahl
43532a0944 RepositoryExternal.mk: fix poppler linking on Ubuntu
need to link poppler static library *before* jpeg

Change-Id: I0fd2abc12c93432715a02a3a567349abda4f990b
2016-11-03 15:58:08 +01:00
Miklos Vajna
a30f969432 svx: add missing ~CONVERT_TWIPS mask in SvxPageItem::PutValue()
With this, it's possible to use AttributePage.* keys in macros.

Change-Id: I3f0b1ea8fb6274e7c18511c2e80774205206a2ba
2016-11-03 14:39:48 +01:00
Samuel Mehrbrodt
b75468d743 SafeModeDialog: Adapt label to reality
Change-Id: I649b1f1f9b8f5c50e69f2cd4228394cfa4d2974a
2016-11-03 14:25:12 +01:00
Samuel Mehrbrodt
3d75d65526 Fix some comments
Change-Id: Ie74eaead67620decf9c9b954be1d13a8e5f400c6
2016-11-03 14:25:12 +01:00
Samuel Mehrbrodt
2569c33f4a SafeModeDialog: Improve description
Change-Id: I86f4a322f3d68caafcfe206e2d0f2164bc789bd8
2016-11-03 14:25:12 +01:00
Tor Lillqvist
5072e6667f Disable gbuildtoide test on macOS, too
Change-Id: I630fd447992ada459190acd1ee310bd2d38820b9
2016-11-03 15:03:50 +02:00
David Tardon
5955e7bf5e update deps for libzmf
Change-Id: I627b3037d7e2dcecfed496068abf697c3258480d
2016-11-03 14:02:20 +01:00
Miklos Vajna
a8aab44d75 xmlsecurity PDF sign: enable unit tests on Windows
Now that the mscrypto part of PDFDocument::ValidateSignature() is
implemented it's possible to run these tests on Windows as well,
provided the machine has at least one signing certificate installed.

Also fix a race, where the workdir of the signing test was used by the
pdfsigning test.

Change-Id: I80bbfbb5dc4baa400f9a6b85961883a247b0f22b
2016-11-03 13:55:01 +01:00
Stephan Bergmann
1fa19c7385 Use a single method of converting between points and 100th mm in starmath
The SmFormat ctor (starmath/source/format.cxx) uses SmPtsTo100th_mm(12) to
initialize aBaseSize, resulting in a height of 422 100th mm.  Getting that value
(and writing it out to a file) through SmModel::_getPropertyValues mapped back
to 12 point, but in turn setting that value (as read from a file) through
SmModel::_setPropertyValues resulted in a height of 423 100th mm.  That, in
turn, caused SmDocShell::GetSize (starmath/source/document.cxx) to compute
diverging sizes, so e.g. clicking into an OLE-embedded formula in a Writer
document caused the Writer document to be marked as modified (as the embedded
formula's size had changed).

Change-Id: Ia90654aeaaf779690997b5c3bb868b193eaf46c6
2016-11-03 13:33:33 +01:00
Michael Stahl
8d1c80e263 RepositoryExternal.mk: really fix jpeg build
Change-Id: I1969db554d156e6af0975d03013ea4f7c10d839f
2016-11-03 13:24:39 +01:00
Samuel Mehrbrodt
16881e76fe SafeModeDialog: Better grouping of options
Disable/Deinstall extensions are mutually exclusive, so group them appropriately

Change-Id: I6dc9c53ef4c18103c7521d494a769d522b0412dd
Reviewed-on: https://gerrit.libreoffice.org/30522
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03 12:23:32 +00:00
Samuel Mehrbrodt
da0a98fa6d SafeModeDialog: Improve labels
Change-Id: If90b25e569a8feaa86e5c43da5966d5314cf0f14
Reviewed-on: https://gerrit.libreoffice.org/30521
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03 12:22:21 +00:00
Samuel Mehrbrodt
00e48a2ea0 SafeModeDialog: Fix enabling/disabling of widgets
Change-Id: I7133b64f975fa8e68550d41056b689dfc18cf172
Reviewed-on: https://gerrit.libreoffice.org/30520
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03 12:21:18 +00:00
Samuel Mehrbrodt
291d8d4f94 SafeMode: Add indicator to window title when in Safe Mode
Change-Id: I1d8350315768093b4c4af1cd8b732602c5217edb
Reviewed-on: https://gerrit.libreoffice.org/30518
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03 12:20:11 +00:00
Samuel Mehrbrodt
e509c22863 SafeModeDialog: Allow to create zip file from profile
Change-Id: I4296d1cf5058be359ffed46745673cf26eba3375
Reviewed-on: https://gerrit.libreoffice.org/30479
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03 12:19:16 +00:00
Tor Lillqvist
954f721ad5 Bin the XSecController::m_pErrorMessage field as it was never used
It was only assigned to. Some follow-up simplification.

Change-Id: I3b522064e946667d3a4c8fb82ee40bd0d44dd569
2016-11-03 14:17:43 +02:00
Jan-Marek Glogowski
f144d319d5 Fix external libjpeg build
Change-Id: I952dd39559cff18dc7850b62915405954eac2fd7
2016-11-03 13:14:42 +01:00
Tor Lillqvist
c2cdf08171 Bin some useless comments
No need to have a comment saying 'write signatures' when calling a
function that is called WriteSignature(). (Actually, the function name
is slightly misleading, as it says 'signature' in singular while what
it actually does is write multiple signatures, if present.)

Also drop some leftover comments that were related to code that was
commented out already in 2004 or 2007 and removed completely in 2010.

Change-Id: I7a53b3eabb81fc03c66e746f78267be4c1751b0f
2016-11-03 14:00:56 +02:00
Noel Grandin
b01c5ae956 loplugin:unusedmethods unused return types
Change-Id: I88204bca60dd1e299b040c52bc87e500cbfaa930
Reviewed-on: https://gerrit.libreoffice.org/30519
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03 11:37:31 +00:00
Samuel Mehrbrodt
b3a229ad0d Add helper for creating zip files
Change-Id: I8b49b74622bf4d671d640e4cd06dc2da348ee222
Reviewed-on: https://gerrit.libreoffice.org/30478
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03 11:25:16 +00:00
Caolán McNamara
11a1b70da2 coverity#1371313 Missing move assignment operator
Change-Id: I07a9d7fe837c18e66b4a2a57186f1f9b0d44daee
2016-11-03 11:23:35 +00:00
Michael Stahl
6a866f99ec configure: fix LIBJPEG_LIBS, jpeg-turbo can also be used on Linux
Change-Id: I710f8ba31b6f780e3fb1d174d9ea21f270f55264
2016-11-03 11:49:36 +01:00
Tor Lillqvist
8b69433394 Clarify comment to mention also HAVE_FEATURE_OPENCL
Change-Id: Ibca8ceedd8c01b4d12ccd9c29838f545fc234347
2016-11-03 12:35:29 +02:00
Michael Stahl
21ca0db5ec poppler: remove obsolete ubsan patch hunk
With eea709f67d "poppler: build against
libjpeg" the poppler internal JPEG code is no longer used.

Change-Id: I018a53a495ec505af92bb9b1c1a0c42e0a4f35b8
2016-11-03 11:13:29 +01:00
Caolán McNamara
69d79abb58 Related: rhbz#1390607 our side of per-monitor fullscreen on wayland
keep the move window to monitor code, so under X, gnome#773857 isn't
a problem

when gnome#772525 fix is available this presumably will then work under
wayland

Change-Id: I50cfe7ede8a4f1404c26d174ef3c5bb920eb5044
2016-11-03 09:45:46 +00:00
Tor Lillqvist
38dc4ea899 Bin unused XSecuritySAXEventKeeper::cloneElementCollector
Change-Id: Icc0ead769fa0a052f7d4dfbc825c96dbb513b33f
2016-11-03 11:10:59 +02:00
Noel Grandin
880bcf9ed8 loplugin:unnecessaryvirtual
Change-Id: I572b83949c7e643536b7d62567760546509e4d9f
Reviewed-on: https://gerrit.libreoffice.org/30514
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03 09:06:45 +00:00
Miklos Vajna
ea6b378221 tdf#102308 sw redline tooltip: show seconds
Commit d9dca1eef9 (tdf#102308 sw: improve
redline timestamp precision) improved the manage changes dialog to show
seconds of the redline timestamps, do the same with tooltips, when the
mouse is hovered over a redline portion.

Change-Id: I6ec42db49cb93d8bce0cdee02e37d871f8e7e2ce
Reviewed-on: https://gerrit.libreoffice.org/30515
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-11-03 08:58:59 +00:00
David Tardon
4a83464f71 tdf#103633 avoid segfault in a11y
This partially reverts commit 8e8a88ec1a
"loplugin:unusedfields".

Change-Id: Id95a46374ed2b35e05dc32a8759e5db01829f050
2016-11-03 09:55:36 +01:00
Tor Lillqvist
a90bf85ae6 Bin pointless differentiated exception handling
All the catch blocks for classes derivved from uno::Exception
contained the same single statement as the catch block for
uno::Exception itself.

Change-Id: Ic33b432416abfda7557862d25237dc7221585327
2016-11-03 10:39:14 +02:00
Miklos Vajna
8d1fb35f5c xmlsecurity PDF verify: initial Windows support
The timestamp isn't extracted yet, but the digest match is already
checked correctly and the certificate is exposed.

Change-Id: Ieca002a5c4ca0b96f4dc397c460adb7f88f5ffc7
Reviewed-on: https://gerrit.libreoffice.org/30499
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-03 08:09:39 +00:00
Tor Lillqvist
47521b5816 Add FIXME
Change-Id: I4ebdca6a7d09a228122842a79b217ac2611a7c06
2016-11-03 10:01:45 +02:00
Xisco Fauli
e4669faa68 tdf#95341: Make last item of menus clickable again
Regression from 4f1dca5083

Change-Id: I7b7f3594499cd049ae59064da244e3f82dff7757
Reviewed-on: https://gerrit.libreoffice.org/28617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-11-03 07:58:45 +00:00
Laurent Balland-Poirier
f2bc1a61f6 tdf#100352 Classification: Update French translation
Change-Id: Ie5efebfe4df73adca51638c85ba52e7901eac139
Reviewed-on: https://gerrit.libreoffice.org/30182
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-11-03 07:19:21 +00:00
Noel Grandin
8de24d1652 Revert "remove unnecessary casts"
This reverts commit fa80dae9a7.

because current Clang master complains with

/home/noel/libo3/svl/source/items/itemset.cxx:189:26: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]
        va_start( pArgs, nNull );
                         ^
/home/noel/libo3/svl/source/items/itemset.cxx:176:89: note: parameter of type 'sal_uInt16' (aka 'unsigned short') is declared here
SfxItemSet::SfxItemSet(SfxItemPool& rPool, sal_uInt16 nWh1, sal_uInt16 nWh2, sal_uInt16 nNull, ...)
2016-11-03 08:47:47 +02:00
melikeyurtoglu
164d8e3b1a tdf#91222 VclBuilder constructor cleanup
Change-Id: I53bca2a9113862b8e7058937e231721c5f81a9de
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/30511
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03 06:37:42 +00:00