Commit Graph

363011 Commits

Author SHA1 Message Date
Michael Stahl
f049b83cc2 scp2: move WNT executables to AutoInstall
Change-Id: I3e541053faf956dc0cd2a3f068cd93b73fcaab6d
2014-10-31 17:53:52 +01:00
Michael Stahl
58735f0608 scp2: move unix/gnome executables to AutoInstall
Change-Id: I0e0c3b5e3f130093f430f47c1730580105718c1e
2014-10-31 17:53:52 +01:00
Michael Stahl
6c778e0a9b sw: [loplugin:salbool]
Change-Id: I7d8e2606f0518d489473a9824cb25b6bcd6a9bb2
2014-10-31 17:53:52 +01:00
Andrea Gelmini
c70f1545e2 Removed duplicated includes
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31 16:18:30 +00:00
Miklos Vajna
693014c9d3 SwXShapesEnumeration: don't generate a set of TextBoxes for each shape
Instead, generate it once and then pass around that list. Again, this
helps ODF export.

For a test document of 2000 mail merge records and 16 frames, the times
for css::text::MailMerge::execute() are 7m53.575s -> 7m30.261s.

Change-Id: Iec993ec34392350b1e26857f7d5434a0a9c494a3
2014-10-31 17:17:02 +01:00
Eike Rathke
32bbe44e89 eliminate duplicated initialization
RowInfo.pCellInfo is already initialized by ctor.
Found while investigating coverity#707985 Uninitialized scalar field

Change-Id: Ibb41032674ce5f07ed855a62d76648526d09a1ad
2014-10-31 17:10:22 +01:00
Miklos Vajna
6606313d6e Add a SwTextBoxHelper::findTextBoxes() variant that takes an SwNode
This method is called by the ODF export for each paragraph, so limiting
the result for TextBoxes anchored to a single paragraph helps to avoid
iterating over all the frames for each paragraph.

For a test document of 2000 mail merge records and 16 frames, the times for
css::text::MailMerge::execute() are 8m18.811s -> 7m53.575s.

Change-Id: I7a9cd7b23a3e903059ec0ae3a6a8f8309681bb2e
2014-10-31 16:53:25 +01:00
Eike Rathke
2ec4c8b074 converity#1249470 Uninitialized scalar field
comment it's unnecessary

Change-Id: Iebf2d1dbed1f9c1e2e09144f47e73d9628355f2e
2014-10-31 16:20:46 +01:00
Eike Rathke
4c3dbdd2af converity#707956 Uninitialized scalar field
Change-Id: Ic341502383de8a5b0843d2c4c15e7388818a6027
2014-10-31 15:54:12 +01:00
Eike Rathke
eeec20ddb3 converity#738797 Uninitialized pointer field
Change-Id: I84cd8b6542d2b52df620d56eb6492139a1d60c10
2014-10-31 15:47:22 +01:00
Eike Rathke
7067d930c8 coverity#735311 Unchecked return value
assert if fouled

Change-Id: Id3a160ff08907cc7792e93eea9f91997bcc0e2c3
2014-10-31 15:34:28 +01:00
Eike Rathke
016636450c coverity#735320 Unchecked return value
assert if fouled

Change-Id: I1bc38690c755b8bc6eab16c8aa33c8f568e0c854
2014-10-31 15:34:24 +01:00
Eike Rathke
36705670ef coverity#735811 Dereference after null check
We always have a DB collection.

Change-Id: I8933be3a01b4c2e63b852361d5d2438e6fca4d05
2014-10-31 15:34:22 +01:00
Stephan Bergmann
8dbe4f2aeb cid#1202756 Clarify with assert that ave == 0 cannot happen
...so (highbit(ave) - 1) will never be negative and never cause undefined shift by negative
value.

Change-Id: I86703f03d30d48c74d2e814c182b9edb85d18186
2014-10-31 15:23:12 +01:00
Eike Rathke
4f93d6960c coverity#705348 Missing break in switch
Change-Id: I23e03e45ba4f6d259128bc5e4c2fd5952be05c2f
2014-10-31 14:43:20 +01:00
Stephan Bergmann
1dd285d0c7 cid#1202755 Clarify with assert that new_size == 0 cannot happen
...so arena->m_hash_shfit will never be negative and never cause undefined shift by negative
value.

Change-Id: Ifc3d28d53bae38bc8deea72473c81f1d043dc18e
2014-10-31 14:11:54 +01:00
Caolán McNamara
bfd4f64bbb coverity#705257 gold, Missing break in switch
this is the image map window, I see that indeed toggling a shape
active/inactive in the image mapwindow makes it change layer
to the front for no good reason

Change-Id: If6556e8f21dee2b0f7c750d460490d4e03fc0c02
2014-10-31 13:04:17 +00:00
Regina Henschel
fe5840aab1 Resolves: #i118191# Red is not red enough
Enable Math to use 16 basic HTML colors
Patch by: Regina Henschel <rb.henschel@t-online.de>
Found by: <lapsap7+ooo@gmail.com
(cherry picked from commit 529e59d90037748d0030191b93252e597935243e)

Conflicts:
	starmath/inc/parse.hxx
	starmath/source/mathmlimport.cxx
	starmath/source/parse.cxx

Change-Id: I08de0ce33928ead3635a3a87c81671b4cc4112ac
2014-10-31 13:04:17 +00:00
Caolán McNamara
fa277f5952 callcatcher: a titchy bit more ww1 filter fallout
Change-Id: I38517bb7fbf4ab1e9314a28973b707223d7120e7
2014-10-31 13:04:16 +00:00
Caolán McNamara
a19817c3ca coverity#1202803 Explicit null dereferenced
Change-Id: Ia914c4842e69b3ea57692f1f8ac52c321240b7c4
2014-10-31 13:04:16 +00:00
Caolán McNamara
b62e428bd1 coverity#1158395 Uncaught exception
and

coverity#1158394 Uncaught exception

Change-Id: I73430678c658202475e0073c3c9bde0a072c1ee9
2014-10-31 13:04:15 +00:00
Caolán McNamara
0b32d9dcb8 coverity#735346 Unchecked return value
Change-Id: Ic9aab232667a9b0a3a995d7b033b7ba508fd42dc
2014-10-31 13:04:15 +00:00
Caolán McNamara
1c5b25e680 coverity#707299 Uncaught exception
and

coverity#707301 Uncaught exception

Change-Id: I6b7b2a9910b8a7d563a08ce84ddf16f550d8818e
2014-10-31 13:04:14 +00:00
Caolán McNamara
9b5718284e coverity#707418 Uncaught exception
and

coverity#707419 Uncaught exception
coverity#707420 Uncaught exception

Change-Id: I98d752c14be5f7b1fccb4bdf2eeefb6bbfe12e0e
2014-10-31 13:04:14 +00:00
Caolán McNamara
337abdbc67 quieten warning
Change-Id: I91bf3bce86d6b7fb01a26a6785d5bcfd7677878c
2014-10-31 13:04:13 +00:00
Stephan Bergmann
f2d8fdabd0 cid#1212456 Silently ignore uno_assignData return value here
...which must be true for pDestTypeDescr == pSourceTypeDescr.

Change-Id: I98b4d654eb0e705ff0b577e7c87971b418ed13fc
2014-10-31 14:03:26 +01:00
Tor Lillqvist
eb37bbe599 Add line numbers to the OpenCL sources being logged
Makes __LINE__ numbers you have inserted in temporary printf() calls in the
(generated) OpenCL code more useful.

Change-Id: I6da5a6937b924c1378f7f0c25ab7e156b23e1b61
2014-10-31 15:01:07 +02:00
Tor Lillqvist
f49880807c Move variable inside the ifdef block where it is only used
Change-Id: Ifa9e77b955cea26da6602d409a1c111f45f72587
2014-10-31 15:00:57 +02:00
Stephan Bergmann
508a78e4b1 cid#982172 Silently ignore F_SETFD FD_CLOEXEC failures
...there should not be any legitimate reason these fcntl calls can fail, anyway.

Change-Id: Ib5cbe5b40ff42656fe3bad2ac50dcf6faeca0e9d
2014-10-31 13:52:45 +01:00
Stephan Bergmann
ac7c79a82f cid#982171 Warn about rename failure in error clean-up code
Change-Id: I02e81d526c07297a5bc3664cc475302a552187eb
2014-10-31 13:45:57 +01:00
Stephan Bergmann
30c9034c87 Simplify by using OString
Change-Id: Ia46417525e655a5a80f9e70f25f65e4916e4c8d8
2014-10-31 13:26:22 +01:00
Tor Lillqvist
292256d2f2 Append kernel signature to the log area in the SAL_INFO dump of its source
Makes it possible to look at the OpenCL source for just a specific function,
by setting for instance SAL_LOG=+INFO.sc.opencl.source.nop_VLookup.

Change-Id: Ie9e1f7b1542043717ac3652226713f4ab88883e1
2014-10-31 13:15:15 +02:00
Stephan Bergmann
6edbcc1b23 cid#1242936 handle rename failure
Change-Id: I92ce690a6f8183ce77c8ed53bd2fcb45d39d756e
2014-10-31 12:05:25 +01:00
Matúš Kukan
f13678d805 missing SAL_CALL
Change-Id: Ifa9034f12f42c0ddc5aa5e363fbcc04bab36492b
2014-10-31 11:11:16 +01:00
Miklos Vajna
997055f50d SwDBManager::MergeMailFiles: set unique fly names at the end of the merge
When generating a unique fly name, we have to iterate over all the
existing flys to find out what's the first not used one, so doing this
for every new fly inserted by mail merge is O(n^2).

During import, we already skip this and only do it once at the end of
the import, which is O(n).

Fix the performance problem by skipping the unique fly name generating
when we produce a combined mail merge document as well, and just
generate them once the mail merge is complete.

For a test document having 12 text frames and 2000 mail merge records,
the times for css::text::MailMerge::execute() is 9m37.330s -> 8m18.811s.

Change-Id: Idfa8e9fe3acc93f1138f5bb12c2419c1492f8ff1
2014-10-31 10:57:58 +01:00
Yousuf Philips
bf4aa9172a fix missing page break icon from showing
Change-Id: Ia205db098ea585e0c72e89dff43fde83becdabe2
Reviewed-on: https://gerrit.libreoffice.org/12162
Reviewed-by: Matthew Francis <mjay.francis@gmail.com>
Tested-by: Matthew Francis <mjay.francis@gmail.com>
2014-10-31 09:12:10 +00:00
Stephan Bergmann
344ad69a04 Duplicate line
Change-Id: I55811305ec24ff3538d33e98c8eac680e7da17fe
2014-10-31 10:10:33 +01:00
Miklos Vajna
4dbed9ef9a Use oox::drawingml::convertEmuToHmm()
And get rid of the writerfilter copy, that does no rounding.  Adjusted
testcases:

- testFdo80555: 245 -> 247 (should be 246.944444444, so a good change)
- testDMLGroupShapeChildPosition: roundtripped values are now closer to
  the initial ones, so also a good change

Change-Id: I4dec7857a0df77face01b7a8ba1da7c647a24b6c
2014-10-31 09:30:49 +01:00
Daniel Sikeler
328f861dfb fdo#80403: AutoCorrect uses XFastParser
depends on c0a5d390e5
ContextClasses implement fast methods.
ImportClasses implement fast methods.
New TokenHandler for AutoCorrectTokens.

Change-Id: I41ef7266da2068da3ab5f047280b13e57ee2e763
2014-10-31 09:24:47 +01:00
Daniel Sikeler
c0a5d390e5 fdo#80403: Import baseclasses implement FastParser interfaces
SvXMLImportContext implements XFastContextHandler
SvXMLImport implements XFastDocumentHandler

Change-Id: Id400260af112f4a448fe469c9580f0ebacec4ab6
2014-10-31 09:22:30 +01:00
Tor Lillqvist
4482f50197 WaE: VarDecl, use "bool" instead of "sal_Bool" [loplugin:salbool]
This likely is a false warning or over-enthusiasm in the salbool plug-in, but
on the other hand, I don't understand why the recently added case needs to use
different coding idioms from the preceding ones in the function? So make the
code more uniform.

Change-Id: I518022c59f6bd54740676cba95670e78b9a40d19
2014-10-31 08:47:11 +02:00
Noel Grandin
41538e2ab7 drop KeyCode::IsDefinedKeyCodeEqual
because it's implementation is the same as operator==

Change-Id: If9b63abcd13f899735d59d85be3da54406a6e324
2014-10-31 07:59:33 +02:00
Noel Grandin
72ce1368b5 convert COMMAND_WHEEL constants to an enum
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-31 07:28:06 +02:00
Noel Grandin
7eb519e92b KEY_ALLMOD is the same as KEY_MOD
so just dump it

Change-Id: I006045aea345e84ff1944fc1ed1daa94bd7bca61
2014-10-31 07:28:06 +02:00
Maxim Monastirsky
c91e045c12 fdo#84792 Correct the link for cmd/sc_square.png
Change-Id: I3f66b621b136b8c42c4acc16058276215fd39835
2014-10-31 01:14:38 +02:00
Maxim Monastirsky
2633e57daf fdo#84792 Correct the link for cmd/lc_square.png
Change-Id: Icbb325517ec835d2bee7ac4693cfe939b741d7fd
2014-10-31 01:01:02 +02:00
Tor Lillqvist
6b7e9bb9a9 Bin dummy source
Change-Id: I41067a6a81e58793ba8b0491b4044de6e7f68e2b
2014-10-31 00:28:49 +02:00
Michael Meeks
593a44a12d thread-pool: re-work termination semantics to avoid problems.
We want a pre-spun-up, shared thread-pool that doesn't get its
workers created & joined frequently.

Change-Id: I29081e3a3e3849ca30e63fd080ee3315d99cbe8d
2014-10-30 22:12:29 +00:00
Michael Meeks
62090f65b8 Move thread-pool down into comphelper for re-use elsewhere.
Change-Id: Ib27b8b1ccc07ff194035d6c2ef3d45c429e3cea1
2014-10-30 22:12:27 +00:00
Tor Lillqvist
2f55701c55 Add a few informative SAL_INFOs
Change-Id: I1ac6366714acd7ec3e74b7afb4670c73825d1032
2014-10-31 00:02:26 +02:00