373784 Commits

Author SHA1 Message Date
Stephan Bergmann
f9290d3011 Clean up checks of sal_Bool values
Change-Id: Ia05565077823d6efaeaeb35d3d80b51dd9a10d4c
2015-05-08 09:49:03 +02:00
Stephan Bergmann
1d3357ccf7 read_percent returns ProgressStatus, not sal_Bool
Change-Id: I6e1c1f88b28db2728b2f29ea47c3e86ef8983697
2015-05-08 09:49:02 +02:00
Stephan Bergmann
c24212ec89 Silence sal_Bool -> sal_IntPtr Link return value mismatches for now
Some uses of untyped Link<> (returning sal_IntPtr) are hard to update to typed
versions, but upcoming changes to loplugin:implicitboolconversion would flag
these uses of sal_False/True, so just explicitly cast them to sal_IntPtr for
now.

Change-Id: I654e555e85faba0b30178c978e7d50fc7240b004
2015-05-08 09:49:02 +02:00
Stephan Bergmann
c5e08b42ac I very much assume this wants to call java.io.Reader.ready
...seeing that there is no java.io.Reader.available.  (And then, there's no good
way to map from java.io.Reader.ready's boolean value to
css.io.XInputStream.available's long value, so conservatively map true to 1.)

But I have no idea how to trigger this code.

Change-Id: I18d12e0d968141410a1b56e700ed544edceda97c
2015-05-08 09:49:02 +02:00
Stephan Bergmann
fa54d73a59 Fix Boolean value operations
(css.sdbc.ColumnValue.NULLABLE happens to be 1, so the odd comparison is
harmless and redundant.)

Change-Id: I6b64cc083e72198c71e4e38ec4347f79af924621
2015-05-08 09:49:02 +02:00
Stephan Bergmann
bdf75a9f6b GLEW_EXT_texture_array is of type GLboolean already
Change-Id: I8348a5e5c13a6628ad543652e50bac0432b2b7be
2015-05-08 09:49:01 +02:00
Stephan Bergmann
79a359fea1 jboolean-related clean-up
Change-Id: Iecd03d0343b9b7c3a8b23b5a1e9654148b94d44c
2015-05-08 09:49:01 +02:00
Stephan Bergmann
1cb0b37ad0 Rephrase comparisons between bool and sal_Bool
...to cater for forthcoming loplugin:implicitboolconversion improvements

Change-Id: I88c0c4681137022005c3a4c418e91cb17bc17148
2015-05-08 09:49:01 +02:00
Miklos Vajna
61b44da9fb gtktiledviewer: unused pFileName
Change-Id: I30cd9d8adffbdf9d7451bca0c09aa56639379486
2015-05-08 09:07:52 +02:00
Stephan Bergmann
665657d3da Also mention exception type
Change-Id: I3ba60fd0ff8f4ed0a2683986cec7bdb25a837c18
2015-05-08 08:57:56 +02:00
Noel Grandin
cce752b1ba convert SHOWDIALOG_ID constants to scoped enum
Change-Id: I58fffa7345f6b5050b8a1b3ac1022c630e64dbb4
Reviewed-on: https://gerrit.libreoffice.org/15651
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-08 06:50:24 +00:00
Thorsten Behrens
d4f90e1a2a Revert "fix for older gcc"
Superseded by 7ad4e562b462af22a1c29c955293238cdb30267b

This reverts commit fbd85c25ba90b8db461555d735ab8b13f52d01ee.
2015-05-08 08:23:33 +02:00
Stephan Bergmann
fc4726a1f4 Use typed Menu::Set[De]actuivateHdl Links
Change-Id: I6736383ad0ec5c9f2ea2281bfdcfa280cd712032
2015-05-08 07:50:14 +02:00
Stephan Bergmann
0c415f61e4 Use typed Menu::SetHighlightHdl Link
Change-Id: I47a35813fddcb90497b621a96bafe74969dc90d0
2015-05-08 07:50:13 +02:00
Andrew
e658cb4d5c Clipart - PNG files optimized.
Lossless optimisation of PNG image files in clipart Gallery.
Total saving of 887 KB !
Used ImageOptim.com and custom tools ('pngslim').

- Arrows: Saved ~44KB out of 189KB. ~23% per file on average (up to 38%).
- Computers: Saved ~17KB out of 242KB. ~7% per file on average (up to 11%).
- Education: Saved ~142KB out of 804KB. ~18% per file on average (up to 36%).
- Environment: Saved ~197KB out of 1.3MB. ~14% per file on average (up to 23%).
- Finance: Saved ~67KB out of 695KB. ~10% per file on average (up to 37%).
- People: Saved ~280KB out of 2.7MB. ~10% per file on average (up to 15%).
- Transportation: Saved ~141KB out of 1MB. ~14% per file on average (up to 15%).

Change-Id: I1812ae84e5672d49a7798dc44f518c1d6cd70ec1
Note: These should ultimately be replaced with original (/improved) SVG vector artwork.
Signed-off-by: Andrew <dent.ace@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/15669
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-07 23:35:45 +00:00
Michael Meeks
03e3d888ff tdf#91073 - hold a reference on the floatwin in UserEvent handler.
Change-Id: I6f8b8681643448d2b335c9f16d63a75cbd43f854
2015-05-07 21:30:46 +01:00
Michael Meeks
94b1c8ca69 tdf#90935 - calc / sort dialog fixage.
Change-Id: I9b33d2a6a47ba210561317679fd8514a1b5cfd11
2015-05-07 19:59:42 +01:00
Miklos Vajna
893871d868 sw: unused Parent [-Werror=unused-parameter]
Change-Id: I4576837da4b908ac0393be155758b6b60afc6c45
2015-05-07 20:28:39 +02:00
Miklos Vajna
1168d5a82e sw: fix -Werror=unused-parameter
Change-Id: I67223090a2a45e9519bd29e41e3e90eb847c5c19
2015-05-07 20:25:33 +02:00
yogesh.bharate001
3ffed8635a tdf#91066: Condensed Character Spacing i.e spc(negative value) is not exported after RT.
Problem Description:
- Condensed character spacing i.e Spacing between characters/letters (negative value)
is not preserved after roundtrip.

XML Difference:
XML Difference :
Original:
<a:rPr lang="en-IN" sz="6000" b="1" kern="0" spc="-1000" baseline="0">

After Roundtrip:
<a:rPr b="1" lang="en-IN" sz="6000" strike="noStrike">

spc="-1000" is missing in roundtripped file.

Change-Id: I02edbb31375c2406a6e39873b7b886f4786a3758
Solution: Added support for Condensed Character Spacing.
Reviewed-on: https://gerrit.libreoffice.org/15635
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07 15:59:49 +00:00
Stephan Bergmann
d0dd41319f loplugin:vclwidgets ("OutputDevice subclass should have ..."
Change-Id: Id2f6bbfa549fd71258b1d875fef44f1833781a3a
2015-05-07 17:56:57 +02:00
Winfried Donkers
bf95b81a5d remove unused code; bMapDupToInternal in struct AddInMap
is not used apart from getting a value.

Conflicts:
	sc/source/core/tool/odffmap.cxx

Change-Id: I26e942f6357970c6d9de27b5d5cf00b451193732
Reviewed-on: https://gerrit.libreoffice.org/15658
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07 15:55:59 +00:00
Mike Kaganski
a612c2ee5f tdf#55665: Fix a corner case OLE processing
This fixes two problems with WW8Export::TestOleNeedsGraphic:
1. not testing for NULL pGraphicsStream pointer,
2. not releasing that pointer in all cases.

Change-Id: I67921aec3ce0cb131359e66ee3a6a136d76952a0
Reviewed-on: https://gerrit.libreoffice.org/15667
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07 15:52:54 +00:00
László Németh
a1bfad005c XTiledRenderable: use HWND instead of HDC
Cherry-picked from e1fb63bb8ed7a9bd4dbe19be0d0da7245c4a2fb2

Change-Id: I2959ea8b1213d6dade1c2567365f177bf542e075
2015-05-07 17:47:23 +02:00
László Németh
96a6128b92 Initial XTiledRenderable API
Cherry-picked from e2ad83e25aa86bc377b664d6d07a0b86abf487c0

Change-Id: I6dc337ec958c1e116fc9763877f331b751b64e6e
2015-05-07 17:47:22 +02:00
Michael Meeks
65376dad89 tdf#90935 - fix dispose ordering for tools->customize dialog.
Change-Id: I1ddd3b804f82438e08ea7761a205fc4b784cdf00
2015-05-07 16:43:48 +01:00
Caolán McNamara
d6e5c52cb2 NoParent condition reversed
regression from...

commit 39078c247d31674544901f8449f5141185f79f7f
Author: Noel Grandin <noel@peralex.com>
Date:   Wed May 6 14:07:17 2015 +0200

    cleanup DIALOG_NO_PARENT, follow on to tdf#91090

    remove the DIALOG_NO_PARENT abomination and replace it with a flags
    parameter

Change-Id: I1955531b41b01623ca94155c60794ae1771849ff
2015-05-07 16:30:51 +01:00
Michael Meeks
da49275807 tdf#90935 - function wizard crash fix.
Change-Id: I1344e194f8fd5d2c0ffff4e8b075564df32706a8
2015-05-07 16:27:56 +01:00
Michael Meeks
6fd3e56090 Catch another erroneous 'make' constructor function.
Change-Id: I4a674b44bce1f3c3f5c3de2639863ff4b4fcd41e
2015-05-07 16:13:51 +01:00
Michael Meeks
630fe2d0c9 tdf#91127 - SwDbTreeList 'make' function fix.
Change-Id: Iaefba9f6f546c3ac22749aa0ff209cbc49f8a552
2015-05-07 16:07:57 +01:00
Michael Meeks
cfcfc5e9de VclBuilder - use VclPtr more consistently internally.
Fixes a number of TabPage related leaks.

Change-Id: I7b904e9bbbce652d2dc645952e266cde102ed194
2015-05-07 16:07:57 +01:00
Michael Meeks
fc8c282e99 tdf#91127 - get SfxTabPage creation function ref-counting right.
Change-Id: I7c730cf311900fe14a09081dd986f17d9b89e77f
2015-05-07 16:07:56 +01:00
Mike Kaganski
28a2f0d6d8 tdf#74299: improve DXF import
1. Now there's no fixed string length limit; see
http://www.autodesk.com/techpubs/autocad/acad2000/dxf/group_code_value_types_dxf_01.htm
The Autodesk's own DXF reference is inconsistent on this matter;
the "Group Code Value Types Reference" tells opposite to "About Group
Codes in DXF Files".
AutoCAD itself easily creates lines 10 000+ characters long!

This removes the hardcoded line length limit; also simplifies
internal struct DXFGroupReader used to parse DXF codes.

2. Improved text import: honor unicode strings in AutoCAD 2007+ DXF;
use more $DWGCODEPAGE values (note: when more codepages will be
discovered, they should be handled in DXFRepresentation::ReadHeader()).
Use LO locale when DXF doesn't specify one. Handle AutoCAD character
names.

3. General fixes & simplifications.

Change-Id: Ifde08978e2da7511696100520732bd76c1a660bb
Reviewed-on: https://gerrit.libreoffice.org/15627
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07 14:15:36 +00:00
Stephan Bergmann
1779568f66 Revert "Tackle Menu with RenderContext refactoring, Invalidate"
This reverts 5485ef70cee1e3a743047f95ce94533024004b7c, which breaks
JunitTest_toolkit_unoapi (toolkit.AccessibleMenu)

Change-Id: Ic9021c23178f1598c08186e5cb24fde13a866579
2015-05-07 16:12:22 +02:00
Christoph Lutz
7ad4e562b4 improve fallback behaviour of underlying_type for old gcc
The fix fbd85c25b is not sufficient to build with an old GCC 4.6.
The problem was, that underlying_type returned an int as default
value for GCC 4.6 and int allows negative values that are forbidden
in typed_flags_set.

Changed it to alternative solution suggested in
http://stackoverflow.com/questions/26148192/underlying-type-of-a-c-enum-in-c03

Change-Id: I20f44b8cef9c692efb583971bd251f1c34c289ab
Reviewed-on: https://gerrit.libreoffice.org/15663
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-05-07 14:10:51 +00:00
Takeshi Abe
6a26624d8b vcl: simplify code by using std::any_of/std::none_of
Change-Id: I37c4fd80780738b823c7928f22deaff0ea1c6bff
Reviewed-on: https://gerrit.libreoffice.org/15585
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07 14:05:16 +00:00
Takeshi Abe
5a7c1bc635 simplify code by replacing std::find_if with std::any_of/std::none_of
Change-Id: Ife6ab3544f73b1de60f5241c68466045161a4d88
Reviewed-on: https://gerrit.libreoffice.org/15615
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07 14:03:42 +00:00
Niklas Johansson
b4d7f82484 tdf#90994 The accessible name should not contain the accessible role
The accessible role (PANEL) is added as a prefix to the title bar
in the sidebar. That is redundant and can even make things confusing
for the users of screen-readers.

Change-Id: I743defa0b1b9f3f278d0cabc7196054796fb3c47
Reviewed-on: https://gerrit.libreoffice.org/15636
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07 13:58:18 +00:00
Niklas Johansson
0fc79344ce tdf#90994 Sidebar tab bar buttons should should have accessible names
The tab bar buttons (Properties, Styles and formatting, Gallery ...)
should expose their name to accessibility tools.

Change-Id: I5292ca848688cf93a046c3f5d8906ac35cee1cfe
Reviewed-on: https://gerrit.libreoffice.org/15639
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07 13:57:43 +00:00
Andrea Gelmini
65088fc470 tdf#91050: fix typo TabePage->TabPage
Change-Id: I21d04451aa747f6d8d9560533674f1c0aa590e65
Reviewed-on: https://gerrit.libreoffice.org/15664
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07 13:55:47 +00:00
Andrea Gelmini
70d01ce947 tdf#91051: fix typo Trancparency->Transparency
Change-Id: I8874e38a4bed6adb409a954c15ce7c9e4348c572
Reviewed-on: https://gerrit.libreoffice.org/15665
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07 13:55:26 +00:00
Andrea Gelmini
755abae091 Fix typo informations -> information
Change-Id: Ie8a7bc9800ed0122092f88cedadb126b7891f2a6
Reviewed-on: https://gerrit.libreoffice.org/15655
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07 13:54:59 +00:00
Caolán McNamara
4073afa350 Resolves: tdf#72007: on switching decks keep our left indent, don't assume 0
Change-Id: I878c999611e1294d5107f1cf2c000d9ed5f88cb1
2015-05-07 14:38:16 +01:00
Noel Grandin
0776b33f79 convert PUSHBUTTON_DROPDOWN constants to scoped enum
Change-Id: Iae363b8478ef2d560ae661af06ba989f27adc093
Reviewed-on: https://gerrit.libreoffice.org/15650
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-07 13:28:09 +00:00
Noel Grandin
2c8dc03733 convert BUTTONDIALOG constants to scoped enum
Change-Id: Icbf73fe55ad604f762dd2b98fd39189bab82f061
Reviewed-on: https://gerrit.libreoffice.org/15648
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-07 13:27:55 +00:00
Caolán McNamara
90d8bf72d9 VclPtr: clicking on another sidebar button when navigator open crashes
Change-Id: Iafcc7246a1149a25f6d6fdfb09cf3e85227580db
2015-05-07 14:19:17 +01:00
Caolán McNamara
15532c9a1f VclPtr: clicking on sidebar impress navigator crashes
not sure how this ever worked, the callback is called
at the end of the ctor and the callback is in the parent
obj which dereferences the pointer to this obj before
that pointer has been set.

Just split the ctor into a ctor and a follow up
post ctor init method.

Change-Id: I04855c8ac95592801f2ebf0b974a9a7b597d0327
2015-05-07 14:13:05 +01:00
Michael Meeks
a3deb48668 tdf#91127 - audit for unfortunate SAL_NO_ACQUIRE referencing issues.
Change-Id: I738f3ea1bf9f003f2b146cda0a8f986375eacd2b
2015-05-07 13:20:21 +01:00
Stephan Bergmann
ba17287cc8 Fix MSVC build
Change-Id: Ibbcb6141cc8941dd4a40d9460e1d83550f21e9cc
2015-05-07 13:55:14 +02:00
Stephan Bergmann
d4e242510f Fix MSVC build
Change-Id: I73fdb73a26f49acf058fcc4ffaa1dbfa92bd7261
2015-05-07 13:51:26 +02:00