For more info and explanation including state of process
information and discussion(s) see task please.
Adding corrections for gerrit build
Change-Id: Ie10fb8093a86459dee80db5ab4355b47e46c1f8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88130
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
The OLE objects (in this case charts) had bad wrap option setting
and this lead to misplaced objects. Now this parameter is set
according to the file.
Change-Id: I506be91b6801f0ffc3942e514f81119d895fdcb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88091
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
So we get a simple button, like it used to be before commit
c81afdb511 ("rework
TextUnderlinePopup to be a PopupWindowController"). The
dropdown doesn't work in reportdesign anyway.
Change-Id: I9cec636ecc983a353b807624cea6523a9a2b92ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88182
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
SharePoint returns broken URIs in its href replies, which aren't
correctly URI encoded, but still "valid" URIs w.r.t. general and
UTF8 encoding, e.g. http://<host>/Shared%20Documents/ümlaut.docx
As a workaround, this allows all invalid / other bytes (except
'\0') in the path of the URI in ne_uri_parse.
Change-Id: I70e7d323837469d7ced429a42c009972f4fb0ebc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88120
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jenkins
This builds NEON with its debugging / logging facility, if
gb_ENABLE_DBGUTIL is set. This still has to be enabled in code by
calling something like ne_debug_init(stderr, NE_DBG_XML) to enable
and ne_debug_init(NULL, 0) to disable it again.
Change-Id: I85ea1cb2bd9586072d5a12a1cb809dd8c76b37d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88171
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Don't only check the width of the line, but also the line style and the
thickness (0 is not visible).
Also there isn't a separate continuationSeparator in sw, so it should
depend on the same condition as the separator.
Unfortuantely Word doesn't support different separators per section.
Change-Id: I55cb3d82ff20c7a21f7d256ec8ba4a43f1e71faa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88131
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Just like with OpenGL, mark zones where Skia code may call into graphics
drivers in order to be able to detect cases where the driver has
caused a crash or a lockup.
Change-Id: I0fdbcc2260e3ab7821a595e9960145ae1fc1adfe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88011
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
...without which `make clean && make CppunitTest_sd_misc_tests` would fire
> cppunittester: vcl/source/gdi/bmpacc.cxx:38: BitmapInfoAccess::BitmapInfoAccess(Bitmap &, BitmapAccessMode): Assertion `xImpBmp && "Forbidden Access to empty bitmap!"' failed.
because
> #3 0x00007ffff6deba66 in __GI___assert_fail
> #4 0x00007fffd23c14af in BitmapInfoAccess::BitmapInfoAccess(Bitmap&, BitmapAccessMode) at vcl/source/gdi/bmpacc.cxx:38
> #5 0x00007fffd23c36fc in BitmapReadAccess::BitmapReadAccess(Bitmap&, BitmapAccessMode) at vcl/source/gdi/bmpacc.cxx:87
> #6 0x00007fffd23c89a0 in BitmapWriteAccess::BitmapWriteAccess(Bitmap&) at vcl/source/gdi/bmpacc.cxx:355
> #7 0x00007fffd3359a02 in Bitmap::AcquireWriteAccess() at vcl/source/bitmap/bitmap.cxx:388
> #8 0x00007fffd1cb15cf in vcl::ScopedBitmapAccess<BitmapWriteAccess, Bitmap, &Bitmap::AcquireWriteAccess>::ScopedBitmapAccess(Bitmap&) at include/vcl/scopedbitmapaccess.hxx:53
> #9 0x00007fffd3375fe6 in BitmapDisabledImageFilter::execute(BitmapEx const&) const at vcl/source/bitmap/BitmapDisabledImageFilter.cxx:28
> #10 0x00007fffd336ed1d in BitmapFilter::Filter(BitmapEx&, BitmapFilter const&) at vcl/source/bitmap/bitmapfilter.cxx:22
> #11 0x00007fffd34c1875 in ImplImage::getBitmapEx(bool) at vcl/source/image/ImplImage.cxx:123
> #12 0x00007fffd34c212c in ImplImage::getBitmapExForHiDPI(bool) at vcl/source/image/ImplImage.cxx:153
> #13 0x00007fffd34b3c7b in Image::Draw(OutputDevice*, Point const&, DrawImageFlags, Size const*) at vcl/source/image/Image.cxx:123
> #14 0x00007fffd1cec66e in OutputDevice::DrawImage(Point const&, Size const&, Image const&, DrawImageFlags) at vcl/source/outdev/bitmap.cxx:1388
> #15 0x00007fffd1cec1f7 in OutputDevice::DrawImage(Point const&, Image const&, DrawImageFlags) at vcl/source/outdev/bitmap.cxx:1372
> #16 0x00007fffd0ea7ca4 in ToolBox::ImplDrawItem(OutputDevice&, unsigned long, unsigned short) at vcl/source/window/toolbox.cxx:2696
> #17 0x00007fffd0ec629d in ToolBox::Paint(OutputDevice&, tools::Rectangle const&) at vcl/source/window/toolbox.cxx:3490
> #18 0x00007fffd003daed in PaintHelper::DoPaint(vcl::Region const*) at vcl/source/window/paint.cxx:309
wants to draw sfx2/res/symphony/morebutton.png
Change-Id: I9c21eb7891a6dfa29033618177c97370695e413d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88146
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
It generally shouldn't activate if the process is progressing slowly
because of debugging.
Change-Id: Iacabe0fee762d5bf292582fdbb1a8f5ce67abb5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88010
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
To be used also by Skia code to detect problems with Vulkan drivers.
The watchdog does not handle OpenCL because neither did the original
code, but also because OpenCLZone::hardDisable() called from it
would deadlock on SolarMutex for some reason.
Change-Id: I483d8cb0b11a4e1e65c564f4e4c29ab68843ff71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88008
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
First, there was a SIGABRT due to
> Could not find platform independent libraries <prefix>
> Could not find platform dependent libraries <exec_prefix>
> Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>]
> Fatal Python error: initfsencoding: Unable to get the locale encoding
> ModuleNotFoundError: No module named 'encodings'
at
> #1 0x00007ffff6ddc8d9 in __GI_abort ()
> #2 0x00007ffd654459db in fatal_error (prefix=<optimized out>, msg=<optimized out>, status=<optimized out>) at workdir/UnpackedTarball/python3/Python/pylifecycle.c:2187
> #3 0x00007ffd654430fe in _Py_FatalInitError (err=...) at workdir/UnpackedTarball/python3/Python/pylifecycle.c:2206
> #4 0x00007ffd65443348 in Py_InitializeEx (install_sigs=1) at workdir/UnpackedTarball/python3/Python/pylifecycle.c:1041
> #5 Py_Initialize () at workdir/UnpackedTarball/python3/Python/pylifecycle.c:1048
> #6 0x00007ffd65d88a65 in pyuno_loader::(anonymous namespace)::PythonInit::PythonInit() (this=0x7ffd65da0820 <pyuno_loader::CreateInstance(com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&)::s_Init>) at pyuno/source/loader/pyuno_loader.cxx:229
> #7 0x00007ffd65d87b54 in pyuno_loader::CreateInstance(com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&) (ctx=...) at pyuno/source/loader/pyuno_loader.cxx:247
And then there was a failure
> postprocess/qa/services.cxx:318:(anonymous namespace)::Test::test
> forced failure
> - instantiating "com.sun.star.wizards.agenda.CallWizard" via "com.sun.star.wizards.agenda.CallWizard" caused com.sun.star.uno.RuntimeException "<class 'ImportError'>: No module named 'wizards.ui' (or 'ui.WizardDialog.WizardDialog' is unknown), traceback follows
> File "instdir/program/pythonloader.py", line 136, in activate
> mod = self.getModuleFromUrl( locationUrl )
> File "instdir/program/pythonloader.py", line 114, in getModuleFromUrl
> mod = __import__( dependent )
> File "instdir/program/uno.py", line 356, in _uno_import
> return _builtin_import(name, *optargs, **kwargs)
> File "instdir/program/wizards/agenda/CallWizard.py", line 21, in <module>
> from .AgendaWizardDialogImpl import AgendaWizardDialogImpl, Desktop
> File "instdir/program/uno.py", line 356, in _uno_import
> return _builtin_import(name, *optargs, **kwargs)
> File "instdir/program/wizards/agenda/AgendaWizardDialogImpl.py", line 20, in <module>
> from .AgendaWizardDialog import AgendaWizardDialog, uno
> File "instdir/program/uno.py", line 356, in _uno_import
> return _builtin_import(name, *optargs, **kwargs)
> File "instdir/program/wizards/agenda/AgendaWizardDialog.py", line 18, in <module>
> from ..ui.WizardDialog import WizardDialog, uno, UIConsts, PropertyNames
> File "instdir/program/uno.py", line 434, in _uno_import
> raise uno_import_exc
> File "instdir/program/uno.py", line 356, in _uno_import
> return _builtin_import(name, *optargs, **kwargs)
>
> "
Change-Id: I80160dccd162641e6a9d5633e45a498f230abfdc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88144
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Files which could become clang-format conformant with
under 5-percent lines of change relative to the total
count of lines in the file are found by using bin/find-clang-format.py,
and fixed with /opt/lo/bin/clang-format -i <path-of-the-file>
There will be follow-up patches to fix all 'under-5-percent' files.
Change-Id: I2886b6da85043218505ff9f3e40a8e28289c6f37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88152
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
This was causing generation of code in violation of clang-format
conformance in these files:
* xmlsecurity/inc/pch/precompiled_xsec_xmlsec.hxx
* connectivity/inc/pch/precompiled_ado.hxx
Also remove these 2 files from the clang-format blacklist.
Change-Id: I882028c0553a3ff7fb356611f498d50dea984a7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88143
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
These were terribly confusing.
.uno:Fontwork does NOT insert fontwork text, despite the tooltip name.
It opens up the old fontwork dialog that modifies contour properties
so that the text can flow along the contour.
The UIname is Fontwork, so lets have an automatic tooltip for that.
.uno:FontworkGalleryFloater has a UIname of "Fontwork Style",
but the auto-generated tooltip was "Fontwork". (Notice that this
conflicts with the UIname of the other one. So when you add "Fontwork"
to your toolbar, and chose the icon with the tooltip "Fontwork" you
get a different item.) Since this one actually inserts text, and
doesn't actually modify any existing style (that's the function of
Fontwork Shape), lets give this one the tooltip "Insert Fontwork Text".
Therefore, this patch effectively switches the two tooltip names around,
which much better matches their function, and their UIname.
I expect that this was the original 2016 intention anyway...
At the end, I decided to also change the UIname to "Insert Fontwork",
since the gallery is normally added to insert menus...
The unit test I had to modify just looked like a functionality test
and had nothing to do specifically with the label's string.
(It was last changed for tdf#91781 which made no specific
reference to fontwork.)
This might help documentation bug tdf#118336 a bit too.
Change-Id: I152596781def2d8dba47f53e345976543e3131bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88101
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
