they always triggered disabled the current state in the roadmap, but disabling
a roadmap step now really disables the associated window in vcl.
These two particular toggles don't actually affect the current roadmap state,
so don't call state-modified when changing them.
That doesn't change the ye-old weird case that the logical state of this final
step is disabled, but don't let the wizard find that out when toggling
radiobuttons that don't contribute to the roadmap state
Change-Id: I5927d20ea461a294e76014892c90ad0b5f39fb6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88280
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
its in vcl not sfx, so under windows its not actually created by the
builder as the factory method isn't found in sfx. While under linux
the method is found anyway despite the wrong lib name.
seeing as its in vcl, keep it there. The factory method isn't needed
when its in vcl and rename the .ui name to VclOptionalBox
Change-Id: If279477d2e4cbb50d202d528c293b471134de30c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88279
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
missed this in
commit eb862a9330
Author: Caolán McNamara <caolanm@redhat.com>
Date: Thu Jan 23 15:16:33 2020 +0000
conditionalentrymobile doesn't work
this is probably based on the non-mobile version, but by when it was
initially integrated it was already out of sync with the non-mobile
version and can't work as it is
Change-Id: I480052230d2f893f540cacb2cc2c3b699f9cba1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87283
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
remove it for the same reason
Change-Id: Ib4db82fbd3846a21efbb3612396332cfaff670af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88278
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
As we cannot generally make sure they stay encrypted.
Change-Id: I15ed41fabcc553608e418608ad1166a951daa4b6
(cherry picked from commit aaf91e7c4833689dc11d0b7f3e9f707a9ce206d5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88209
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Extracted SetBackgroundComponentBounds() which removes need for
checking OutDevType especially whether it is Printer or not in OutputDevice.
Change-Id: Ib8884b861314f595283af9ae3a2cd5645b334d51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86312
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Make use of mentioned task's 1st commit now
and implement direct dashing for cairo. All
the data is now available (that was the work),
make use of it.
Keeping a local static bool to control it, so
later if needed can be switched on/off e.g
using some global var/setting.
Cairo will now do buffering of complex polygon
data in cairo path data (from some compexity
on and timer/mem-controlled), but not dismantle
to own, stroked data.
With bDoDirectCairoStroke disabled, the dis-
mantled data will be buffered - more mem, but
should also help - at least it gets reused
now that it is possible to keep it at the
original geometry (incoming polygon) at all
Change-Id: Ic08f659d7ccbedc910ec678b1509ee1a7f3f2112
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88262
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Grabing focus at this location in SwFormatTablePage::DeactivatePage
prevents adjacent tab pages from keeping focus on their tab when
keyboard navigating the dialog.
Change-Id: Ie90722572569ac0cd5251682a19727c91e2a326d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88162
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
when there is more than one language, there needs to be two separate
columns with a renderer each, not one column with two renderers
Change-Id: Id4f2c9938fd3bd0aa3e006166df6081d57ef57df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88222
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Regression from commit a3c7a8282d
(jsdialogs: apply .uno:Color and CharBackColor to floating text frames,
2019-11-08), the problem was that the original code populated aNewAttr, while
SetAttrToMarked() was only invoked in case there were arguments.
Fix this by making pNewAttrs a copy, so lcl_convertStringArguments() can
work on it in place, and then restore the old code that copied from
pNewAttrs to aNewAttr. This fixes the no-arguments case and keeps the
lcl_convertStringArguments() case working.
Change-Id: If7bf2d7b21e48d513a512ec6127b61ee74635ef5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88227
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
This takes over Caolán's solution for gtk3 from
dbcdc5cd98
("tdf#129809 take a reference in case m_aContents is replaced")
for the qt5 case as well, to prevent that the XTransferable
is destroyed along with the Qt5MimeData object as new QMimeData
are set in the clipboard, as follows:
1 Qt5Clipboard::setContents Qt5Clipboard.cxx
2 TransferableHelper::CopyToSelection transfer.cxx
3 TransferableHelper::CopyToSelection transfer.cxx
4 SwTransferable::CreateSelection swdtflvr.cxx
5 SwWrtShell::SttSelect select.cxx
6 SwWrtShell::SelectTextAttr move.cxx
7 SwTransferable::GetData swdtflvr.cxx
8 TransferableHelper::getTransferData2 transfer.cxx
9 TransferableHelper::getTransferData transfer.cxx
10 Qt5MimeData::retrieveData Qt5Transferable.cxx
11 QMimeDataPrivate::retrieveTypedData qvariant.h
12 QMimeData::data qmimedata.cpp
13 QInternalMimeData::renderDataHelper(QString const&, QMimeData const *)
14 ??
15 ??
16 ??
17 QXcbConnection::handleXcbEvent(xcb_generic_event_t *)
18 QXcbConnection::processXcbEvents(QFlags<QEventLoop::ProcessEventsFlag>)
19 ??
20 g_main_context_dispatch
Change-Id: Ic712c901a31131efc596cac7f00f14bb6a7ce068
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88192
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
* Update helpcontent2 from branch 'master'
to a797d607f1d56f4e401d03669d766124317baa46
- adjust embedding of Position header in chapter numbering help
Change-Id: I0e3e5ecc78dc8747e71342edbce23358a14e71a7
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88254
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
This is similar to commit 26f2a9e1a1 (DOCX
export: fix handling of section starts that originally had headers,
2020-02-06), except here the top margin has to taken from that follow
page style, not the header.
Without this, it can happen that the page number in the original Writer
doc model and the exported Word result do not match.
This required reworking WriteNextStyleHeaderFooter(), which assumed that
the header/footer status is already calculated by the time its called.
But the page margin code runs earlier, so we need to make that decision
earlier, even when the header/footer status is not yet calculated.
Change-Id: Ife7396603702d2048d544aa46f96acfa337a041a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88211
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
- refactor out field formatting
* make direct calls explicit with new UpdateTextNode() call
* try to bring at least some sanity to the event handler
Change-Id: I40a39ddf70476b7fa0bf5e157fb263e863bb1d20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87927
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
