mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
406,095 Commits 1 Branch 0 Tags
Commit Graph

2738 Commits

Author SHA1 Message Date
Takeshi Abe
14bead7f42 forms: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: Ia4f56692c9beddda13ee948ab8bbc1ee95098fbf
Reviewed-on: https://gerrit.libreoffice.org/17648
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-08-11 13:30:17 +00:00
Noel Grandin
2886f830a9 idl,framework,forms: inline some use-once typedefs 
Change-Id: Icb4908c274ec0778af7ed9fe2d935bf6723fedfb
 2015-08-04 08:55:56 +02:00
Noel Grandin
4eeeec899f convert RGCHK constants to scoped enum 
Change-Id: Iafeae0f85f751469900471cf8fccd5f763407890
 2015-07-28 08:35:34 +02:00
Noel Grandin
38ecca9b30 inline a bunch of use-once macros 
no point in having a macro unless it's actually going to reduce the
number of lines of code

Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
 2015-07-27 08:18:16 +02:00
Noel Grandin
efac5fa06e remove some unused defines 
Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188
Reviewed-on: https://gerrit.libreoffice.org/17332
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-27 06:12:01 +00:00
Noel Grandin
771d9ef3f6 loplugin:unusedmethods forms 
Change-Id: I6b7938e948fb1422f83e2175fee5fcabe0a0b83f
 2015-07-17 11:07:13 +02:00
Stephan Bergmann
891c80e172 loplugin:simplifybool 
Change-Id: I8b704401233fa865c8ec4d4663d720a3d7d8de69
 2015-07-16 14:00:17 +02:00
danlrobertson
5a61d7f049 tdf#92459 replace unary_function in forms 
Remove all instances of classes that are derived from the now
depreciated unary_function and binary_function with lambda expressions.

Change-Id: Iab662159b8b8554e10dfe6886ee803da78a937ed
Reviewed-on: https://gerrit.libreoffice.org/16631
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2015-07-15 23:50:50 +00:00
Noel Grandin
4c5498ec5e fix windows build 
Change-Id: I505b7b0e6bf86093fbed1aa7e28b710e12116e6e
 2015-07-14 12:37:32 +02:00
Zolnai Tamás
70f152983f tdf#47832: Pictures on buttons, created in forms, gone after reopening form 
When image is set to a Button control the correspoding graphic object
lives only temporarily, after the graphic is copied from the graphic
object it's destroyed so save can't find it by graphic ID.
Use the same solution which works for ImageControls: use a graphic object
member for the control, so save can find it.

Change-Id: If99a3efc4727a07df9d2daaefbdacc9565920005
 2015-07-14 10:36:17 +02:00
Stephan Bergmann
cbce40e965 Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds 
...to avoid lots of loplugin:staticmethods warnings.  Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.

Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
 2015-07-13 18:14:11 +02:00
Noel Grandin
89c77994d4 remove some unnecessary typedefs around uno::Reference 
Not very useful these days, since we have the css:: prefix to reduce
verbosity.

Found with a search like:
   git grep -nP 'typedef .*uno::Reference.*<.*>\s+\w+;'
       | grep -v 'std::'

Change-Id: I16f41c53837ec5c613545ae45df38b0daddcbadd
Reviewed-on: https://gerrit.libreoffice.org/16730
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-06 06:14:15 +00:00
Andrea Gelmini
465489d97a Fix typos 
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-07-03 09:43:46 +00:00
Andrea Gelmini
1a8915ef83 Fix typos 
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
Reviewed-on: https://gerrit.libreoffice.org/16582
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
 2015-06-30 15:57:12 +00:00
Caolán McNamara
5d39063581 coverity#1308583 Uncaught exception 
Change-Id: Ibc6a8e437d81769b9a77d0a52e98f71b1c7e7d51
 2015-06-29 09:43:35 +01:00
Caolán McNamara
0a4e65219e coverity#1308582 Uncaught exception 
Change-Id: Ibe15ebdbdd5c0eb719821043696ce22f76c5b232
 2015-06-29 09:43:35 +01:00
Caolán McNamara
265ad0605c coverity#1308542 Uncaught exception 
Change-Id: I083d3152c0bb51f72e9f61203a7b3d9c4421a072
 2015-06-28 17:56:00 +01:00
Stephan Bergmann
6390d2c52b Get rid of comphelper::string::is*Ascii functions 
Change-Id: I99912112e5b009d7a143f9816d757cdf6ebb1783
 2015-06-24 15:27:28 +02:00
Stephan Bergmann
bd20422248 Disambiguate needlessly overloaded OGridControlModel::createColumn 
Change-Id: Ie12370fbd0b1d5aaacd56d6e21de29b6134d9741
 2015-06-19 11:04:15 +02:00
Andrea Gelmini
ae150c6a54 Fix typos 
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
Reviewed-on: https://gerrit.libreoffice.org/16314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2015-06-18 11:44:56 +00:00
Stephan Bergmann
8e1ad96626 Some missing SolarMutexGuard around VclPtr acquire/release 
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so
apparently rely on the SolarMutex being locked whenever they are called.  Fixed
those places that caused "make check" to fail for me when temporarily adding
DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release.  (A recurring pattern is
that a class fails to ensure the SolarMutex is locked around the destruction of
non-null VclPtr members.)

Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
 2015-06-17 15:24:19 +02:00
Andrea Gelmini
3fa7b0b70f Fix typos 
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e
Reviewed-on: https://gerrit.libreoffice.org/16310
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 11:25:13 +00:00
Andrea Gelmini
ca9de688c2 Fix typos 
Change-Id: I549635318f46718042e50c8f89ce3c620cade990
Reviewed-on: https://gerrit.libreoffice.org/16281
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 11:10:51 +00:00
Andrea Gelmini
01532b1ab8 Fix typos 
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072
Reviewed-on: https://gerrit.libreoffice.org/16297
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 11:05:58 +00:00
Noel Grandin
4729774b24 remove unnecessary check for null when calling delete 
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
 2015-06-15 14:46:41 +02:00
Caolán McNamara
8d8f264f57 cppcheck: passedByValue 
Change-Id: I444c40340bcfd64f88dac34da6cc858f66996fe6
 2015-06-15 11:11:43 +01:00
Stephan Bergmann
885bf7c68c loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I1d24939c085ee0751de00124d2a90de1270dbd22
 2015-06-08 16:25:15 +02:00
Noel Grandin
d33c6cd785 fix Windows build 
after my commit 55bc128636596032c23ee855904822ad813986fc
"loplugin:loopvartoosmall"

Change-Id: I1d43447df24d7bf5c8737801389447980bb69d26
 2015-06-01 10:19:15 +02:00
Noel Grandin
55bc128636 loplugin:loopvartoosmall 
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5
 2015-06-01 09:58:56 +02:00
Stephan Bergmann
3a05a08ba7 loplugin:redundantcast: const_cast to same type 
Change-Id: I5fe081bc2edfe14c81372ae0fd407e493d80d689
 2015-05-29 12:04:32 +02:00
Noel Grandin
66854d697f convert WINDOW_DRAW flags to scoped enum 
Change-Id: I9400a286fab18d683b4c109007961685f01b6da3
 2015-05-27 11:14:26 +02:00
Tomaž Vajngerl
22fd5e0806 refactor forms classes to use RenderContext 
Change-Id: I18026eb4a3784afc84c68c4effdb0c267e31e5db
 2015-05-18 15:55:00 +09:00
Julien Nabet
3aebc670e1 Remove include stdio (part2) 
Change-Id: Iae58d107d8df1c543a165086fb2b7c288e7121dd
Reviewed-on: https://gerrit.libreoffice.org/15775
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2015-05-18 05:33:52 +00:00
Noel Grandin
82d68f9cbc convert COMMAND_ constants to scoped enum 
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95
Reviewed-on: https://gerrit.libreoffice.org/15671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-05-11 12:17:42 +00:00
Stephan Bergmann
6dc42c82ba Use IMPL_LINK_NOARG[_TYPED] where applicable 
Change-Id: I70598072c1d492e360ef46dd7b5ef5a2fa4be495
 2015-05-10 12:06:16 +02:00
Stephan Bergmann
4f00dce2b3 Use IMPL_[STATIC_]LINK_NOARG where applicable 
Change-Id: I1e24b032bdeea017b0e77c5446e55310899ce752
 2015-05-10 11:25:48 +02:00
Stephan Bergmann
e3ff2da892 Replace IMPL_STATIC_LINK[_TYPED] with more useful variants 
Change-Id: I347eb4655babca809f4141e2f0dfe86077b77c75
 2015-05-10 11:25:43 +02:00
Takeshi Abe
99e60d8d62 std::ptr_fun became deprecated since C++11 
Change-Id: If93609d032c9864e0251230bf9ed76e6b6741a62
Reviewed-on: https://gerrit.libreoffice.org/15672
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-05-08 15:54:12 +00:00
Michael Stahl
8fca0c44e8 vcl: rename other members of StateChangedType for consistency 
Change-Id: Ifd3339813e5d3dfb54566fd226aaf2d2a199d59a
 2015-05-05 15:51:11 +02:00
Stephan Bergmann
c9b4c56811 Use typed Idle::SetIdleHdl Link 
Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
 2015-05-05 12:05:38 +02:00
Stephan Bergmann
8cafd08278 Use typed Timer::SetTimeoutHdl Link 
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
 2015-05-05 10:21:54 +02:00
Noel Grandin
e95b073790 loplugin:staticmethods 
Change-Id: I60678dfd1bd0d2e4754dbbe6ba053e90d5870780
 2015-05-05 09:30:40 +02:00
Michael Meeks
393c51cee8 Audit LoseFocus - forms, reportdesign, sc, starmath, svtools. 
Change-Id: If7068e59c88e8c3c3bafc70f64899a26d739e331
 2015-05-02 00:50:06 +02:00
Stephan Bergmann
3ead3ad52f Gradually typed Link 
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior.  That way, individual uses of the
Link class can be updated over time.

All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).

(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)

Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
 2015-04-30 10:20:00 +02:00
Tor Lillqvist
d1ca0f4ed0 Bin some pointless comments and reduce some vertical whitespace 
Bin pointless '// predeclarations' or '// forward declarations' comments.  If
a programmer doesn't know what a forward declaration is, well, why read C++
source code?

Also bin some pointless '// end of namespace foo' comments after namespace
blocks just a handful of lines long, and some superfluous vertical whitespace.

Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
 2015-04-30 06:14:12 +03:00
Stephan Bergmann
e6c08b6b30 Remove unnecessary STATIC_LINK macro 
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
 2015-04-29 18:29:59 +02:00
Tomaž Vajngerl
f50fd9692e mass rewrite Paint(Rect&) to Paint(RenderContext&, Rect&) 
Change-Id: Ia1667246064d11827dbd149def15e5bf08b119b8
 2015-04-29 09:19:47 +09:00
Michael Meeks
e8b97a52c9 Merge remote-tracking branch 'origin/feature/vclptr' 
Resolve several thousand lines of conflicts.

Conflicts:
	accessibility/source/extended/accessiblelistbox.cxx
	accessibility/source/standard/vclxaccessiblecombobox.cxx
	accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
	accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
	accessibility/source/standard/vclxaccessiblelistbox.cxx
	accessibility/source/standard/vclxaccessibletextfield.cxx
	basctl/source/basicide/basidesh.cxx
	cui/source/inc/chardlg.hxx
	cui/source/tabpages/tpbitmap.cxx
	dbaccess/source/ui/dlg/UserAdmin.cxx
	dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
	extensions/source/propctrlr/propertyeditor.hxx
	extensions/source/scanner/sanedlg.cxx
	filter/source/pdf/impdialog.cxx
	include/sfx2/mgetempl.hxx
	include/sfx2/sidebar/SidebarToolBox.hxx
	include/sfx2/viewsh.hxx
	include/svtools/brwbox.hxx
	include/svtools/filectrl.hxx
	include/svtools/scrwin.hxx
	include/svx/dlgctrl.hxx
	include/svx/sidebar/Popup.hxx
	include/svx/sidebar/PopupContainer.hxx
	include/svx/sidebar/PopupControl.hxx
	include/svx/sidebar/SidebarDialControl.hxx
	include/svx/sidebar/ValueSetWithTextControl.hxx
	sc/source/ui/condformat/condformatdlgentry.cxx
	sc/source/ui/navipi/navipi.cxx
	sc/source/ui/sidebar/CellBorderStyleControl.hxx
	sd/source/ui/animations/CustomAnimationDialog.cxx
	sd/source/ui/inc/DrawViewShell.hxx
	sd/source/ui/inc/Ruler.hxx
	sd/source/ui/inc/SlideSorter.hxx
	sd/source/ui/inc/ViewTabBar.hxx
	sd/source/ui/inc/Window.hxx
	sd/source/ui/inc/morphdlg.hxx
	sd/source/ui/inc/sdpreslt.hxx
	sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
	sd/source/ui/sidebar/LayoutMenu.hxx
	sd/source/ui/sidebar/MasterPagesSelector.hxx
	sd/source/ui/sidebar/NavigatorWrapper.hxx
	sd/source/ui/sidebar/PanelBase.hxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
	sd/source/ui/slideshow/showwindow.hxx
	sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
	sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
	sd/source/ui/view/ViewShellBase.cxx
	sd/source/ui/view/drviewsa.cxx
	sfx2/source/appl/fileobj.hxx
	sfx2/source/appl/opengrf.cxx
	sfx2/source/control/thumbnailviewacc.hxx
	sfx2/source/dialog/securitypage.cxx
	sfx2/source/dialog/templdlg.cxx
	sfx2/source/doc/docinsert.cxx
	sfx2/source/doc/guisaveas.cxx
	sfx2/source/inc/alienwarn.hxx
	sfx2/source/sidebar/Deck.cxx
	sfx2/source/sidebar/Deck.hxx
	sfx2/source/sidebar/DeckTitleBar.cxx
	sfx2/source/sidebar/DeckTitleBar.hxx
	sfx2/source/sidebar/MenuButton.cxx
	sfx2/source/sidebar/MenuButton.hxx
	sfx2/source/sidebar/Panel.cxx
	sfx2/source/sidebar/Panel.hxx
	sfx2/source/sidebar/PanelTitleBar.hxx
	sfx2/source/sidebar/SidebarDockingWindow.hxx
	sfx2/source/sidebar/SidebarToolBox.cxx
	sfx2/source/sidebar/TabBar.hxx
	sfx2/source/sidebar/TabItem.cxx
	sfx2/source/sidebar/TabItem.hxx
	sfx2/source/sidebar/TitleBar.hxx
	sfx2/source/toolbox/imgmgr.cxx
	starmath/inc/edit.hxx
	starmath/inc/smmod.hxx
	starmath/qa/cppunit/test_starmath.cxx
	starmath/source/edit.cxx
	starmath/source/smmod.cxx
	svtools/source/brwbox/brwbox1.cxx
	svtools/source/brwbox/datwin.hxx
	svtools/source/contnr/fileview.cxx
	svtools/source/contnr/simptabl.cxx
	svtools/source/control/filectrl.cxx
	svtools/source/control/valueimp.hxx
	svx/inc/GalleryControl.hxx
	svx/source/dialog/dlgctrl.cxx
	svx/source/dialog/swframeexample.cxx
	svx/source/fmcomp/fmgridif.cxx
	svx/source/gallery2/GalleryControl.cxx
	svx/source/sidebar/EmptyPanel.hxx
	svx/source/sidebar/area/AreaPropertyPanel.hxx
	svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
	svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
	svx/source/sidebar/insert/InsertPropertyPanel.cxx
	svx/source/sidebar/insert/InsertPropertyPanel.hxx
	svx/source/sidebar/line/LinePropertyPanel.hxx
	svx/source/sidebar/line/LineWidthControl.cxx
	svx/source/sidebar/line/LineWidthControl.hxx
	svx/source/sidebar/line/LineWidthValueSet.hxx
	svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
	svx/source/sidebar/possize/SidebarDialControl.cxx
	svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
	svx/source/sidebar/text/TextPropertyPanel.hxx
	svx/source/sidebar/tools/PopupContainer.cxx
	svx/source/sidebar/tools/PopupControl.cxx
	svx/source/sidebar/tools/ValueSetWithTextControl.cxx
	svx/source/svdraw/svdfmtf.hxx
	svx/source/svdraw/svdibrow.cxx
	svx/source/tbxctrls/colrctrl.cxx
	svx/source/tbxctrls/tbcontrl.cxx
	sw/source/ui/dbui/mmaddressblockpage.cxx
	sw/source/ui/dialog/uiregionsw.cxx
	sw/source/ui/index/cnttab.cxx
	sw/source/uibase/inc/drpcps.hxx
	sw/source/uibase/sidebar/PageColumnControl.hxx
	sw/source/uibase/sidebar/PageMarginControl.hxx
	sw/source/uibase/sidebar/PageOrientationControl.hxx
	sw/source/uibase/sidebar/PagePropertyPanel.hxx
	sw/source/uibase/sidebar/PageSizeControl.hxx
	sw/source/uibase/uiview/view2.cxx
	sw/source/uibase/utlui/navipi.cxx
	vcl/inc/svdata.hxx
	vcl/source/control/combobox.cxx
	vcl/source/control/lstbox.cxx
	vcl/source/window/dockwin.cxx
	vcl/source/window/winproc.cxx

Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
 2015-04-28 15:08:48 +01:00
Stephan Bergmann
e19cd844be Rephrase comparisons between bool and sal_Bool 
...to cater for forthcoming loplugin:implicitboolconversion improvements

Change-Id: I801b6b73648715448198d582a087cc834f6e20c8
 2015-04-28 10:21:01 +02:00
Stephan Bergmann
5db2f661ce More loplugin:simplifybool 
Change-Id: I8996d0afb3669046040a4dfebc9c2c6c07fc7644
 2015-04-27 15:30:56 +02:00