mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
406,095 Commits 1 Branch 0 Tags
Commit Graph

2738 Commits

Author SHA1 Message Date
Miklos Vajna
73076f5e9a forms: use constructor feature for OFormsCollection 
Change-Id: Ifdc031480617ec4d0a50ae5b6cd6a2c838ae076a
 2015-02-09 08:09:25 +01:00
Stephan Bergmann
73e117d19a loplugin:deletedspecial 
Change-Id: Ic3b744fe3eb3a07d7f5a7feeaf43cde2ec2b3241
 2015-02-07 12:35:59 +01:00
Caolán McNamara
76e372ccd9 coverity#704645 Dereference after null check 
Change-Id: Id6930c8e87f27051520e10e1277d769d0b380374
 2015-01-30 21:15:31 +00:00
Caolán McNamara
05abd8b205 chisel off some more unused code 
Change-Id: I62cafc8e10e9c9dab3fde1785b826ba8ff68569f
 2015-01-30 12:44:36 +00:00
Noel Grandin
f61dbc3029 followup code removal after changing virtual methods to non-virtual 
This cleanups up indentation and removes dead classes.

This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"

Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
 2015-01-26 08:42:29 +02:00
Noel Grandin
b44cbb26ef new loplugin: change virtual methods to non-virtual 
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
 2015-01-26 08:42:28 +02:00
Stephan Bergmann
3ad6e328a7 Some more loplugin:cstylecast: forms 
Change-Id: I39325fccdadcc57df32fe5821eef0d8477018b59
 2015-01-20 09:06:47 +01:00
Stephan Bergmann
4efa9604cf Revert "ListBox: refuse to give values before we are loaded" 
This reverts commit 1cc29a04adb721205655091854f5ea828bb8eb11, as it caused
JunitTest_forms_unoapi trigger the

  assert( m_nConvertedBoundValuesType == getValueType())

at forms/source/component/ListBox.cxx:1189.
 2015-01-14 08:35:33 +01:00
Noel Grandin
c32a5a3b8e simplify Date/Time/DateTime conversion code 
add constructors to Date/DateTime/Time,
that take the css::util counterparts,
to simplify code converting between these type

Change-Id: I4b03da02c63f65b6ec18cb4d6ecc3859bdef1ff7
Reviewed-on: https://gerrit.libreoffice.org/13855
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2015-01-13 15:24:04 +00:00
Stephan Bergmann
7ca657e5ee css.form.component.{CheckBox,RadioButton} DefaultState property values 
...must be in the range 0--2; avoid setting bad values from generic qadevOOo
property set tests, and throw an IllegalArgumentException if bad values do
get set.

Change-Id: Ia4a97d0fac326b3ca2ce254946dc4d418e9dd5a7
 2015-01-13 15:17:18 +01:00
Lionel Elie Mamane
0331fa6a90 ListBox with value list: consider first empty value as NULL 
Change-Id: I15c040b481b7f03720d0227ba5d2fcd2ccc78386
 2015-01-13 14:59:04 +01:00
Lionel Elie Mamane
1cc29a04ad ListBox: refuse to give values before we are loaded 
If we are not loaded,
we don't know our field type,
so cannot give values with the right type

Change-Id: I372b77647ec8ff7428b67cca72fdd89e5e147a32
 2015-01-13 14:59:03 +01:00
Lionel Elie Mamane
5cd4ab7f5c janitorial 
Change-Id: If0fcad97538556ef7be5fe5f8405ca171696502d
 2015-01-13 14:59:03 +01:00
Michael Stahl
2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load 
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
 2015-01-09 00:00:47 +01:00
Noel Grandin
45ec1d9b56 brute-force find-and-remove of unused #define constants. 
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
 2015-01-08 10:39:36 +02:00
Noel Grandin
7f8f277b94 fdo#84938: convert STREAM_ #defines to 'enum class' 
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
 2015-01-07 11:20:44 +02:00
Noel Grandin
54942f0d09 spelling: attachement -> attachment 
Change-Id: I1bb1ad04adec864b594d96711f85b8fcdc1d1ef2
 2015-01-05 12:57:18 +02:00
Caolán McNamara
fd1372ba8b boost::unordered_map->std::unordered_map 
you can get debug stl this way

Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
 2015-01-02 16:14:36 +00:00
Stephan Bergmann
9e3ced1956 forms: Use appropriate OUString functions on string constants 
Change-Id: I1bcd815663c29025da6b3ce50bdf767eef74fe94
 2014-12-18 14:12:26 +01:00
Michael Weghorn
afb5143639 fdo#39440 reduce scope of local variables 
This addresses some cppcheck warnings.

Change-Id: I1d037e87c69b1a7de019f1abf1f729bf7e28d762
Reviewed-on: https://gerrit.libreoffice.org/13494
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-17 07:31:17 +00:00
Stephan Bergmann
0c1b8516cb forms: Use appropriate OUString functions on string constants 
Change-Id: I196e847e2f63d1bac6ed0f520cba67508aec1a5d
 2014-12-15 10:12:09 +01:00
Tobias Madl
ea6399b837 changed timers to idles 
Change-Id: Ic0d7730f7880dfe2e83c84e773b8cc420249b269
 2014-12-09 12:34:57 +00:00
Tobias Madl
14596452e7 fdo#84938: replace EVENT_ constants with enum 
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f
Reviewed-on: https://gerrit.libreoffice.org/13134
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-01 07:43:31 +00:00
Matúš Kukan
09186fceb0 unotools: Internalize ucblockbytes.hxx header 
Change-Id: I1a9b795eda832673a83a426c8bf10d5bb9c28581
 2014-11-24 23:14:54 +01:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use 
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
 2014-11-18 18:51:49 +01:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use 
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
 2014-11-17 11:06:53 +01:00
Caolán McNamara
275eb9c78e coverity#706540 Uncaught exception 
Change-Id: I9dabd74824ec7cffe5371ed8be202ad27fecc80d
 2014-11-14 12:02:47 +00:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method 
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-11-14 09:20:38 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Stephan Bergmann
2a68ed19e8 Revert "Some SvxFontHeightItem clean-up" 
This reverts commit d5f93eb47ec4c27e93ad908b0199790c702491a0,
SvxFontHeightItem::SetProp was used to override "dummy" 100% nProp/ePropUnit
values that did not match the computed nHeight value with nProp/ePropUnit values
that are supposed to match the computed nHeight value.  Yuck.

Change-Id: Ic12e824054b3c5da7aca766b9b3eb076d1837d9a
 2014-11-11 19:51:22 +01:00
Stephan Bergmann
d5f93eb47e Some SvxFontHeightItem clean-up 
...and operator= shall probably copy rSize.ePropUnit...

Change-Id: I112c02b3a3b2ce23f3d03f03881136e05be29017
 2014-11-11 18:39:20 +01:00
Zolnai Tamás
5771bde234 Try to fix ambiguity error 
Change-Id: I93cf7497e52d065d00f762f61f79a4e8f8609bfc
 2014-11-07 16:54:58 +01:00
Stephan Bergmann
fc0d57b7af Revert "use the new OUString::fromUtf8 method" 
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
 2014-11-06 17:24:13 +01:00
Noel Grandin
05050cdb23 use the new OUString::fromUtf8 method 
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
 2014-11-06 13:51:10 +02:00
Caolán McNamara
12bcfec04f markup with event type not checker type 
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
 2014-11-05 14:58:00 +00:00
Noel Grandin
5f15cc01b3 new loplugin: use more efficient find() methods 
(Original idea from Kendy)
Look for code that is calling std::find on a sorted container
(set/map/vector) and warn about it - the code should be using
the find method on the container itself, since that is considerably faster.

Change-Id: Ib74e5d3faa836eeb0df16a736d202696626bdfd2
 2014-11-05 15:59:23 +02:00
Noel Grandin
3c58f07680 fdo#84938: replace TOOLBOXITEM_ constants with enum 
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6
Reviewed-on: https://gerrit.libreoffice.org/12258
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-05 06:45:07 +00:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals 
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
 2014-11-05 08:44:19 +02:00
David Tardon
cd6e6712a1 coverity#706543 uncaught exception 
Change-Id: I65932932712dad87f8e21dcd09f477744cc33763
 2014-11-04 19:52:51 +01:00
Andrea Gelmini
c70f1545e2 Removed duplicated includes 
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2014-10-31 16:18:30 +00:00
Caolán McNamara
8fbbb94a39 coverity#706537 Uncaught exception 
Change-Id: I687948ef04e4ffdce51a7ac20854d6ebe96f1f25
 2014-10-27 14:34:22 +00:00
Jan Holesovsky
31af61ea09 Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip" 
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.

Conflicts:

	cui/source/tabpages/transfrm.cxx
	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx
	tools/source/generic/rational.cxx

Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
 2014-10-23 18:34:39 +02:00
Jan Holesovsky
858c2a2977 Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit" 
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.

Conflicts:

	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx

Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
 2014-10-23 18:34:34 +02:00
Noel Grandin
e2548315bf loplugin: cstylecast 
Change-Id: Iad39bce8e7562821bc8fbf8156ea56aedc19c7d6
 2014-10-23 12:36:15 +02:00
Noel Grandin
182fc4f184 fdo#84938: replace WINDOW_BORDER constants with enum 
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
 2014-10-21 09:06:40 +02:00
Caolán McNamara
ae218f4895 tweak CaughtException 
Change-Id: If5aac87876b139bfb394ec124136de131c3518ae
 2014-10-20 16:17:58 +01:00
Stephan Bergmann
66da64c748 Missing include 
...and only use getCaughtException as first statement in catch block.

Change-Id: Idcac073896b84fd2671b52b2315f454651dbf910
 2014-10-20 15:42:36 +02:00
Caolán McNamara
9e8a88b6da coverity#706540 Uncaught exception 
Change-Id: I175050b5ab66f4eeaa658f0aab1739b175d38d51
 2014-10-20 10:57:19 +01:00
Caolán McNamara
4fd65ac329 coverity#706538 Uncaught exception 
Change-Id: If23396c545e7add653fa9e5ac6e544aaa794120d
 2014-10-20 10:57:18 +01:00
Noel Grandin
67c9d05451 fdo#84938: replace TIB_ constants with enum 
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84
Reviewed-on: https://gerrit.libreoffice.org/12023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-20 07:16:46 +00:00