mir/lxc
2
0
Fork 0
mirror of git://github.com/lxc/lxc synced 2025-08-31 11:09:33 +00:00
Code Issues Releases Wiki Activity

bdev_create: don't default to btrfs if possible

Browse Source 
Ideally it would be great to default to a btrfs subvolume for each new
container created.  However, this is not as we previously thought
without consequence.  'rsync --one-file-system' will not descend into
btrfs subvolumes.  This means that 'lxc-create -B _unset' will cause
different behavior for rsync -vax /var/lib/lxc based on whether that
fs is btrfs or not.

So don't do that.  If -B is not specified, use -B dir.

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
This commit is contained in:
Serge Hallyn
2013-08-15 12:22:26 -05:00
parent d007f8ab3d
commit d3060bd055
1 changed files with 1 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/lxc/bdev.c
View File

@@ -1993,25 +1993,9 @@ struct bdev *bdev_create(const char *dest, const char *type,
{
struct bdev *bdev;
if (!type) {
char *p, *p1;
if (!type)
type = "dir";
/*
* $lxcpath/$lxcname/rootfs doesn't yet exist. Check
* whether $lxcpath/$lxcname is btrfs. If so, specify
* btrfs backing store for the container.
*/
p = strdupa(dest);
p1 = rindex(p, '/');
if (p1) {
*p1 = '\0';
if (is_btrfs_fs(p))
type = "btrfs";
}
}
bdev = bdev_get(type);
if (!bdev) {
ERROR("Unknown fs type: %s\n", type);