mir/openvswitch
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-10-25 15:07:05 +00:00
Code Issues Releases Wiki Activity

lacp: Fix misleading prototype for lacp_configure().

Browse Source 
Only the first 6 bytes (ETH_ADDR_LEN) of the 'sys_id' argument are used,
but the prototype declared it as an array of 8 bytes.  This has no effect
on the generated code--the declared size of an array parameter is
irrelevant--but it is misleading.

Also, add 'const' since the array is not modified.
This commit is contained in:
Ben Pfaff
2011-03-21 13:15:31 -07:00
parent 3e519d8e84
commit 02c9ed77e3
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/lacp.c
View File

@@ -128,7 +128,7 @@ lacp_destroy(struct lacp *lacp)
* 'active' parameters. */
void
lacp_configure(struct lacp *lacp, const char *name,
uint8_t sys_id[ETH_ADDR_LEN], uint16_t sys_priority,
const uint8_t sys_id[ETH_ADDR_LEN], uint16_t sys_priority,
bool active, bool fast)
{
if (!lacp->name || strcmp(name, lacp->name)) {

4
lib/lacp.h
View File

@@ -19,6 +19,7 @@
#include <stdbool.h>
#include <stdint.h>
#include "packets.h"
struct ds;
struct lacp;
@@ -31,7 +32,8 @@ typedef void lacp_send_pdu(void *slave, const struct lacp_pdu *);
void lacp_init(void);
struct lacp *lacp_create(void);
void lacp_destroy(struct lacp *);
void lacp_configure(struct lacp *, const char *name, uint8_t sys_id[8],
void lacp_configure(struct lacp *, const char *name,
const uint8_t sys_id[ETH_ADDR_LEN],
uint16_t sys_priority, bool active, bool fast);
void lacp_process_pdu(struct lacp *, const void *slave,
const struct lacp_pdu *);