mir/openvswitch
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-10-17 14:28:02 +00:00
Code Issues Releases Wiki Activity

xml2nroff: Read whole file instead of line by line.

Browse Source 
The previous code processed the input file line by line, but I think
it looks a little more straight forward to just process the whole file
at once.

This patch also explicitly closes the file after reading its contents.

Signed-off-by: Russell Bryant <russell@ovn.org>
Acked-by: Justin Pettit <jpettit@ovn.org>
This commit is contained in:
Russell Bryant
2015-12-10 14:22:58 -05:00
parent 138bc37a3a
commit 069390bb36
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
build-aux/xml2nroff
View File

@@ -41,13 +41,11 @@ The following options are also available:
def manpage_to_nroff(xml_file, subst, version=None):
f = open(xml_file)
content = []
for line in f:
for k, v in subst.iteritems():
line = line.replace(k, v)
content += [line]
doc = xml.dom.minidom.parseString(''.join(content)).documentElement
with open(xml_file) as f:
content = f.read()
for k, v in subst.iteritems():
content = content.replace(k, v)
doc = xml.dom.minidom.parseString(content).documentElement
if version is None:
version = "UNKNOWN"