2020-01-09 12:48:30 -08:00
|
|
|
/* Copyright (c) 2009, 2010, 2017, 2019 Nicira, Inc.
|
2009-11-04 15:11:44 -08:00
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at:
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#ifndef OVSDB_TRANSACTION_H
|
|
|
|
#define OVSDB_TRANSACTION_H 1
|
|
|
|
|
|
|
|
#include <stdbool.h>
|
2024-06-19 08:54:53 -04:00
|
|
|
#include <stdint.h>
|
2009-11-04 15:11:44 -08:00
|
|
|
#include "compiler.h"
|
|
|
|
|
2024-06-19 08:54:53 -04:00
|
|
|
struct hmap;
|
2009-11-13 13:37:55 -08:00
|
|
|
struct json;
|
2009-11-04 15:11:44 -08:00
|
|
|
struct ovsdb;
|
2024-01-09 20:54:03 +01:00
|
|
|
struct ovsdb_row;
|
2023-03-27 21:42:57 +02:00
|
|
|
struct ovsdb_schema;
|
2009-11-04 15:11:44 -08:00
|
|
|
struct ovsdb_table;
|
|
|
|
struct uuid;
|
|
|
|
|
|
|
|
struct ovsdb_txn *ovsdb_txn_create(struct ovsdb *);
|
2019-02-28 09:15:17 -08:00
|
|
|
void ovsdb_txn_set_txnid(const struct uuid *, struct ovsdb_txn *);
|
2019-02-28 09:15:18 -08:00
|
|
|
const struct uuid *ovsdb_txn_get_txnid(const struct ovsdb_txn *);
|
2009-11-04 15:11:44 -08:00
|
|
|
void ovsdb_txn_abort(struct ovsdb_txn *);
|
2017-12-28 13:21:11 -08:00
|
|
|
|
ovsdb raft: Precheck prereq before proposing commit.
In current OVSDB Raft design, when there are multiple transactions
pending, either from same server node or different nodes in the
cluster, only the first one can be successful at once, and following
ones will fail at the prerequisite check on leader node, because
the first one will update the expected prerequisite eid on leader
node, and the prerequisite used for proposing a commit has to be
committed eid, so it is not possible for a node to use the latest
prerequisite expected by the leader to propose a commit until the
lastest transaction is committed by the leader and updated the
committed_index on the node.
Current implementation proposes the commit as soon as the transaction
is requested by the client, which results in continously retry which
causes high CPU load and waste.
Particularly, even if all clients are using leader_only to connect to
only the leader, the prereq check failure still happens a lot when
a batch of transactions are pending on the leader node - the leader
node proposes a batch of commits using the same committed eid as
prerequisite and it updates the expected prereq as soon as the first
one is in progress, but it needs time to append to followers and wait
until majority replies to update the committed_index, which results in
continously useless retries of the following transactions proposed by
the leader itself.
This patch doesn't change the design but simplely pre-checks if current
eid is same as prereq, before proposing the commit, to avoid waste of
CPU cycles, for both leader and followers. When clients use leader_only
mode, this patch completely eliminates the prereq check failures.
In scale test of OVN with 1k HVs and creating and binding 10k lports,
the patch resulted in 90% CPU cost reduction on leader and >80% CPU cost
reduction on followers. (The test was with leader election base time
set to 10000ms, because otherwise the test couldn't complete because
of the frequent leader re-election.)
This is just one of the related performance problems of the prereq
checking mechanism dicussed at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2019-February/048243.html
Signed-off-by: Han Zhou <hzhou8@ebay.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
2019-03-01 10:56:37 -08:00
|
|
|
bool ovsdb_txn_precheck_prereq(const struct ovsdb *db);
|
2017-12-31 21:15:58 -08:00
|
|
|
struct ovsdb_error *ovsdb_txn_replay_commit(struct ovsdb_txn *)
|
2017-12-28 13:21:11 -08:00
|
|
|
OVS_WARN_UNUSED_RESULT;
|
2017-12-31 21:15:58 -08:00
|
|
|
struct ovsdb_txn_progress *ovsdb_txn_propose_commit(struct ovsdb_txn *,
|
|
|
|
bool durable)
|
2017-12-28 13:21:11 -08:00
|
|
|
OVS_WARN_UNUSED_RESULT;
|
2017-12-31 21:15:58 -08:00
|
|
|
struct ovsdb_error *ovsdb_txn_propose_commit_block(struct ovsdb_txn *,
|
|
|
|
bool durable)
|
2014-12-15 14:10:38 +01:00
|
|
|
OVS_WARN_UNUSED_RESULT;
|
2017-12-31 21:15:58 -08:00
|
|
|
void ovsdb_txn_complete(struct ovsdb_txn *);
|
|
|
|
|
|
|
|
struct ovsdb_txn_progress *ovsdb_txn_propose_schema_change(
|
2023-03-27 21:43:00 +02:00
|
|
|
struct ovsdb *, const struct ovsdb_schema *,
|
|
|
|
const struct json *data, struct uuid *txnid);
|
2017-12-31 21:15:58 -08:00
|
|
|
|
|
|
|
bool ovsdb_txn_progress_is_complete(const struct ovsdb_txn_progress *);
|
|
|
|
const struct ovsdb_error *ovsdb_txn_progress_get_error(
|
|
|
|
const struct ovsdb_txn_progress *);
|
|
|
|
void ovsdb_txn_progress_destroy(struct ovsdb_txn_progress *);
|
2009-11-04 15:11:44 -08:00
|
|
|
|
2024-01-09 20:54:03 +01:00
|
|
|
void ovsdb_txn_row_modify(struct ovsdb_txn *, const struct ovsdb_row *,
|
|
|
|
struct ovsdb_row **row_new,
|
|
|
|
struct ovsdb_row **row_diff);
|
2009-11-04 15:11:44 -08:00
|
|
|
void ovsdb_txn_row_insert(struct ovsdb_txn *, struct ovsdb_row *);
|
|
|
|
void ovsdb_txn_row_delete(struct ovsdb_txn *, const struct ovsdb_row *);
|
|
|
|
|
2020-01-09 12:48:30 -08:00
|
|
|
bool ovsdb_txn_may_create_row(const struct ovsdb_table *,
|
|
|
|
const struct uuid *row_uuid);
|
|
|
|
|
2009-11-13 13:37:55 -08:00
|
|
|
typedef bool ovsdb_txn_row_cb_func(const struct ovsdb_row *old,
|
|
|
|
const struct ovsdb_row *new,
|
2010-03-11 17:14:31 -08:00
|
|
|
const unsigned long int *changed,
|
2009-11-13 13:37:55 -08:00
|
|
|
void *aux);
|
|
|
|
void ovsdb_txn_for_each_change(const struct ovsdb_txn *,
|
|
|
|
ovsdb_txn_row_cb_func *, void *aux);
|
2024-06-19 08:54:53 -04:00
|
|
|
struct ovsdb_row *ovsdb_index_search(struct hmap *index,
|
|
|
|
struct ovsdb_row *, size_t i,
|
|
|
|
uint32_t hash);
|
2009-11-13 13:37:55 -08:00
|
|
|
|
2009-12-16 13:30:53 -08:00
|
|
|
void ovsdb_txn_add_comment(struct ovsdb_txn *, const char *);
|
|
|
|
const char *ovsdb_txn_get_comment(const struct ovsdb_txn *);
|
2019-02-28 09:15:17 -08:00
|
|
|
void ovsdb_txn_history_run(struct ovsdb *);
|
ovsdb monitor: Fix crash when using non-zero last-id with standalone DB.
When a client uses monitor-cond-since with a non-zero last-id but the
server is not in cluster mode for the DB being monitored, it leads to
segmentation fault because the txn_history list is not initialized in
this case.
Program terminated with signal SIGSEGV, Segmentation fault.
1536 struct ovsdb_txn *txn = h_node->txn;
(gdb) bt
0 ovsdb_monitor_get_changes_after (txn_uuid=txn_uuid@entry=0x7ffe8605b7e0, dbmon=0x17c1b40, p_mcs=p_mcs@entry=0x17c4900) at ovsdb/monitor.c:1536
1 0x000000000040da2d in ovsdb_jsonrpc_monitor_create (request_id=0x1804630, version=<optimized out>, params=0x17ad330, db=0x18015b0, s=<optimized out>) at ovsdb/jsonrpc-server.c:1469
2 ovsdb_jsonrpc_session_got_request (request=0x17ad520, s=<optimized out>) at ovsdb/jsonrpc-server.c:1002
3 ovsdb_jsonrpc_session_run (s=<optimized out>) at ovsdb/jsonrpc-server.c:556
...
Although it doesn't happen in normal use cases, no one can prevent a
client to send this on purpose or in a corner case when a client firstly
connected to a clustered DB but later the server restarted with a
non-clustered DB.
This patch fixes it by always initialize the txn_history list to avoid
the undefined behavior in this case. It adds a test case to cover it, too.
Fixes: 695e815 ("ovsdb-server: Transaction history tracking.")
Reported-by: Aliasgar Ginwala <aginwala@ebay.com>
Signed-off-by: Han Zhou <hzhou8@ebay.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
2019-08-19 16:30:35 -07:00
|
|
|
void ovsdb_txn_history_init(struct ovsdb *, bool need_txn_history);
|
2019-02-28 09:15:17 -08:00
|
|
|
void ovsdb_txn_history_destroy(struct ovsdb *);
|
2009-12-16 13:30:53 -08:00
|
|
|
|
2009-11-04 15:11:44 -08:00
|
|
|
#endif /* ovsdb/transaction.h */
|