mirror of
https://github.com/openvswitch/ovs
synced 2025-08-22 01:51:26 +00:00
0add983b38
Currently all OVSDB database queries except for UUID lookups all result in linear lookups over the entire table, even if an index is present. This patch modifies ovsdb_query() to attempt an index lookup first, if possible. If no matching indexes are present then a linear index is still conducted. To test this, I set up an ovsdb database with a variable number of rows and timed the average of how long ovsdb-client took to query a single row. The first two tests involved a linear scan that didn't match any rows, so there was no overhead associated with sending or encoding output. The post-patch linear scan was a worst case scenario where the table did have an appropriate index but the conditions made its usage impossible. The indexed lookup test was for a matching row, which did also include overhead associated with a match. The results are included in the table below. Rows | 100k | 200k | 300k | 400k | 500k -----------------------+------+------+------+------+----- Pre-patch linear scan | 9ms | 24ms | 37ms | 49ms | 61ms Post-patch linear scan | 9ms | 24ms | 38ms | 49ms | 61ms Indexed lookup | 3ms | 3ms | 3ms | 3ms | 3ms I also tested the performance of ovsdb_query() by wrapping it in a loop and measuring the time it took to perform 1000 linear scans on 1, 10, 100k, and 200k rows. This test showed that the new index checking code did not slow down worst case lookups to a statistically detectable degree. Reported-at: https://issues.redhat.com/browse/FDP-590 Signed-off-by: Mike Pattrick <mkp@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
82 lines
3.2 KiB
C
82 lines
3.2 KiB
C
/* Copyright (c) 2009, 2010, 2017, 2019 Nicira, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#ifndef OVSDB_TRANSACTION_H
|
|
#define OVSDB_TRANSACTION_H 1
|
|
|
|
#include <stdbool.h>
|
|
#include <stdint.h>
|
|
#include "compiler.h"
|
|
|
|
struct hmap;
|
|
struct json;
|
|
struct ovsdb;
|
|
struct ovsdb_row;
|
|
struct ovsdb_schema;
|
|
struct ovsdb_table;
|
|
struct uuid;
|
|
|
|
struct ovsdb_txn *ovsdb_txn_create(struct ovsdb *);
|
|
void ovsdb_txn_set_txnid(const struct uuid *, struct ovsdb_txn *);
|
|
const struct uuid *ovsdb_txn_get_txnid(const struct ovsdb_txn *);
|
|
void ovsdb_txn_abort(struct ovsdb_txn *);
|
|
|
|
bool ovsdb_txn_precheck_prereq(const struct ovsdb *db);
|
|
struct ovsdb_error *ovsdb_txn_replay_commit(struct ovsdb_txn *)
|
|
OVS_WARN_UNUSED_RESULT;
|
|
struct ovsdb_txn_progress *ovsdb_txn_propose_commit(struct ovsdb_txn *,
|
|
bool durable)
|
|
OVS_WARN_UNUSED_RESULT;
|
|
struct ovsdb_error *ovsdb_txn_propose_commit_block(struct ovsdb_txn *,
|
|
bool durable)
|
|
OVS_WARN_UNUSED_RESULT;
|
|
void ovsdb_txn_complete(struct ovsdb_txn *);
|
|
|
|
struct ovsdb_txn_progress *ovsdb_txn_propose_schema_change(
|
|
struct ovsdb *, const struct ovsdb_schema *,
|
|
const struct json *data, struct uuid *txnid);
|
|
|
|
bool ovsdb_txn_progress_is_complete(const struct ovsdb_txn_progress *);
|
|
const struct ovsdb_error *ovsdb_txn_progress_get_error(
|
|
const struct ovsdb_txn_progress *);
|
|
void ovsdb_txn_progress_destroy(struct ovsdb_txn_progress *);
|
|
|
|
void ovsdb_txn_row_modify(struct ovsdb_txn *, const struct ovsdb_row *,
|
|
struct ovsdb_row **row_new,
|
|
struct ovsdb_row **row_diff);
|
|
void ovsdb_txn_row_insert(struct ovsdb_txn *, struct ovsdb_row *);
|
|
void ovsdb_txn_row_delete(struct ovsdb_txn *, const struct ovsdb_row *);
|
|
|
|
bool ovsdb_txn_may_create_row(const struct ovsdb_table *,
|
|
const struct uuid *row_uuid);
|
|
|
|
typedef bool ovsdb_txn_row_cb_func(const struct ovsdb_row *old,
|
|
const struct ovsdb_row *new,
|
|
const unsigned long int *changed,
|
|
void *aux);
|
|
void ovsdb_txn_for_each_change(const struct ovsdb_txn *,
|
|
ovsdb_txn_row_cb_func *, void *aux);
|
|
struct ovsdb_row *ovsdb_index_search(struct hmap *index,
|
|
struct ovsdb_row *, size_t i,
|
|
uint32_t hash);
|
|
|
|
void ovsdb_txn_add_comment(struct ovsdb_txn *, const char *);
|
|
const char *ovsdb_txn_get_comment(const struct ovsdb_txn *);
|
|
void ovsdb_txn_history_run(struct ovsdb *);
|
|
void ovsdb_txn_history_init(struct ovsdb *, bool need_txn_history);
|
|
void ovsdb_txn_history_destroy(struct ovsdb *);
|
|
|
|
#endif /* ovsdb/transaction.h */
|