mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-22 18:07:40 +00:00
Code Issues Releases Wiki Activity
ovs/lib/ofp-errors.h

703 lines
22 KiB
C
Raw Normal View History

Automatically extract error types and codes for formatting.
2011-01-12 13:42:50 -08:00
/*
classifier: Add support for conjunctive matches. A "conjunctive match" allows higher-level matches in the flow table, such as set membership matches, without causing a cross-product explosion for multidimensional matches. Please refer to the documentation that this commit adds to ovs-ofctl(8) for a better explanation, including an example. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2015-01-11 13:25:24 -08:00
* Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015 Nicira, Inc.
Automatically extract error types and codes for formatting.
2011-01-12 13:42:50 -08:00
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at:
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#ifndef OFP_ERRORS_H
#define OFP_ERRORS_H 1
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
#include <stdbool.h>
#include <stddef.h>
Automatically extract error types and codes for formatting.
2011-01-12 13:42:50 -08:00
#include <stdint.h>
ofp-util: Make ofperr_encode_msg__() use correct Open Flow version Make ofperr_encode_msg__() use correct Open Flow version in the header of messages. Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-08-01 16:01:48 +09:00
#include "openflow/openflow.h"
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
struct ds;
ofp-msgs: New approach to encoding and decoding OpenFlow headers. OpenFlow headers are not as uniform as they could be, with size, alignment, and numbering changes from one version to another and across varieties (e.g. ordinary messages vs. "stats" messages). Until now the Open vSwitch internal APIs haven't done a good job of abstracting those differences in header formats. This commit changes that; from this commit forward very little code actually needs to understand the header format or numbering. Instead, it can just encode or decode, or pull or put, the header using a more abstract API using the ofpraw_, ofptype_, and other APIs in the new ofp-msgs module. Signed-off-by: Ben Pfaff <blp@nicira.com> Tested-by: Simon Horman <horms@verge.net.au> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-07-19 23:23:17 -07:00
struct ofpbuf;
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
/* Error codes.
*
* We embed system errno values and OpenFlow standard and vendor extension
* error codes into the positive range of "int":
*
* - Errno values are assumed to use the range 1 through 2**30 - 1.
*
* (C and POSIX say that errno values are positive. We assume that they
* are less than 2**29. They are actually less than 65536 on at least
* Linux, FreeBSD, OpenBSD, and Windows.)
*
* - OpenFlow standard and vendor extension error codes use the range
* starting at 2**30 (OFPERR_OFS).
*
* Zero and negative values are not used.
*/
#define OFPERR_OFS (1 << 30)
ofp-errors: Ignore text enclosed in square brackets Enhance to extract-ofp-errors to omit text enclosed in square brackets from error description. This allows some commentary other than the error description to be supplied in ofp-errors.h As suggested by Ben Pfaff <blp@nicira.com> Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added the large comment on enum ofperr.] Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-09-05 11:50:36 +09:00
/* OpenFlow error codes.
*
* The comments below are parsed by the extract-ofp-errors program at build
* time and used to determine the mapping between "enum ofperr" constants and
* error type/code values used in the OpenFlow protocol:
*
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
* - The first part of each comment specifies the vendor, OpenFlow versions,
* type, and sometimes a code for each protocol that supports the error:
*
* # The vendor is OF for standard OpenFlow error codes. Otherwise it
* is one of the *_VENDOR_ID codes defined in openflow-common.h.
*
* # The version can specify a specific OpenFlow version, a version
* range delimited by "-", or an open-ended range with "+".
*
* # Standard OpenFlow errors have both a type and a code. Extension
* errors generally have only a type, no code. There is one
* exception: Nicira extension (NX) errors for OpenFlow 1.0 and 1.1
* have both a type and a code. (This means that the version
* specification for NX errors may not include version 1.0 or 1.1 (or
* both) along with version 1.2 or later, because the requirements
* for those versions are different.)
ofp-errors: Ignore text enclosed in square brackets Enhance to extract-ofp-errors to omit text enclosed in square brackets from error description. This allows some commentary other than the error description to be supplied in ofp-errors.h As suggested by Ben Pfaff <blp@nicira.com> Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added the large comment on enum ofperr.] Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-09-05 11:50:36 +09:00
*
* - Additional text is a human-readable description of the meaning of each
* error, used to explain the error to the user. Any text enclosed in
* square brackets is omitted; this can be used to explain rationale for
* choice of error codes in the case where this is desirable. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
enum ofperr {
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
/* Expected duplications. */
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* Expected: 0x0,3,5 in OF1.1 means both OFPBIC_BAD_EXPERIMENTER and
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
* OFPBIC_BAD_EXP_TYPE. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
/* ## ------------------ ## */
/* ## OFPET_HELLO_FAILED ## */
/* ## ------------------ ## */
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(0,0). No compatible version. */
ofp-errors: Remove OFPERR_* values for error categories. The main use of OFPERR_* is to define specific errors, but OFPERR_* also existed for each possible category of error, to enable partial decoding of unknown specific errors within a known category. However, in practice, it was very easy to misuse the error categories as if they were particular errors. This commit removes the error category values, to make that error impossible. (If partial decoding of unknown specific errors turns out to have been a valuable feature, then we can reintroduce it some other way.) Signed-off-by: Jarno Rajahalme <jarno.rajahalme@nsn.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-11-30 14:32:12 -08:00
OFPERR_OFPHFC_INCOMPATIBLE = OFPERR_OFS,
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(0,1). Permissions error. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPHFC_EPERM,
/* ## ----------------- ## */
/* ## OFPET_BAD_REQUEST ## */
/* ## ----------------- ## */
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(1,0). ofp_header.version not supported. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBRC_BAD_VERSION,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(1,1). ofp_header.type not supported. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBRC_BAD_TYPE,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(1,2). ofp_stats_msg.type not supported. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBRC_BAD_STAT,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(1,3). Vendor not supported (in ofp_vendor_header or
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
* ofp_stats_msg). */
OFPERR_OFPBRC_BAD_VENDOR,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(1,4). Vendor subtype not supported. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBRC_BAD_SUBTYPE,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(1,5). Permissions error. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBRC_EPERM,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(1,6). Wrong request length for type. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBRC_BAD_LEN,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(1,7). Specified buffer has already been used. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBRC_BUFFER_EMPTY,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(1,8). Specified buffer does not exist. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBRC_BUFFER_UNKNOWN,
ofp-errors: Use OFPERR_OFPBRC_BAD_TABLE_ID * In the case of OpenFlow 1.1+ OFPERR_OFPBRC_BAD_TABLE_ID is defined in the specification and seems to be the most appropriate error to use when an unknown table id is encountered. * In the case of OpenFlow 1.0 no appropriate error message seems to exist. Perhaps because an invalid port is not possible? I'm unsure. In any case, make use of a non-standard error code (1,512). This was formerly known as OFPERR_NXBRC_BAD_TABLE_ID but has been rolled into OFPERR_OFPBRC_BAD_TABLE_ID to allow the latter to be used without concern for the prevailing Open Flow version. Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-09-05 11:50:38 +09:00
/* NX1.0(1,512), OF1.1+(1,9). Specified table-id invalid or does not exist.
* [ A non-standard error (1,512), formerly OFPERR_NXBRC_BAD_TABLE_ID,
ofp-errors: Fix typos in comment. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-02-12 21:12:06 -08:00
* is used for OpenFlow 1.0 as there seems to be no appropriate error
ofp-errors: Use OFPERR_OFPBRC_BAD_TABLE_ID * In the case of OpenFlow 1.1+ OFPERR_OFPBRC_BAD_TABLE_ID is defined in the specification and seems to be the most appropriate error to use when an unknown table id is encountered. * In the case of OpenFlow 1.0 no appropriate error message seems to exist. Perhaps because an invalid port is not possible? I'm unsure. In any case, make use of a non-standard error code (1,512). This was formerly known as OFPERR_NXBRC_BAD_TABLE_ID but has been rolled into OFPERR_OFPBRC_BAD_TABLE_ID to allow the latter to be used without concern for the prevailing Open Flow version. Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-09-05 11:50:38 +09:00
* code defined the specification. ] */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBRC_BAD_TABLE_ID,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
/* OF1.2+(1,10). Denied because controller is slave. */
OFPERR_OFPBRC_IS_SLAVE,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(1,514), OF1.2+(1,11). Invalid port. [ A non-standard error
* (1,514), formerly OFPERR_NXBRC_BAD_IN_PORT is used for OpenFlow 1.0 and
* 1.1 as there seems to be no appropriate error code defined the
* specifications. ] */
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
OFPERR_OFPBRC_BAD_PORT,
/* OF1.2+(1,12). Invalid packet in packet-out. */
OFPERR_OFPBRC_BAD_PACKET,
Initial OpenFlow 1.3 support Initial OpenFlow 1.3 support with new include/openflow/openflow-1.3.h. Most of the messages that differ from 1.2 are implemented. OFPT_SET_ASYNC is implemented via NX_SET_ASYNC_CONFIG, other new message types are yet to be implemented. Stats replies that add duration fields are implemented at encode/decode level only. Test cases for implemented features are included. Remaining FIXME:s should not cause runtime aborts. Make check comes out clean. Signed-off-by: Jarno Rajahalme <jarno.rajahalme@nsn.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-11-27 17:44:22 +02:00
/* OF1.3+(1,13). Multipart request overflowed the assigned buffer. */
OFPERR_OFPBRC_MULTIPART_BUFFER_OVERFLOW,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(1,256), NX1.2+(2). Invalid NXM flow match. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_NXBRC_NXM_INVALID,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(1,257), NX1.2+(3). The nxm_type, or nxm_type taken in
* combination with nxm_hasmask or nxm_length or both, is invalid or not
* implemented. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_NXBRC_NXM_BAD_TYPE,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(1,515), NX1.2+(4). Must-be-zero field had nonzero value. */
Add ability to direct "packet-in"s to particular controllers. Nicira's controllers are somewhat heterogeneous, so that particular "packet-in" messages should be directed to particular controllers. This new Nicira extension action allows designating a controller or controllers to receive the "packet-in" using a 16-bit integer ID. The new NXAST_CONTROLLER action also specifies the "reason" code to include in the "packet-in" message. This is particularly useful for simulating a "no-match" "packet-in" using a rule. Feature #8946. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-02-09 14:17:33 -08:00
OFPERR_NXBRC_MUST_BE_ZERO,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(1,516), NX1.2+(5). The reason in an ofp_port_status message
* is not valid. */
Abstract everything that uses ofp_phy_port, add OF1.1 support. Reviewed-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-02-15 16:33:04 -08:00
OFPERR_NXBRC_BAD_REASON,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(1,520), NX1.2+(9). The 'event' in an NXST_FLOW_MONITOR reply
* does not specify one of the NXFME_ABBREV, NXFME_ADD, NXFME_DELETE, or
Don't use error categories as if they were actually errors. The OFPERR_* naming scheme is confusing, because it mixes categories with specific errors. Categories can't be encoded for sending to controllers, so this is a problem. This commit fixes up the cases where categories were used as errors, replacing them by real errors types. Signed-off-by: Jarno Rajahalme <jarno.rajahalme@nsn.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-11-30 13:45:08 -08:00
* NXFME_MODIFY. */
OFPERR_NXBRC_FM_BAD_EVENT,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(1,521), NX1.2+(10). The error that occurred cannot be
* represented in this OpenFlow version. */
ofp-errors: Make every error encodable. Until now, some values could not be encoded to send over OpenFlow, for a few possible reasons. This meant that, when one of these situations came up, that a controller would not receive any notification that its request failed. This is not a good way to behave, so this commit changes the error encoder so that, if a particular error cannot be encoded, it will instead encode a fallback error code. This commit also slightly simplifies ofconn_send_error() because it no longer has to handle ofperr_encode_error() returning NULL. Reported-by: Jarno Rajahalme <jarno.rajahalme@nsn.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-11-30 16:22:52 -08:00
OFPERR_NXBRC_UNENCODABLE_ERROR,
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
/* ## ---------------- ## */
/* ## OFPET_BAD_ACTION ## */
/* ## ---------------- ## */
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(2,0). Unknown action type. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBAC_BAD_TYPE,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(2,1). Length problem in actions. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBAC_BAD_LEN,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(2,2). Unknown experimenter id specified. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBAC_BAD_VENDOR,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(2,3). Unknown action type for experimenter id. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBAC_BAD_VENDOR_TYPE,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(2,4). Problem validating output port. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBAC_BAD_OUT_PORT,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(2,5). Bad action argument. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBAC_BAD_ARGUMENT,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(2,6). Permissions error. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBAC_EPERM,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(2,7). Can't handle this many actions. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBAC_TOO_MANY,
ofp-errors: Rename "OF" to "OF1.0+", "NX" to "NX1.0+". This seems like a more reasonable way to do things given that we will soon need "OpenFlow 1.1 and later" and "OpenFlow 1.1 only" keywords. Signed-off-by: Ben Pfaff <blp@nicira.com> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:22:42 -07:00
/* OF1.0+(2,8). Problem validating output queue. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBAC_BAD_QUEUE,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(2,9). Invalid group id in forward action. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBAC_BAD_OUT_GROUP,
meta-flow: Use correct OF1.2+ errors for invalid fields in actions. OFPERR_OFPBAC_BAD_ARGUMENT is not as specific as the errors provided by OpenFlow 1.2 and later. Some of these errors needed Nicira extension numbers for use with OpenFlow 1.0 and 1.1, so this commit also adds those. Some of these errors had poor explanations likely to confuse users, so this commits improves them. Some of the errors had the wrong names, so this commit fixes them. Reported-by: Jean Tourrilhes <jt@hpl.hp.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jean Tourrilhes <jt@hpl.hp.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2013-08-23 11:11:03 -07:00
/* NX1.0(1,522), OF1.1+(2,10). Action can't apply for this match or a
* prerequisite for use of this field is unmet. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBAC_MATCH_INCONSISTENT,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(2,11). Action order is unsupported for the action list in an
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
* Apply-Actions instruction */
OFPERR_OFPBAC_UNSUPPORTED_ORDER,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(2,12). Actions uses an unsupported tag/encap. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBAC_BAD_TAG,
meta-flow: Use correct OF1.2+ errors for invalid fields in actions. OFPERR_OFPBAC_BAD_ARGUMENT is not as specific as the errors provided by OpenFlow 1.2 and later. Some of these errors needed Nicira extension numbers for use with OpenFlow 1.0 and 1.1, so this commit also adds those. Some of these errors had poor explanations likely to confuse users, so this commits improves them. Some of the errors had the wrong names, so this commit fixes them. Reported-by: Jean Tourrilhes <jt@hpl.hp.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jean Tourrilhes <jt@hpl.hp.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2013-08-23 11:11:03 -07:00
/* NX1.0-1.1(1,523), OF1.2+(2,13). Action uses unknown or unsupported OXM
* or NXM field. */
OFPERR_OFPBAC_BAD_SET_TYPE,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
meta-flow: Use correct OF1.2+ errors for invalid fields in actions. OFPERR_OFPBAC_BAD_ARGUMENT is not as specific as the errors provided by OpenFlow 1.2 and later. Some of these errors needed Nicira extension numbers for use with OpenFlow 1.0 and 1.1, so this commit also adds those. Some of these errors had poor explanations likely to confuse users, so this commits improves them. Some of the errors had the wrong names, so this commit fixes them. Reported-by: Jean Tourrilhes <jt@hpl.hp.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jean Tourrilhes <jt@hpl.hp.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2013-08-23 11:11:03 -07:00
/* NX1.0-1.1(1,524), OF1.2+(2,14). Action references past the end of an
* OXM or NXM field, or uses a length of zero. */
OFPERR_OFPBAC_BAD_SET_LEN,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
meta-flow: Use correct OF1.2+ errors for invalid fields in actions. OFPERR_OFPBAC_BAD_ARGUMENT is not as specific as the errors provided by OpenFlow 1.2 and later. Some of these errors needed Nicira extension numbers for use with OpenFlow 1.0 and 1.1, so this commit also adds those. Some of these errors had poor explanations likely to confuse users, so this commits improves them. Some of the errors had the wrong names, so this commit fixes them. Reported-by: Jean Tourrilhes <jt@hpl.hp.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jean Tourrilhes <jt@hpl.hp.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2013-08-23 11:11:03 -07:00
/* NX1.0-1.1(1,525), OF1.2+(2,15). Action sets a field to an invalid or
* unsupported value, or modifies a read-only field. */
OFPERR_OFPBAC_BAD_SET_ARGUMENT,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
ofp-errors: Use official extension code for OFPBAC_BAD_SET_MASK. ONF-JIRA: EXT-425 Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-11-24 10:27:01 -08:00
/* ONF1.3-1.4(4250), OF1.5+(2,16). Field in Set-Field action has Has-Mask
* bit set to 1. */
ofp-actions: Use specific error code for oxm_hasmask=1 in Set-Field. Based on the OpenFlow 1.5 draft. ONF-JIRA: EXT-425 Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-11 14:13:53 -07:00
OFPERR_OFPBAC_BAD_SET_MASK,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(2,256), NX1.2+(11). Must-be-zero action argument had nonzero
* value. */
Add ability to direct "packet-in"s to particular controllers. Nicira's controllers are somewhat heterogeneous, so that particular "packet-in" messages should be directed to particular controllers. This new Nicira extension action allows designating a controller or controllers to receive the "packet-in" using a 16-bit integer ID. The new NXAST_CONTROLLER action also specifies the "reason" code to include in the "packet-in" message. This is particularly useful for simulating a "no-match" "packet-in" using a rule. Feature #8946. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-02-09 14:17:33 -08:00
OFPERR_NXBAC_MUST_BE_ZERO,
classifier: Add support for conjunctive matches. A "conjunctive match" allows higher-level matches in the flow table, such as set membership matches, without causing a cross-product explosion for multidimensional matches. Please refer to the documentation that this commit adds to ovs-ofctl(8) for a better explanation, including an example. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2015-01-11 13:25:24 -08:00
/* NX1.0-1.1(2,526), NX1.2+(15). Conjunction action must be only action
* present. conjunction(id, k/n) must satisfy 1 <= k <= n and 2 <= n <=
* 64. */
OFPERR_NXBAC_BAD_CONJUNCTION,
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
/* ## --------------------- ## */
/* ## OFPET_BAD_INSTRUCTION ## */
/* ## --------------------- ## */
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(3,0). Unknown instruction. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBIC_UNKNOWN_INST,
ofp-actions: Pretend that OpenFlow 1.0 has instructions. This allows callers to be more uniform, because they don't have to pick out whether they should parse actions or instructions based on the OpenFlow version in use. It also allows the Write-Metadata instruction emulation in OpenFlow 1.0 to be treated just as in OpenFlow 1.1 in the sense that it is allowed in contexts where instructions are allowed in OpenFlow 1.1 and not elsewhere. (The changes in the tests reflect this more accurate treatment.) Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:09:07 -07:00
/* NX1.0(2,257), OF1.1+(3,1). Switch or table does not support the
* instruction. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBIC_UNSUP_INST,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(3,2). Invalid Table-ID specified. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBIC_BAD_TABLE_ID,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(3,3). Metadata value unsupported by datapath. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBIC_UNSUP_METADATA,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(3,4). Metadata mask value unsupported by datapath. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBIC_UNSUP_METADATA_MASK,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
/* OF1.1+(3,5). Unknown experimenter id specified. */
OFPERR_OFPBIC_BAD_EXPERIMENTER,
/* OF1.1(3,5), OF1.2+(3,6). Unknown instruction for experimenter id. */
OFPERR_OFPBIC_BAD_EXP_TYPE,
/* OF1.2+(3,7). Length problem in instructions. */
OFPERR_OFPBIC_BAD_LEN,
/* OF1.2+(3,8). Permissions error. */
OFPERR_OFPBIC_EPERM,
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
ofp-errors: Fix bugs in treatment of OpenFlow experimenter errors. OpenFlow 1.2 and later have "experimenter errors". The OVS implementation was buggy in a few ways. First, a bug in extract-ofp-errors prevented OF1.2+ experimenter errors from being properly decoded. Second, OF1.2+ experimenter errors have only a type, not a code, whereas all other types of errors (standard errors, OF1.0/1.1 Nicira extension errors) have both, but extract-ofp-errors didn't properly enforce that. This commit fixes both problems and improves existing tests to verify that encoding and decoding of experimenter errors now works properly. This commit also fixes the definition of OFPBIC_DUP_INST. It claimed to have an OF1.1 experimenter error value although OF1.1 didn't have experimenter errors. This commit changes it to use a Nicira extension error in OF1.1 instead. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-21 10:38:15 -07:00
/* NX1.1(3,256), ONF1.2-1.3(2600), OF1.4+(3,9). Duplicate instruction. */
ofp-errors: Duplicate instruction error Add OFPERR_OFPBIC_DUP_INST (type = OFPET_BAD_INSTRUCTION, code = 9) and use it for OpenFlow1.4+. For OpenFlow1.1 - 1.3 map this error to ONFBIC_DUP_INSTRUCTION (experimenter = ONF, type = 2600) which is proposed in OpenFlow enhancement proposal EXT-260 "Add error code for duplicate instruction.". Previously ONFBIC_DUP_INSTRUCTION was used for OpenFlow1.3+. Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-06-02 21:36:28 +09:00
OFPERR_OFPBIC_DUP_INST,
ofp-errors: New error code ONFBIC_DUP_INSTRUCTION. This is a prototype of OpenFlow enhancement proposal EXT-260 "Add error code for duplicate instruction." It uses the error code proposed there. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:47 -07:00
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
/* ## --------------- ## */
/* ## OFPET_BAD_MATCH ## */
/* ## --------------- ## */
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(4,0). Unsupported match type specified by the match */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBMC_BAD_TYPE,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(4,1). Length problem in match. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBMC_BAD_LEN,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(4,2). Match uses an unsupported tag/encap. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBMC_BAD_TAG,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(4,3). Unsupported datalink addr mask - switch does not support
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
* arbitrary datalink address mask. */
OFPERR_OFPBMC_BAD_DL_ADDR_MASK,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(4,4). Unsupported network addr mask - switch does not support
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
* arbitrary network address mask. */
OFPERR_OFPBMC_BAD_NW_ADDR_MASK,
nx-match: Reject bad wildcard combinations. A log message has warned that this was going to happen for some time, and newer OpenFlow versions require this behavior. The test updates fix this behavior in our testsuite. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
2014-09-04 13:34:37 -07:00
/* NX1.0(1,262), OF1.1+(4,5). Unsupported wildcard specified in the
* match. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBMC_BAD_WILDCARDS,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(4,6). Unsupported field in the match. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBMC_BAD_FIELD,
ofp-errors: Use standardised code for OFPERR_OFPBMC_BAD_VALUE Use standardised code for Open Flow 1.1 OFPERR_OFPBMC_BAD_VALUE OFPERR_OFPBMC_BAD_VALUE is defined in Open Flow 1.1 as (4,7), so use that code instead of a non-standard one. Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-09-04 15:52:03 +09:00
/* NX1.0(1,258), OF1.1+(4,7). Unsupported value in a match
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
* field. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPBMC_BAD_VALUE,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(1,259), OF1.2+(4,8). Unsupported mask specified in the match,
* field is not dl-address or nw-address. */
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
OFPERR_OFPBMC_BAD_MASK,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(1,260), OF1.2+(4,9). A prerequisite was not met. */
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
OFPERR_OFPBMC_BAD_PREREQ,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(1,261), OF1.2+(4,10). A field type was duplicated. */
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
OFPERR_OFPBMC_DUP_FIELD,
/* OF1.2+(4,11). Permissions error. */
OFPERR_OFPBMC_EPERM,
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
/* ## --------------------- ## */
/* ## OFPET_FLOW_MOD_FAILED ## */
/* ## --------------------- ## */
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(5,0). Unspecified error. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPFMFC_UNKNOWN,
ofp-errors: Merge OF1.0 "all tables full" with OF1.1+ "table full". These codes represent essentially the same condition and only one of them exists in any given version of OpenFlow, so merge them together into a single OFPERR_* code. Reported-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-12 10:15:11 -07:00
/* OF1.0(3,0), OF1.1+(5,1). Flow not added because of full table(s). */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPFMFC_TABLE_FULL,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(5,2). Table does not exist */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPFMFC_BAD_TABLE_ID,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.0(3,1), OF1.1+(5,3). Attempted to add overlapping flow with
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
* CHECK_OVERLAP flag set. */
OFPERR_OFPFMFC_OVERLAP,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.0(3,2), OF1.1+(5,4). Permissions error. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPFMFC_EPERM,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(5,5). Flow not added because of unsupported idle/hard
* timeout. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPFMFC_BAD_TIMEOUT,
/* OF1.0(3,3). Flow not added because of non-zero idle/hard timeout. */
OFPERR_OFPFMFC_BAD_EMERG_TIMEOUT,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.0(3,4), OF1.1+(5,6). Unsupported or unknown command. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPFMFC_BAD_COMMAND,
ofp-util: Abstract flow_mod OFPFF_* flags. The OFPFF_* flags used in flow_mods are just confusing enough that it seems worthwhile to try to abstract them out. In particular: * OFPFF_EMERG was introduced in OF1.0, deleted in OF1.1, and then its bit was reused for a different purpose in OF1.2. * OFPFF_RESET_COUNTS was introduced in OF1.2 but the semantics that it specifies are implied by "add" commands in earlier versions, so proper translation requires the OpenFlow version number and flow_mod command. This commit does the abstraction. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2013-08-26 16:23:50 -07:00
/* NX1.0(3,258), NX1.1(5,258), OF1.2+(5,7). Unsupported or unknown
* flags. */
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
OFPERR_OFPFMFC_BAD_FLAGS,
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
/* OF1.0(3,5). Unsupported action list - cannot process in the order
* specified. */
OFPERR_OFPFMFC_UNSUPPORTED,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(5,256), NX1.2+(12). Generic hardware error. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_NXFMFC_HARDWARE,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(5,257), NX1.2+(13). A nonexistent table ID was specified in
* the "command" field of struct ofp_flow_mod, when the
* nxt_flow_mod_table_id extension is enabled. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_NXFMFC_BAD_TABLE_ID,
/* ## ---------------------- ## */
/* ## OFPET_GROUP_MOD_FAILED ## */
/* ## ---------------------- ## */
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(6,0). Group not added because a group ADD attempted to replace
* an already-present group. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPGMFC_GROUP_EXISTS,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(6,1). Group not added because Group specified is invalid. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPGMFC_INVALID_GROUP,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(6,2). Switch does not support unequal load sharing with select
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
* groups. */
OFPERR_OFPGMFC_WEIGHT_UNSUPPORTED,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(6,3). The group table is full. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPGMFC_OUT_OF_GROUPS,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(6,4). The maximum number of action buckets for a group has been
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
* exceeded. */
OFPERR_OFPGMFC_OUT_OF_BUCKETS,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(6,5). Switch does not support groups that forward to groups. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPGMFC_CHAINING_UNSUPPORTED,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(6,6). This group cannot watch the watch_port or watch_group
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
* specified. */
OFPERR_OFPGMFC_WATCH_UNSUPPORTED,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(6,7). Group entry would cause a loop. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPGMFC_LOOP,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(6,8). Group not modified because a group MODIFY attempted to
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
* modify a non-existent group. */
OFPERR_OFPGMFC_UNKNOWN_GROUP,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
/* OF1.2+(6,9). Group not deleted because another
group is forwarding to it. */
OFPERR_OFPGMFC_CHAINED_GROUP,
/* OF1.2+(6,10). Unsupported or unknown group type. */
OFPERR_OFPGMFC_BAD_TYPE,
/* OF1.2+(6,11). Unsupported or unknown command. */
OFPERR_OFPGMFC_BAD_COMMAND,
/* OF1.2+(6,12). Error in bucket. */
ofp-errors: Fix typos in error enumeration names. OFPGMFC is so nice these constants said it twice. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-19 13:55:17 -07:00
OFPERR_OFPGMFC_BAD_BUCKET,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
/* OF1.2+(6,13). Error in watch port/group. */
ofp-errors: Fix typos in error enumeration names. OFPGMFC is so nice these constants said it twice. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-19 13:55:17 -07:00
OFPERR_OFPGMFC_BAD_WATCH,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
/* OF1.2+(6,14). Permissions error. */
ofp-errors: Fix typos in error enumeration names. OFPGMFC is so nice these constants said it twice. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-19 13:55:17 -07:00
OFPERR_OFPGMFC_EPERM,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
ofp-errors: Add (draft) OpenFlow 1.5 group mod errors. Add OFPERR_OFPGMFC_UNKNOWN_BUCKET and OFPERR_OFPGMFC_BUCKET_EXISTS which are part of (draft) OpenFlow 1.5 groups. ONF-JIRA: EXT-350 Signed-off-by: Simon Horman <simon.horman@netronome.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-11-11 12:39:17 +09:00
/* OF1.5+(6,15). Invalid bucket identifier used in
* INSERT BUCKET or REMOVE BUCKET command. */
OFPERR_OFPGMFC_UNKNOWN_BUCKET,
/* OF1.5+(6,16). Can't insert bucket because a bucket
* already exist with that bucket-id. */
OFPERR_OFPGMFC_BUCKET_EXISTS,
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
/* ## --------------------- ## */
/* ## OFPET_PORT_MOD_FAILED ## */
/* ## --------------------- ## */
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.0(4,0), OF1.1+(7,0). Specified port does not exist. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPPMFC_BAD_PORT,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.0(4,1), OF1.1+(7,1). Specified hardware address does not match the
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
* port number. */
OFPERR_OFPPMFC_BAD_HW_ADDR,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(7,2). Specified config is invalid. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPPMFC_BAD_CONFIG,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(7,3). Specified advertise is invalid. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPPMFC_BAD_ADVERTISE,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
/* OF1.2+(7,4). Permissions error. */
OFPERR_OFPPMFC_EPERM,
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
/* ## ---------------------- ## */
/* ## OFPET_TABLE_MOD_FAILED ## */
/* ## ---------------------- ## */
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(8,0). Specified table does not exist. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPTMFC_BAD_TABLE,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(8,1). Specified config is invalid. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPTMFC_BAD_CONFIG,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
/* OF1.2+(8,2). Permissions error. */
OFPERR_OFPTMFC_EPERM,
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
/* ## --------------------- ## */
/* ## OFPET_QUEUE_OP_FAILED ## */
/* ## --------------------- ## */
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.0(5,0), OF1.1+(9,0). Invalid port (or port does not exist). */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPQOFC_BAD_PORT,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.0(5,1), OF1.1+(9,1). Queue does not exist. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPQOFC_BAD_QUEUE,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.0(5,2), OF1.1+(9,2). Permissions error. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPQOFC_EPERM,
/* ## -------------------------- ## */
/* ## OFPET_SWITCH_CONFIG_FAILED ## */
/* ## -------------------------- ## */
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(10,0). Specified flags is invalid. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPSCFC_BAD_FLAGS,
ofp-errors: Use OF1.1+ in place of OF1.1 throughout. In general, I guess that the common case is for most error codes to be retained without change in future versions of OpenFlow, so to me it seems best to use the "+" version "by default". Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 11:25:52 -07:00
/* OF1.1+(10,1). Specified len is invalid. */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
OFPERR_OFPSCFC_BAD_LEN,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
/* OF1.2+(10,2). Permissions error. */
OFPERR_OFPSCFC_EPERM,
/* ## ------------------------- ## */
/* ## OFPET_ROLE_REQUEST_FAILED ## */
/* ## ------------------------- ## */
/* OF1.2+(11,0). Stale Message: old generation_id. */
OFPERR_OFPRRFC_STALE,
/* OF1.2+(11,1). Controller role change unsupported. */
OFPERR_OFPRRFC_UNSUP,
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
/* NX1.0-1.1(1,513), OF1.2+(11,2). Invalid role. */
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
OFPERR_OFPRRFC_BAD_ROLE,
Initial OpenFlow 1.3 support Initial OpenFlow 1.3 support with new include/openflow/openflow-1.3.h. Most of the messages that differ from 1.2 are implemented. OFPT_SET_ASYNC is implemented via NX_SET_ASYNC_CONFIG, other new message types are yet to be implemented. Stats replies that add duration fields are implemented at encode/decode level only. Test cases for implemented features are included. Remaining FIXME:s should not cause runtime aborts. Make check comes out clean. Signed-off-by: Jarno Rajahalme <jarno.rajahalme@nsn.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-11-27 17:44:22 +02:00
/* ## ---------------------- ## */
/* ## OFPET_METER_MOD_FAILED ## */
/* ## ---------------------- ## */
/* OF1.3+(12,0). Unspecified error. */
OFPERR_OFPMMFC_UNKNOWN,
/* OF1.3+(12,1). Meter not added because a Meter ADD attempted to
* replace an existing Meter. */
OFPERR_OFPMMFC_METER_EXISTS,
/* OF1.3+(12,2). Meter not added because Meter specified is invalid. */
OFPERR_OFPMMFC_INVALID_METER,
/* OF1.3+(12,3). Meter not modified because a Meter MODIFY attempted
* to modify a non-existent Meter. */
OFPERR_OFPMMFC_UNKNOWN_METER,
/* OF1.3+(12,4). Unsupported or unknown command. */
OFPERR_OFPMMFC_BAD_COMMAND,
/* OF1.3+(12,5). Flag configuration unsupported. */
OFPERR_OFPMMFC_BAD_FLAGS,
/* OF1.3+(12,6). Rate unsupported. */
OFPERR_OFPMMFC_BAD_RATE,
/* OF1.3+(12,7). Burst size unsupported. */
OFPERR_OFPMMFC_BAD_BURST,
/* OF1.3+(12,8). Band unsupported. */
OFPERR_OFPMMFC_BAD_BAND,
/* OF1.3+(12,9). Band value unsupported. */
OFPERR_OFPMMFC_BAD_BAND_VALUE,
/* OF1.3+(12,10). No more meters available. */
OFPERR_OFPMMFC_OUT_OF_METERS,
/* OF1.3+(12,11). The maximum number of properties for a meter has
* been exceeded. */
OFPERR_OFPMMFC_OUT_OF_BANDS,
/* ## --------------------------- ## */
/* ## OFPET_TABLE_FEATURES_FAILED ## */
/* ## --------------------------- ## */
/* OF1.3+(13,0). Specified table does not exist. */
OFPERR_OFPTFFC_BAD_TABLE,
/* OF1.3+(13,1). Invalid metadata mask. */
OFPERR_OFPTFFC_BAD_METADATA,
ofp-util: Generalize functions for parsing OF1.3+ properties. The main effect is to move these functions a little earlier in the file. Also, OpenFlow 1.4 changed the table-features specific error codes to new values that apply to all property sets, so this commit updates the error code names and adds the appropriate OpenFlow 1.4+ codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-05-09 19:29:56 -07:00
/* OF1.3+(13,5). Permissions error. */
OFPERR_OFPTFFC_EPERM,
Initial OpenFlow 1.3 support Initial OpenFlow 1.3 support with new include/openflow/openflow-1.3.h. Most of the messages that differ from 1.2 are implemented. OFPT_SET_ASYNC is implemented via NX_SET_ASYNC_CONFIG, other new message types are yet to be implemented. Stats replies that add duration fields are implemented at encode/decode level only. Test cases for implemented features are included. Remaining FIXME:s should not cause runtime aborts. Make check comes out clean. Signed-off-by: Jarno Rajahalme <jarno.rajahalme@nsn.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-11-27 17:44:22 +02:00
ofp-util: Generalize functions for parsing OF1.3+ properties. The main effect is to move these functions a little earlier in the file. Also, OpenFlow 1.4 changed the table-features specific error codes to new values that apply to all property sets, so this commit updates the error code names and adds the appropriate OpenFlow 1.4+ codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-05-09 19:29:56 -07:00
/* ## ------------------ ## */
/* ## OFPET_BAD_PROPERTY ## */
/* ## ------------------ ## */
Initial OpenFlow 1.3 support Initial OpenFlow 1.3 support with new include/openflow/openflow-1.3.h. Most of the messages that differ from 1.2 are implemented. OFPT_SET_ASYNC is implemented via NX_SET_ASYNC_CONFIG, other new message types are yet to be implemented. Stats replies that add duration fields are implemented at encode/decode level only. Test cases for implemented features are included. Remaining FIXME:s should not cause runtime aborts. Make check comes out clean. Signed-off-by: Jarno Rajahalme <jarno.rajahalme@nsn.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-11-27 17:44:22 +02:00
ofp-util: Generalize functions for parsing OF1.3+ properties. The main effect is to move these functions a little earlier in the file. Also, OpenFlow 1.4 changed the table-features specific error codes to new values that apply to all property sets, so this commit updates the error code names and adds the appropriate OpenFlow 1.4+ codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-05-09 19:29:56 -07:00
/* OF1.3(13,2), OF1.4+(14,0). Unknown property type.
*
* [Known as OFPTFFC_BAD_TYPE in OF1.3.] */
OFPERR_OFPBPC_BAD_TYPE,
Initial OpenFlow 1.3 support Initial OpenFlow 1.3 support with new include/openflow/openflow-1.3.h. Most of the messages that differ from 1.2 are implemented. OFPT_SET_ASYNC is implemented via NX_SET_ASYNC_CONFIG, other new message types are yet to be implemented. Stats replies that add duration fields are implemented at encode/decode level only. Test cases for implemented features are included. Remaining FIXME:s should not cause runtime aborts. Make check comes out clean. Signed-off-by: Jarno Rajahalme <jarno.rajahalme@nsn.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-11-27 17:44:22 +02:00
ofp-util: Generalize functions for parsing OF1.3+ properties. The main effect is to move these functions a little earlier in the file. Also, OpenFlow 1.4 changed the table-features specific error codes to new values that apply to all property sets, so this commit updates the error code names and adds the appropriate OpenFlow 1.4+ codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-05-09 19:29:56 -07:00
/* OF1.3(13,3), OF1.4+(14,1). Length problem in property.
*
* [Known as OFPTFFC_BAD_LEN in OF1.3.] */
OFPERR_OFPBPC_BAD_LEN,
/* OF1.3(13,4), OF1.4+(14,2). Unsupported property value.
*
* [Known as OFPTFFC_BAD_ARGUMENT in OF1.3.] */
OFPERR_OFPBPC_BAD_VALUE,
ofp-errors: Migrate EXT-444 errors to ONF experimenter ID. Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com> [blp@nicira.com removed the definitions of these errors in OF1.1 and OF1.2] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-21 10:40:51 -07:00
/* ONF1.3(4443), OF1.4+(14,3). Can't handle this many properties. */
ofp-util: Generalize functions for parsing OF1.3+ properties. The main effect is to move these functions a little earlier in the file. Also, OpenFlow 1.4 changed the table-features specific error codes to new values that apply to all property sets, so this commit updates the error code names and adds the appropriate OpenFlow 1.4+ codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-05-09 19:29:56 -07:00
OFPERR_OFPBPC_TOO_MANY,
ofp-errors: Migrate EXT-444 errors to ONF experimenter ID. Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com> [blp@nicira.com removed the definitions of these errors in OF1.1 and OF1.2] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-21 10:40:51 -07:00
/* ONF1.3(4444), OF1.4+(14,4). A property type was duplicated. */
ofp-util: Generalize functions for parsing OF1.3+ properties. The main effect is to move these functions a little earlier in the file. Also, OpenFlow 1.4 changed the table-features specific error codes to new values that apply to all property sets, so this commit updates the error code names and adds the appropriate OpenFlow 1.4+ codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-05-09 19:29:56 -07:00
OFPERR_OFPBPC_DUP_TYPE,
ofp-errors: Migrate EXT-444 errors to ONF experimenter ID. Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com> [blp@nicira.com removed the definitions of these errors in OF1.1 and OF1.2] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-21 10:40:51 -07:00
/* ONF1.3(4445), OF1.4+(14,5). Unknown experimenter id specified. */
ofp-util: Generalize functions for parsing OF1.3+ properties. The main effect is to move these functions a little earlier in the file. Also, OpenFlow 1.4 changed the table-features specific error codes to new values that apply to all property sets, so this commit updates the error code names and adds the appropriate OpenFlow 1.4+ codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-05-09 19:29:56 -07:00
OFPERR_OFPBPC_BAD_EXPERIMENTER,
ofp-errors: Migrate EXT-444 errors to ONF experimenter ID. Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com> [blp@nicira.com removed the definitions of these errors in OF1.1 and OF1.2] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-21 10:40:51 -07:00
/* ONF1.3(4446), OF1.4+(14,6). Unknown exp_type for experimenter id. */
ofp-util: Generalize functions for parsing OF1.3+ properties. The main effect is to move these functions a little earlier in the file. Also, OpenFlow 1.4 changed the table-features specific error codes to new values that apply to all property sets, so this commit updates the error code names and adds the appropriate OpenFlow 1.4+ codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-05-09 19:29:56 -07:00
OFPERR_OFPBPC_BAD_EXP_TYPE,
ofp-errors: Migrate EXT-444 errors to ONF experimenter ID. Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com> [blp@nicira.com removed the definitions of these errors in OF1.1 and OF1.2] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-21 10:40:51 -07:00
/* ONF1.3(4447), OF1.4+(14,7). Unknown value for experimenter id. */
ofp-util: Generalize functions for parsing OF1.3+ properties. The main effect is to move these functions a little earlier in the file. Also, OpenFlow 1.4 changed the table-features specific error codes to new values that apply to all property sets, so this commit updates the error code names and adds the appropriate OpenFlow 1.4+ codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-05-09 19:29:56 -07:00
OFPERR_OFPBPC_BAD_EXP_VALUE,
ofp-errors: Migrate EXT-444 errors to ONF experimenter ID. Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com> [blp@nicira.com removed the definitions of these errors in OF1.1 and OF1.2] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-21 10:40:51 -07:00
/* ONF1.3(4448), OF1.4+(14,8). Permissions error. */
ofp-util: Generalize functions for parsing OF1.3+ properties. The main effect is to move these functions a little earlier in the file. Also, OpenFlow 1.4 changed the table-features specific error codes to new values that apply to all property sets, so this commit updates the error code names and adds the appropriate OpenFlow 1.4+ codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-05-09 19:29:56 -07:00
OFPERR_OFPBPC_EPERM,
Initial OpenFlow 1.3 support Initial OpenFlow 1.3 support with new include/openflow/openflow-1.3.h. Most of the messages that differ from 1.2 are implemented. OFPT_SET_ASYNC is implemented via NX_SET_ASYNC_CONFIG, other new message types are yet to be implemented. Stats replies that add duration fields are implemented at encode/decode level only. Test cases for implemented features are included. Remaining FIXME:s should not cause runtime aborts. Make check comes out clean. Signed-off-by: Jarno Rajahalme <jarno.rajahalme@nsn.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-11-27 17:44:22 +02:00
Add basic implementation for OpenFlow 1.4 bundles This is only the communication part of the bundles functionality. The actual message pre-validation and commits are not implemented. We also enable OF1.4 for all the tests. Signed-off-by: Alexandru Copot <alex.mihai.c@gmail.com> Cc: Daniel Baluta <dbaluta@ixiacom.com> [blp@nicira.com made ofputil_decode_bundle_add() more obviously correct] Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-05-02 09:54:27 +03:00
/* ## -------------------- ## */
/* ## OFPET_BUNDLE_FAILED ## */
/* ## -------------------- ## */
/* OF1.4+(17,0). Unspecified error. */
OFPERR_OFPBFC_UNKNOWN,
/* OF1.4+(17,1). Permissions error. */
OFPERR_OFPBFC_EPERM,
/* OF1.4+(17,2). Bundle ID doesn't exist. */
OFPERR_OFPBFC_BAD_ID,
/* OF1.4+(17,3). Bundle ID already exists. */
OFPERR_OFPBFC_BUNDLE_EXIST,
/* OF1.4+(17,4). Bundle ID is closed. */
OFPERR_OFPBFC_BUNDLE_CLOSED,
/* OF1.4+(17,5). Too many bundle IDs. */
OFPERR_OFPBFC_OUT_OF_BUNDLES,
/* OF1.4+(17,6). Unsupported of unknown message control type. */
OFPERR_OFPBFC_BAD_TYPE,
/* OF1.4+(17,7). Unsupported, unknown, or inconsistent flags. */
OFPERR_OFPBFC_BAD_FLAGS,
/* OF1.4+(17,8). Length problem in included message. */
OFPERR_OFPBFC_MSG_BAD_LEN,
/* OF1.4+(17,9). Inconsistent or duplicate XID. */
OFPERR_OFPBFC_MSG_BAD_XID,
/* OF1.4+(17,10). Unsupported message in this bundle. */
OFPERR_OFPBFC_MSG_UNSUP,
/* OF1.4+(17,11). Unsupported message combination in this bundle. */
OFPERR_OFPBFC_MSG_CONFLICT,
/* OF1.4+(17,12). Cant handle this many messages in bundle. */
OFPERR_OFPBFC_MSG_TOO_MANY,
/* OF1.4+(17,13). One message in bundle failed. */
OFPERR_OFPBFC_MSG_FAILED,
/* OF1.4+(17,14). Bundle is taking too long. */
OFPERR_OFPBFC_TIMEOUT,
/* OF1.4+(17,15). Bundle is locking the resource. */
OFPERR_OFPBFC_BUNDLE_IN_PROGRESS,
ofp-errors: Add OFPET_FLOW_MONITOR_FAILED Add OFPET_FLOW_MONITOR_FAILED which is added in OpenFLow1.4. Map the OFPERR_NXBRC_FM_* errors to the corresponding new OpenFlow errors. This is a step towards supporting OpenFlow1.4 flow monitors. Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-06-10 19:27:07 +09:00
/* ## ------------------------- ## */
/* ## OFPET_FLOW_MONITOR_FAILED ## */
/* ## ------------------------- ## */
/* OF1.4+(16,0). Unspecified error. */
OFPERR_OFPMOFC_UNKNOWN,
/* NX1.0-1.1(1,517), NX1.2-1.3(6), OF1.4+(16,1). Monitor not added
* because a Monitor ADD attempted to replace an existing Monitor. */
OFPERR_OFPMOFC_MONITOR_EXISTS,
/* OF1.4+(16,2). Monitor not added because
* Monitor specified is invalid. */
OFPERR_OFPMOFC_INVALID_MONITOR,
/* NX1.0-1.1(1,519), NX1.2-1.3(8), OF1.4+(16,3). Monitor not modified
* because a Monitor MODIFY attempted to modify a non-existent Monitor. */
OFPERR_OFPMOFC_UNKNOWN_MONITOR,
/* OF1.4+(16,4). Unsupported or unknown command. */
OFPERR_OFPMOFC_BAD_COMMAND,
/* NX1.0-1.1(1,518), NX1.2-1.3(7), OF1.4+(16,5). Flag configuration
* unsupported. */
OFPERR_OFPMOFC_BAD_FLAGS,
/* OF1.4+(16,6). Specified table does not exist. */
OFPERR_OFPMOFC_BAD_TABLE_ID,
/* OF1.4+(16,7). Error in output port/group. */
OFPERR_OFPMOFC_BAD_OUT,
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
/* ## ------------------ ## */
/* ## OFPET_EXPERIMENTER ## */
/* ## ------------------ ## */
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
};
ofp-error: Remove ofperr_domain from external API It seems that ofp_version suffices in all cases. Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-08-01 16:01:49 +09:00
const char *ofperr_domain_get_name(enum ofp_version);
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
bool ofperr_is_valid(enum ofperr);
Add error codes for Open Flow v1.2 * Where Open Flow 1.2 breaks apart error codes defined in previous versions, provide all new definitions to previous versions and map the numeric error code to the first first definition supplied in ofp-errors.h. The case handled so far is: OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER, OFPERR_OFPBIC_BAD_EXP_TYPE } * Where Open Flow 1.2 adds error codes that were previously defined as Nicira extension errors define the later in terms of the new codes. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com added better error checking in extract-ofp-errors, added unit tests, miscellaneous cleanup] Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
2012-03-26 13:46:35 -07:00
enum ofperr ofperr_from_name(const char *);
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
ofp-msgs: New approach to encoding and decoding OpenFlow headers. OpenFlow headers are not as uniform as they could be, with size, alignment, and numbering changes from one version to another and across varieties (e.g. ordinary messages vs. "stats" messages). Until now the Open vSwitch internal APIs haven't done a good job of abstracting those differences in header formats. This commit changes that; from this commit forward very little code actually needs to understand the header format or numbering. Instead, it can just encode or decode, or pull or put, the header using a more abstract API using the ofpraw_, ofptype_, and other APIs in the new ofp-msgs module. Signed-off-by: Ben Pfaff <blp@nicira.com> Tested-by: Simon Horman <horms@verge.net.au> Reviewed-by: Simon Horman <horms@verge.net.au>
2012-07-19 23:23:17 -07:00
enum ofperr ofperr_decode_msg(const struct ofp_header *,
struct ofpbuf *payload);
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
struct ofpbuf *ofperr_encode_reply(enum ofperr, const struct ofp_header *);
ofp-util: Make ofperr_encode_msg__() use correct Open Flow version Make ofperr_encode_msg__() use correct Open Flow version in the header of messages. Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-08-01 16:01:48 +09:00
struct ofpbuf *ofperr_encode_hello(enum ofperr, enum ofp_version ofp_version,
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
const char *);
ofp-errors: Implement OpenFlow 1.2+ experimenter error codes. OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-24 13:49:40 -07:00
int ofperr_get_vendor(enum ofperr, enum ofp_version);
ofp-error: Remove ofperr_domain from external API It seems that ofp_version suffices in all cases. Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-08-01 16:01:49 +09:00
int ofperr_get_type(enum ofperr, enum ofp_version);
int ofperr_get_code(enum ofperr, enum ofp_version);
Better abstract OpenFlow error codes. This commit switches from using the actual protocol values of error codes internally in Open vSwitch, to using abstract values that are translated to and from protocol values at message parsing and serialization time. I believe that this makes the code easier to read and to write. This is also one step along the way toward OpenFlow 1.1 support because OpenFlow 1.1 renumbered a bunch of error codes. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-01-12 15:48:19 -08:00
const char *ofperr_get_name(enum ofperr);
const char *ofperr_get_description(enum ofperr);
void ofperr_format(struct ds *, enum ofperr);
const char *ofperr_to_string(enum ofperr);
Automatically extract error types and codes for formatting.
2011-01-12 13:42:50 -08:00
#endif /* ofp-errors.h */
Reference in New Issue Copy Permalink