2
0
mirror of https://github.com/openvswitch/ovs synced 2025-08-22 18:07:40 +00:00
ovs/lib/sset.c

384 lines
9.7 KiB
C
Raw Normal View History

/*
* Copyright (c) 2011, 2012, 2013, 2015, 2016 Nicira, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at:
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <config.h>
#include "sset.h"
#include "openvswitch/dynamic-string.h"
#include "hash.h"
static uint32_t
hash_name__(const char *name, size_t length)
{
return hash_bytes(name, length, 0);
}
static uint32_t
hash_name(const char *name)
{
return hash_name__(name, strlen(name));
}
static struct sset_node *
sset_find__(const struct sset *set, const char *name, size_t hash)
{
struct sset_node *node;
HMAP_FOR_EACH_WITH_HASH (node, hmap_node, hash, &set->map) {
if (!strcmp(node->name, name)) {
return node;
}
}
return NULL;
}
static struct sset_node *
sset_add__(struct sset *set, const char *name, size_t length, size_t hash)
{
struct sset_node *node = xmalloc(length + sizeof *node);
memcpy(node->name, name, length + 1);
hmap_insert(&set->map, &node->hmap_node, hash);
return node;
}
/* Initializes 'set' as an empty set of strings. */
void
sset_init(struct sset *set)
{
hmap_init(&set->map);
}
/* Destroys 'sets'. */
void
sset_destroy(struct sset *set)
{
if (set) {
sset_clear(set);
hmap_destroy(&set->map);
}
}
/* Initializes 'set' to contain the same strings as 'orig'. */
void
sset_clone(struct sset *set, const struct sset *orig)
{
struct sset_node *node;
sset_init(set);
hmap_reserve(&set->map, sset_count(orig));
HMAP_FOR_EACH (node, hmap_node, &orig->map) {
sset_add__(set, node->name, strlen(node->name),
node->hmap_node.hash);
}
}
/* Exchanges the contents of 'a' and 'b'. */
void
sset_swap(struct sset *a, struct sset *b)
{
hmap_swap(&a->map, &b->map);
}
/* Adjusts 'set' so that it is still valid after it has been moved around in
* memory (e.g. due to realloc()). */
void
sset_moved(struct sset *set)
{
hmap_moved(&set->map);
}
/* Initializes 'set' with substrings of 's' that are delimited by any of the
* characters in 'delimiters'. For example,
* sset_from_delimited_string(&set, "a b,c", " ,");
* initializes 'set' with three strings "a", "b", and "c". */
void
sset_from_delimited_string(struct sset *set, const char *s_,
const char *delimiters)
{
sset_init(set);
char *s = xstrdup(s_);
char *token, *save_ptr = NULL;
for (token = strtok_r(s, delimiters, &save_ptr); token != NULL;
token = strtok_r(NULL, delimiters, &save_ptr)) {
sset_add(set, token);
}
free(s);
}
/* Returns a malloc()'d string that consists of the concatenation of all of the
* strings in 'sset' in lexicographic order, each separated from the next by
* 'delimiter' and followed by 'terminator'. For example:
*
* sset_join(("a", "b", "c"), ", ", ".") -> "a, b, c."
* sset_join(("xyzzy"), ", ", ".") -> "xyzzy."
* sset_join((""), ", ", ".") -> "."
*
* The caller is responsible for freeing the returned string (with free()).
*/
char *
sset_join(const struct sset *sset,
const char *delimiter, const char *terminator)
{
struct ds s = DS_EMPTY_INITIALIZER;
const char **names = sset_sort(sset);
for (size_t i = 0; i < sset_count(sset); i++) {
if (i) {
ds_put_cstr(&s, delimiter);
}
ds_put_cstr(&s, names[i]);
}
free(names);
ds_put_cstr(&s, terminator);
return ds_steal_cstr(&s);
}
/* Returns true if 'set' contains no strings, false if it contains at least one
* string. */
bool
sset_is_empty(const struct sset *set)
{
return hmap_is_empty(&set->map);
}
/* Returns the number of strings in 'set'. */
size_t
sset_count(const struct sset *set)
{
return hmap_count(&set->map);
}
/* Adds 'name' to 'set'. If 'name' is new, returns the new sset_node;
* otherwise (if a copy of 'name' already existed in 'set'), returns NULL. */
struct sset_node *
sset_add(struct sset *set, const char *name)
{
size_t length = strlen(name);
uint32_t hash = hash_name__(name, length);
return (sset_find__(set, name, hash)
? NULL
: sset_add__(set, name, length, hash));
}
/* Adds a copy of 'name' to 'set' and frees 'name'.
*
* If 'name' is new, returns the new sset_node; otherwise (if a copy of 'name'
* already existed in 'set'), returns NULL. */
struct sset_node *
sset_add_and_free(struct sset *set, char *name)
{
struct sset_node *node = sset_add(set, name);
free(name);
return node;
}
/* Adds 'name' to 'set'. Assert-fails if a copy of 'name' was already in
* 'set'. */
void
sset_add_assert(struct sset *set, const char *name)
{
ovs_assert(sset_add(set, name));
}
/* Adds a copy of each of the 'n' names in 'names' to 'set'. */
void
sset_add_array(struct sset *set, char **names, size_t n)
{
size_t i;
for (i = 0; i < n; i++) {
sset_add(set, names[i]);
}
}
/* Removes all of the strings from 'set'. */
void
sset_clear(struct sset *set)
{
const char *name;
SSET_FOR_EACH_SAFE (name, set) {
sset_delete(set, SSET_NODE_FROM_NAME(name));
}
}
/* Deletes 'node' from 'set' and frees 'node'. */
void
sset_delete(struct sset *set, struct sset_node *node)
{
hmap_remove(&set->map, &node->hmap_node);
free(node);
}
/* Searches for 'name' in 'set'. If found, deletes it and returns true. If
* not found, returns false without modifying 'set'. */
bool
sset_find_and_delete(struct sset *set, const char *name)
{
struct sset_node *node = sset_find(set, name);
if (node) {
sset_delete(set, node);
}
return node != NULL;
}
/* Searches for 'name' in 'set' and deletes it. Assert-fails if 'name' is not
* in 'set'. */
void
sset_find_and_delete_assert(struct sset *set, const char *name)
{
ovs_assert(sset_find_and_delete(set, name));
}
/* Removes a string from 'set' and returns a copy of it. The caller must free
* the returned string (with free()).
*
* 'set' must not be empty.
*
* This is not a very good way to iterate through an sset: it copies each name
* and it takes O(n**2) time to remove all the names. Use SSET_FOR_EACH_SAFE
* instead, if you can. */
char *
sset_pop(struct sset *set)
{
const char *name = SSET_FIRST(set);
if (!name) {
return NULL;
}
char *copy = xstrdup(name);
sset_delete(set, SSET_NODE_FROM_NAME(name));
return copy;
}
/* Searches for 'name' in 'set'. Returns its node, if found, otherwise a null
* pointer. */
struct sset_node *
sset_find(const struct sset *set, const char *name)
{
return sset_find__(set, name, hash_name(name));
}
/* Returns true if 'set' contains a copy of 'name', false otherwise. */
bool
sset_contains(const struct sset *set, const char *name)
{
return sset_find(set, name) != NULL;
}
/* Returns true if 'a' and 'b' contain the same strings, false otherwise. */
bool
sset_equals(const struct sset *a, const struct sset *b)
{
struct sset_node *node;
if (sset_count(a) != sset_count(b)) {
return false;
}
HMAP_FOR_EACH (node, hmap_node, &a->map) {
if (!sset_find__(b, node->name, node->hmap_node.hash)) {
return false;
}
}
return true;
}
/* Returns the next node in 'set' in hash order, or NULL if no nodes remain in
* 'set'. Uses '*pos' to determine where to begin iteration, and updates
* '*pos' to pass on the next iteration into them before returning.
*
* It's better to use plain SSET_FOR_EACH and related functions, since they are
* faster and better at dealing with ssets that change during iteration.
*
* Before beginning iteration, set '*pos' to all zeros. */
struct sset_node *
sset_at_position(const struct sset *set, struct sset_position *pos)
{
struct hmap_node *hmap_node;
hmap_node = hmap_at_position(&set->map, &pos->pos);
treewide: Avoid offsetting NULL pointers. This is undefined behavior and was reported by UB Sanitizer: lib/meta-flow.c:3445:16: runtime error: member access within null pointer of type 'struct vl_mf_field' 0 0x6aad0f in mf_get_vl_mff lib/meta-flow.c:3445 1 0x6d96d7 in mf_from_oxm_header lib/nx-match.c:260 2 0x6d9e2e in nx_pull_header__ lib/nx-match.c:341 3 0x6daafa in nx_pull_header lib/nx-match.c:488 4 0x6abcb6 in mf_vl_mff_nx_pull_header lib/meta-flow.c:3605 5 0x73b9be in decode_NXAST_RAW_REG_MOVE lib/ofp-actions.c:2652 6 0x764ccd in ofpact_decode lib/ofp-actions.inc2:4681 [...] lib/sset.c:315:12: runtime error: applying zero offset to null pointer 0 0xcc2e6a in sset_at_position lib/sset.c:315:12 1 0x5734b3 in port_dump_next ofproto/ofproto-dpif.c:4083:20 [...] lib/ovsdb-data.c:2194:56: runtime error: applying zero offset to null pointer 0 0x5e9530 in ovsdb_datum_added_removed lib/ovsdb-data.c:2194:56 1 0x4d6258 in update_row_ref_count ovsdb/transaction.c:335:17 2 0x4c360b in for_each_txn_row ovsdb/transaction.c:1572:33 [...] lib/ofpbuf.c:440:30: runtime error: applying zero offset to null pointer 0 0x75066d in ofpbuf_push_uninit lib/ofpbuf.c:440 1 0x46ac8a in ovnacts_parse lib/actions.c:4190 2 0x46ad91 in ovnacts_parse_string lib/actions.c:4208 3 0x4106d1 in test_parse_actions tests/test-ovn.c:1324 [...] lib/ofp-actions.c:3205:22: runtime error: applying non-zero offset 2 to null pointer 0 0x6e1641 in set_field_split_str lib/ofp-actions.c:3205:22 [...] lib/tnl-ports.c:74:12: runtime error: applying zero offset to null pointer 0 0xceffe7 in tnl_port_cast lib/tnl-ports.c:74:12 1 0xcf14c3 in map_insert lib/tnl-ports.c:116:13 [...] ofproto/ofproto.c:8905:16: runtime error: applying zero offset to null pointer 0 0x556795 in eviction_group_hash_rule ofproto/ofproto.c:8905:16 1 0x503f8d in eviction_group_add_rule ofproto/ofproto.c:9022:42 [...] Also, it's valid to have an empty ofpact list and we should be able to try to iterate through it. UB Sanitizer report: include/openvswitch/ofp-actions.h:222:12: runtime error: applying zero offset to null pointer 0 0x665d69 in ofpact_end ./include/openvswitch/ofp-actions.h:222:12 1 0x66b2cf in ofpacts_put_openflow_actions lib/ofp-actions.c:8861:5 2 0x6ffdd1 in ofputil_encode_flow_mod lib/ofp-flow.c:447:9 [...] Signed-off-by: Dumitru Ceara <dceara@redhat.com> Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2022-04-11 13:37:50 +02:00
return hmap_node
? SSET_NODE_FROM_HMAP_NODE(hmap_node)
: NULL;
}
/* Replaces 'a' by the intersection of 'a' and 'b'. That is, removes from 'a'
* all of the strings that are not also in 'b'. */
void
sset_intersect(struct sset *a, const struct sset *b)
{
const char *name;
SSET_FOR_EACH_SAFE (name, a) {
if (!sset_contains(b, name)) {
sset_delete(a, SSET_NODE_FROM_NAME(name));
}
}
}
/* Returns a null-terminated array of pointers to the strings in 'set', in no
* particular order. The caller must free the returned array when it is no
* longer needed, but the strings in the array belong to 'set' and thus must
* not be modified or freed. */
const char **
sset_array(const struct sset *set)
{
size_t n = sset_count(set);
const char **array;
const char *s;
size_t i;
array = xmalloc(sizeof *array * (n + 1));
i = 0;
SSET_FOR_EACH (s, set) {
array[i++] = s;
}
ovs_assert(i == n);
array[n] = NULL;
return array;
}
static int
compare_string_pointers(const void *a_, const void *b_)
{
const char *const *a = a_;
const char *const *b = b_;
return strcmp(*a, *b);
}
/* Returns a null-terminated array of pointers to the strings in 'set', sorted
* alphabetically. The caller must free the returned array when it is no
* longer needed, but the strings in the array belong to 'set' and thus must
* not be modified or freed. */
const char **
sset_sort(const struct sset *set)
{
const char **array = sset_array(set);
qsort(array, sset_count(set), sizeof *array, compare_string_pointers);
return array;
}