mirror of
https://github.com/openvswitch/ovs
synced 2025-08-22 01:51:26 +00:00
packets: Fix typo in reserved multicast Ethernet addresses.
The reserved multicast Ethernet addresses begin with 01:80:c2, not 01:08:c2. Reported-by: Padmanabhan Krishnan <kprad1@yahoo.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
This commit is contained in:
parent
ec9f40dce1
commit
f0ac9da996
1
AUTHORS
1
AUTHORS
@ -178,6 +178,7 @@ Min Chen ustcer.tonychan@gmail.com
|
||||
Murphy McCauley murphy.mccauley@gmail.com
|
||||
Mikael Doverhag mdoverhag@nicira.com
|
||||
Niklas Andersson nandersson@nicira.com
|
||||
Padmanabhan Krishnan kprad1@yahoo.com
|
||||
Pankaj Thakkar thakkar@nicira.com
|
||||
Paul Ingram paul@nicira.com
|
||||
Paulo Cravero pcravero@as2594.net
|
||||
|
@ -59,22 +59,22 @@ eth_addr_is_reserved(const uint8_t ea[ETH_ADDR_LEN])
|
||||
|
||||
static struct eth_addr_node nodes[] = {
|
||||
/* STP, IEEE pause frames, and other reserved protocols. */
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c2000000ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c2000001ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c2000002ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c2000003ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c2000004ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c2000005ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c2000006ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c2000007ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c2000008ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c2000009ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c200000aULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c200000bULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c200000cULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c200000dULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c200000eULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0108c200000fULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c2000000ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c2000001ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c2000002ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c2000003ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c2000004ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c2000005ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c2000006ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c2000007ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c2000008ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c2000009ULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c200000aULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c200000bULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c200000cULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c200000dULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c200000eULL },
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x0180c200000fULL },
|
||||
|
||||
/* Extreme protocols. */
|
||||
{ HMAP_NODE_NULL_INITIALIZER, 0x00e02b000000ULL }, /* EDP. */
|
||||
|
@ -253,7 +253,7 @@ A switch should also not forward IEEE 802.1D Spanning Tree Protocol
|
||||
packets with reserved multicast protocols:
|
||||
|
||||
ovs-ofctl add-flow br0 \
|
||||
"table=0, dl_dst=01:08:c2:00:00:00/ff:ff:ff:ff:ff:f0, actions=drop"
|
||||
"table=0, dl_dst=01:80:c2:00:00:00/ff:ff:ff:ff:ff:f0, actions=drop"
|
||||
|
||||
We could add flows to drop other protocols, but these demonstrate the
|
||||
pattern.
|
||||
@ -287,12 +287,12 @@ such a flow would be treated as it goes through the switch.
|
||||
|
||||
Try this command:
|
||||
|
||||
ovs-appctl ofproto/trace br0 in_port=1,dl_dst=01:08:c2:00:00:05
|
||||
ovs-appctl ofproto/trace br0 in_port=1,dl_dst=01:80:c2:00:00:05
|
||||
|
||||
The output should look something like this:
|
||||
|
||||
Flow: metadata=0,in_port=1,vlan_tci=0x0000,dl_src=00:00:00:00:00:00,dl_dst=01:08:c2:00:00:05,dl_type=0x0000
|
||||
Rule: table=0 cookie=0 dl_dst=01:08:c2:00:00:00/ff:ff:ff:ff:ff:f0
|
||||
Flow: metadata=0,in_port=1,vlan_tci=0x0000,dl_src=00:00:00:00:00:00,dl_dst=01:80:c2:00:00:05,dl_type=0x0000
|
||||
Rule: table=0 cookie=0 dl_dst=01:80:c2:00:00:00/ff:ff:ff:ff:ff:f0
|
||||
OpenFlow actions=drop
|
||||
|
||||
Final flow: unchanged
|
||||
@ -315,11 +315,11 @@ interesting here.
|
||||
|
||||
Try another command:
|
||||
|
||||
ovs-appctl ofproto/trace br0 in_port=1,dl_dst=01:08:c2:00:00:10
|
||||
ovs-appctl ofproto/trace br0 in_port=1,dl_dst=01:80:c2:00:00:10
|
||||
|
||||
The output should be:
|
||||
|
||||
Flow: metadata=0,in_port=1,vlan_tci=0x0000,dl_src=00:00:00:00:00:00,dl_dst=01:08:c2:00:00:10,dl_type=0x0000
|
||||
Flow: metadata=0,in_port=1,vlan_tci=0x0000,dl_src=00:00:00:00:00:00,dl_dst=01:80:c2:00:00:10,dl_type=0x0000
|
||||
Rule: table=0 cookie=0 priority=0
|
||||
OpenFlow actions=resubmit(,1)
|
||||
|
||||
|
@ -4,6 +4,6 @@ ovs-ofctl add-flow br0 \
|
||||
"table=0, dl_src=01:00:00:00:00:00/01:00:00:00:00:00, actions=drop"
|
||||
|
||||
ovs-ofctl add-flow br0 \
|
||||
"table=0, dl_dst=01:08:c2:00:00:00/ff:ff:ff:ff:ff:f0, actions=drop"
|
||||
"table=0, dl_dst=01:80:c2:00:00:00/ff:ff:ff:ff:ff:f0, actions=drop"
|
||||
|
||||
ovs-ofctl add-flow br0 "table=0, priority=0, actions=resubmit(,1)"
|
||||
|
Loading…
x
Reference in New Issue
Block a user