mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

reportdesign: Use NC_ to create a TranslateId

Browse Source 
I don't see any reason for handling `RID_STR_EXPLANATION`
differently than all other translatable strings here.

Change-Id: Ica678557124f4daf48c3759fe3640fe95a2bc8ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173810
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This commit is contained in:
Michael Weghorn
2024-09-23 10:25:53 +02:00
parent d12c622da8
commit 249d37a8c4
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
reportdesign/inc/strings.hrc
View File

@@ -64,7 +64,7 @@
#define RID_STR_TYPE NC_("RID_STR_TYPE", "Data Field Type")
#define RID_STR_MASTERFIELDS NC_("RID_STR_MASTERFIELDS", "Link master fields")
#define RID_STR_DETAILFIELDS NC_("RID_STR_DETAILFIELDS", "Link slave fields")
#define RID_STR_EXPLANATION ("Charts can be used to display detailed data about the current record of the report. To do this, you can specify which columns in the chart match which columns in the report.")
#define RID_STR_EXPLANATION NC_("RID_STR_EXPLANATION", "Charts can be used to display detailed data about the current record of the report. To do this, you can specify which columns in the chart match which columns in the report.")
#define RID_STR_DETAILLABEL NC_("RID_STR_DETAILLABEL", "Chart")
#define RID_STR_MASTERLABEL NC_("RID_STR_MASTERLABEL", "Report")
#define RID_STR_PREVIEW_COUNT NC_("RID_STR_PREVIEW_COUNT", "Preview Row(s)")

2
reportdesign/source/ui/inspection/DataProviderHandler.cxx
View File

@@ -470,7 +470,7 @@ bool DataProviderHandler::impl_dialogLinkedFields_nothrow( ::osl::ClearableMutex
{"ParentWindow", m_xContext->getValueByName(u"DialogParentWindow"_ustr)},
{"Detail", uno::Any(m_xDataProvider)},
{"Master", uno::Any(m_xReportComponent->getSection()->getReportDefinition())},
{"Explanation", uno::Any(RptResId(TranslateId(nullptr, RID_STR_EXPLANATION)))},
{"Explanation", uno::Any(RptResId(RID_STR_EXPLANATION))},
{"DetailLabel", uno::Any(RptResId(RID_STR_DETAILLABEL))},
{"MasterLabel", uno::Any(RptResId(RID_STR_MASTERLABEL))},
}));