410563 Commits

Author SHA1 Message Date
Noel Grandin
3964408f7f loplugin:constparams in sdext
Change-Id: Ia5d2c00b02bf1758f7502065dd109f0f54fda2d3
Reviewed-on: https://gerrit.libreoffice.org/40124
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-18 14:59:47 +02:00
Andrea Gelmini
e56596e009 Fix typos
Change-Id: If6023dfa1d90f79185197622a738373a189ea6af
Reviewed-on: https://gerrit.libreoffice.org/40118
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-18 14:47:19 +02:00
Stephan Bergmann
098b685e90 No reason to silently misbehave when these UNO services are missing
...which e.g. made it unnecessarily hard to track down
7a23668e4f4e235c7a4e1c99e38506bd9c874be8 "Fix CppunitTest_cppcanvas_emfplus"

Change-Id: I2f537fabb067b77e82b900bd2cba30fd65c275aa
2017-07-18 14:22:54 +02:00
Eike Rathke
6959aff406 Address b0210c34dcaa5fc44956078ffa1dfe734d379224 nitpicks, tdf#43157 follow-up
Change-Id: I3c70225f4d19ea85a54026e8eb78ba729acd6dfd
2017-07-18 13:30:16 +02:00
Noel Grandin
41dc56df37 loplugin:constparams codemaker,idl,idlc
Change-Id: Ic72b7525cfbfbd3c5afb12fe9ea814176e6c8c9d
Reviewed-on: https://gerrit.libreoffice.org/40126
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-18 13:27:45 +02:00
Noel Grandin
50985d9b60 loplugin:constparams in package
Change-Id: I78386422f90f860647c844666548cd63e630b9a7
Reviewed-on: https://gerrit.libreoffice.org/40125
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-18 13:26:39 +02:00
Bernhard Widl
b0210c34dc fdo#43157 convert OSL_ASSERT to assert in sc/source/filter
Change-Id: I3d6d3da69ed7539dacf7eaf82fa7633f85619b39
Reviewed-on: https://gerrit.libreoffice.org/39366
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-18 13:24:51 +02:00
Mohammed Abdul Azeem
42c8000e68 Moving legacy contexts to FastContexts:
ScXMLNullDateContext
ScXMLIterationContext
ScXMLContentValidationContext
ScXMLHelpMessageContext
ScXMLErrorMessageContext
ScXMLErrorMacroContext

Change-Id: Ic2a4f038891aefbb94b1d9ada96da7c139c6c9fe
Reviewed-on: https://gerrit.libreoffice.org/40012
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-18 13:03:33 +02:00
Caolán McNamara
ce00985e24 fix oss-fuzz build
Change-Id: Ia279c7726f1bbf9cdfb6bdc481c884d56e9206c0
2017-07-18 11:55:21 +01:00
Samuel Mehrbrodt
229c217791 We no longer patch libxmlsec for this
Change-Id: I0e817499e80d2b7292833f5e734974b05ef579b6
Reviewed-on: https://gerrit.libreoffice.org/40041
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-18 12:17:56 +02:00
Miklos Vajna
c6d2e7d779 vcl pdf tokenizer: indentation fixes
These files had a consistent style before, let's keep them that way.

Change-Id: I32cf4ae61d0fac37df5e5412ae9cf3e2b3c92d17
2017-07-18 11:52:34 +02:00
Varun Dhall
315b6afc90 Partially revert c1723a3b6
The loop behavior was changed by the original commit
instead of starting from 1 it started from 0 due to which
it ends up saving Default Style and missed an important custom style

Change-Id: I4853b70fbb6a24c9ccbd0b5713c6dbe4215830a6
Reviewed-on: https://gerrit.libreoffice.org/40093
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2017-07-18 11:48:12 +02:00
Szymon Kłos
00b506ff03 Embedded documents: show title in menu entries
Change-Id: I478d81798e6f1e2d96e570cb6788a438c6a0be62
Reviewed-on: https://gerrit.libreoffice.org/40079
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-07-18 11:27:46 +02:00
Noel Grandin
c932e26138 loplugin:constparams in toolkit,ucb,xmlhelp
Change-Id: I2287bf468aae5008e25aa8b1bc0b63cff7bb1bf1
Reviewed-on: https://gerrit.libreoffice.org/40117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-18 11:13:05 +02:00
brainbreaker
e530689ef6 Clean up android specific template functions defined in std namespace
Change-Id: I2094ee8eec00587f166d96723a02eb5957dbf79b
Reviewed-on: https://gerrit.libreoffice.org/39890
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18 10:14:39 +02:00
Stanislav Horacek
6b0cace60b Updated core
Project: help  6cdd87dd0e6dc4c50bf31bd29dd340345885be42

Find & Replace dialog: options are under Find, not Replace

Change-Id: I8b2ebe6282beb9ac111ebd4688310c57b338626b
Reviewed-on: https://gerrit.libreoffice.org/40098
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-18 10:13:09 +02:00
Pranav Kant
ecba18e226 gtv: G_OPTION_FLAG_NONE is available since 2.42 only
Change-Id: Ic3aacb79a3e828e59fede437213f2b7298e49bc1
2017-07-18 13:32:30 +05:30
Stephan Bergmann
86d4a76b51 -Werror,-Wunused-private-field
Change-Id: Idd356214b553eadf5030115fc60a526e4428b1bb
2017-07-18 10:00:32 +02:00
Noel Grandin
72f36adb93 loplugin:constparams in vcl
Change-Id: I36afe2107e07ffb9b73c0b76be600e3e999a0fd4
Reviewed-on: https://gerrit.libreoffice.org/40116
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-18 09:57:26 +02:00
Luke Deller
bff8cd3d52 tdf#109080 First page header/footer ODF (1/2)
The proposal to add <style:header-first> / <style:footer-first>
to the ODF standard has not yet been accepted, so meanwhile we
should be using an extension namespace for these elements.

This first commit (intended for backport) adds support for reading
<loext:header-first> / <loext:footer-first>

Change-Id: I616b6a0acaead9d767ae7d119e539b865f3a6774
Reviewed-on: https://gerrit.libreoffice.org/39863
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18 09:50:17 +02:00
Miklos Vajna
ac3c24bec9 connectivity writer driver: add PreparedStatement implementation
Gets rid of the stub warnings in OWriterConnection::prepareStatement().

Change-Id: I05db81898d8117578130e660932608fcc927edf0
Reviewed-on: https://gerrit.libreoffice.org/40092
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18 09:09:20 +02:00
Miklos Vajna
a11ddfdcf3 connectivity writer driver: add Columns implementation
Gets rid of the stub warnings in OWriterTable::refreshColumns().

Change-Id: I2dd43777a00a6958548e3dc8119c5cb825ebb02e
Reviewed-on: https://gerrit.libreoffice.org/40091
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18 09:08:26 +02:00
Miklos Vajna
bec2da98c7 connectivity writer driver: add Table implementation
Gets rid of the stub warnings in OWriterTables::createObject().

Change-Id: I161e498d5704bb9a3d9f423ce1823664d8249c86
Reviewed-on: https://gerrit.libreoffice.org/40090
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18 09:07:16 +02:00
Miklos Vajna
60020f6133 connectivity writer driver: add Tables implementation
But leave OWriterTables::createObject() as a stub for now.

Change-Id: I8a05d698e565cefded1286decdfbdfece8c2237b
2017-07-18 09:03:39 +02:00
Miklos Vajna
6fb3e3a9c1 connectivity writer driver: add Catalog implementation
But leave OWriterCatalog::refreshTables() as a stub for now.

Change-Id: Ica5eb9d45937c826501b666d565019e2e04df6bf
Reviewed-on: https://gerrit.libreoffice.org/40071
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18 09:01:40 +02:00
Miklos Vajna
138269391a tdf#108955 RTF import: fix missing paragraph background
See commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305:
writerfilter RTF import: override style properties like Word,
2014-06-17) for the context.

Here the problem was that details of the paragraph background were
removed during the style deduplication, but not the paragraph background
sprm itself. That was interpreted (correctly) by dmapper as "no
background", rather than "inherit from style".

Change-Id: I88904cbd0a3c7686ede1f98d06df8fc875978afc
Reviewed-on: https://gerrit.libreoffice.org/40099
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-07-18 09:00:50 +02:00
Stephan Bergmann
8fc843472e More avoidance of invoking gdb with LD_LIBRARY_PATH set
...similar to 785eb0ed14cde731c2795f68f004f0b811cfe387 "gbuild: try to avoid
invoking gdb with LD_LIBRARY_PATH set", this time for DEBUGCPPUNIT=TRUE in
addition to CPPUNITTRACE="gdb --args"

Change-Id: I3e2cc5abf76947dc4c7b4d6caa3fd5720720e050
2017-07-18 08:27:48 +02:00
Noel Grandin
e669f70613 loplugin:constparams in i18npool,opencl,svl
Change-Id: I23368c3ce6d29c7b2e758e209e5a8315e82a2818
Reviewed-on: https://gerrit.libreoffice.org/40051
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-18 08:19:59 +02:00
Noel Grandin
3ccaa4d9e9 loplugin:constparams in scaddins,hwpfilter
Change-Id: I91b3559b9c3f5d8837d182cf9406fad9aeee78b3
Reviewed-on: https://gerrit.libreoffice.org/40049
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-18 08:19:46 +02:00
Chris Sherlock
871f1f727f Followup to final followup 647382f52351a75 of my followup
Change-Id: I0ee075cadb26eb0ceedec1dd047fc157f3929dad
2017-07-18 12:32:27 +10:00
Chris Sherlock
7a743b472d osl: update named pipe handle test names
Change-Id: I7c4da48b372c70cea51d8318aba384b9c605c5e1
Reviewed-on: https://gerrit.libreoffice.org/40113
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-07-18 00:45:35 +02:00
Chris Sherlock
013a87be06 osl: pipe test remove unnecessary comment cruft
Change-Id: I3bbf7cd131804e6788f91ec7418644cb73c62458
Reviewed-on: https://gerrit.libreoffice.org/40107
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-07-18 00:43:52 +02:00
Samuel Mehrbrodt
a83888e775 Fix warning for loext namespace
Define the namespace near the element that's using it

Change-Id: If0a135a331d4f67ef2dfe4981e93110e7a1a787a
Reviewed-on: https://gerrit.libreoffice.org/40084
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-17 22:33:39 +02:00
Andrea Gelmini
72b48cb904 Remove duplicated includes
Change-Id: Iba098ff1c96fb6f830e136102f687b345fb958ef
Reviewed-on: https://gerrit.libreoffice.org/39981
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-17 22:28:12 +02:00
Szymon Kłos
b2207e165d Embedded documents: don't open in web view mode
Change-Id: I621d4ba4223c1b389acdb63bb6f8f10ef3f3ba48
Reviewed-on: https://gerrit.libreoffice.org/40076
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-07-17 22:15:26 +02:00
Paul Trojahn
30907c0bb7 tdf#109067 Fix default value of rotWithShape
According to the OOXML standard the default value is true, so for
the export of gradients and blips it has to be set explicitly to
false.

Change-Id: I06f6f2a00fca88ec79e2eb956c3c780f037a9d1e
Reviewed-on: https://gerrit.libreoffice.org/39973
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-17 22:10:09 +02:00
Eike Rathke
21394b0847 Defer also loading of the English CalendarWrapper, tdf#109045 follow-up
Always constructing the en-US CalendarWrapper defeats the original intention
that not for every construction of SvNumberFormatter a calendar is needed, plus
if no en-US is requested constructing such calendar is just wasted.

Since

	commit 2a22696546ace75c38a72ad13f7383aedd00e06a
	Date:   Mon Jul 10 15:56:32 2017 +0200

		tdf#109045: store en calendar separately in OnDemandCalendarWrapper

Change-Id: I06e13754f03fc1fe4fbf48b76ccb82c917606480
2017-07-17 22:01:42 +02:00
Chris Sherlock
9af8964dd2 RTL_UNICODETOTEXT_INFO_{DEST|SCR}BUFFERTOSMALL should use TOO, not TO
I have kept the old mispelled constant for backwards compatibility

Change-Id: I128a2eec76d00cc5ef058cd6a0c35a7474d2411e
Reviewed-on: https://gerrit.libreoffice.org/39995
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-07-17 21:47:38 +02:00
Chris Sherlock
2cbd412168 cppu: remove unnecessary LOG_LIFECYCLE_* macros
Change-Id: I0f19cf7045e6ff2906404a73ce710e42800c0a72
Reviewed-on: https://gerrit.libreoffice.org/39994
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-07-17 21:46:35 +02:00
Samuel Mehrbrodt
fab7288516 This should be a namespace, not an attribute "namespace"
Change-Id: I159db32662679a3194edf942fa6672370e2b8587
Reviewed-on: https://gerrit.libreoffice.org/40072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-17 20:29:29 +02:00
Eike Rathke
7232980be6 Resolves: tdf#104186 spaces between function name and ( not allowed in OOXML
Change-Id: I6f6fcdab24a426d0f62052fa2d31f4098d1d893a
2017-07-17 20:13:38 +02:00
Johnny_M
2b530e4f3f Translate randomly found German comments
Change-Id: I7db515e04d3845c3ec51c7f88fe51bcafddd5268
Reviewed-on: https://gerrit.libreoffice.org/39987
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-17 19:28:56 +02:00
Rene Engelhard
77d6bb6908 use ifeq "$(SDK_AUTO_DEPLOYMENT)" "YES"
... instead of ifneq "$(SDK_AUTO_DEPLOYMENT)" "", as the variable is = NO
if disabled

Change-Id: I7dd2d165235f5cb7e55a8fed628ada71b04c7881
2017-07-17 19:20:56 +02:00
Andrea Gelmini
be604957ec Fix typos
Change-Id: I0fec2abc1bed9c0cfcd78d1b0f6daebc335831be
Reviewed-on: https://gerrit.libreoffice.org/39982
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-17 19:17:46 +02:00
Andrea Gelmini
26b52972a8 Fix typos
Change-Id: I9d2c641b485c32ddccf0bfaaed1d0796572d1d33
Reviewed-on: https://gerrit.libreoffice.org/39477
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-07-17 19:15:00 +02:00
Szymon Kłos
e16304c46f Embedded obj: resize to avoid rendering issue
Force resize, before sidebar wasn't rendered correctly.

Change-Id: I0aeec50751a165bf4ab1aeefeda079ff97feb990
Reviewed-on: https://gerrit.libreoffice.org/40065
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-07-17 19:14:31 +02:00
Katarina Behrens
53be53b35e gpg4libre: Import public key payload if verification result != valid
it is essential to look closer at the results of verification (code
doing that was removed by commit bdbebda1d80f538f946b14042) to be
able to proceed with importing public key payload from the file if
needed

I've also killed one more instance of xmlStrlen being used on binary
data

Change-Id: I8cd45fe963c8dde91727471ddbebe6943374a121
Reviewed-on: https://gerrit.libreoffice.org/40066
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-17 18:10:57 +02:00
Miklos Vajna
d7ac239793 connectivity writer driver: initial DatabaseMetaData implementation
With this the list of tables is visible in Data Sources.

Change-Id: I7ee4955c54a76c57f854dba19fd1a6a8ee606089
Reviewed-on: https://gerrit.libreoffice.org/40056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-17 17:31:53 +02:00
Stephan Bergmann
ddb02ccb8a loplugin:unnecessaryparen: xmlsecurity (clang-cl)
Change-Id: Iaef0f4dda4ea4cb2d3bb67d9007873c89b9aa5c5
2017-07-17 17:29:06 +02:00
Stephan Bergmann
c88cd3f0a5 loplugin:unnecessaryparen: winaccessibility (clang-cl)
Change-Id: I9d83d16adbccd1dc29ea23dfa012a349c74150a3
2017-07-17 17:28:35 +02:00