Commit Graph

402057 Commits

Author SHA1 Message Date
Noel Grandin
e8b49f0907 new loplugin: useuniqueptr: vcl
Change-Id: Idcbc8655108ff57c06c33bbcabd652387bf3c4ec
Reviewed-on: https://gerrit.libreoffice.org/32948
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13 06:49:23 +00:00
Jochen Nitschke
5e0e27e758 tdf#48140 replace CellRangeAddress in xlsx import (14)
Change-Id: Ie322489bd11d2a14810fec87f83ce04c652bea43
Reviewed-on: https://gerrit.libreoffice.org/33002
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-12 23:35:14 +00:00
Michael Stahl
983ac87793 tdf#105188 sd: fix shutdown crash after accessing master pages
The problem here is that the destructor of SdModule does a lot of
things, including destroying an SdXImpressDocument that is referenced
from some SdGlobalResourceContainer.

This calls SD_MOD() to get the SdModule to get some resource, but at
that point SfxApplication::GetModule() returns null, because the
sequence was changed from first deleting the SfxModules, then clearing
the pointer in ~SfxModule to null, to unique_ptr::reset(), which, at
least in libstdc++, is implemented via std::swap, so it clears the
pointer before deleting the SfxModule.

It appears rather brittle to rely on such a subtle detail, so refactor
things so that SdGlobalResourceContainer is no longer owned by SdModule
but has its own pet XTerminationListener, which means it will be
destroyed earlier, while the SdModule is still fully alive.

(regression from f7b1cd6616)

Change-Id: I7f03f3adf431be8728ef3d65a078b536cb96f959
2017-01-13 00:27:15 +01:00
Khaled Hosny
349a3c0733 Drop unused struct members
Change-Id: I37aea9a2a40ab0e9642709de3b9e935bee9a6a53
Reviewed-on: https://gerrit.libreoffice.org/32986
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2017-01-12 22:29:19 +00:00
Michael Stahl
e19cdeaf7d sfx2: fix race in JunitTest UndoManager.checkBrokenScripts()
1) checkBrokenScripts(complex.sfx2.UndoManager)
java.lang.NullPointerException
    at complex.sfx2.UndoManager.impl_clickButton(UndoManager.java:432)
    at complex.sfx2.UndoManager.checkBrokenScripts(UndoManager.java:188)

impl_clickButton() gets the wrong accessible object and throws.

The .uno:SwitchControlDesignMode is dispatched async, so make sure
it's processesed before trying to click the button.

See UnoControl::getAccessibleContext() "in design mode, use a fallback".

This was running in "rr record --chaos".

Change-Id: Iee9f25c2fff56d32e6b579b5d44ee6df9870fd8b
2017-01-12 22:11:30 +01:00
Bartosz Kosiorek
5e223be210 tdf#50916 Use aCol.size() instead of MAXCOL to increase max number of column
Currently when we are increasing MAXCOL variable, the memory usage and
performance are increase dramatically. To resolve that, columns
needs to be created dynamically according to needs.
This patch replace hardcoded MAXCOL with aCol.size().
It is next step to make creation of columns dynamic.

Change-Id: Ic7b7a76863e063a607165629bdf82699eaa847b3
Reviewed-on: https://gerrit.libreoffice.org/32708
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-12 21:04:06 +00:00
Caolán McNamara
80e261cec7 ofz: this cluster of variables are unused
but lead to a fpe on an empty filter

Change-Id: Id76b365b5fcc866d214753dada80411fc33d2e5c
2017-01-12 20:58:25 +00:00
Caolán McNamara
1cd1b640f4 ofz: avoid config during fuzzing
Change-Id: Ia5fa7a9c3304483e69db31256b9ffb22bb152c62
2017-01-12 20:56:06 +00:00
Rene Engelhard
8f15fa63ce add -mlong-jump-table-offsets for m68k also for oox
Change-Id: Ibfba6c7c808ca5212884032c17546e95fa16353a
2017-01-12 19:02:06 +01:00
Alex McMurchy1917
03ec9c397c tdf#105071 MM no emails sent when using doc as mail body
The conditional statement exits if there is data to process and
continues if there is no data to process. Thus all records are lost.

This commit reverses this behaviour so that data is processed
by the rest of the Mail merge activities.

Change-Id: I4c92cbd7ca55be7842b07ad887813e417430ba4f
Reviewed-on: https://gerrit.libreoffice.org/32994
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-01-12 17:26:20 +00:00
Jochen Nitschke
58c5a9de2a tdf#48140 replace CellAddress in xlsx import (4)
Change-Id: I52d7a37dd106744052d714e66fd84895aeb0a9b8
Reviewed-on: https://gerrit.libreoffice.org/33001
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-12 17:09:35 +00:00
Caolán McNamara
2fd88ab1cb Resolves: tdf#101187 colossal page width wraps around if doubled
when trying to generate a reasonable upper bound clipping region

Change-Id: I53f8ea1bd6c52c88284e1f41369f83492d078b5d
2017-01-12 16:42:46 +00:00
Tomaž Vajngerl
00db9f5121 tdf#103225 make AreaTab box fill to content
Change-Id: I9900bab2bb4510352d191ee42c0fa83049d9cecc
Reviewed-on: https://gerrit.libreoffice.org/33006
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-12 16:42:29 +00:00
Mike Kaganski
6bc2c54711 tdf#104414: don't stop on exception from SwXFrame::setPosition
Change-Id: Ib6d4e398d546d6fe250b9c1efe099ae8eef2d580
Reviewed-on: https://gerrit.libreoffice.org/32978
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-12 15:48:25 +00:00
Caolán McNamara
1d7cf3f039 Resolves: tdf#104897 sort windows buttons into yes, no, cancel
and kde, for gnome/macosx use no, cancel, yes

Change-Id: I4aff39938c1c9f81b47934d8f1d9400c106781ad
2017-01-12 15:24:40 +00:00
Caolán McNamara
2d93108082 don't check every possible kde variant, startswith kde is good enough
Change-Id: I7fb9d22af32ad5bab2deedfc993e1ffaebd57111
2017-01-12 15:08:33 +00:00
Michael Stahl
7a75b39273 gbuild: make 3.81 doesn't currently work with gbuildtojson
There is some problem with the pattern rule in post_GbuildToJson.mk
being ignored, causing spurious
workdir/GbuildToJson/Library/lib*.exports files with bogus content to be
written; rather than trying to adapt that to 3.81 pattern rule
evaluation, just refuse to run with 3.81, which is obsolete anyway.

Change-Id: I492866464b309f8c475e34e8f311e42bf8736247
2017-01-12 15:46:03 +01:00
Stephan Bergmann
38d1c303e1 Adapt loplugin:overrideparam to recent Clang trunk change
Change-Id: Ia372e39bc7e51f290a6d631bf0b81fd75f4fdc1d
2017-01-12 15:19:22 +01:00
Caolán McNamara
ff30d20c1a a11y crash on accessing disposed TabControl during close of impress
Change-Id: I3064eb136ed3a6a32acd64bfb2f6fbe31595e1cf
2017-01-12 14:04:11 +00:00
Michael Stahl
0373db40fd gbuild: fix "make gbuildtojson" on Mac OS X
Fails because library has dep on GeneratedPackage_python3, so nerf the
dep like the others.

Change-Id: I050a0f50996ce4231eb966fb6b624908d2f1788c
2017-01-12 14:27:16 +01:00
Tor Lillqvist
69e0fa14ea Fix apparent mistake
Change-Id: I848c3e3229cc216dc1181893da32221b9d9f8274
2017-01-12 14:59:28 +02:00
Justin Luth
14d05c9b85 tdf#64588 - prevent loss of non-uniquely-named slide
Although the UI prevents someone from renaming slides
so that two have the same name, it is still possible to
have such non-uniquely named pages apparently.  Since drag/drop
uses the name to add a slide to the clipboard, it resulted
in duplicates of the first found instance of the slidename, and
loss of the similarly-named slides when they were dragged to
a new location.

Change-Id: I2986a7c6c3360162adf9430f645d0dfc73f1d4e2
Reviewed-on: https://gerrit.libreoffice.org/32481
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-12 12:58:38 +00:00
Caolán McNamara
ec6c0319a1 update symbols names to match current reality
Change-Id: Iba6dbec0ec1061e8953eed06a14632305bdb3e44
2017-01-12 12:25:39 +00:00
Caolán McNamara
1c364b96d3 add ppm/pbm fuzzer
Change-Id: I6f403570abcf50be4cf11f20ea52bb2a07367b2a
2017-01-12 12:25:39 +00:00
Caolán McNamara
5d98a54058 add met fuzzer
Change-Id: I061739db5e7913ef13d3b862b5dee9152734d473
2017-01-12 12:25:39 +00:00
Caolán McNamara
0f6d5638c7 add dxf fuzzer
Change-Id: Ibf3d42ef0e0b0698309e567a92d0c5c45cc2ef94
2017-01-12 12:25:39 +00:00
Stephan Bergmann
a3dfe938ef Allow CompilerTest_compilerplugins_clang to include css/uno/Reference.hxx
Change-Id: Ib35d8fcc41e1c49bfef01c980b25c051190cb753
Reviewed-on: https://gerrit.libreoffice.org/32990
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-12 11:55:11 +00:00
Douglas Mencken
77a0817cf4 make the include of OpenGLHelper.hxx not global here
surround it like in pieces of code which actually uses it

Change-Id: Iac993553455248a2d2f999f857b781dbdb37acf5
Reviewed-on: https://gerrit.libreoffice.org/32852
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-12 11:22:28 +00:00
Vitaliy Anderson
1c1747ac13 tdf#104668 remove the difference between MSO and LO text alignment
Change-Id: Id1964d87f6f4ec3dbcd617af2251a321c50ec428
Reviewed-on: https://gerrit.libreoffice.org/32213
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-12 11:20:32 +00:00
Caolán McNamara
7536791802 in extremis dump Ole10Native payload and launch system viewer on it
so embedded plain text documents/source code/etc in word documents can be viewed
by us under Linux

Change-Id: I19e19619070841fe097c70297adc2e8b96d1c581
2017-01-12 11:18:51 +00:00
Caolán McNamara
a70a62c013 silence coverity#1371305 Missing move assignment operator
Change-Id: I761e07d1583262d83074addbff4ca67b01640387
2017-01-12 11:18:50 +00:00
Tor Lillqvist
d2f5da9418 Update comment to match reality
Change-Id: I0b4ee6377aac984b7acf7085ac43cad3d088612d
2017-01-12 13:10:01 +02:00
Olivier
1120256f89 Updated core
Project: help  2550608f310dd5cba88967e2b1d7430d46bd1bcd

No need to explain errors after user mistake.

Change-Id: I986fcfffe790fe8cff3d209f514c5a34c7d28478
Reviewed-on: https://gerrit.libreoffice.org/32939
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-01-12 10:57:15 +00:00
Jean-Pierre Ledure
9e634331a7 Access2Base - Improve precision of query typing
Change-Id: I6c5246809cb533a2c69978008ea996392e2fbe6a
2017-01-12 11:40:49 +01:00
Jean-Pierre Ledure
e2a1e22288 Access2Base - Use Empty() builtin function
... i.o. uninitialized variable

Change-Id: I732705df11ea25c2b106d542f9e97f3f32cc9867
2017-01-12 11:40:49 +01:00
Jean-Pierre Ledure
de5222082f Access2Base - Recognize correctly formatted fields
New ImplementationName introduced in LO 5.1

Change-Id: Ifa181570575622aca27520397f2e88cbc9742d1e
2017-01-12 11:40:49 +01:00
Jean-Pierre Ledure
92608b8909 Access2Base - Addition of Module object
New Module Basic module
New AllModules() collection in Application module
Extension of regex to backward searches

Change-Id: Id58f3b29d08e9f0b73e192cfc0c2a99988e73fcf
2017-01-12 11:40:49 +01:00
Jean-Pierre Ledure
9017bcc76b Access2Base - Reorder functions in Database module
Change-Id: I62fb5d0722363fdcd7d464d0490b1f6e890221a4
2017-01-12 11:40:49 +01:00
Jean-Pierre Ledure
fa69125cb0 Access2Base - Review UtilProperty module
Insert dates and 2-dim arrays in property values
Export array or property values to string for file or database temporary storage
Reimport from string into array or property values
(for later use)

Change-Id: I7f2dc2ad6adde6249e68a6cb51b52e2a4dad79b7
2017-01-12 11:40:49 +01:00
Jean-Pierre Ledure
047d1ed3df Access2Base - Implement regex search
Based on XTextSearch UNO service
_CStr also refined

Change-Id: Ibeceeeb549511e575c6842e43e5a76c8308db1aa
2017-01-12 11:40:49 +01:00
Jean-Pierre Ledure
62e508c2a7 Access2Base - More accurate CStr function
Includes arrays, distinguishes integers and real numbers
Side effects in DebugPrint solved

Change-Id: Id84203cea1a93dcbc164f8661fcf2f57778b0df8
2017-01-12 11:40:49 +01:00
Jean-Pierre Ledure
53d261f2ff Access2Base - Avoid use of outdated routines
in getObject, getValue and setValue functions

Change-Id: I98ff54bf62cfb34218d1fdb43fb37ba21846b068
2017-01-12 11:40:49 +01:00
Jean-Pierre Ledure
076084a717 Access2Base - Implement On ... event properties
Event properties applied to form, subform, control events
Controls may belong to forms, subforms, dialogs, grid controls

Change-Id: Iaf33adcd03527ac938913675cf0930e317a17f97
2017-01-12 11:40:49 +01:00
Thorsten Behrens
e442b76667 package: fixup SAL_CALL removal
Change-Id: I3b688b660ef4374442b616cb5c8bb4cee9ef7cb7
2017-01-12 10:48:22 +01:00
Katarina Behrens
229d98e94a SafeModeDialog: set correct initial checkbox state
Change-Id: I3aa45ae4b02afd2ea8e1a5a427eb6f0f17219430
Reviewed-on: https://gerrit.libreoffice.org/32967
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-12 09:20:23 +00:00
David Tardon
fbbb4850dc upload libwps 0.4.5
Change-Id: Ifab6f95d22d0d335d68bb367dca12a92b864cdd9
2017-01-12 08:58:09 +01:00
Edmund Wong
a6931e8d00 No need for a separate variable. Just get the value directly from the dictionary.
Change-Id: Ic8a707ac78cf5ad3e225131ae23f1f1277f3ae7c
Reviewed-on: https://gerrit.libreoffice.org/31991
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-12 07:15:50 +00:00
Kohei Yoshida
14e65f7d2d These SAL_CALL can go as well...
Change-Id: I79aa4374126faaf9f782fb7ff0c12c171e7041b1
2017-01-11 21:55:06 -05:00
Kohei Yoshida
f7c9ecaac9 Use std::unique_ptr for the ZipFile instance.
Change-Id: Ifac7a9e29c8cf0afcf44a82db608ba3c48499ca1
2017-01-11 19:42:24 -05:00
Kohei Yoshida
e5dc4ab7a0 Not worth having this as a separate data member.
It is the same as the input stream instance, and it is only used in
one call site.

Change-Id: If52209420462aec7ec3dbc180e05f09603acaea1
2017-01-11 19:31:28 -05:00