Commit Graph

402057 Commits

Author SHA1 Message Date
Tor Lillqvist
a6216119be Always exit with error if codesign fails
That sanity check was added in
615fae2f67 but we lost it at some stage.

The codesigning script has a very confusing history, in part caused by
its use for two purposes, when building for the Mac App Store and when
building for a TDF style distribution on a dmg disk image. Those who
work with the former and those who work with the latter haven't
necessarily checked that it doesn't break for the other case. Sorry.

Change-Id: I79011302f60b1f6551328c8b80e00f5d3698504c
2017-01-12 01:56:07 +02:00
Tor Lillqvist
3e7e4df5a4 CodesignRules.plist was removed in 615fae2f67
Change-Id: Ibde5189ecf09ec8dfaf3223683c5480974084865
2017-01-12 01:35:26 +02:00
Jochen Nitschke
88f561204d tdf#48140 replace CellAddress in xlsx import (3)
Change-Id: Ie56cea7fdee7ff6c9e72880e56f9e31ce5f7e03b
Reviewed-on: https://gerrit.libreoffice.org/32970
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-11 23:08:28 +00:00
Jochen Nitschke
3400613075 tdf#48140 replace CellAddress in xlsx import (2)
Change-Id: I14bf283fe8a795944a08a4cde2fff3d670f6e3ed
Reviewed-on: https://gerrit.libreoffice.org/32969
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-11 23:07:10 +00:00
Michael Stahl
7d0e3b32de framework: call disposing from disposing, not notifyTermination
Don't rely on current implementation details of TerminateListener.

Change-Id: I7977c73669f0ab5afac1c93be620e7aeebfe68a2
2017-01-11 20:37:05 +01:00
Tor Lillqvist
9334de4f6d Don't suggest any "devel packages" on macOS
Installing random 3rd-party "devel packages" is exactly what we don't
want people to do when building on macOS. And anyway, there is no
reason to believe this particular check will ever fail (there even is
a comment that says "MacOS X has system MIT Kerberos 5 since 10.4"),
unless something is very wrong.

Change-Id: Ic880e59358c7c510de9db29e66dfeee7f4e85b4d
2017-01-11 19:57:29 +02:00
Tamás Bunth
38ce989b4f XBlob::getBytes expects 1-indexed position
There was also a wrong relation. Now blob resets its position.

Change-Id: I41caf7cdfa261cafa5b9e66c9523c7f15225bfd8
Reviewed-on: https://gerrit.libreoffice.org/32937
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-11 17:48:01 +00:00
Caolán McNamara
018beb3884 don't position cursor inside a utf-16 sequence
seen examining rhbz#1409011

insert three 0x2F940 in insert special character

click on end and press backspace and text was mangled
clise inside the 3 glyph sequence and press delete/backspace and more mangling

Change-Id: I5898e9272e7a90e8b9dabb0be65f493df7dcbaf9
2017-01-11 16:47:37 +00:00
David Tardon
d9d14d0a4c astyle
Change-Id: Iee24a1b7bc4ada389dfa5f0f39c9d06938ed1481
2017-01-11 17:35:35 +01:00
David Tardon
c2447d0b6a honor lib version in import tests again
Change-Id: Idf99aab4bc136ac4a8a07945001e4f34a34a0e17
2017-01-11 17:35:35 +01:00
Michael Stahl
aa1ee198b5 tdf#105182 sd: avoid iterating too far in SdOutliner::Initialize()
Considering the valid indexes are extended by "-1" for backwards
iterators and "size()" for forward iterators, it's obvious that a
not-yet-at-the-end-in-the-other-direction iterator can be incremented
once, but not necessarily twice.

Why this code even wants to increment it twice isn't obvious to me.

Change-Id: I578c8c6202049ebe6dbed41b8276a6bfa0566bbc
2017-01-11 17:27:52 +01:00
Caolán McNamara
4ff1b35890 fold ImplConstruct into ctors and reduce to necessary
ImplConstruct sets mnAnimationLoopCount, but is always followed by
ImplAssignGraphicData which overwrites it so we can omit that

ImplConstruct sets mnDataChangeTimeStamp, but is always
followed by ImplAssignGraphicData which always calls
ImplAfterDataChange which overwrites it so we can omit that

Change-Id: I2304dc1ea590071a83ca30768426f721c1bd259c
Reviewed-on: https://gerrit.libreoffice.org/32953
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-11 16:14:21 +00:00
Christian Lohmaier
05d509482c update credits
Change-Id: I7e32a57cf6941d36e0bbcfb447065c4b0d56f8c3
2017-01-11 17:11:38 +01:00
Stephan Bergmann
b820de995d Remove leftover code
Change-Id: I3f6e9ec0343074b506cb07b1ad5c9b3e1ef20b5e
2017-01-11 16:57:21 +01:00
Stephan Bergmann
584262fed1 loplugin:stringconstant: handle OStringBuffer::append
Change-Id: I283da52c0ee2b63c19e31e9a61ab24997c037a6a
2017-01-11 16:39:43 +01:00
Jochen Nitschke
e316c4f2a4 tdf#48140 replace CellAddress in xlsx import (1)
Change-Id: I14bd0d9d55a03f4cd33aaf131e66f859569f5b18
Reviewed-on: https://gerrit.libreoffice.org/32968
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-11 15:39:13 +00:00
Christian Lohmaier
b365d56ed9 update emoji autocorrect files from po-files
Change-Id: Ifc78ba8ae27544e8588c18cd5ba962a9fdeb1497
2017-01-11 15:58:42 +01:00
Kohei Yoshida
52b8739f5b Let's return std::unique_ptr<...> directly.
It's only used at one call site, which already uses
std::unique_ptr.

Change-Id: I5ff528ebc560bb6eb8783d20002cea40a451761e
Reviewed-on: https://gerrit.libreoffice.org/32946
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-01-11 14:48:32 +00:00
Kohei Yoshida
a544fd5fa2 Remove unnecessary UNO-ness from ZipFile class.
This class is only used inside package module, and totally private
to the module.

Change-Id: Ib00e7066c22a74c0b16c8d6ecf72b99ac42682dd
Reviewed-on: https://gerrit.libreoffice.org/32945
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-01-11 14:43:57 +00:00
Takeshi Abe
be7d0697b0 starmath: Kill unused forward declaration
Change-Id: I03f76aada322a7222795795d32553ae2425092c3
Reviewed-on: https://gerrit.libreoffice.org/32962
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-11 14:18:26 +00:00
Noel Grandin
549efd7f82 new loplugin: useuniqueptr: lotuswordpro
Change-Id: I1f9569cb5ca05faf12663b3df8508d10a8cd75e6
Reviewed-on: https://gerrit.libreoffice.org/32957
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-11 13:11:06 +00:00
Eike Rathke
28a0737f8c Resolves: tdf#105209 CHF currency symbol is CHF instead of SFr.
Change-Id: Ic216c7b901bf6da779e161f35e5143739267b066
2017-01-11 13:55:56 +01:00
Stephan Bergmann
33c81a4580 loplugin:externvar (clang-cl)
Change-Id: I6f4c294cb15a4426545d05be7b0a7f26f580563c
2017-01-11 13:42:42 +01:00
Stephan Bergmann
db5cfb790f loplugin:externvar (clang-cl)
Change-Id: I0f967f75dc41b3dc65790cf97bdac992033d1c92
2017-01-11 13:42:42 +01:00
Stephan Bergmann
556f1eab63 loplugin:externvar (clang-cl)
Change-Id: I9efdd5136fdf793e0075b91fcfae4fed42050109
2017-01-11 13:42:42 +01:00
Stephan Bergmann
b58b241f3a loplugin:externvar (clang-cl)
Change-Id: Iebf83ccfb9e7128fd328a548ce77cdee4ef7ca4b
2017-01-11 13:42:41 +01:00
Stephan Bergmann
a9d06182f8 loplugin:externvar (clang-cl)
Change-Id: I81877e46cf95dcc7de16b797fca33658036bf9e8
2017-01-11 13:42:41 +01:00
Stephan Bergmann
698bdcdb0c loplugin:externvar (clang-cl)
Change-Id: I29c40113f9248f9041dacc398416f39889f5ddf8
2017-01-11 13:42:41 +01:00
Stephan Bergmann
f2cb396c8d loplugin:externvar (clang-cl)
Change-Id: Ie2a96299d8d3cc9c1ccad7cfb8fbee05c6734148
2017-01-11 13:42:41 +01:00
Stephan Bergmann
6ec5717e06 loplugin:externvar (clang-cl)
Change-Id: I638199f1455bead71f0a03f15e4b6f418a0cd0e2
2017-01-11 13:42:40 +01:00
Stephan Bergmann
2597a2f1ad loplugin:externvar (clang-cl)
Change-Id: Ic7e4ba1ada97a0fff1ae6d209b22e372431cc6e7
2017-01-11 13:42:40 +01:00
Stephan Bergmann
691bc3e15d loplugin:externvar (clang-cl)
Change-Id: I034eeb9525bbb8fdc39e176a2433f1b3dfff566a
2017-01-11 13:42:40 +01:00
Stephan Bergmann
91dfb4712d loplugin:externvar (clang-cl)
Change-Id: I7219f2e720b7c1581c59cefe39e152c5aa20a8fe
2017-01-11 13:42:39 +01:00
Stephan Bergmann
f50fa59583 loplugin:externvar (clang-cl)
Change-Id: Ibbcb8b6dfaf1c979db2e7930c4f6c8475d693ac8
2017-01-11 13:42:39 +01:00
Stephan Bergmann
f22e5db80b loplugin:externvar (clang-cl)
Change-Id: Ied0ee5f637e83fe7819c68e3f4ea4634f21ac3f6
2017-01-11 13:42:39 +01:00
Abhilash Singh
acc939f6cb tdf#104807 Placeholder field doesn't resize
Change-Id: I55f1ff2be091ea5e8475e22abdf62aa5c0c435be
Reviewed-on: https://gerrit.libreoffice.org/32921
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-01-11 12:32:04 +00:00
pv2k
6a41cef3f9 tdf#103391: ask user whether to open online help
opens a dialog box from which user can choose to take online help or cancel it

Change-Id: I8c1278aab88d55901a65c38b15fcc8519360dc59
Reviewed-on: https://gerrit.libreoffice.org/31385
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-11 11:21:55 +00:00
Stephan Bergmann
618785dfd2 Some loplugin:conststringvar/stringconstant improvements
Change-Id: I73f694e6dedb84b3fb3b63ffb9dcda2481bc403c
2017-01-11 11:27:40 +01:00
Stephan Bergmann
f28939b9f9 Some loplugin:conststringvar/stringconstant improvements: connectivity
Change-Id: I8b026b61b8744e21584bc64d80a957aca08aae2b
2017-01-11 11:27:22 +01:00
Stephan Bergmann
8f37bcb51c Some loplugin:conststringvar/stringconstant improvements: dbaccess
Change-Id: I30fee1c51ff3e0b8e3e74b4293227a5bfbfe0837
2017-01-11 11:27:08 +01:00
Stephan Bergmann
3dbea89a72 Some loplugin:conststringvar/stringconstant improvements: forms
Change-Id: Iec2be8c9ddbdf8d5d8bc1054c20a0bd40707262a
2017-01-11 11:27:02 +01:00
Stephan Bergmann
44960f43f5 Some loplugin:conststringvar/stringconstant improvements: linguistic
Change-Id: Ic41c77c24f43503a7984bae3520948917ec6bb23
2017-01-11 11:26:56 +01:00
Stephan Bergmann
5e355dabcc Some loplugin:conststringvar/stringconstant improvements: sal
Change-Id: I8b5d81c2b51f846a24fd1f7f9cdd831f1ea54ea5
2017-01-11 11:26:49 +01:00
Stephan Bergmann
3c29d5a502 Some loplugin:conststringvar/stringconstant improvements: sc
Change-Id: Ie01088776c4339ec7d1fb5941c4e65d95aff8b1f
2017-01-11 11:26:45 +01:00
Stephan Bergmann
7533e58f7c Some loplugin:conststringvar/stringconstant improvements: sd
Change-Id: If44cce6e4c241f6a2203d73f6d191f270fb5ca5a
2017-01-11 11:26:42 +01:00
Stephan Bergmann
e838e360ff Some loplugin:conststringvar/stringconstant improvements: sdext
Change-Id: I47884eeb14a67b7e260835b8603d7b76c7ec018b
2017-01-11 11:26:38 +01:00
Stephan Bergmann
15e1a0bb4a Some loplugin:conststringvar/stringconstant improvements: sw
Change-Id: I5b9c3d2dac275659569141d4eae7b97e3aa397b8
2017-01-11 11:26:34 +01:00
Stephan Bergmann
7ca7e52bca Some loplugin:conststringvar/stringconstant improvements: vcl
Change-Id: I999549a840864060be4e80fe973ebb530202b807
2017-01-11 11:25:47 +01:00
Stephan Bergmann
15f84c9cd4 Some loplugin:conststringvar/stringconstant improvements: xmloff
Change-Id: I05e03936d9e5518fa7ba4d9c72d5b8e241e32526
2017-01-11 11:25:42 +01:00
Caolán McNamara
5088b20666 Resolves: rhbz#1408500 gtk3 toolbar borders too distinct vs native gtk3 ones
Change-Id: I7ce284d3e6f999e2ac08326dc40b060bf70d7d4b
2017-01-11 10:15:11 +00:00