402057 Commits

Author SHA1 Message Date
Caolán McNamara
44ffbca37c coverity#1398586 Uncaught exception
and

coverity#1398591 Uncaught exception

Change-Id: Id46cb66ea8e26af480234703cafd26ff7b7271f0
2017-01-14 11:14:03 +00:00
Xisco Fauli
5930cf8745 tdf#104158: Add uitest
Change-Id: If2391365e71df0e95dc1be177e3595a62e0d6eab
Reviewed-on: https://gerrit.libreoffice.org/33057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2017-01-14 09:30:30 +00:00
jan Iversen
9cb3b064e5 gbuild-to-ide cleanup GbuildParser
Removed .files replaced by
.modules[*]['targets']

Affected generators updated.

Change-Id: I4bf4cb5a23ba0b48b11adb1795c0a4f9dfbb0d3a
2017-01-14 10:02:28 +01:00
jan Iversen
b6e6d2d31d gbuild-to-ide added control of platforms.
The debug generator is extended to build IDE for all platforms,
these IDE will of course not be useable, but it gives a security
that the script does not break.

Removed target_by_location from GbuildParser, to simplify that
class.

Change-Id: Ie41ca3d156321041958213333b2d73c57ba918f9
2017-01-14 09:30:37 +01:00
Zdeněk Crhonek
bbaf57e0ba add BIN2DEC,BIN2HEX, BIN2OCT test case
Change-Id: I611ae5bbb65c5f717a22d3eb4e3d05fdf5cecb07
Reviewed-on: https://gerrit.libreoffice.org/33058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-14 07:07:34 +00:00
Zdeněk Crhonek
e65da0ea45 add T.DIST test case
Change-Id: Idc1966d2ca80fa403bc63feaa4cfcf36a8100dfd
Reviewed-on: https://gerrit.libreoffice.org/33005
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-14 06:27:18 +00:00
Justin Luth
9e7526044c tdf#105294 - only add spacing for the border being set
related to bug 41542 which now allows the space-to-contents value
even if the border is not visible.

For years, LO has been resetting the spacing to zero when a line
is diabled. Setting all border distances here was a mistake that
was never caught before, and the documents created because of
this oversight will likely cause some grief to bug 41542.

Change-Id: Id2708cf20600e29e97dc6c8d8b779894ad9c38d1
Reviewed-on: https://gerrit.libreoffice.org/33055
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-01-14 04:21:39 +00:00
Katarina Behrens
ec1afa55e8 SafeMode: Deactivate 'Restart in safe mode' when already in safe mode
Change-Id: I75f7024528190cf3732fb80063132ef0c6de3118
Reviewed-on: https://gerrit.libreoffice.org/33049
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-13 21:29:04 +00:00
Zdeněk Crhonek
2d6c7ebe83 add TDIST,T.TEST,T.DIST.2T test case
Change-Id: Ie5e3c72ef2f062032579ecd0ded780d385f0c06e
Reviewed-on: https://gerrit.libreoffice.org/33054
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-13 21:26:52 +00:00
Jochen Nitschke
1ad45ecbf1 tdf#105204 shellcheck
addressed issues in order of appearance:
warnings
 - prefer [..] && [..] (SC2166)
 - unused 'awkCMD' (SC2034)
 - typo currentFirstLIne -> currentFirstLine (SC2154)

recommendations
 - use $(..) instead of `..` (SC2006)
 - remove $ on arithmetic variable OPTIND (SC2004)
 - double quote to prevent globbing in $findArgs (SC2086)

Change-Id: I2d2b7aecac97b2e4e0df8ce556c85995d4ecf7cf
Reviewed-on: https://gerrit.libreoffice.org/33003
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-01-13 20:54:53 +00:00
Caolán McNamara
e81454861f acquire/release in ctor/dtor
Change-Id: I4cf6ba1ece0491bc7a83c4adf1e5c086c0fa3553
2017-01-13 20:48:00 +00:00
Takeshi Abe
1f30385e0a vcl: Fix memory leaks
Change-Id: Id2e1b945d17abeffd35828ffde6eba821de0cefe
Reviewed-on: https://gerrit.libreoffice.org/33047
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-13 20:09:50 +00:00
Noel Grandin
a076a062ce tdf# 105017 Crash when click a "New Theme..." in Gallery on detached SideBar
Change-Id: I6a3c44a0a08cf036776976d40c985889698c08ac
Reviewed-on: https://gerrit.libreoffice.org/33041
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13 18:24:11 +00:00
Noel Grandin
24fa5d0570 better fix for tdf#101563: Export to PDF creates huge PDF files
Change-Id: Idda6a5ac824090e620fc6577fc82d5c5f1234b7e
Reviewed-on: https://gerrit.libreoffice.org/33037
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13 18:22:58 +00:00
Caolán McNamara
9e3d5996b9 fix met leaks
Change-Id: Ic26d70cd967324432d0b5fbd7346cfee9f1d305e
2017-01-13 16:40:31 +00:00
Samuel Mehrbrodt
f86845b606 iOS bridge: Log function names, not string pointers
Change-Id: I5db7a014e671bbf4b4eca9fcbaba4fdc2363e0f5
Reviewed-on: https://gerrit.libreoffice.org/33053
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-13 15:47:12 +00:00
Caolán McNamara
7420e35090 guard against self-recursive GetBoundingBox
Change-Id: If33f0e5e326604bf731d6ad50644e3a0b24ccf51
2017-01-13 15:13:37 +00:00
Zdeněk Crhonek
a658c18161 add POISSON, POISSON.DIST test case
Change-Id: Ia7a8e135de0eba7de9951f653f5c4d5a6b2e91ca
Reviewed-on: https://gerrit.libreoffice.org/32840
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-13 14:49:35 +00:00
Zdeněk Crhonek
c3fc9ac6ef add BESSELI,BESSELJ,BESSELK,BESSELY test case
Change-Id: I306cb042cec122cf3bf63bd0eaea8e8bcdee5b57
Reviewed-on: https://gerrit.libreoffice.org/32848
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-13 14:39:59 +00:00
Samuel Mehrbrodt
08316e7b2f tdf#96011 Document is not focused when opening a second window
This reverts commit fa52e16b3fb1b8b051f8f64a52c126ba3cbf4d54.
2017-01-13 15:35:15 +01:00
Jean-Pierre Ledure
3107a5d0e9 Access2Base - Review size limits of VARCHAR fields
- Basic has no practical limit anymore for string variables
- LONGVARCHAR fields can vary a lot in size across RDBMS's (f.i. Sqlite < 64K)
This forces an overflow check when setting a field value and no check when getting it

Change-Id: I4c9629f63164fbbdb84497e7002fa3186d7c63b7
2017-01-13 15:28:06 +01:00
Caolán McNamara
15cee52b62 use the same number in alloc and memset
Change-Id: Ie532985e655d1dd383a1781422213cee0787bfae
2017-01-13 14:22:30 +00:00
Caolán McNamara
467e32348f coverity#1371198 Missing move assignment operator
Change-Id: I89a718a245ea36f33c47f8044280bf7e46c0f66a
2017-01-13 14:20:23 +00:00
Caolán McNamara
6bd96eda06 coverity#1371289 avoid the need for an assignment
Change-Id: Ia0efc427d9996eb8414821d07f7e760fb1b35246
2017-01-13 13:46:12 +00:00
Caolán McNamara
2eb035adf7 coverity#1371287 don't need to copy and then overwrite
Change-Id: Ica30e4bed463e8e42cbf54f4b81491149a8de8ab
2017-01-13 13:40:31 +00:00
Zdeněk Crhonek
24dd5bce3e add STEYX testcase
Change-Id: I9184dab8c0b7ef80055835ef962449a63761ae86
Reviewed-on: https://gerrit.libreoffice.org/32977
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-13 13:39:41 +00:00
Caolán McNamara
57779b5f3a avoid infinite loops in dxf rendering
Change-Id: Id2eb5540241f0792cde35c444fc2c0c5b7778353
2017-01-13 13:21:07 +00:00
Noel Grandin
cd8fdb46fd new loplugin: useuniqueptr: editeng
Change-Id: I6df65eab882780d996ee996b5fef8020186b6d98
Reviewed-on: https://gerrit.libreoffice.org/32958
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13 13:08:52 +00:00
Tomaž Vajngerl
e6d7d73752 tdf#105259 calculate sizes of all area tab pages on construction
When we open dialog that contains the area tab, we need to
calculate the size of area tab pages (that are triggered by
clicking on a button) and set the page area to the appropriate
combined size. Otherwise we don't account for the needed space
correctly and some page will be squished or have overlapping
controls.

This change creates all pages at dialog construction, gets
all the optimal sizes and sets the size of the page container box
to the combined (minimal) size.

Change-Id: Ie04a121810b96973f6e4502a52af675b2baacf25
Reviewed-on: https://gerrit.libreoffice.org/33040
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-13 13:05:31 +00:00
Caolán McNamara
fa44327ed7 don't build the internal hsqldb and rhino for coverity checking
Change-Id: I7d269b1de29ecc1b0b9e6d58e316d5084e2fdcb6
2017-01-13 13:03:45 +00:00
Jan-Marek Glogowski
66fd9738a5 Rename mail dispatcher members
Makes the members conform with most LO variable naming,

This especially switches Active <=> Running in the member names.

"Running" is normally referred to as the thread state, while it
exists (also look into the osl::Thread API) and now active is the
state, when messages are processed, controlled by the start() and
stop() functions.

Change-Id: I3b8437d4ff24731348272a84720ff81fdea90db7
2017-01-13 14:00:57 +01:00
Caolán McNamara
ebf541f7c5 refactor this to open the display just once
and use the https://wiki.gnome.org/HowDoI/HiDpi
HiDPI detection rules.

all of this does nothing in practice, cause there is
no hidpi splashscreen image

Change-Id: I609faab0f207d71fd4a17bb54ef688bdd623eaea
2017-01-13 12:45:22 +00:00
Abhilash Singh
f424c8f053 tdf#90794 Fix the Linux HiDPI start screen
Change-Id: I2553cf69d6968865dc6011c73a0d2c0e7519b7a8
Reviewed-on: https://gerrit.libreoffice.org/32018
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-13 12:45:01 +00:00
Michael Stahl
8cc747ad51 solenv: don't run solenv_python test with make 3.81
see 7a75b39273de47190b7a1fa20e0bcaca6d089033

Change-Id: I575e5d5dc757cc054a49ae6596183f46373072f2
2017-01-13 13:23:13 +01:00
jan Iversen
057c526b88 gbuild-to-ide simplifications.
Simplified GbuildLinkTarget, removed functions.

Prepare to clean GbuildParser

Change-Id: I67bb3ba0279f615cb6c361818ade6fe629dca60c
2017-01-13 13:20:02 +01:00
Caolán McNamara
14d9b3519a ofz: ensure all not explicitly set indexes are zero
Change-Id: Idbe6ceeb61d3dfe26f281349181e7a60f7e59000
2017-01-13 11:42:46 +00:00
Noel Grandin
414ede0435 new loplugin: useuniqueptr: sc part 1
Change-Id: Ic96fd3b56b2063df0882168a7d02725d3c50515f
Reviewed-on: https://gerrit.libreoffice.org/32961
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13 11:39:21 +00:00
Caolán McNamara
d05f56b160 make this a tiny bit less unreadable
Change-Id: Ib8205e76f6d1d59ef06eba6e3365c0b4cad0ecaf
2017-01-13 11:33:42 +00:00
pv2k
7a275521a5 tdf#46552 fixing preview for bullets/numbering configuration
Change-Id: I959169428d4ed0498a2b78fc7a6ae0815e780648
Reviewed-on: https://gerrit.libreoffice.org/32816
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-13 11:05:54 +00:00
Samuel Mehrbrodt
561840f131 Remove --disable-gtk from Windows distro configs
Change-Id: I04e8bdfb3129a444008755f461da5ea7d97a7248
Reviewed-on: https://gerrit.libreoffice.org/33027
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-13 10:35:22 +00:00
Tomáš Chvátal
3f5584526f unixODBC changed soname to .2 so reflect it
we dlopen this library and thus we should be able to find it with any
soname, so far .1 and .2 seem to be used.

Also now the load order on linux is: .so.2 -> .so.1 -> .so

Change-Id: Idcd284fada1acdfe8dde46c3056c21b792777280
Reviewed-on: https://gerrit.libreoffice.org/32755
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-13 10:17:13 +00:00
Lionel Elie Mamane
afe64b6f0a jdbc clob character stream: return 1 when returning a single odd byte
if at that point nBytesToRead is 0, it may be that it was 1, but we
have read one byte from the buffer (m_buf). So in this case, return 1,
not 0 (which would signal EOF).

Change-Id: I229e53f1c38c80f709df244a3509caccd69c8ecf
Reviewed-on: https://gerrit.libreoffice.org/33029
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-13 10:12:13 +00:00
Mert Tumer
2e582ed403 tdf#101689 - Fix returning to first part of documents when resumed
Change-Id: I6d3a9354c702628e991c69176086efbbc28ddd74
Reviewed-on: https://gerrit.libreoffice.org/31753
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-13 09:59:54 +00:00
Noel Grandin
978ff8f55c inline InitGuard
since it is only used in one place

Change-Id: Ie541a255ddbe71105f6b58f02f372f4f45667d7a
2017-01-13 11:59:01 +02:00
Samuel Mehrbrodt
53a3e0cd48 Remove unused ini properties
Change-Id: Iea95f5975968f73e2e4aea34246c83f384341592
Reviewed-on: https://gerrit.libreoffice.org/33000
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-13 09:50:41 +00:00
Caolán McNamara
a409ec6932 unused variables
Change-Id: I77a3fc5478a068530d9de4cc6962fe439169567e
2017-01-13 09:18:52 +00:00
Rosemary Sebastian
95cf7fa25d tdf#105272: fix wrong namespace URL
regression from f1dcb8b3e2e01848d44dd1beb82cd4e6e68a2acd

Change-Id: I088894711617bd762bf4e9352ddf6d850a5cbe7b
2017-01-13 09:42:13 +01:00
Noel Grandin
a706bb06d5 new loplugin: useuniqueptr: sw part 1
Change-Id: I2bc55634e80976951ede768c97fbc4b7c4eda46c
Reviewed-on: https://gerrit.libreoffice.org/32963
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13 08:34:03 +00:00
Zdeněk Crhonek
8c73acd101 add PI, NA testcase
Change-Id: I1c72c1c81883b43a13cf583a98b2f2a261a60895
Reviewed-on: https://gerrit.libreoffice.org/32844
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-13 07:40:22 +00:00
Noel Grandin
d1787d6ac6 fix android build
Change-Id: I55ff31b40366398b6159ee7a99c75e393a05b36a
2017-01-13 09:25:40 +02:00