This first step only affects GTK3, later we will extend the support
to other platforms.
Note that these images are derived from the OSX PNG files, not the header-file
encoded data we currently use for gtk/gtk3.
Also rename the files to more useful names.
Change-Id: Ia13a3f2ac35b06672aff724f4cf5bdcd823f6342
Reviewed-on: https://gerrit.libreoffice.org/67528
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Destroy Qt5Frame after all events are received.
Update Qt5Object to use delayed destruction too.
Change-Id: I07c7251e097ad56f3616f325fdc394d00fec4f4f
Reviewed-on: https://gerrit.libreoffice.org/68316
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
This change fixes clipping and drawing issues
for document recovery window and other modal windows.
Change-Id: I005254d4cd2598f4f2d02ba7e7bbf7388affe36c
Reviewed-on: https://gerrit.libreoffice.org/68307
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
...as instead of the original shared document, a temporary copy (with a file URL
denoting a temporary directory, like <file:///tmp/lulmhoxl.tmp/0.ods>) is opened
in that case.
Change-Id: I415f5a0ec44ee06f7ca98495f0e8f032ba93e05c
Reviewed-on: https://gerrit.libreoffice.org/68391
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The snake algorithm in PowerPoint seem to interpret spacing as follows:
if you have N elements, then there should be the requested amount of
spacing between the elements, and also double amount of spacing around
the actual list of elements.
With this, the SmartArt and the title shape in the bugdoc no longer
overlaps.
Change-Id: I5d6885b434bfaff9de9aac595a298a5346524e19
Reviewed-on: https://gerrit.libreoffice.org/68397
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
RTF is a bit simplistic compared to the others, but at least
we can handle the Environment situation similarly.
Change-Id: I87bc389373275d19f1229e11ffd742836a0fd498
Reviewed-on: https://gerrit.libreoffice.org/66966
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
...when implicit special member functions are defined for FWE_DLLPUBLIC
MergeMenuInstruction etc.
Change-Id: Ida796edaea73cf2c918feee1ee961e2065f25ee8
Reviewed-on: https://gerrit.libreoffice.org/68376
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
after
commit 589ce33041
Date: Mon Feb 25 14:38:21 2019 +0200
sal_uIntPtr->sal_uInt64 in SalTimer::Start
Change-Id: I0fe5d972d2acf90a98f6e0203c51e509a60920c1
The bugdoc has 3 items in the picture strip and PowerPoint laid this out
as a single column with 3 rows (as a snake algorithm). We used to put
the first two items to the first row and the third item to the second
row.
Improve out layout by taking into account what aspect ratio the child
algorithms request: this way it's obvious that we should use a single
column in case we have a large enough aspect ratio and few enough items.
(PowerPoint also uses multiple columns without the aspect ratio
request.)
Change-Id: I9f1158c04c665fc6a2c85e4ac3a1ed363b1c75fb
Reviewed-on: https://gerrit.libreoffice.org/68370
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
...so the new background tab page works correctly in Calc Border/
Background dialog
Change-Id: I4121d5ef0e69ccd6f819b5ea760461004d484364
Reviewed-on: https://gerrit.libreoffice.org/68369
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
after
commit 589ce33041
Date: Mon Feb 25 14:38:21 2019 +0200
sal_uIntPtr->sal_uInt64 in SalTimer::Start
Change-Id: I0091ac4750dfb2ca8a3f4b5a544f7ec4f0ee0957
At least during JunitTest_sw_unoapi_4
sw.SwXTextTable::com::sun:⭐:text::TextTable::TableColumnSeparators, some
SwFormatFrameSize is created with a width of USHRT_MAX ("Set USHRT_MAX as the
Table's default SSize") in SwDoc::InsertTable
(sw/source/core/docnode/ndtbl.cxx). In SwTabFrame::Format
(sw/source/core/layout/tabfrm.cxx) that leads to nWishedTableWidth with a value
near USHRT_MAX and substantially larger than nMax, causing nLeftSpacing to be a
large negative value in the text::HoriOrientation::CENTER case. That in turn
causes SwTextAdjuster::CalcRightMargin (sw/source/core/text/itradj.cxx) to
set
pRight->PrtWidth( sal_uInt16( nRealWidth - nPrtWidth ) );
with a value of 32768 (where pRight is a SwGluePortion). And a later call to
that SwGluePortion's GetPrtGlue would try to convert that 32768 to 'short',
getting flagged by Clang's -fsanitize=implicit-signed-integer-truncation.
In addition to changing GetPrtGlue (and MoveGlue) to use 'long' instead of
'short', drop some unncessary narrowing casts from client code.
Change-Id: I6a0d763acfad1fc3b550ec6107adf9f5429dd005
Reviewed-on: https://gerrit.libreoffice.org/68253
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The reason was that A2 had an explicit paragraph style reference, but A1
did not, so table buffering caused A2 style to affect A1 style as well.
Combine this with style deduplication, and then A2 style considered the
direct formatting (font size) in A1 to be redundant, so it was lost on
import.
Fix the problem by moving the copy&pasted properties buffering to a
single function, and there buffering not only the properties, but also
the active style index.
Change-Id: I99f2020b8bef237849fd622b25ac5ef0516d69e4
Reviewed-on: https://gerrit.libreoffice.org/68361
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
sal_uInt32 seems reasonable given that this is the number of rectanges
in an image.
And then convert all of the other BeginSetClipRegion methods to use
sal_uInt32 too.
Change-Id: I85a712ec823662ac30f3859051e2b974fb99775e
Reviewed-on: https://gerrit.libreoffice.org/68343
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This way bottom docked toolbars appear above each other
to avoid Table pushing Track Changes out from under the mouse cursor
Change-Id: Ic0a9e745246bce6d12cfb17d6adf8ad703753168
Reviewed-on: https://gerrit.libreoffice.org/68365
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
This patch allows the whole interactive sequence to
restart automatically when it's done. User don't
need to insert multiple pause toggle command to
a media object just for toggling the media
multiple times.
Change-Id: I000a55f580917327ae438ea8e79e62f63275cce7
Reviewed-on: https://gerrit.libreoffice.org/68283
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
