Commit Graph

423210 Commits

Author SHA1 Message Date
Michael Stahl
750fe9560b sw: prefix members in SwAttrHandler::SwAttrStack
Change-Id: I64c4bfa709b6cd12793efba1d9773731fb66939d
Reviewed-on: https://gerrit.libreoffice.org/54369
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-16 10:35:37 +02:00
Caolán McNamara
c87c6166f7 ofz#8327 Abrt
Change-Id: I89f7dd3909cfbe27d7ce41a6bfb51a166fe885bb
Reviewed-on: https://gerrit.libreoffice.org/54401
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-16 09:56:17 +02:00
Caolán McNamara
f4b80fc579 ofz#6352 set limits for useful fuzzing
Change-Id: Id4a2dab7da84adf6c6268340dff34e8776abe924
Reviewed-on: https://gerrit.libreoffice.org/54383
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-16 09:55:26 +02:00
Caolán McNamara
414226273a coverity#1430102 Division or modulo by zero
Change-Id: I2db581b3f30713edaca4ec11f85343c436c54fae
Reviewed-on: https://gerrit.libreoffice.org/54380
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-16 09:54:33 +02:00
Caolán McNamara
873dbd2c3a coverity#1435605 silence Unchecked return value
Change-Id: I1617ff8157ad69b467a0feaad5680e90e2c08a47
Reviewed-on: https://gerrit.libreoffice.org/54382
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-16 09:54:10 +02:00
andreas kainz
3e39db0202 tdf#117630 wrong accelerator character for update command
Change-Id: I36888ddda9ca5cfd9f5e9d344d0656917637f348
Reviewed-on: https://gerrit.libreoffice.org/54404
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-05-16 09:33:54 +02:00
andreas kainz
3316edf639 Change 53905 - Modified IDs for objects in writer "notebookbar.ui"
Change-Id: Id8b7367c5d29419c5889f652363269a5384b99f5
Reviewed-on: https://gerrit.libreoffice.org/54403
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-05-16 09:32:57 +02:00
Gabor Kelemen
7c8b29c1fe tdf#108523 Remove @author annotations
Change-Id: Idb0eb975511c80d65a896193fd0b9c8fcfe1f9a1
Reviewed-on: https://gerrit.libreoffice.org/54392
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-16 09:08:35 +02:00
Chris Sherlock
99dbaba70a tools: test Pair
Change-Id: I03e48c134ec9b8fc53c247ced231f209e1205cb1
Reviewed-on: https://gerrit.libreoffice.org/54189
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-16 09:07:14 +02:00
Noel Grandin
8611689f0d loplugin:unusedmethods
Change-Id: I10c291788061ec8467126a0dc719e20fb3cf47ec
Reviewed-on: https://gerrit.libreoffice.org/54386
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-16 09:05:08 +02:00
Noel Grandin
196f46db1b loplugin:constantparam
Change-Id: I0110e0c662004456e4bc8f8082e2e2fea59e0148
Reviewed-on: https://gerrit.libreoffice.org/54385
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-16 09:04:55 +02:00
Noel Grandin
19b4520fbf loplugin:useuniqueptr in SvxOutlinerForwarder
Change-Id: Ie861132b43b0a01ee8b4f3bc201bbf12f8af9f36
Reviewed-on: https://gerrit.libreoffice.org/54181
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-16 09:03:47 +02:00
Stephan Bergmann
6da400912e [API CHANGE] Remove no longer working rtl_arena -> rtl_cache feature
rtl_arena_create's quantum_cache_max parameter (when non-zero) would have
allowed an rtl_arena to internally use an rtl_cache for chunk allocation.  (And
none of the LO-internal uses of rtl_arena_create makes use of that.)

However, with the combination of old ce906b8096
"skip tricky allocators on G_SLICE=always-malloc" and recent
bc6a5d8e79 "Disable custom allocator", rtl_cache
unconditionally just uses malloc/free now, so the rtl_arena_create
quantum_cache_max feature has effectively become irrelevant.  As those changes
appear to have no negative consequences overall (and help remove quite a chunk
of no-longer used code), leave it at that and officially abandon the
quantum_cache_max feature.

Change-Id: I7d186a4a1589db6a73059c2be164aa81d81aef47
Reviewed-on: https://gerrit.libreoffice.org/54388
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-16 08:38:15 +02:00
Justin Luth
5dcb065d24 NFC: unassigned variable pNewItem is always nullptr
In 2015 commit 2ebd79b3d2 a
possible initialization of the variable was removed. So
at this point pNewItem must return false.

Change-Id: I5af9d8440463c96323c38a01f255c1dbb0113e09
Reviewed-on: https://gerrit.libreoffice.org/54395
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-05-16 07:24:42 +02:00
Tomaž Vajngerl
d57c6f5d44 tdf#117596 set the size for Asian and Complex char height too
Change-Id: I703fc4d1cf34747d924a7fa44913a4bfe9bff67b
Reviewed-on: https://gerrit.libreoffice.org/54406
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-16 06:41:29 +02:00
Adolfo Jayme Barrientos
3403675964 Updated core
Project: help  c3b0090070148eeb995eaf4d0df3333b19c7e462

Since LO 4.4, there’s not Edit File icon in Writer by default

Change-Id: I96b8a212df54017f67994195a5d775f2704e93b7
2018-05-16 03:00:40 +02:00
Tomaž Vajngerl
29cebedfbd sw: cleanup globalfilter test
- use OUString for filter names
- use modern iteration through filter names
- no change to the tests

Change-Id: Idab4183efe2b489b91b4f3c96e7cb1d639628766
Reviewed-on: https://gerrit.libreoffice.org/54374
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-16 01:37:08 +02:00
Tomaž Vajngerl
b2b1d0a4c4 sw: improvements of globalfilter test
- check if linked graphic is registered in LinkManager
- remove setting of graphic cache size as it doesn't have any
  effect anymore
- improve asserts for Graphic / XGraphic objects

Change-Id: I97e2772e2a8209ff61975c273ec27401c3e7a976
Reviewed-on: https://gerrit.libreoffice.org/54373
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-16 01:36:47 +02:00
Olivier Hallot
fc3e676f56 Updated core
Project: help  f3003dafc6568878d1ea4cceb658506f77567852

Add digital signature entry in help contents tree

Preparation for more on digital signatures, signature lines, etc...

Change-Id: I2cf8b5253f8c539850bb968ff1b14e85da06d4a1
Reviewed-on: https://gerrit.libreoffice.org/54402
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-05-15 22:54:08 +02:00
andreas kainz
db9a6dbbd6 NB Implementation: update Menu drop down menu
Change-Id: If4b5ba6579e06a3f179de032919bdf7335b39a7b
Reviewed-on: https://gerrit.libreoffice.org/54389
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-05-15 22:44:10 +02:00
Olivier Hallot
ab523a0771 Updated core
Project: help  35e61539e7c5da38d61a042e9740494dead42ced

Fix external reference to blog post on pivot charts

Change-Id: Icabfdcce2ae18848793bd467fd606e20afa97f5f
Reviewed-on: https://gerrit.libreoffice.org/54347
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-05-15 22:42:54 +02:00
Olivier Hallot
07a0cb64a2 Updated core
Project: help  51d800a8af9637c31b1b4c6d5bdd490f8952d218

Fix "Master Slide"

Change-Id: I766d38b014282701df34f056ae7184e4d62be6c6
Reviewed-on: https://gerrit.libreoffice.org/54397
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-05-15 22:39:07 +02:00
Zdeněk Crhonek
e6c99316fb uitest Calc - format Cells
Change-Id: I2a2f0515d872e1affd7c1c27eb901ea2a183114b
Reviewed-on: https://gerrit.libreoffice.org/54387
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-15 22:30:31 +02:00
Eike Rathke
ed9416446d Resolves: tdf#117617 Add Iloko [ilo-PH] to language list
Change-Id: If8444a847fa652de8b7b834e08c3e5116721c987
2018-05-15 20:21:19 +02:00
Caolán McNamara
409441652a ofz#7802 infinite loop
Change-Id: I1b631dec998efb4a689ef13ea29bcff89cf7a47f
Reviewed-on: https://gerrit.libreoffice.org/54377
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 19:25:01 +02:00
andreas kainz
dd84c23bf6 Colibre: Hamburger icon for NB is now well aligned
Change-Id: Ie6ef7f2ca68b9f158e166a62b9cec8adfc91f006
Reviewed-on: https://gerrit.libreoffice.org/54376
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-05-15 17:42:49 +02:00
Tomaž Vajngerl
3c6b0eb0f1 tdf#117427 need to check originURL when ReRead is called
Previously we checked the originURL of Graphic for SwGrfNode in
constructor which then called ReRead. This is OK for linked
graphic when they are loaded from the document, but when we change
the Graphic through API, only the ReRead method is called. So to
get this to work we need to move checking of originURL into the
ReRead method.

Change-Id: Iaa4a332459baab656740ff209b997c48b7287e16
Reviewed-on: https://gerrit.libreoffice.org/54362
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-15 17:30:59 +02:00
andreas kainz
92ca8dfeb3 NB Implementations: update for better maintenance and sync
Change-Id: I024d597f218824d8618d113a5aaae2fd314ec807
Reviewed-on: https://gerrit.libreoffice.org/54367
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-05-15 17:29:24 +02:00
Zdeněk Crhonek
e29eacbb6a Calc -print range + tdf#33341
Change-Id: I486dd0cffb4173530ee78d3971865df3bac2818b
Reviewed-on: https://gerrit.libreoffice.org/54341
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-15 16:56:59 +02:00
Rene Engelhard
fe4bc1c09d CppunitTest_svl_qa_cppunit: fix system-libnumbertext build
libnumbertext_numbertext package doesn't exist...

Change-Id: I5fc7c9c2386c10a10f2980655292ab12beb1a977
2018-05-15 16:24:43 +02:00
Samuel Mehrbrodt
86e8cfdd54 Sign Signature Line
This adds a new context menu entry "Sign Signature Line" to signature lines.
You can directly sign the document from there.

Still missing is the updating of the graphic to reflect the valid/invalid
signature state.

Change-Id: Ib8bc8c57f9d5370a10e379f86f9e41e57c715e3f
Reviewed-on: https://gerrit.libreoffice.org/53778
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-15 16:16:22 +02:00
Noel Grandin
863d2485e6 loplugin:useuniqueptr in ParagraphList
Change-Id: I042fb945b0585a0409d76a509c7f9287aa220b68
Reviewed-on: https://gerrit.libreoffice.org/54180
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-15 15:56:14 +02:00
Rene Engelhard
9411936399 fix build
Change-Id: I71238209b4819f256045487f1db83d79f6fe49ba
2018-05-15 14:51:01 +02:00
Eike Rathke
fb34539769 Guard static variables, tdf#115007 tdf#117171 follow-up
Change-Id: Ib8f73ceefb8278b6233d46d86a34a3869622239f
2018-05-15 14:35:27 +02:00
Caolán McNamara
9aff7f3c49 weld ScSolverNoSolutionDialog
Change-Id: I403e39e0f5cd642c5996a49f50cc7ee7bbdfbd02
Reviewed-on: https://gerrit.libreoffice.org/54354
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 13:45:20 +02:00
Caolán McNamara
932c96e158 weld ScSolverSuccessDialog
Change-Id: I29bf7b59fbac8f969e5a61963d65b626ac03b0fa
Reviewed-on: https://gerrit.libreoffice.org/54355
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 13:25:31 +02:00
Caolán McNamara
5f170e6972 weld WPFTEncodingDialog
and pass in parent window for dialog

Change-Id: Ibe9f576a74dfbbee3e568c8d3454440700cb0405
Reviewed-on: https://gerrit.libreoffice.org/54328
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 13:05:35 +02:00
Caolán McNamara
d15c240434 OSL_ENSURE->assert
Change-Id: I6b93a221bc00fd92ef01135727c7e50560fb4517
Reviewed-on: https://gerrit.libreoffice.org/54357
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 12:55:40 +02:00
Caolán McNamara
a09888adcd weld ScSolverIntegerDialog
Change-Id: I4d7196ead0dd60fe4b40af72a1c7ec64c5a2315a
Reviewed-on: https://gerrit.libreoffice.org/54352
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 12:53:00 +02:00
Caolán McNamara
f7048e9b79 weld ScColOrRowDlg
Change-Id: I475974fc54910da88064779ceae6586bd71a3865
Reviewed-on: https://gerrit.libreoffice.org/54356
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 12:46:28 +02:00
Caolán McNamara
d735ffde2d weld ScSolverValueDialog
Change-Id: I1c55d184052482fc472d66069ea8722cd27d1543
Reviewed-on: https://gerrit.libreoffice.org/54353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 12:46:11 +02:00
Stephan Bergmann
135cbec440 Adapt solenv/flatpak-manifest.in to recent download.lst changes
Change-Id: Ic8f4afe8f46b5f0c36eeffdbb04b3cc652884ab4
2018-05-15 12:14:19 +02:00
Mike Kaganski
56a7f308cf tdf#115007: add NatNum codes for cardinal/ordinal number names/indicators
... based on libnumbertext integrated since commit
f1579d3d6c.

[NatNum12] gives cardinal number names (one, two, three, ...)
[NatNum13] gives ordinal number names (first, second, third, ...)
[NatNum14] gives ordinal indicators (1st, 2nd, 3rd, ...)

Change-Id: Ie2afdeeb82da1b36e9755c02d7b2276c77be9c72
Reviewed-on: https://gerrit.libreoffice.org/54186
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-15 11:42:36 +02:00
Michael Stahl
5193d7fc00 sw: these SwRedlineItr members index into the SwRedlineTable, not the node
Change-Id: Idb04fcb46a72d63d4f35b61eb0333ebd6abaaf0c
Reviewed-on: https://gerrit.libreoffice.org/54309
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-15 10:09:23 +02:00
Caolán McNamara
881636aed7 ofz#8255 check multiply
Change-Id: I3b125aba227e46c92510f7388aff4fff1478c78e
Reviewed-on: https://gerrit.libreoffice.org/54329
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 09:52:25 +02:00
Caolán McNamara
d9f4c8ded4 weld ScFillSeriesDlg
Change-Id: I1b4c6777d3334813c6bfe47efbb67f065efa555c
Reviewed-on: https://gerrit.libreoffice.org/54338
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 09:51:59 +02:00
Caolán McNamara
0e4f93e88b weld ScRetypePassInputDlg
Change-Id: Ie57f3fdaeed5b15f2ce7a1825debdc92788b4e94
Reviewed-on: https://gerrit.libreoffice.org/54343
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15 09:51:44 +02:00
Stephan Bergmann
bff6751413 loplugin:unnecessaryoverride, loplugin:cstylecast (clang-cl)
Change-Id: I316965219f70a87b59b731e4d5e6b67d2010c2b9
Reviewed-on: https://gerrit.libreoffice.org/54350
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-15 09:44:23 +02:00
Stephan Bergmann
8e8c4da188 loplugin:stringconcat, loplugin:sallogareas (clang-cl)
("bridges.win64" isn't more useful than plain "bridges" here, as each platform
uses only one bridges/source/cpp_uno/ sub-dir, anyway)

Change-Id: Ic8c2af892cdfad98e10d43532b3bf3c892555446
Reviewed-on: https://gerrit.libreoffice.org/54351
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-15 09:44:03 +02:00
Gabor Kelemen
8713c1ffd8 tdf#42949 Fix IWYU warnings in sc/inc/e*
Found with bin/find-unneeded-includes
Only removal proposals/trivial replacements are dealt with here.

Change-Id: I0ad6772012c771e8ab3f3f42af26f9ac05615771
Reviewed-on: https://gerrit.libreoffice.org/54147
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-15 09:09:01 +02:00