mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
Commit Graph

6674 Commits

Author SHA1 Message Date
Noel Grandin
aeb41c9b9b remove redundant calls to OUString constructor 
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
 2013-11-04 10:11:07 +02:00
Noel Grandin
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator 
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
 2013-11-04 08:06:10 +02:00
Julien Nabet
124beed407 Resolves: fdo#71062 Embedded Firebird - Tables with Date-fields let LO crash 
Change-Id: Ie28a1e8765ab9ff6eb345198d6ea223e25429e11
 2013-11-01 18:01:35 +01:00
Caolán McNamara
0b79f6ce62 cannot convert parameter 1 from ´const char [2]´ to ´sal_Unicode 
Change-Id: I66a1005c3f6bcad448ed2c162a8399c7c32ad78e
 2013-11-01 11:23:56 +00:00
Noel Grandin
ccbea81484 fix mozab driver after OUString change 
for Windows build after my change in
commit e2451bd729d0f1d795a5b689deba65bc4e9d92c6
"Convert indexOf->startsWith and lastIndexOf->endsWith"

Change-Id: I9397f1310742cdd773a7d2d3c5f0dbe728041d2d
 2013-11-01 08:43:24 +02:00
Noel Grandin
dc6e04878d fix ambiguous OUString constructor call 
after commit e2451bd729d0f1d795a5b689deba65bc4e9d92c6
"Convert indexOf->startsWith and lastIndexOf->endsWith"

Change-Id: I19c0e33e318cbf4be90d60bcbb83bc5de4336190
 2013-10-31 10:56:07 +02:00
Tor Lillqvist
526e754b2a WaE: while loop has empty body 
Not just a warning, but clearly an accidental editing error.

Change-Id: Ib708b1de774d56d6c4b144c4e10e280f8181b67b
 2013-10-31 10:46:55 +02:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith 
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
 2013-10-31 08:34:21 +02:00
Michael Stahl
ffa7f7b8ac connectivity: mozabdrv: avoid warning C4005 macro redefinition 
Both winnls.h (included via windows.h) and mozilla nsCharTraits.h
define macro IS_HIGH_SURROGATE/IS_LOW_SURROGATE; it turns out that
the nsEmbedAPI.h that drags in winodws.h is apparently unused.

Change-Id: If5189c58dc1fe3a508a360a270337f97333e0ce8
 2013-10-30 00:01:35 +01:00
Thomas Arnhold
7eb42bddb3 windows: warning 4706 is disabled globally in com_MSC_defs.mk 
So there is no need to do this locally, too.

Change-Id: Ibc623235cae07a86dfd0dbc1d7672ca4273facec
 2013-10-28 01:08:27 +01:00
Andrzej J.R. Hunt
0ef3db3563 Remove redundant comment. 
Change-Id: I317f83e8aca7f61148385763bc1f0a78a84530d8
 2013-10-27 19:30:19 +00:00
Andrzej J.R. Hunt
05e50fd54b Firebird: Use explicit integer sizes. 
Change-Id: I5cabe21a2d675773792f9c9d5130d8660718efe8
 2013-10-27 19:20:42 +00:00
Arnaud Versini
82bafb4860 FIREBIRD: SQL_INT64 should be 8 bytes 
Change-Id: Iae71aab4cd68592fa6e5a7d55468e442e6d94385
Reviewed-on: https://gerrit.libreoffice.org/6451
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2013-10-27 16:09:28 +00:00
Lionel Elie Mamane
d1fdaafd7c fdo#6412 firebird-sdbc DatabaseMetaData unimplemented getXXX: provide empty RS 
As opposed to NULL object. Else, callers that do a UNO_QUERY_THROW get unexpected results.

Change-Id: Ie9dd157eed03031ba04ed59c363a45e246bbb001
 2013-10-25 10:09:21 +02:00
Lionel Elie Mamane
373e4d33c1 connectivity commontools DatabaseMetaData: provide for getUDTs, too 
Change-Id: Id361ac34f400922893f6a906e4345eed2be1b2d2
 2013-10-25 10:09:21 +02:00
Lionel Elie Mamane
60b67b7e39 janitorial: indentation 
Change-Id: I0b571a9fe719c4f18f89638eb62434dd0813bd01
 2013-10-25 10:09:21 +02:00
Thomas Arnhold
f852bda5ec clean up some include guards 
Conflicts:
	sw/source/ui/inc/content.hxx

Change-Id: I58d81881271fc6e3320bf3b5f1321594b28614a6
Reviewed-on: https://gerrit.libreoffice.org/6388
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2013-10-23 10:28:07 +00:00
Noel Grandin
7a06928bcf convert code to use OUString::endsWith 
Convert places that call
   aStr[aStr.getLength()-1] == 'x'
to use the shorter form
   aStr.endsWith("x")

Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
 2013-10-23 08:29:15 +02:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included 
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
 2013-10-22 16:56:28 +03:00
Thomas Arnhold
8fc6905674 fdo#68849 add some header guards 
Change-Id: I9d25a58f22095689eccc0ac444c163d1e9bee69f
Reviewed-on: https://gerrit.libreoffice.org/6364
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-10-21 09:15:59 +00:00
Lionel Elie Mamane
6940532b81 Revert "fdo#68657 bool->string conversion to 1/0, not "true"/"false" 
This reverts commit b89fb0d03ead22f023f367c9a9d046d3d41ba1cf.

It was intended for stble branch only; in master, we let the
incompatible change go through, but we have introduced a
work-around to get the old behaviour again.
 2013-10-20 19:28:19 +02:00
Lionel Elie Mamane
5dde691e3e an ORowSetValue constructed from a boolean is a boolean 
as opposed to a bit

Change-Id: Ife1c8cef5ca1266e161da3a9190e744dd70ec2fd
 2013-10-20 19:27:27 +02:00
Lionel Elie Mamane
b89fb0d03e fdo#68657 bool->string conversion to 1/0, not "true"/"false 
This matches what OO.org / older versions of LibreOffice did, and which was inadvertently changed in 2bd856e6

Reviewed-on: https://gerrit.libreoffice.org/6275
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>

Conflicts:
	connectivity/source/commontools/FValue.cxx

Change-Id: I1d45ea975a096c599a996caafc41e4aa06d35fcd
 2013-10-20 11:16:39 +02:00
Lionel Elie Mamane
a1c6000984 per SQL standard, BIT is 0/1 but BOOLEAN is true/false 
Change-Id: If088cd33c19bccddbf145a44d19bf37adf638f3b
 2013-10-17 16:20:19 +02:00
Lionel Elie Mamane
ffff474592 respect reference values in checkboxes 
Change-Id: Ifd0953f779f530af6b190425794f009a891f0afb
 2013-10-16 18:45:22 +02:00
Lionel Elie Mamane
5c5df097e6 janitorial: bool is bool, not sal_Bool 
Change-Id: Ia6fbde0521d503c3d774ebd265097804d375ed3b
 2013-10-16 18:45:20 +02:00
Lionel Elie Mamane
b9fac5769d string->bool conversion recognise "1"/"0" additionally to "true"/"false" 
since that is what the conversion in the other direction recognises.
It also recognises the "true"/"false" written by LibreOffice versions affected by fdo#68657

Change-Id: I213c23a19e4857905da93eeb2be1b9714215594a
 2013-10-16 18:45:18 +02:00
Marcos Paulo de Souza
2b91dc3ae6 fdo#54938: Adapt connectivity module to use cppu::supportsService 
Change-Id: I885b4c7a60ff51d44138c4f8a56a584c38a9804a
Reviewed-on: https://gerrit.libreoffice.org/6172
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-09 15:03:38 +00:00
Caolán McNamara
2a20c95e84 CID#738572 uninitialized members 
Change-Id: Ie3614d86e27aab67cfe68bea76de30b775173fb3
 2013-10-07 09:16:26 +01:00
David Ostrovsky
b4e25bc4c1 fdo#64741 Thunderbird mork driver: implement collected addresses 
Change-Id: I5a8516a6cf4bd71cea2be916d5a7fcfb16b4e749
Reviewed-on: https://gerrit.libreoffice.org/6020
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2013-10-04 14:43:20 +00:00
Stephan Bergmann
723412eac5 -Werror,-Wunused-variable 
Change-Id: I3ad7139190758e86cadebf9555a838dbaddbbf3e
 2013-10-02 18:14:38 +02:00
Stephan Bergmann
0718498999 Replace deprecated std::auto_ptr with boost::scoped_ptr 
Change-Id: Ic55d1a8b14ec0355a6289007d954e89cd41c7486
 2013-10-02 16:49:49 +02:00
Stephan Bergmann
abb6ab4145 Fix warnings in sqlflex.l, sqlbison.y 
Change-Id: I6c6b9452014940e09f8f4b7466c5a5f562c9fff5
 2013-10-02 16:49:48 +02:00
Stephan Bergmann
7f02173bba -Werror,-Wunused-const-variable 
Change-Id: Ic4edbbc0bf74887ab9624e4551b54ecbe3538108
 2013-10-02 16:49:31 +02:00
Stephan Bergmann
3ade152323 -Werror,-Wunused-const-variable 
Change-Id: I07351213c3a8c215a3c02f263f872cee8f7c7cfd
 2013-10-02 16:49:30 +02:00
Stephan Bergmann
54a737ab4d -Werror,-Wunused-const-variable 
Change-Id: I2cf98c691fb11be340ff973a51477c56d5d97d50
 2013-10-02 16:49:29 +02:00
Caolán McNamara
8e30689680 drop worthless _VECTOR_/_MAP_ header guards 
Change-Id: I54be19847b8fb609f0b08a528cc06dbae9f579d5
 2013-09-25 19:24:24 +02:00
Caolán McNamara
98de5b40c8 Related: fdo#38838 remove UniString::EqualsIgnoreCaseAscii 
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
 2013-09-25 19:24:23 +02:00
Andrzej J.R. Hunt
85d1ee4f1c Use LO_JAVA_DIR for HSQLDB classpath. 
This is needed to allow usage of HSQLDB in a unit test in solver
(in conjunction with the following patch which adds LO_JAVA_DIR
to solver's unorc).

Change-Id: Ia3757b61d4ba0b2353e0d33290938cea40551d3a
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2013-09-23 14:11:40 +02:00
Andrzej J.R. Hunt
27c11f1f08 Implement creation/loading of external firebird .fdbs. 
Change-Id: I61186189d791e54fb096505abd2fa7ac248035e8
 2013-09-20 15:02:27 +01:00
Andrzej J.R. Hunt
c856ab73af Cleanup ResultSet exceptions. 
Change-Id: I77e4fd5fffe45446050f8a1dfbcc8cc27290c786
 2013-09-19 20:37:55 +01:00
Andrzej J.R. Hunt
65719df3e3 Cleanup exceptions in PreparedStatement. 
Change-Id: Ice11ec8131a00335db48a05661bbe0285bb53fea
 2013-09-19 20:37:55 +01:00
Andrzej J.R. Hunt
101040a130 Set sane default for type. 
Change-Id: Ib63e6abd7b378671d1e01bf9357dd811ae88fc40
 2013-09-19 20:37:55 +01:00
Andrzej J.R. Hunt
831f01b739 Move type conversion into template.` 
Change-Id: I7b646673eacf2abbac8a2bcfa744f840ff344c84
 2013-09-19 20:37:55 +01:00
Andrzej J.R. Hunt
79f1c6e50e Use conversion for Byte/Bool. 
These are both non-native to firebird, hence always have to be converted
from whatever data we have.

Change-Id: I6e6843d95ee4f5cf0cd5953251796150f325f800
 2013-09-19 20:37:54 +01:00
Andrzej J.R. Hunt
52841daec9 Throw sane exception when wrong type used in PreparedStatement. 
Change-Id: Ie9577ed021930c56f3270aa30306d89365c1b3b1
 2013-09-19 20:37:54 +01:00
Andrzej J.R. Hunt
a11b6d5356 Don't throw unnecessary exception. 
Even an empty ResultSet can be valid, and no other drivers do this.

Change-Id: Ie3aee718f0187d039dbd0c53fc32a71be4a1d9e9
 2013-09-19 20:37:54 +01:00
Andrzej J.R. Hunt
fc118515ee Implement implicit type conversion in ResultSet. (firebird-sdbc) 
Change-Id: I9faf9752556b7e0769d3a353e393924f5a1edb63
 2013-09-19 20:37:54 +01:00
Andrzej J.R. Hunt
dba4e216c9 Remove null indicator for type checking. (firebird-sdbc) 
Change-Id: I3f693f5662f3022323c7ec726c9d7a506ce02185
 2013-09-18 21:03:03 +01:00
Andrzej J.R. Hunt
936cce1110 Add some type checking to ResultSet. 
This is in preparation for complying with the API by allowing
implicit type conversion.

Change-Id: I5e52fdc2f3562f806d7f9fba5d558ece4bd182ac
 2013-09-18 20:57:08 +01:00