Would have caused eternal recursion, probably was intended to use
throwGenericSQLException or similar, but throwing the correct
exception is probably cleaner anyway.
Change-Id: Ic4afa623bfcd57eb68ef6cfbf737862fd40eaaa2
Currently if the first set* method to be called is setNull, then
we segfault since we try to access m_pInSqlda which doesn't exist
yet.
Change-Id: I4ad9c0a7d68da11b2260a596dd95c4c2cb5bcd4c
This replaces the erronous Connection wide mutex. Libfbembed
is multithreaded hence we don't need a connection wide mutex.
Change-Id: Ifae79cdefecfe6597a535e36bda318563092bf6c
Firebird doesn't support catalogs or schemas hence these parameters
are unused in the various get[...] methods. Previously these were (void)
casted however commenting out the parameters seems more correct and reduces
the amount of code.
(This was omitted for as-of-yet unimplemented methods since they will still
be looked at in detail.)
Change-Id: Ic6566ff0b3e873b802deec79d5497efdd21e577d
Firebird's DROP INDEX statements only need to contain the index name, including
the table name causes an error.
Change-Id: I5b61d82bda7176148f7849e31bd050e025f84e02
This ensures that the enclosing directory is kept while we work with
it.
Conflicts:
connectivity/source/drivers/firebird/Connection.cxx
Change-Id: I5c095d481414e345cf05efc3d40d314f8f40ed12
Reviewed-on: https://gerrit.libreoffice.org/5814
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
osl::FileBase::getTempDirURL uses the general tmp directory which
can be the system wide directory (i.e. /tmp). This can lead to conflicts
e.g. if we have multiple instances each trying to create /tmp/firebird.
Instead we use ::utl::TempFile which uses a user-specific directory (as a
subdirectory of what osl::FileBase::getTempDirURL provides), in which we
can have the FIREBIRD_TMP and FIREBIRD_LOCK directories.
Change-Id: Ic868f12b0a56900eac75f2418986193dd5fe0f10
Reviewed-on: https://gerrit.libreoffice.org/5797
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
In this case we can just pass the DisposedException (is a RuntimeException)
onto the calling methods.
Change-Id: I89d2421c03a5f8e81f209b94109ffde117cfb0cd
In this case we can just pass the DisposedException (is a RuntimeException)
onto the calling methods.
Change-Id: Ia85a2d147ed3822847fe64b8cac671c88c6444fe
In this case we can just pass the DisposedException (is a RuntimeException)
onto the calling methods.
Change-Id: I379974fd7998151d503020742ae7ae18cbdfaf7c
In this case we can just pass the DisposedException (is a RuntimeException)
onto the get* methods.
Change-Id: I97a3575709e2f50fa651a5d26c3029ed014630da
Otherwise dbaccess's indexcollection gets confused and can segfault
when indexes not belonging to the desired table are returned.
Change-Id: I4dfe62bf1053c65cac907bf490749ee2cc24e6ca
Noticed by the MS linker when doing link-time code generation (!). In
all cases, a "return" after a call to a function that always throws an
exception. To avoid other compilers perhaps warning about missing
return of a value, put the "returns" inside ifdefs.
Change-Id: I83aa04cb5c3ff8413d3ed4dc85fb57f2a41fd589
These two methods don't seem to be used at all within the LO codebase.
They are also extremely complicated to implement hence will be left for
later implementation -- my part implementation will be put on the wiki
firebird page.
Change-Id: I72922a4f3c4705fdcc3bbca140d6df64a1e16253
