394279 Commits

Author SHA1 Message Date
Noel Grandin
7855ea4830 remove comphelper::string::remove
and replace it with OUString/OString::replaceAll

Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a
Reviewed-on: https://gerrit.libreoffice.org/26850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04 06:49:52 +00:00
Noel Grandin
cd71034b26 comphelper::OBaseMutex -> cppu::BaseMutex
convert usage of deprecated class, and remove the old class

Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2
Reviewed-on: https://gerrit.libreoffice.org/26843
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04 06:49:07 +00:00
Noel Grandin
70bfe5f71c remove deprecated Link functions from Registry
Change-Id: Id678d4b6263df86993b289e8439faac847dd7c5f
Reviewed-on: https://gerrit.libreoffice.org/26855
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04 06:48:25 +00:00
Stephan Bergmann
f904bd567f loplugin:stringconcat
Change-Id: I4156d1d57d0afaa2fc7ef93370fa824b38d273e4
2016-07-04 08:22:25 +02:00
Muhammet Kara
41051ebbc4 Localize error message in ODataTypeRepository
Change-Id: I92b5a69daf405d71bf8f72685696c647a64cc9d1
Reviewed-on: https://gerrit.libreoffice.org/26807
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-07-04 06:17:41 +00:00
Stephan Bergmann
b60a5dc5b8 loplugin:stringconstant
Change-Id: I09f4dc83cd1408c4286a11a94f592b8e3d2b027c
2016-07-04 08:16:39 +02:00
Otto Kekäläinen
428e23f4f7 Fix some spelling errors in comments and strings
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e
Reviewed-on: https://gerrit.libreoffice.org/26883
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-07-04 06:11:36 +00:00
Zdeněk Crhonek
61d95c70c0 add ANORDEGRC test case
Change-Id: I10fdf45171505ba53e971c1a634ffa66a4a09f9a
Reviewed-on: https://gerrit.libreoffice.org/26811
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-04 06:11:18 +00:00
Tomaž Vajngerl
b5cd1220b8 tdf#98710 check the font is bound, substitute FON fonts
If we can't bind the font then we can't proceed with rendering
and caching of the glyphs. This may avoid the crash but the font
won't be drawn. This happens for old Windows 3.1 bitmap fonts in
FON format which Direct Write doesn't support. So in addition
substitute "Script" and "Roman" FON fonts with "Times New Roman".

Change-Id: I16b480399b47989738a703ad84c0398493f9f4e3
Reviewed-on: https://gerrit.libreoffice.org/26885
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-04 04:43:37 +00:00
Jan-Marek Glogowski
21a3d78cf0 tdf#100458 Don't forcefully change cell type
Just quoting the source comment from the breaking commit
61c39eae570d6d6040b65bfe93127b30e6080cc8.

// If a matrix formula has a matrix reference cell that is intended to
// have // a blank text result, the matrix reference cell is actually
// saved(export) as a float cell with 0 as the value and empty <text:p/>.

Ok

// Import works around this by setting these cells as text cells so that
// the blank text is used for display instead of the number 0.

This seems to be wrong.

Forcing the cell to a util::NumberFormat::TEXT actually kills
the cell value, if the text is a result of the formular.

I'm not sure if forcefully changing the cell format at this point is
correct at any time, if a cell type was already determinated.

I imagine that an undefined cell type should probably be fixed at the
end of the row import, if Calc detected an error case, or even generally,

This patch is just a minimalistic initial fix. If it's correct, it
probably needs an additional code comment.

Change-Id: If7d9d69467d56c7d8fd2444f9e8b3ae906285264
Reviewed-on: https://gerrit.libreoffice.org/26435
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-04 03:35:09 +00:00
Takeshi Abe
bb01a3536d starmath: Drop unused definition
Change-Id: Ifb91d3a913d6fe3f92ef93bd0e25b8c6152727f3
Reviewed-on: https://gerrit.libreoffice.org/26872
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-04 02:02:52 +00:00
Zdeněk Crhonek
147bf38036 add CEILING test case
Change-Id: Ie335210609a556fc4081b16292ba756819bfa4d1
Reviewed-on: https://gerrit.libreoffice.org/26827
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-04 01:29:24 +00:00
Zdeněk Crhonek
0aa577970d add NOMINAL test case
Change-Id: Iec3e70ceeae38d6a5c18996e89fa5ae10a9f9668
Reviewed-on: https://gerrit.libreoffice.org/26862
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-04 01:29:02 +00:00
Bartosz Kosiorek
cc503abb86 tdf#100347 Fix Outline export into XLSX format
In previous XLSX export implementation the outline
for column was not saved. Also rows without cell content
was not saved if it was collapsed or outline level was set.
This commit resolve all such issues

Change-Id: I401f23e97f4803209fcd31c7d93baca3bd2a2385
Reviewed-on: https://gerrit.libreoffice.org/26625
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-04 00:01:40 +00:00
Bartosz Kosiorek
46094ff4b0 tdf#48767 Fix orientation issue after export to .xlsx
After save to .xlsx in usePrinterDefaults was added into PageSetup.
Due to bug in MS Excel, when usePrinterDefaults is present,
(no matter what value), the orientation of the Page is alway "portrait".
To resolve that issue, if usePrinterDefaults is set to default value,
then usePrinterDefaults XML field is not added during export to .xlsx

Change-Id: I3ab310babb278913bce3d66f7fae1192ed9727b9
Reviewed-on: https://gerrit.libreoffice.org/26871
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-03 23:57:50 +00:00
Rishabh Kumar
c89294233b Grid line color change for SvxPixelCtl
Change-Id: I0a7c0f2f8da9323a341fe378dcb7ef596aa133af
Reviewed-on: https://gerrit.libreoffice.org/26884
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-07-03 22:37:31 +00:00
Laurent Balland-Poirier
e364e52b9a tdf#81939 Add qa unit test
Test removal or not of escape char in number format strings in XLSX

Change-Id: I02a7e1bfd9df1ffd3bbad7dc072cfc85be68f949
Reviewed-on: https://gerrit.libreoffice.org/26877
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-03 16:51:16 +00:00
Arnold Dumas
68900bad94 tdf#57950: Replace chained OUStringBuffer::append() with operator+
Change-Id: I5e6cb493a5e742232cd312014d4b5b2820cf8314
Reviewed-on: https://gerrit.libreoffice.org/26878
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-03 15:48:42 +00:00
Muhammet Kara
d5784e91e9 Improve readability of OUString concatanation in LibPage
, ScriptDocument
, PropBrw
, VBATest
, SbUnoClass
, SbModule
, and SbiSymPool

It is more readable and more efficient as a bonus.
See: https://goo.gl/jsVAwy:

Change-Id: I73926989345193b133e538d5aeca36f12723162c
Reviewed-on: https://gerrit.libreoffice.org/26853
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-03 15:46:58 +00:00
Henry Castro
bad68fd0b4 sd: add status bar UNO commands
Change-Id: I7da065edf76ccdbf9e410756c4d1fe81462975ed
Reviewed-on: https://gerrit.libreoffice.org/26881
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-07-03 14:20:02 +00:00
Henry Castro
f41c20dc23 sw lok: add status bar UNO commands
Change-Id: I4ffa3a3e07d00cfac48e67a0c32e85de0eda803d
Reviewed-on: https://gerrit.libreoffice.org/26876
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-07-03 03:58:52 +00:00
Henry Castro
7e3e55c39e sc lok: add status bar UNO commands
Change-Id: I2dbed808a23609773baf9154820a7121c7919c70
Reviewed-on: https://gerrit.libreoffice.org/26809
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-07-02 23:44:36 +00:00
Rishabh Kumar
527b88efbd tdf#100728: Crash when area dialog is opened
Change-Id: I2246c5bf3a1d33e7a08fa9062e568a4c95fef571
Reviewed-on: https://gerrit.libreoffice.org/26875
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-07-02 20:34:35 +00:00
Christian Lohmaier
6cac840964 android: another constructor function that fell victim to tdf#74608
Change-Id: Ie7619ec157c1ce825ad82b2de8b5e7742fd5c96e
2016-07-02 17:23:21 +02:00
Christian Lohmaier
66be4feef7 android: prevent crash if storage is unavailable
Change-Id: I350acc1735d5fd22a27434fc5ccf2ab39bf3d2cf
2016-07-02 17:20:52 +02:00
Christian Lohmaier
3b219e5487 allow android ndk version 12.1.x
Change-Id: Id1bbc683afda021c0801327bceee10cb4f28e9f6
2016-07-02 17:17:53 +02:00
Michael Meeks
ef47ce2397 tdf#90336 - further cleanup of OpenCL options page.
Still problematic; since we only show OpenCL as being available
if it has already been initialized and used.

Change-Id: I5e82a3f778f4f2025408330b6d9da51402d01e79
Reviewed-on: https://gerrit.libreoffice.org/26866
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-01 19:02:57 +00:00
Miklos Vajna
3ebfc5b955 svx lok: add LOK_CALLBACK_GRAPHIC_VIEW_SELECTION
So a view can be aware where the graphic selections of other views are.

Change-Id: I0cc420cfe4bf3824fbfa1a58da889cac5e9a7b60
Reviewed-on: https://gerrit.libreoffice.org/26863
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-01 17:20:17 +00:00
Rishabh Kumar
a2c09913d8 Remove unused controls in Pattern tab
Change-Id: Ie53dbbe652413c1ce098d1690d68ae8acc491ca4
Reviewed-on: https://gerrit.libreoffice.org/26858
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-07-01 16:15:16 +00:00
Miklos Vajna
cca44fe229 lokdocview: replace handle_graphic.png with manual drawing
If we draw a black graphic handle manually, then it's possible to color
it later, this isn't easy if a bitmap is painted.

Change-Id: Ib4456fd5155862d52e3ffa79ee49c7bfd16fb742
Reviewed-on: https://gerrit.libreoffice.org/26860
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-01 16:02:01 +00:00
Miklos Vajna
d77d81604d CppunitTest_sc_tiledrendering: clear reference to local var in time
Should fix
<http://ci.libreoffice.org/job/lo_callgrind_linux/2013/console>.

Change-Id: I4ff4ddafbbb15ee360cb845afe8e8b4dbbf04460
2016-07-01 17:41:48 +02:00
Arnold Dumas
85aa807316 tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctor
Change-Id: I45b0ae284ccd34f53ee93114ae45ebacd212251f
Reviewed-on: https://gerrit.libreoffice.org/26857
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-01 15:26:58 +00:00
Samuel Mehrbrodt
e4532e9d14 Mention that this is about *toolbar* icon size
Change-Id: Id48edf2677d6adc31983ca21e248447af9a58a23
Reviewed-on: https://gerrit.libreoffice.org/26859
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-01 15:13:18 +00:00
Caolán McNamara
fe7b8bc9fd gtk3: XEmbed isn't going to happen
Change-Id: I7a7589a159a7fccdc224262bf5f91f8d98f5f619
2016-07-01 15:49:49 +01:00
Noel Grandin
b5f60ef841 fix accidental vcl::Region->Region
from my commit 8dbde084 "fdo#82577: Handle Region"

Change-Id: I55a7b7fc6a6f2cf270eb7f51c5e3fd1d1f59263f
2016-07-01 16:19:07 +02:00
Miklos Vajna
e3c36c789f sc: add LOK_CALLBACK_CELL_VIEW_CURSOR testcase
Fails with the sc/source part of commit (sc lok: add
LOK_CALLBACK_CELL_VIEW_CURSOR, 2016-07-01) reverted.

Change-Id: I4a1a7d97b744dd089fe15bd58af6cca5e0b79e8f
Reviewed-on: https://gerrit.libreoffice.org/26856
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-01 14:18:27 +00:00
Stephan Bergmann
4961274c5b fix mis-merge
Change-Id: I529b7abff98e38e503ffbcb39946e30d12a053cc
2016-07-01 16:05:56 +02:00
Caolán McNamara
6752590fec don't autocapitalize words that follow a field mark
Change-Id: Ia8efa88aaf47edba9a590c858d0ea30d7bfe2977
2016-07-01 14:49:03 +01:00
Szymon Kłos
4760c44c80 GSoC possibility to change icon size in the SidebarToolBox
+ Added registy entry to store icon size
+ Added UI to change settings: Tools -> Options... -> View
+ Loading last settings in the SidebarToolBox
+ Settings update listener

Update icon code from: framework/source/uielement/toolbarmanager.cxx

Change-Id: I1d713c50fccfc19e1c8ea82eba68556ddb76cd3c
Reviewed-on: https://gerrit.libreoffice.org/26362
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-01 13:31:46 +00:00
Mark Page
663b7aec30 Modify the ImpGraphic class, mpAnimation to use a unique pointer
Change-Id: Icb2be06cf5476d4d04752ab2270fe1c58453fe8f
Reviewed-on: https://gerrit.libreoffice.org/26791
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-01 13:05:20 +00:00
Miklos Vajna
8e3451c096 CppunitTest_sc_tiledrendering: replace ifdefs with a single makefile condition
Change-Id: I1dded11e0572dee7cd917a1aa8c2e2ca53b81d84
Reviewed-on: https://gerrit.libreoffice.org/26849
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-01 12:18:45 +00:00
Samuel Mehrbrodt
4c917dbf99 Slide transition sound dialog: Set default path to home dir
Not the gallery where user sees only one sdg file

Change-Id: I0f30f3d566c0f2e4784e0feb5825f1c3e5926804
Reviewed-on: https://gerrit.libreoffice.org/26848
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-01 12:18:07 +00:00
Samuel Mehrbrodt
faaa6a4bcb Add link option to sd file open dialog
Change-Id: I4627996fa142d350ba97aa53ac303dfdc7968f7e
Reviewed-on: https://gerrit.libreoffice.org/26847
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-01 12:16:41 +00:00
Samuel Mehrbrodt
5198c98337 Add new open dialog type: Play and link
This is needed e.g. for the "Slide transition sound" files
where we want to play files and also give the choice whether to link or not

Change-Id: I5aaef7152be8e5c0a0f88c4d7234926f233c5d92
Reviewed-on: https://gerrit.libreoffice.org/26846
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-01 12:15:08 +00:00
Stephan Bergmann
6373f9ec6d clang-analyzer-deadcode.DeadStores
Change-Id: I2b03835f83fca604f8ef4db2cb292e6123140e86
2016-07-01 14:14:41 +02:00
Marco Cecchetti
d3f5800a96 svg-export - Removal of the SVG 1.1 path API in Chrome
On Chrome browser most of shape effects and slide transitions did not
work anymore: that was due to the fact that several animations exploit
the DOM api for handling path segments of the svg:path element.
Starting from version 48 such an api has been removed from Chrome:
https://bugs.chromium.org/p/chromium/issues/detail?id=539385 ;
Moreover Chrome does not yet provide an implementation for the new
svgpath api introduced in SVG 2.0 draft: so there is no native support
for handling path data directly.

The present patch adapts the JavaScript implementation of the old SVG
1.1 path api proposed here: https://github.com/progers/pathseg .

Change-Id: I536202291e0b8895f91d9e499a32fa57c110b2c1
Reviewed-on: https://gerrit.libreoffice.org/26839
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-07-01 11:55:32 +00:00
Stephan Bergmann
b3b78c6016 clang-analyzer-deadcode.DeadStores
...after 19bacff27bd2201fb136963e11e865b8a31d849e "loplugin:singlevalfields in
sd"

Change-Id: Id0fb95abc3c4f2830abe833fe63f6ec26b9aa18f
2016-07-01 13:50:08 +02:00
Samuel Mehrbrodt
6fb44f527c filedlg: Improve code readability a bit
Change-Id: Ic018c5795fabc0bf8425b8b5cabae4ab6eb68317
Reviewed-on: https://gerrit.libreoffice.org/26845
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-01 11:34:19 +00:00
Michael Stahl
59e4bd0721 svl: remove pointless catch around "delete" statement
In C++11 the destructors are implicitly noexcept so if any of the
subclasses of SfxUndoAction would have a throwing dtor we would have
found out by now.

Change-Id: I4e044f8c2c391464cdc236bac15465860fa0ef62
2016-07-01 13:20:44 +02:00
Michael Stahl
e31914d7f4 python3: override LINKCC properly, it needs -pthread
Build on Fedora 24 fails with "Python/thread.o: undefined
reference to symbol 'pthread_key_delete@@GLIBC_2.0'"

Change-Id: If23838722e1cd0220c509d25932ae0539e8da7a1
2016-07-01 13:09:00 +02:00