Commit Graph

394279 Commits

Author SHA1 Message Date
Michael Stahl
ca6592c0ae remove executable bit from .mk files
Change-Id: Id79898bb4f71103830ad7f74da71fbd5102e4fb5
2016-07-01 13:09:00 +02:00
Stephan Bergmann
5a002a0ac6 clang-analyzer-deadcode.DeadStores
...after 19bacff27b "loplugin:singlevalfields in
sd"

Change-Id: Ic8dbc4d9f2710b848bfd462285ec86193e55ee8b
2016-07-01 12:50:34 +02:00
Stephan Bergmann
eeb852ea1e loplugin:unreffun
...after recently splitting up the test .cxx files

Change-Id: I11542454188b3636ef880beb7f28f2638828e99e
2016-07-01 12:31:38 +02:00
Stephan Bergmann
fb4580f6aa loplugin:unreffun
...after 0a93639221 "sd: split up sd_export_tests"
added assertion_traits<Color> to sd/qa/unit/sdmodeltestbase.hxx

Change-Id: Ief66367b6cd5499d75ac563b6f99427789394ff5
2016-07-01 12:22:19 +02:00
Marco Cecchetti
546c3469af bccu#1910 - better handling of not supported animation nodes.
Earlier, when a not supported animation node was hit all effects in
the same slide was ignored since the whole animation tree was
invalidated. This patch tries to minimize the impact of this issue by
removing only all children nodes of the direct parent container of the
not supported animation node.

Change-Id: I31896cf29d18e64ff44d7d4bcdc60392ac1c1ec3
Reviewed-on: https://gerrit.libreoffice.org/26838
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:53:44 +00:00
Marco Cecchetti
232541ef25 bccu#1900 - added support for discrete activities
Change-Id: Ib11f32faf50ba9616b0d5d517ae3820806ed42d2
Reviewed-on: https://gerrit.libreoffice.org/26837
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:53:07 +00:00
Marco Cecchetti
a3dae1ec55 bccu#1900 - additive and calc mode were not parsed correctly
Change-Id: I00c4af6a6c992fc41c4b993621cded59800b5e06
Reviewed-on: https://gerrit.libreoffice.org/26836
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:52:27 +00:00
Marco Cecchetti
14272dde34 bccu#1870 - added support for rotate attribute
Change-Id: I0b29fa65171c12c25122176af3c9b4e7a9c0826f
Reviewed-on: https://gerrit.libreoffice.org/26835
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:51:41 +00:00
Andras Timar
e545a16689 avoid 'Compiler Error C2026 string too big, trailing characters truncated'
Change-Id: I57e74cbf7bf3a51f73f554c1f17b8c4420a1e386
Reviewed-on: https://gerrit.libreoffice.org/26834
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:51:04 +00:00
Andras Timar
6b400cd64e bccu#1800 fix bogus loops in slide animations and transitions
Change-Id: Ic0b6a7b526f4ae09653d29f73bff7fde78a25cbf
Reviewed-on: https://gerrit.libreoffice.org/26833
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:50:27 +00:00
Stephan Bergmann
27b3bfbe31 loplugin:stringconstant
Change-Id: Ie5aee19517cff0c724f03f73c0e79a057ae9c2b6
2016-07-01 11:48:10 +02:00
Eike Rathke
835fa9bd68 no need to check twice
Change-Id: Iad2942851fced632c0c662bf754b1d687740105c
2016-07-01 11:47:32 +02:00
Eike Rathke
f45a78ac58 use GetInt32() for integer Add-In parameters
Change-Id: Id62acb1800b3a302d62900699a01d1a5cdf1ab56
2016-07-01 11:47:31 +02:00
Eike Rathke
415cd81d90 let GetInt*() truncate to integer towards 0
like it should always had been the case ...

Change-Id: I75b9e71bbaad5e356a45b416a3b42dc4becec801
2016-07-01 11:47:31 +02:00
Stephan Bergmann
3a944846a8 loplugin:defaultparams
Change-Id: I359b7c58fed6343f58a75bc2afedb78ff7c16719
2016-07-01 11:45:47 +02:00
Marco Cecchetti
880c6e40f6 bccu#1307 - svg filter - added support for clip region meta action
Change-Id: I90beea5e101a14f0dc9df8c7db0bb55782aba110
Reviewed-on: https://gerrit.libreoffice.org/26832
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:42:35 +00:00
Marco Cecchetti
0f95f4f99c svg filter - rewritten context handling
Change-Id: I9c18f6ca641de2957cbbf8fd57035f5aa2e5c294
Reviewed-on: https://gerrit.libreoffice.org/26831
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:41:58 +00:00
Marco Cecchetti
1085035078 svgfilter - polish code formatting
Change-Id: Ic63cfeb352326f3375ba664a775e58c566901320
Reviewed-on: https://gerrit.libreoffice.org/26830
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:41:20 +00:00
Marco Cecchetti
8dfeaeae47 lool - bccu#1307 - stop colors for background gradient was wrong
Change-Id: Ic5ddd4d3a3018c014a77b2e54d639b5589f9d477
Reviewed-on: https://gerrit.libreoffice.org/26829
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:40:40 +00:00
Marco Cecchetti
43e8c76321 lool - bccu#1307 - images must be scaled in a non-uniform way
Change-Id: I4093452d543ba45d8c1a2c1fc0811646e12c23a5
Reviewed-on: https://gerrit.libreoffice.org/26828
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-07-01 09:40:14 +00:00
Miklos Vajna
68c5c0bb7e sc lok: add LOK_CALLBACK_CELL_VIEW_CURSOR
So a view can be aware where the cell cursors of other views are.

Change-Id: Ifcf06c0019c6af8b859e2e92222e4f3fd18da74f
Reviewed-on: https://gerrit.libreoffice.org/26844
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-01 09:28:49 +00:00
Michael Stahl
3fc8262363 sd: sd_export_ooxml still takes the most time, split it in 2
Change-Id: Ib102ba9b54c4b7730c583e3cb5e769f70fcb5b09
2016-07-01 11:21:10 +02:00
Michael Stahl
0a93639221 sd: split up sd_export_tests
Move all PPTX export tests to a new file.

Change-Id: Idb90baf6b145cdfaf5301583489a7257c5fa23a4
2016-07-01 11:21:10 +02:00
Michael Stahl
f3cb21a3fb cppunittester: always print execution time of each test
Not much point in disabling this by default, nobody but the author
will find it.

Change-Id: I637b214644d2cc7bc70b8bca4f214955355ea951
2016-07-01 11:21:10 +02:00
Michael Stahl
110a500b68 re-enable unit tests accidentally disabled with HAVE_FEATURE_ATL
Macro is only true on WNT, but the tests should be enabled then.

Change-Id: Ife5657c8204c9906afd42b4b4671a7fa6356a748
2016-07-01 11:21:10 +02:00
Miklos Vajna
b020026741 CppunitTest_sal_rtl_ostringbuffer: fix loplugin:cppunitassertequals warnings
Change-Id: I1b7710556f179f35694c05e209854bbcb152041f
Reviewed-on: https://gerrit.libreoffice.org/26842
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-01 08:31:11 +00:00
Muhammet Kara
35de25aac0 Improve readability of OUString concatanation in SvxPixelCtlAccessible
, SvxShowCharSetVirtualAcc
, SvxBmpMask
, SvxSuperContourDlg
, and SvxTPView

It is more readable and more efficient as a bonus.
See: https://goo.gl/jsVAwy:

Change-Id: Id0641673e1e6fb04b3193c2b8e9a2ab3156b4552
Reviewed-on: https://gerrit.libreoffice.org/26794
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-01 07:19:28 +00:00
Justin Luth
1a13a9a46a remove stylename dependency from rtfimport
It was not the intention of this unittest
to specify the name of the style.
Better not to hardcode a "random" name in a unit test.

Change-Id: Ibf96f8c0e88ec61c4994d57c67d8958cde9a8d25
Reviewed-on: https://gerrit.libreoffice.org/26735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-01 07:14:25 +00:00
Stephan Bergmann
bfff963fef clang-analyzer-deadcode.DeadStores
...after 0f17e34330 "loplugin:singlevalfields in
chart2"

Change-Id: I111d6a0eb5380d9559799db348deb43594f90630
2016-07-01 08:53:14 +02:00
Takeshi Abe
faddbce32e Make SmStructureNode's ctor initialize the number of sub nodes
This also drops newly unused SetNumSubNodes() as a result.

Change-Id: I9b33cb547eb6883da4b45dc5760144cce8fa14ee
Reviewed-on: https://gerrit.libreoffice.org/26795
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-01 05:13:54 +00:00
Stephan Bergmann
45129b0a20 loplugin:badstatics: new static only found with libc++
Change-Id: I93f12629fe6aa4bddae7379a5a7ac4f4c42c7923
2016-06-30 21:14:45 +02:00
Rishabh Kumar
4fbd96f6b3 Minor changes for Pattern tab
Change-Id: Ibc10b24c2367fd7a6ca068ee61fd4098d2f66bdb
Reviewed-on: https://gerrit.libreoffice.org/26825
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-06-30 18:15:40 +00:00
Muhammet Kara
1a4da58395 Rename GetFoucsPosIndex() to GetFocusPosIndex()
Change-Id: Ic05d69976d053037c9d02cf5f8b843c6b590000c
Reviewed-on: https://gerrit.libreoffice.org/26803
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-30 17:55:34 +00:00
Eike Rathke
14e31d6cf4 Resolves: tdf#100440 check mode to be 0 or 1 for MONTHS(), YEARS() and WEEKS()
Needed to adapt the WEEKS and YEARS test documents to cope with the
change.

Change-Id: Ia52505418f4fed684bd04290c608e2a65eee2fbc
2016-06-30 18:53:50 +02:00
Caolán McNamara
ad59dcf7da everything is called Dispose, hard to find anything
Change-Id: I473ed39c975886a6be30860cb61f6fe59c5508a4
2016-06-30 17:17:33 +01:00
Mark Hung
0381026924 tdf#100179 correct cell merging in pptx.
Change-Id: I7a5bc6fb33c64d1ff398986eff5b960fe037df4d
Reviewed-on: https://gerrit.libreoffice.org/25791
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-06-30 14:55:41 +00:00
Szymon Kłos
5ee7caad68 GSoC added button with small padding
+ vcl builder setups action for custom buttons
+ new control: vcllo-SmallButton with WB_SMALLSTYLE property

Change-Id: I54891969f26d237eac8e45532906d76040264272
Reviewed-on: https://gerrit.libreoffice.org/26781
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30 13:38:45 +00:00
Caolán McNamara
675c8faefd Resolves: tdf#100692 crash in sidebar on deleting image from writer
stumbled on this in passing and it has the same bt as

http://crashreport.libreoffice.org/stats/signature/vcl::Window::setPosSizePixel(long,long,long,long,PosSizeFlags)

Change-Id: I1f19275029b05f353dfa823a2ff435e5045250a6
2016-06-30 12:49:06 +01:00
Samuel Mehrbrodt
d12ed381be tdf#65356 Photo Album: Disable "Insert Link" in the add dialog
since we have that option in the dialog directly

Change-Id: Id8f0e39df7c468759cb4dc4d94f0042f09c8296b
Reviewed-on: https://gerrit.libreoffice.org/26797
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30 11:43:06 +00:00
Samuel Mehrbrodt
e9891e5dd8 Add new open dialog type: Preview only (without link)
This is needed e.g. for the "Insert Photo Album" dialog
where we don't want the "Insert Link" option in the file open dialog (tdf#65356)

Change-Id: I01aecaaf8194a8123931b0482b4a37155654dfc2
Reviewed-on: https://gerrit.libreoffice.org/26796
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30 11:40:42 +00:00
Miklos Vajna
6168f10b62 sw lok: mix missing invalidation due to page calc in visible cursor change
Steps to reproduce in gtktiledviewer:

- two windows, then enable edit in both
- view #0: go inside a word
- view #1: select the same word
- press Del in view #1 -> no invalidation

Fix the problem by changing the LOK-specific GetPageNum() call in
SwVisibleCursor::SetPosAndShow(), so that it doesn't re-calculate the
frame, that way later when SwLayAction::TurboAction_() attempts to
re-calculate the layout, then the frame will be still invalid, and that
re-calculation then triggers the necessary invalidations.

Change-Id: I8c4472b9809537fcbd4a20c73f39be7ebca16b1f
Reviewed-on: https://gerrit.libreoffice.org/26802
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-06-30 11:37:37 +00:00
Eike Rathke
0ac0061b43 use GetInt*() in the most obvious places
found with /approxFloor.*GetDouble

Change-Id: Ice058c9cb318d7b0b0cadb9a26b4eb9f3691752f
2016-06-30 12:58:17 +02:00
Eike Rathke
2b376803a7 use GetInt*() in the most obvious places
found with /approxFloor.*GetDouble

Change-Id: I2a08d8c268e6c1d64270d9c9f343b69a62f27708
2016-06-30 12:58:16 +02:00
Eike Rathke
366a166936 use GetInt*() in the most obvious places
found with /approxFloor.*GetDouble

Change-Id: Ib14a60e872c6a3adde2aa11f96f391c42b4e510c
2016-06-30 12:58:16 +02:00
Eike Rathke
f8f655da59 return SAL_MAX_... instead of 0 for GetInt*()
Most places will use GetInt*() to obtain flags or enums in a range
0..somenumber and explicitly check for valid values, so returning MAX instead
of 0 will save us an extra comparison of nGlobalError and push/return.

Change-Id: I84c5d693d3642ea643308dc4650a391de2ebe82a
2016-06-30 12:58:15 +02:00
Eike Rathke
2087b8f2f6 introduce ScInterpreter::GetInt32WithDefault()
Change-Id: Ic3a5c65e4846a4582461564f572be83897b1d12d
2016-06-30 12:58:15 +02:00
Eike Rathke
75c364e426 introduce ScInterpreter::GetUInt32()
Change-Id: Iba1a8cfcab01083a23b4956d7da51651ad3a447f
2016-06-30 12:58:14 +02:00
Eike Rathke
7b2432a2b7 use GetInt16()
in the places changed by 2606915f0f and
0026972212

Change-Id: Iea056b3101c5c41ee932defe13edf4769cb9eab1
2016-06-30 12:58:14 +02:00
Eike Rathke
7dd093b283 introduce ScInterpreter GetInt32() and GetInt16()
in preparation of replacing oversimplifying casts and special handling
like in 2606915f0f and
0026972212

Change-Id: I81327dbc2218f40359c3485cf3d639d19fd69cef
2016-06-30 12:58:13 +02:00
Stephan Bergmann
2ea01fb900 loplugin:badstatics: further (Linux-only) static only found with libc++
Change-Id: I048212e3feb3f548d5a65940dd71ccb71cade778
2016-06-30 12:53:40 +02:00