394279 Commits

Author SHA1 Message Date
Takeshi Abe
b39596b109 tdf#47813 Fix alignment for SmUnHorNode
Originally SmUnHorNode::Arrange() was somewhat kludgy. This change
implements a similar manner with SmBinHorNode::Arrange().

Change-Id: Ic18d2e7f70becfabb2c651719926e358a4585526
Reviewed-on: https://gerrit.libreoffice.org/26841
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-08 12:10:37 +00:00
Caolán McNamara
17cb84338d Resolves: tdf#100713 on cancel curData points to deleted parents vector entry
Change-Id: Ic2f313c357ce9526eb045791e2d27451e52a7572
2016-07-08 13:01:56 +01:00
Takeshi Abe
2fcb8022a2 starmath: Fix missing negation
which was a regression from fa614231733800f4a961b77e36c86f8840d12251.

Change-Id: Ia7bab72dbd6f82519024809cf6384e1442a02327
Reviewed-on: https://gerrit.libreoffice.org/27033
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
2016-07-08 11:43:22 +00:00
Caolán McNamara
aac93f19ad don't need to link to these libraries anymore
Change-Id: I0e9424180e0c909c35ed94436c08693fa32edbba
2016-07-08 12:16:01 +01:00
Caolán McNamara
b2c6c91391 Related: rhbz#100713 move extensions restart to a better place
move it to when the dialog is closed rather than trying to
launch it as soon as any modifications take place because
those are happening during threaded code and the restart
is always cancelled by the dialog itself leading to repeated
restart dialogs

Now at least it doesn't crash, but if we open an oxt on the command
line, a restart will reopen it, which is probably not what we want.
Maybe this restart on an extension modification is a bad idea in
the first place.

Change-Id: Ib7d6179e6703ed3353fce44c3e54f5be1c1dfa68
2016-07-08 12:14:54 +01:00
Stephan Bergmann
d44c1c2ca6 LinkParamNone can be complete but uninstantiatable
Change-Id: I39bd23cd95ff97c6aeb00c9b02901ad6262767c1
Reviewed-on: https://gerrit.libreoffice.org/27031
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-08 10:53:10 +00:00
Armin Le Grand
f80e6b9ead renamed local var 'clipRegion' to silence werror
Had to rename 'clipRegion' to 'localClipRegion' to silence
a warning created by [-Werror=shadow]. The shadowed entry
is a function definition, so in this case the warning is
questionable and maybe unwanted by the compiler

Change-Id: I05aa93ad1d9b34dc8e82a4a2a099cf8070c01463
2016-07-08 10:45:59 +02:00
Caolán McNamara
467887d3c9 Related: tdf#100713 fix more recent bug to try and see older bug...
at the moment AddonsOptions::Notify is called with a null this
which crashes during adding an extension

regression from...

commit 3bdc5063f942b9ea3b6e39e707926fbc516c19f9
Date:   Wed Jun 22 02:30:43 2016 +0200

    tdf#89329: use shared_ptr for pImpl in addonsoptions

Change-Id: Ic28951e56bb8beca2a01ef2a1864eadcf3864e5b
2016-07-08 09:22:46 +01:00
Caolán McNamara
efbe959732 gtk3: this is why the active position in a menu jumps to some weird place
if there is a reason for this then perhaps it needs to be protected
with pEvent->window == widget_get_window(pThis->getMouseEventWidget()

Change-Id: I714b67c3e6ace932a605dcd00d337c92c5fdfd19
2016-07-08 09:22:46 +01:00
Miklos Vajna
f9f50f2e52 CppunitTest_sal_rtl_ostring: fix loplugin:cppunitassertequals warnings
Change-Id: Ie5168b9844dadd042bcbd825e8f48030ac1ef91c
Reviewed-on: https://gerrit.libreoffice.org/27032
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-08 08:10:58 +00:00
Zdeněk Crhonek
6e226ab4ad add BITXOR test case
Change-Id: If70d48667d54258e0673f12a1ec05300c15f949c
Reviewed-on: https://gerrit.libreoffice.org/26928
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-08 07:29:36 +00:00
Justin Luth
a60b2f7c22 tdf#64372 docx import: don't ignore continuous section break
If the previous break was also a continuous section break,
this break was simply ignored ever since
commit 1fdd61db155cf63d5dd55cc2bfb45af33796e131.

Thus, the default handler took over and assigned PROP_PAGE_DESC
if there was some kind of page style known
(either the first page/Standard defaults or any "converted" styles
that had been created) which effectively became a new page break.

Change-Id: I839570b0330ba274552cc671014e997c42765f4b
Reviewed-on: https://gerrit.libreoffice.org/26567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-08 07:24:10 +00:00
Miklos Vajna
f8847d3ab4 oox: indentation fixes
These files had consistently no space between the "const" and "&", keep
it that way.

Change-Id: I5463c488d807344d67fb22ad544c049ea749be94
2016-07-08 09:05:43 +02:00
Miklos Vajna
9d1f51307d Upgrade libxmlsec to 1.2.21
Obsoletes xmlsec1-ooxml.patch.1 and xmlsec1-vs2015.patch.1.

Adds xmlsec1-keyinfo-revert.patch.1 till the LO side is adapted to the
new xmlsec requirements.

Change-Id: I1a46ad8fd7e9c8b4fa7a97591a1d90922969393d
Reviewed-on: https://gerrit.libreoffice.org/24403
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-08 07:01:58 +00:00
Zdeněk Crhonek
9960537e66 add CEILING.PRECISE test case
Change-Id: Id154e8033f8caa0d6ff9c6e5550005d9ac4a4659
Reviewed-on: https://gerrit.libreoffice.org/27010
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-08 06:38:40 +00:00
Zdeněk Crhonek
1c72b4fe15 add ODDLPRICE test case
Change-Id: Id788779808e6c6a362d5e793ed9eb6a22be23ae7
Reviewed-on: https://gerrit.libreoffice.org/26924
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-08 06:38:19 +00:00
Zdeněk Crhonek
ba0ff617fb add IFNA test case
Change-Id: I0d5a4a86166c52ad619112d01e3b5e00488c8578
Reviewed-on: https://gerrit.libreoffice.org/26927
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-08 06:38:01 +00:00
Zdeněk Crhonek
6762a87618 add CEILING.MATH test case
Change-Id: I4914056ffc3fff08c94058f7593ad616ad487386
Reviewed-on: https://gerrit.libreoffice.org/27008
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-08 06:37:27 +00:00
Zdeněk Crhonek
9b2f818895 add CEILING.XCL test case
Change-Id: If17b2cf3488e86d7c8cd8d022f6f4d0629cc95fb
Reviewed-on: https://gerrit.libreoffice.org/27014
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-08 06:37:12 +00:00
Stephan Bergmann
97be7f906d loplugin:nullptr
Change-Id: I5878df00006ca8a1b4e249c4b3775f21c610d151
2016-07-08 07:59:13 +02:00
Markus Mohrhard
54f2a4184d tdf#100295: try to cover second place in curl using GetTickCount64
Change-Id: I08e51f70c7b0c92a8c1b8b06e7eb2f1437e2f3f4
Reviewed-on: https://gerrit.libreoffice.org/27025
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-08 00:45:36 +00:00
Stephan Bergmann
00a9f80948 loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: Icd5cc30d88f514a724dfe4858d0077650584820d
2016-07-07 23:20:44 +02:00
Stephan Bergmann
a9d87f33d2 loplugin:nullptr
Change-Id: Ic37247f1e4ffe5a32e2fbb73464dfdfa59a79296
2016-07-07 23:07:06 +02:00
Armin Le Grand
63ed9d7f5b Related: tdf#50613 use an own instance of ThreadPool
Using the global ThreadPool (getSharedOptimalPool()) can lead to
problems when more than one usage executes and one of them
already calls waitUntilEmpty() what of course influences the
other usage. Thus I added an own instance of ThreadPool for
async loading of chart models in writer

Change-Id: I4bea64af0d36e87081abec95c75574966d0fe5b9
2016-07-07 22:32:39 +02:00
Armin Le Grand
5046ebd813 tdf#82214 optimize PatternFillPrimitive and SVG
Use buffering in the drawinglayer, and don't do slow stuff in the
windows gdi renderer.

Conflicts:
	svgio/source/svgreader/svgstyleattributes.cxx

Change-Id: Id955ee6a3b03e568c2678f02d77af35d2e5ba1d4
2016-07-07 22:32:39 +02:00
Armin Le Grand
4609380bb0 tdf#82214 optimize performance for primitives
See svg bug doc, which is processed quite slowly. Beyond needing faster
renderers, there is also demand to improve the handling of primitives
created by SVG import.

Conflicts:
	drawinglayer/source/primitive2d/patternfillprimitive2d.cxx
	vcl/win/gdi/gdiimpl.cxx

Change-Id: I10992a5746b8b2d6b50e3ee3fe415a035685c9ba
2016-07-07 22:32:39 +02:00
Armin Le Grand
c1f476d918 tdf#99165 avoid passing empty control points for beziers
Some graphic sub systems have problems to create correct
geometry for fat line drawing when 'empty' control points
are handed over for bezier curves. Avoid this by offering the
mathematical correct default in that cases.

Change-Id: I20f484ef4537076889d832d83581844690514acc
2016-07-07 22:32:39 +02:00
Armin Le Grand
3dc8ee7d8e sw: tdf#50613 fix async chart load handling
Especially if synchronous loading is requested, an async worker is on the way
and we would need to 'wait' for the data.

Change-Id: I20f9938738c1b46bda6b9a7f5a761e82153aed3b
2016-07-07 22:32:39 +02:00
Armin Le Grand
68e8d075d9 sw: tdf#50613 fix waitFinished into a loop
Change-Id: Ic8a720657c326d8d51bb3a73688b8f02b7096488
2016-07-07 22:32:39 +02:00
Armin Le Grand
9f0766917a tdf#50613 add support to load charts asynchronously
Generating primitives for chart visualisation can be moved to a
paralell executed task that loads the chart, thus speeding up
initial visualization. This is not possible for e.g. PDF or print
targets, only for edit visualization. On fallback, the replacement
images of the charts are used which are metafiles and have less
quality as primitives, but load quicker.

Change-Id: I68caa9e1bec50832bce535b5f54633d53cdef037
2016-07-07 22:32:38 +02:00
Armin Le Grand
de7d596d11 tdf#83360 avoid inconsistent connector path data
When loading/importing connectors from ODF format, use the available path
data _only_ if the redundant data of start and end point coordinates of
path start/end and connector start/end is equal. This is to avoid using errorneous
or inconsistent path data at import of foreign formats. LibO itself always
writes out a consistent data set. Not using it when there is inconsistency
is okay since the path data is completely redundant, just to avoid recalculation
of the connector's layout at load time, no real information would be lost.
A 'connected' end has prio to direct coordinate data in Start/EndPosition
to the path data.

Change-Id: Id5aff0889e1e61112b6185f2384b7922f90a16a9
2016-07-07 22:32:38 +02:00
Armin Le Grand
64e1113916 tdf#50613 buffer OLE primitives for charts
If OLE is a chart, buffer the primitives used for presentation as
info at the SwOLEObj, after getting them the first time using the
ChartHelper.

Change-Id: I6d7486185f6eac450de9328d37ea800f424f351b
2016-07-07 22:32:38 +02:00
Armin Le Grand
30fdc46969 tdf#50613 add close_path to correctly show closed polygons
For closed polygons it is essential to add a close_path to
correctly show the last line join.

Change-Id: Ib6f37bbc5e85133f21a936b186eb0ab12773f7da
2016-07-07 22:32:38 +02:00
Armin Le Grand
cb382034b0 tdf#50613 speedup fat line drawing on linux using cairo
Drawing fat lines is slow on linux due to X11 having no direct
support for it. This leads to creating the PolyPolygon geometry
for each fat line, then tesselate and draw as trapezoids. This
is not buffered in any way and is done at each paint.
As a side effect, fat lines composed of multiple anti-aliased
lines also show errors since AA-ed edges do not add up graphically.
Since we have cairo now available it makes sense to use it
for fat line drawing, it is markedly faster despite being a software
renderer. No such gains for PolyPolygons though.

Change-Id: If4001556e2dd4c15ecf2587cad6ce1e864558f2d
2016-07-07 22:32:38 +02:00
Rishabh Kumar
8550366138 Revert "Add XBitmapList to SvxPresetListBox"
This reverts commit a38901295082ff72948a18fe9c82c37973061490.

Change-Id: Ibfee6df54c24baf8b4e9cfc47be3f12e0ebd82a4
Reviewed-on: https://gerrit.libreoffice.org/27020
Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
Tested-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-07-07 20:10:19 +00:00
Mike Kaganski
d1a32a01be tdf#100783 Avoid infinite recursion in Content::getObject()
With certain CMIS host URLs, it is possible that exception handler
in Content::getObject() will recursively call itself with the same
data (xParent from the same URL).

This patch checks if the new URL is not the same as own, to avoid
this.

Change-Id: Ifaeb4ff27a9c809c5c96fa35ec190c3263a8fe62
Reviewed-on: https://gerrit.libreoffice.org/26977
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2016-07-07 19:49:35 +00:00
Rishabh Kumar
a389012950 Add XBitmapList to SvxPresetListBox
Change-Id: I104463039f3aad5d19b3badca9a104021acf3b94
Reviewed-on: https://gerrit.libreoffice.org/27012
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-07-07 19:42:47 +00:00
Rishabh Kumar
bae5a12b04 Increase spacing between SvxPresetListBox entries
Change-Id: Ia92ab9afd2cba5b5f327eb6ff722ea51ae5dba2f
Reviewed-on: https://gerrit.libreoffice.org/27018
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-07-07 19:21:35 +00:00
Julien Nabet
0f54db1ce9 Simplify a bit by using return iterator from vector erase func
Change-Id: I5d927171cb05a253ef8f5f8abd9af11b499f9fc0
Reviewed-on: https://gerrit.libreoffice.org/25786
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-07-07 19:02:29 +00:00
Rishabh Kumar
cdf3a3907e Change fill styles correctly
Change-Id: I0a20693d5db1df5f560acdf014aee05360854e9b
Reviewed-on: https://gerrit.libreoffice.org/27016
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-07-07 17:42:19 +00:00
Stephan Bergmann
eba4f69a32 loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: I76cfdcd031430dc10c464896af2e79221e9da0c3
2016-07-07 18:59:55 +02:00
Stephan Bergmann
3b6a0b1e66 loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: Ie6dd8317cb5add8a5072dd6aca2833d2d22b78d9
2016-07-07 18:59:55 +02:00
Stephan Bergmann
8c81f307ee loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: Ide1102f4dcc5f31de0f896b570fe453b8074454d
2016-07-07 18:59:55 +02:00
Stephan Bergmann
da7259b584 loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: I0d1ee65be8a3e4b01454dba34bbeb4de58744853
2016-07-07 18:59:55 +02:00
Stephan Bergmann
04aed0574f loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: I7b11fa9efc507635506bfedb141ad02c2afa68c9
2016-07-07 18:59:55 +02:00
Stephan Bergmann
dad4ddbbde loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: I0add8faa004c14226ef76125a55dc9e82b37a488
2016-07-07 18:59:55 +02:00
Stephan Bergmann
69257ddb57 loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: Ia113176ebeca497c557ace01408467b17bcdfe31
2016-07-07 18:59:55 +02:00
Stephan Bergmann
e4d7ed0394 loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: I1d02b91f908c744dd3f7664cd453a791da7bd675
2016-07-07 18:59:55 +02:00
Stephan Bergmann
5f1e7fe6f0 loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: I08992bb66d5459333e018bb52dceee3e808fac8b
2016-07-07 18:59:55 +02:00
Stephan Bergmann
716caf6fe0 loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: Iac3011e99956d1ebb288184fd93555973c76ccdc
2016-07-07 18:59:55 +02:00