412155 Commits

Author SHA1 Message Date
Stephan Bergmann
b51fe8ddc1 Remove unused m_aBatchVector members
Change-Id: I7b7ff3295fa5eb87d113b48dcff0cf3c0b12b4ff
Reviewed-on: https://gerrit.libreoffice.org/41780
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-01 13:40:35 +02:00
Eike Rathke
715569984e Updated core
Project: help  5c2654302e9e4dcf45f802e8d31e53f55251c367

Rename Help CONVERT to CONVERT_OOO, CONVERT_ADD to CONVERT, tdf#69539

UI function name wise this was already done for 5.3, see
https://bugs.documentfoundation.org/show_bug.cgi?id=69539

So CONVERT actually matches the ODF definition and Excel and what the
user expects.

Change-Id: Ifdcbedc324dc5b4c8e43f2428a5c02dbe97d48c0
2017-09-01 12:37:50 +02:00
Eike Rathke
78bedc094f Use named enum/constant instead of comment
Change-Id: I91c6e50518d2430e32312ba35f9ff5d76635460e
2017-09-01 12:09:51 +02:00
Caolán McNamara
69c1e6c548 Resolves: tdf#112063 ensure closing dialog is not parent for file dialog
Change-Id: Iea2ecaf1669cf7af00f00b1f0b32e24d34ec3757
Reviewed-on: https://gerrit.libreoffice.org/41764
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-01 11:49:45 +02:00
Miklos Vajna
fa7e150241 android: remove a hard to address TODO
NSS upstream doesn't seem to support building static libs. The benefit
of avoiding a few lines of extra java code doesn't appear to outweigh
the cost of patching NSS to provide static libs & carry on those patches
in our LO-bundled NSS.

Change-Id: I01fc0b1ff076923fec64b469529d1b920c1d91c2
2017-09-01 11:18:50 +02:00
Luke Deller
14bb680949 Insert blank page when first page number is even
When the page number is explicitly changed at a page break,
LibreOffice will insert a blank page if necessary to ensure that
even page numbers appear on "left" pages.

This commit fixes a case that was missed: the case where the page
number of the very first page in the document is explicitly set to
be an even number.

Also:

 - adjust a couple of unit tests which were referring to specific
   physical page numbers, that were not expecting this blank page to be
   there

 - enhance SwModelTestBase::parseDump to support xpath expressions
   evaluating to simple values rather than nodes, for use in a
   test case for this change

Change-Id: I1f41760c3bb17bdffb868cf32a1331de87d1d0e1
Reviewed-on: https://gerrit.libreoffice.org/39858
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-01 10:45:43 +02:00
Miklos Vajna
feb463e93f xmlsecurity: fix inconsistent param naming in interface/implementation
Don't talk about enumeration when it's a number.

Change-Id: I756063534b38478c382eaf72829091a4e27a6c4f
Reviewed-on: https://gerrit.libreoffice.org/41779
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-09-01 10:33:33 +02:00
Tor Lillqvist
4ee81b9db3 No need to give a new name to a Timer that was already named when created
Change-Id: I995ccf18b24a6bb3950a23d8feaed6494d82cd3d
2017-09-01 11:08:01 +03:00
Julien Nabet
6a7bbef036 Replace list with a vector in PutData (sc)
+ revamp a little bit by using unique_ptr

Change-Id: I07fa08d1981db65dbb22e887fcab0e8a6ca64b58
Reviewed-on: https://gerrit.libreoffice.org/41774
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-01 09:36:53 +02:00
Noel Grandin
65ca7bd49a call SetPriority() on correct Idle
Change-Id: I56ce5607d77410b9252a7fa1093325dc8d67983c
Reviewed-on: https://gerrit.libreoffice.org/41760
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-01 09:26:25 +02:00
Matthias Freund
ca208daed3 tdf#98315 - Function Wizard showing Breeze icons when in Sifr theme
Fixes the missing link.

Change-Id: Id138e0fd34293194b32c22575d1a763aefe0da05
Reviewed-on: https://gerrit.libreoffice.org/41775
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-01 03:30:12 +02:00
Olivier Hallot
3b33f01871 Updated core
Project: help  7efd9647910ebfe0d2eb6050b812fd2894a30dcb

Give Safe Mode more visibility

Change-Id: If1e446aed65524f429eb3d56f9127e79f5aba44a
Reviewed-on: https://gerrit.libreoffice.org/41778
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-09-01 00:21:47 +02:00
Olivier Hallot
dbaf057240 Updated core
Project: help  ec8bc0cdb172478c9825dc434219519f702c2ac7

Add language detector when landing in helponline

Change-Id: I3481024a7503ea12d9bf8075e3045ab2b8801d20
Reviewed-on: https://gerrit.libreoffice.org/41773
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-09-01 00:21:22 +02:00
Bartosz Kosiorek
baed960b8c tdf#89139 Fix exporting of DateTime to CacheDefinition according to ISO 8601
With this commit, the date is saved in Excel format, like:
"2009-07-06T10:53:02"

We are now exporting attributes:
  "minDate"
  "maxDate"
  "containsDate"

This is necessary to export properly .xlsx file. Without that MS Office 365
is displaying error, and it is not even trying displaying .xslx file content
Change-Id: I1239f5582173afe99bf9178fd4edd1dc5ca28e8e
Reviewed-on: https://gerrit.libreoffice.org/41162
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-09-01 00:20:31 +02:00
Gabor Kelemen
e3c2968b78 tdf#111734 Reorder buttons to reach them with the Down arrow
This seems to be enough to step through the buttons with the Down arrow.

Change-Id: Ib9ad76bedb6abbf87164aafdf1c95cc438af8c3d
Reviewed-on: https://gerrit.libreoffice.org/41772
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-31 23:59:17 +02:00
Julien Nabet
4c99b8a9de Replace some lists by vectors (+rename vars)
Change-Id: Iad4e3cc13f7908840ef45a04ea4b551d3b0fc487
Reviewed-on: https://gerrit.libreoffice.org/41771
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-31 22:31:32 +02:00
Stephan Bergmann
1007e74d05 Remove unused desktop/StaticLibrary_minidump.mk
...after f4c68d3ad80734e15d093eeee211519e97e2a8ec "use a dynamic library for
minidump shared code"

Change-Id: I155fdfbdcd6bdeff4def94c713c4372c13c3a0b2
Reviewed-on: https://gerrit.libreoffice.org/41732
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-31 21:46:13 +02:00
Julien Nabet
70d9ae239b Use vector and replace m_aBatchList by m_aBatchVector
Change-Id: I7c2c529eb78679f9733374bf0785773684c728c4
Reviewed-on: https://gerrit.libreoffice.org/41770
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-31 21:44:10 +02:00
Julien Nabet
39c6112b5b Replace list by vector for getResourceStringWithSubstitution
Change-Id: I0b09a575971286ecc4d3bbc40926b949e9ab28c0
Reviewed-on: https://gerrit.libreoffice.org/41768
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-31 20:52:16 +02:00
Caolán McNamara
70b9aa7bc1 Resolves: tdf#112122 Use EndElement instead of dtor to call throwing methods
Change-Id: I1cc3b9af4089f1e657c5c63e0911aac8bdce04f3
Reviewed-on: https://gerrit.libreoffice.org/41756
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-31 20:20:13 +02:00
Justin Luth
c071e5f685 tdf#108765 DOCX: after import, allow default styles again
During import, we don't want LO's style defaults to intermingle
with those of MSO [1]. However, if any styles are NOT defined by
the document itself, then we want to use that new style with
appropriate defaults.

For example, if footnotes were never used, that style might not be
defined in the .docx file. Later, if a user inserts a footnote
for the first time, we certainly don't want the "default paragraph"
settings. Instead, we want the default "Footnote" settings.

[1]: see commit b95d203bc17c83ec0fe5139f519d53ed1d842d3a

Change-Id: Ia71490e795885d3c16f764d0f716f6499765cb67
Reviewed-on: https://gerrit.libreoffice.org/41546
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-08-31 20:13:00 +02:00
Justin Luth
b55d866101 tdf#108932 - prevent textbox shrink from actually growing
fix regression from a4dee94afed9ade6ac50237c8d99a6e49d3bebc1 for
a particular situation - where the textbox flowed onto the following
page.

Change-Id: I58fe2909411c4e5e484083cfc395976f0bc4ba17
Reviewed-on: https://gerrit.libreoffice.org/40558
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-08-31 20:09:32 +02:00
Eike Rathke
04d70c0999 Upgrade to language-subtag-registry-2017-08-15
Change-Id: I437a86de2de2b3f660b462cfb0ff2167d9cc7a2d
2017-08-31 18:55:01 +02:00
Noel Grandin
1cdaec1931 make the ScColumnsRange iterator return SCCOL
since we don't want to expose internal details like the ScColumn to most
of the code, make the ScColumnsRange iterators return SCCOL instead of
ScColumn*

Change-Id: I67a58df90959170105255d18e7dd38ef0d6e3c11
Reviewed-on: https://gerrit.libreoffice.org/41719
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-08-31 18:29:42 +02:00
Christian Lohmaier
0aad6244eb need to manuall load all native-libs on e.g. Jellybean
511ae02c6457e69cb6daab871acd9c3e7d64e2e3 introduced additional libraries
that are not merged to the single liblo-native-code.so
These need to be manually loaded in correct order. See
https://stackoverflow.com/questions/11058898/loading-shared-libs-that-depend-on-other-shared-libs
for details.

Change-Id: I34b279b69de8a0f8f58f8f980e5b3a7347cd0439
2017-08-31 18:29:07 +02:00
Stephan Bergmann
36910b444c Revert loplugin:constparam behavior when param is subject of cast
...cf. 72cfd4d024aa9deb68010824a804f252e37b8388 "loplugin:constparams: Also
handle ObjCObjectPointerType"

Change-Id: Ieec294d721002cac0c37bf2590a9ce20b3e123e3
2017-08-31 17:55:52 +02:00
Eike Rathke
1897812ed4 Classify ocPercentSign as Array capable
Actually it's implemented in RPN as Array 100 ocDiv, and ocDiv is Array
capable. Not being classified as Array capable resulted in ArraySize times
matrix-Div being executed, effectively ArraySize*ArraySize div operations.

Change-Id: I23366b5aa9c146cc59dc880f2a561348f7977329
2017-08-31 17:29:22 +02:00
Miklos Vajna
880d092e90 vcl PDF export: remove no longer direct curl dependency
The relevant code has been moved to svl.

Change-Id: Ib635de3ec541d2ef3b7f54071d444356ef076711
Reviewed-on: https://gerrit.libreoffice.org/41745
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-31 17:09:02 +02:00
andreas kainz
3dc349b0ab sifr add charmapcontrol icon for new drop down function
Change-Id: Idc01a4bb82cbfad57f28d26d4859db685184982e
Reviewed-on: https://gerrit.libreoffice.org/41690
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-08-31 16:04:10 +02:00
Caolán McNamara
1b7d983684 Resolves: tdf#112123 check m_xAutoStyles like in similar methods
Change-Id: I099da789a0e64fd862d09bb462ccb699e1dc8b9f
Reviewed-on: https://gerrit.libreoffice.org/41751
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-31 15:44:32 +02:00
Eike Rathke
13787b61d2 SYLK import: init nRefCol,nRefRow with start col,row instead of 1,1
So in a malformed document that does not specify ;X;Y;C;R before ;M a 1x1
matrix formula is created at nStartCol,nStartRow instead of 2x2

Change-Id: Idcc0f9d8c65bb142587fa6419af6f4dcb6209a0e
2017-08-31 15:27:51 +02:00
Stephan Bergmann
e601a2cf16 Fix silent merge conflict
Change-Id: I8879560850b4cf94984e3b3657800273b276fcdb
2017-08-31 15:24:07 +02:00
Miklos Vajna
3d1bb76ebf tdf#112109 sw: split section frames inside table cells, ignore nested tables
Commit f8a76d218305a56d15b82b9dac4fafa558872780 (tdf#108524 sw: split
section frames inside table cells, non-split text frames, 2017-07-06)
added support for moving text frame masters to a next page inside
section-in-table frames. But the code in SwFrame::GetNextSctLeaf()
responsible for this is not up to nested tables, so don't try to split
sections in this case.

Otherwise we'll end up with frames which are marked as "in table", but
don't actually have have table frame parents, so we crash in
SwFrame::IsFootnoteAllowed() which assumes being in a table means a
table frame parent.

Change-Id: Iff19a4eda21a4dbfb9562dea7af8ec6767d47873
Reviewed-on: https://gerrit.libreoffice.org/41748
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-31 15:22:40 +02:00
Michael Stahl
98552e4652 tdf#112122 xmloff: inserting index marks into editengine throws
Catch the exception, since that isn't even invalid input, editengine
just can't do it.

Change-Id: I362923889add4f1a1d3f8f18b0795993119d54b1
2017-08-31 15:20:25 +02:00
Dennis Francis
c864fc9eab tdf#111939: Fallback to getting view data from best view shell...
...when ScDocShell::GetViewData() returns nullptr. This is needed
when a macro is run from the macro editor window instead of running
the macro from Tools menu in the Calc window.

Change-Id: I89c23c2ec08e8e9907f02eb1389236111530058b
Reviewed-on: https://gerrit.libreoffice.org/41733
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
2017-08-31 14:45:38 +02:00
Miklos Vajna
0906937a5d sdext: fix loplugin:constparams warnings
Change-Id: I1dd57031f8c83241ef4cfa5b22db7a34657ab0bd
2017-08-31 13:48:20 +02:00
Caolán McNamara
4091841023 ofz#3240: avoid oom in gif loader
Change-Id: Ifd00962ed607166b5521a3977a3021fb7b24957e
Reviewed-on: https://gerrit.libreoffice.org/41747
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-31 13:15:17 +02:00
Tor Lillqvist
2e1cafaf66 Bin fairly pointless default for parameter that was defaulted just once anyway
Change-Id: If6d7c8f3223a45803a05d4950abe27bd90ac6dc6
2017-08-31 14:07:54 +03:00
Katarina Behrens
7cc22cb069 Updated core
Project: help  d32748eb92d52f1163ff560529ac488dfb25a3b7

tdf#105606: Clarify access to X509 certificate storage

* hint to MSIE on Windows, it's perhaps the easiest
* MacOSX uses TB/FF storage
* point to Tools > Options way to choose which TB/FF profile to use
* env. variables are so 90ties

Change-Id: I6aef05d1f71f98c71cfcc0278b0e5d373959f0ca
Reviewed-on: https://gerrit.libreoffice.org/41743
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-08-31 13:07:10 +02:00
Tor Lillqvist
1d1a1ff731 No need to call SetDebugName() when we already pass the same name to the ctor
(Well, actually there wwre a minor difference, "sc ScModule IdleTimer"
vs. "sc::ScModule aIdleTimer", and ditto for "SpellIdle", but that is
hardly essential if even intentional?)

Change-Id: I18a2af0d25c40404a41b1461664feda73183881e
2017-08-31 14:06:34 +03:00
Christian Lohmaier
66518ead51 use extractNativeLibs="false" for less disk usage and faster installation
no need to extract the (huge) nativve lib to the device's filesystem on
newer android versions (Marshmallow and later) - can access the .so from
within the apk if it is uncompressed.
While the standalone apk will be larger, the delta-update mechanism of
playstore can be more efficient, so you get:
* faster installation (since the file doesn't need to be extracted)
* less disk usage on device (for same reason)
* smaller delta-updates for playstore

drawbacks
* larger standalone apk
* on older android version more storage needed (the increased size of
the standalone apk), as those will still extract the native-lib

Unfortunately uncompressed it exceeds the current maximum size for
single apk files in playstore (100MB), so cannot use for release-builds

also revive installLocation attribute to allow installation on external
storage and move from manifestPlaceholders from defaultConfig to release
buildType (as otherwise gradle complains about having "Multiple entries
with same key")

Change-Id: Id07ac9c144886bb89abaf7b5b4bc7bd548f27247
2017-08-31 12:49:13 +02:00
Christian Lohmaier
e19100212c android: use sp (instead of dp) for font-size
Change-Id: I11dbf24b38c08b4dfd3cc64dbacbcd949a37b833
2017-08-31 12:49:12 +02:00
Christian Lohmaier
6f29e5cb30 min and target SdkVersions are taken from gradle
Change-Id: I2eeb265b101b126f6bf268c9c5fa0195a44b0ce7
2017-08-31 12:49:12 +02:00
Stephan Bergmann
6d57d6c40f Adapt lopluign:constparams to variadic CXXOperatorCallExpr
Change-Id: I21c7a0fb447b5ba0a7aa0ddc690b969b156a91f3
2017-08-31 12:14:41 +02:00
Stephan Bergmann
9a81c6933b loplugin:constparams: xmlsecurity (clang-cl)
Change-Id: If79b5c1bfdecc8e40247e9f1b2ba314f06ebbe84
2017-08-31 12:14:41 +02:00
Stephan Bergmann
0829b992a2 loplugin:constparams: winaccessibility (clang-cl)
Change-Id: Ic668c1ee6c2dac70642480bc584f962921b428b2
2017-08-31 12:14:41 +02:00
Stephan Bergmann
3f226429e3 loplugin:constparams: vcl (clang-cl)
Change-Id: Iabcbb6e09616a28c0d8927d11af3da47e48cbd90
2017-08-31 12:14:41 +02:00
Stephan Bergmann
237d62284f loplugin:constparams: svl (clang-cl)
Change-Id: Iddeb46c10046a83708ccff82e7125c36ed27c34d
2017-08-31 12:14:41 +02:00
Stephan Bergmann
3fe9d25e32 loplugin:constparams: smoketest (clang-cl)
Change-Id: I24c79c1a66ce2dc4cbb1736993643a8f4c14120c
2017-08-31 12:14:41 +02:00
Stephan Bergmann
b2d56c8b58 loplugin:constparams: shell (clang-cl)
Change-Id: I7ffe60d53f4c4b7690efc8bec9d29a4959740d9a
2017-08-31 12:14:40 +02:00