This took a bit of code archaelogy for me to track down. It turns out that
as part of an effort to optimize startup, the line of code in this function
was commented out, presumably to be rewritten later. This happened in
commit ee3351d78c in July 2001 (!).
About three years later, in February 2004, the function was rewritten in
commit 189c2388d8. As it turns out, the only two functions that used
the Window parameter were vcl/source/window/window.cxx (which passed
itself in, but of course this did nothing) and
vcl/source/window/winproc.cxx. Furthermore, winproc only ever passed in
the first frame, so it didn't really do anything either.
Consequently, the function as it stands *now* only notifies the
application that system settings have been changed. It doesn't care
which window it tells.
Therefore, I have excised this parameter from the function. I don't
think it made sense when it was implemented anyway, so there is no net
loss.
After removing the unneeded parameter, I was also able to remove the
Window parameter from winproc.cxx's ImplHandleSalSettings function as
it was only ever used to set the top level window, which is now
irrelevant.
Change-Id: I84f2c5c5ff8969387da3af81e4a9c7f9ac6237e1
Reviewed-on: https://gerrit.libreoffice.org/7541
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
I'm not exactly sure why existing code didn't do this implicitly, but at
least this improves the situation.
Change-Id: Id2bb169c513827b7ef48640dc88fad90a83d2bee
Documented the VCL Application class in Doxygen format. Also
reindented some of the code, and moved ValidateSystemFont down
the list of class functions (better code organization).
Change-Id: Id421647a9a25e11be87b0f6c46d1ac0f4846f6a4
Reviewed-on: https://gerrit.libreoffice.org/7515
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
The table manager can work with more table simultaneously
and so m_aCellWidths contains more table's properties.Only one
item of it belongs to the current table (getCurrentCellwidths).
Regression from 74c5ed19f4
Change-Id: I93efac0c004af1b2524c955ffb20c3ecd74a2920
before the character
(cherry picked from commit acac627b8aed3353e542ce41fa9a7064e4d1790b)
Conflicts:
vcl/source/control/field.cxx
Change-Id: Ia9c5496e1e2345f6249dc03efaf2c60f4231aecd
Seems to be merge artifacts in 260df50ae6.
Otherwise, I really like how Caolán implemented this in a proper,
per-locale way. Caolán, you rock!
Change-Id: I42e70b240fdf013316ad282e70b8e42eec8225a8
and remove separator between value and percent to match with ISO 31-0
(cherry picked from commit 0cea884e3f417e4b58d2fdcfc7b0111f3bfc6f30)
Conflicts:
chart2/source/controller/dialogs/tp_SeriesToAxis.src
cui/source/dialogs/colorpicker.cxx
cui/source/dialogs/colorpicker.src
cui/source/dialogs/grfflt.src
cui/source/dialogs/zoom.src
cui/source/tabpages/tabline.src
editeng/source/items/frmitems.cxx
editeng/source/items/textitem.cxx
sd/source/ui/animations/CustomAnimationDialog.src
sd/source/ui/animations/SlideTransitionPane.src
svx/source/dialog/bmpmask.src
svx/source/engine3d/float3d.src
svx/source/items/algitem.cxx
svx/source/sidebar/text/TextCharacterSpacingControl.cxx
svx/source/xoutdev/xattr.cxx
sw/source/ui/utlui/attrdesc.cxx
sw/source/ui/utlui/uiitems.cxx
Change-Id: I554309cb72dd8956077c5ca6866a982cdd6529aa
Galleries are needed in a cross-compilation only when targeting DESKTOP
platforms, which people don't do very often, so the problem had not been
noticed for a while.
Change-Id: Ieb0f010505af230db0661f02345ac6ace3b52957
in fixed line around the preview on print dialog
(cherry picked from commit 99d599a9ff636dc16b42889ca5d2d7323f45cae4)
Conflicts:
vcl/source/window/printdlg.cxx
Change-Id: I632766cfbc89be32f5991890df0c5cc918263f00
