mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
353,519 Commits 1 Branch 0 Tags
Commit Graph

353519 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Caolán McNamara
bbfa7a65cf crash because iterator position wasn't changed in stl conversion 
regression from e0284f4bba59912e1c49cb36936e041e891a5833

Here's the original code using the pre stl iterators.

if( !pPara && nDepth > 0 &&  rSet.GetItemState( EE_PARA_NUMBULLET ) == SFX_ITEM_ON &&
    pOutliner->GetDepth( (sal_uInt16) pOutliner->GetAbsPos( (Paragraph*) pList->First() ) ) > 0 )
	pPara = pOutliner->GetParagraph( 0 );  // Put NumBulletItem in outline level 1

Hidden in there is a pList->First() which only gets called if the prior
conditions are true.  pList->First() resets the index of the internal pList
iterator position of pList to 0 i.e. the next call to pList->Prev will now return 0.

The equivalent in the post-stl-conversion code is to jump the reverse_iterator
iter to the last position in the reverse view.

Create a level 10 entry in master view, select level 10, and use the bullets
and numbering dropdown from the side panel to see this crash

Change-Id: I52c22ea52020feb0fb75924f63ebe225be462071
 2014-05-21 16:26:33 +01:00
Stephan Bergmann
7aed3a0089 Remove spurious assert(false) 
...inadvertently left over debug code

Change-Id: I4bb9ee37ee7fd5d7e4e7f91afbcc036ba5802880
 2014-05-21 17:06:08 +02:00
Stephan Bergmann
1c92fbf4fd Replace ZCodec::mbInit with sane enum 
...and document how the member functions are supposed to be called from client
code.

Change-Id: Ia4847945e4a361c43a0ed001e3e78e901c9abcad
 2014-05-21 17:03:41 +02:00
Miklos Vajna
d4af55670f try to fix Mac build 
Change-Id: Id36f801cdf72d7654958b9d9837590990fdf161b
 2014-05-21 16:50:31 +02:00
Caolán McNamara
583619b771 don't crash on formatting outline level 10 in master view 
There are only 9 outline level styles, but we are allowed
(for some nutball reason) to create 10 levels, trying
to change the format of level 10 will then crash when
trying to apply its formatting to the non-existent
underlying style

Change-Id: Ic240322f98d832bc59edb502dd6d4988aa022481
 2014-05-21 15:27:42 +01:00
Stephan Bergmann
67444a92e4 -Werror,-Wunused-variable 
Change-Id: Ie7919740e7e95eb53f7a719e3dc2b114c6fd3862
 2014-05-21 16:21:26 +02:00
Markus Mohrhard
08bc9faedb remove second part of the debug output 
Change-Id: Ie691746b4621a90d2b7abbfbc75367780574032f
 2014-05-21 16:11:31 +02:00
Markus Mohrhard
31e32d3624 remove debug output 
Change-Id: Ib77911177ec4d2f5b1f7c7ff75db30b6104f0682
 2014-05-21 16:05:14 +02:00
Markus Mohrhard
6fd54c8e34 improve the text rendering a little bit more 
Change-Id: I7662b77df94c439678d17fe31e611272d1802981
 2014-05-21 16:05:14 +02:00
Tor Lillqvist
6e38357d5d Cosmetics 
Change-Id: I4ad71bd3538b1d5b033802469b16dd35df5b9724
 2014-05-21 16:53:21 +03:00
Jan Holesovsky
663c6800ca collada2gltf: Ignore case of the extension. 
Change-Id: If7f39a1a0537c561373137e6a9dcdb22b48037f0
 2014-05-21 10:36:55 +02:00
Jan Holesovsky
2fa2e6db1c gltf: Send delta when rotating, not absolute value. 
Change-Id: I2453132fedc9a38f43c3de4b110459ba7771d085
 2014-05-21 10:36:54 +02:00
Jan Holesovsky
f72d85e6fa Avoid blinking when doing operations in the spreadsheets. 
Change-Id: I31d24ef32ef4bb9ea4b57d596cccd269d07d91ec
 2014-05-21 10:36:54 +02:00
Jan Holesovsky
f635aed5b1 libgltf: The FPS counting is not necessary in LibreOffice. 
And leaving it out kills the freetype dependency :-)

Change-Id: I1fa33492da9d30a98014bae06aa196a508cedfe7
 2014-05-21 10:36:54 +02:00
Jan Holesovsky
f933cb0a64 libgltf: Update to the new version. 
Change-Id: Iffc91425d4395699a1c5f18ac10f5ed065231fdf
 2014-05-21 10:36:53 +02:00
Stephan Bergmann
1b0402f87c Use varying aElement name 
Change-Id: Idc135ef5031a01961cc18d897a734b598bc833f4
 2014-05-21 15:30:19 +02:00
Stephan Bergmann
4d2113250f ZCodec::UpdateCRC is private 
Change-Id: I2103f8a323d0454bdd1c779aadb99889ae1cf6e5
 2014-05-21 15:30:18 +02:00
Stephan Bergmann
b928cfb512 Remove unused ZCodec::IsFinished 
Change-Id: I9741daf288c11dc8e0f0ad2f64e934e814c3ef8a
 2014-05-21 15:30:18 +02:00
Stephan Bergmann
46d442860a ZCodec instances can be allocated on the stack just fine 
Change-Id: I4b185f9a0ecaa74ca3f1e93b3bfe504e9778a8ca
 2014-05-21 15:30:18 +02:00
Stephan Bergmann
2993c7c000 ZCodec instances can be allocated on the stack just fine 
Change-Id: Id115af34011fbedc93a1fea1734ea6b1e7cfafd0
 2014-05-21 15:30:17 +02:00
Stephan Bergmann
0696dd9a3d ZCodec instances can be allocated on the stack just fine 
Change-Id: I523fba14c721815f8416f6e0224e42052d13429a
 2014-05-21 15:30:17 +02:00
Stephan Bergmann
47169087c1 Remove unnecessary GZCodec derivation 
Change-Id: Id710a1fe4a3c1593add69bb2a7014d26f9499e87
 2014-05-21 15:30:16 +02:00
Stephan Bergmann
a1ec916df8 Remove unused ZCODEC_BEST_SPEED, ZCODEC_BEST_COMPRESSION macros 
Change-Id: Ibdf211b858c25a4b301cbde3dcab3a51765e4050
 2014-05-21 15:30:16 +02:00
Stephan Bergmann
200d530f47 Split ZCodec::BeginCompression param into its 3 independent components 
Change-Id: I275abafe81c8bb617c70646244b14f6cecc33854
 2014-05-21 15:30:16 +02:00
Stephan Bergmann
5e82dc511e Simplify logic 
Change-Id: I2350c1a4d57a0e25753756e99d2b93ab3f2f6997
 2014-05-21 15:30:15 +02:00
Stephan Bergmann
e05a200249 Remove unnecessary ZCODEC_DEFAULT macro 
Change-Id: I57a5a14a51c0441e0fed006457ac95057f188462
 2014-05-21 15:30:15 +02:00
Stephan Bergmann
201d429ad0 Remove unnecessary ZCODEC_DEFAULT_STRATEGY macro 
...and directly use zlib.h's Z_DEFAULT_STRATEGY

Change-Id: Ibf528cbc32afec4d442656aa2963f50c0875d6a5
 2014-05-21 15:30:15 +02:00
Stephan Bergmann
a34d0fb56f Remove unused ZCODEC_ZFILTERED, ZCODEC_ZHUFFMAN_ONLY macros 
Change-Id: Ie02fb495beebd02d8331e547cbe6648dc70f241f
 2014-05-21 15:30:14 +02:00
Stephan Bergmann
b2e5b0ec14 Remove unnecessary DEFAULT_IN/OUT_BUFSIZE macros 
Change-Id: Icd509f55b3f91c4ce3b21bfa3a501d99532539d9
 2014-05-21 15:30:14 +02:00
Stephan Bergmann
5271e5b01b nMemUsage is always MAX_MEM_USAGE 
...so just use zlib.h's MAX_MEM_LEVEL directly.

Change-Id: I76d73f665df242bfb180b76aa7054cf8ddbe9e67
 2014-05-21 15:30:14 +02:00
Stephan Bergmann
f5e44ac7e6 Use default argument values 
Change-Id: I69273648155f5071b297c9c77edda58a8f25436d
 2014-05-21 15:30:13 +02:00
Stephan Bergmann
fe1e1d1292 A single ZCodec ctor suffices 
Change-Id: Ib831b80afcdde98928a2759616810923348f65e8
 2014-05-21 15:30:13 +02:00
Stephan Bergmann
faac2327e9 Clean-up C-style (void) parameter lists 
Change-Id: I41da8920e33dfdd0f1483ea2d7cf67111224b441
 2014-05-21 15:30:13 +02:00
Zolnai Tamás
d1711bb430 glTF embedding: handle missing image on a better way 
Using empty tree leads to empty image url which
cause problem.

Change-Id: If815ce588fb303905035185404ede93fa424fcba
 2014-05-21 15:25:08 +02:00
Zolnai Tamás
ee734562df glTF objects: set playback loop by default 
Change-Id: I17f5636196ba2b14f46f805ce013af5e6bede9a8
 2014-05-21 15:25:08 +02:00
Douglas Mencken
7e4708739d care for Java 1.5 support in external packages 
apache commons-lang 3.3.1 and commons-codec 1.9 are for use
only with JDK 1.6 and higher

see commits:
  1731f6e692bb0a07a2bca4b1b190163f209d2b9e "bump apache-commons-lang to 3.3.1"
  3dad9b1019bebcc6db63a424afa146e007f768d2 "bump apache-commons-codec to 1.9"

Change-Id: I3e71f6474becafe6c91836bbac5c6a8b7ca3442c
Reviewed-on: https://gerrit.libreoffice.org/9312
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-05-21 07:57:55 -05:00
Noel Grandin
e142ad49ce cid#708875 Unused pointer value 
Change-Id: I0cf85027a84482fd504b753bfc32ceb1c07241b4
 2014-05-21 14:56:39 +02:00
Caolán McNamara
b1439cf5de drop unused helpids 
Change-Id: I35fd20220a206fbe9cbc9eed9670b59e4051ae11
 2014-05-21 13:55:56 +01:00
Markus Mohrhard
1225fc1047 improve the text rendering a bit 
Less scaling means more beautiful text

Change-Id: I787244a5f7a472a14f463729f8f434a4969a6285
 2014-05-21 14:50:53 +02:00
Markus Mohrhard
addc7e821f we need to set text size in woorld coordinates 
Change-Id: If77133080851a3b2d700ac54c9722f560e71f26e
 2014-05-21 14:50:52 +02:00
Caolán McNamara
705c26a655 Updated core 
Project: help  2ef15cb93840390d9927f64bddb958ad699cb792
 2014-05-21 07:54:59 -05:00
Caolán McNamara
ca4a381947 lets drop the custom DescriptionEdit widget 
Change-Id: Id08b364b828ccacd5c54276daf605ec4ff3fdb0a
 2014-05-21 13:47:05 +01:00
sk94
5690def7c8 RID_DLG_UPDATE conversion to .ui 
Conflicts:
	desktop/source/deployment/gui/descedit.hxx

Change-Id: Icf9ee3081b468f99833d1e38182887ad1da6f675
Reviewed-on: https://gerrit.libreoffice.org/9417
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-05-21 07:46:34 -05:00
Markus Mohrhard
2bbcf97eb3 fix my issues with the offscreen rendering 
Change-Id: I4a2ed8a20890119220d63a6768f13365a7b5f97d
 2014-05-21 14:24:09 +02:00
Eike Rathke
b8e8c9c471 add unit test for static isValidBcp47() method 
Change-Id: Ib234fb1d14087236d337dfe351aea941945e718c
 2014-05-21 14:15:24 +02:00
Eike Rathke
a6e6cc49bf add static LanguageTag::isValidBcp47() 
Change-Id: I2c646b3e2f13a6fccc845ce8eb82fccee154f3c6
 2014-05-21 14:15:24 +02:00
Noel Grandin
f824604b5c fix spelling 
Change-Id: I1a4d66a78549ea49649a6bed92acb44dbd8b13e2
 2014-05-21 13:14:11 +02:00
Bjoern Michaelsen
46f1a5a7de also add Unity and Systemd 
Change-Id: I941c1f651f7b1a4478c50a9047993da881ebfd70
 2014-05-21 12:48:19 +02:00
Eike Rathke
636581bf87 most certainly == was meant 
Change-Id: I1b0833daa576cd8603421e1036b8773badc8c775
 2014-05-21 12:45:24 +02:00
Bjoern Michaelsen
e1d90b31f6 add Debian Jessie 
Change-Id: I94473904747593714998ed159a304417060d691d
 2014-05-21 12:43:57 +02:00