mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
452,964 Commits 1 Branch 0 Tags
Commit Graph

2426 Commits

Author SHA1 Message Date
Noel Grandin
163086a649 loplugin:virtualdead unused param in ResourceChangeListener 
Change-Id: I6bfaef6694ec654889ddf1f300851f323bcc56b3
Reviewed-on: https://gerrit.libreoffice.org/81272
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-22 08:14:02 +02:00
Noel Grandin
6921cde391 loplugin:virtualdead unused param in ChartTypeDialogController 
Change-Id: I71eaedcd2fbd5b6d05bc90c4c5ddbc7fca9f5925
Reviewed-on: https://gerrit.libreoffice.org/81271
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-22 08:13:56 +02:00
Noel Grandin
db90e072fa loplugin:virtualdead unused params in OCacheSet 
these methods do nothing except forward to their similar named variants,
so just remove them

Change-Id: I28d31bbe2c1e39fe5a9c2d7eaa9e14006213ab27
Reviewed-on: https://gerrit.libreoffice.org/81247
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-22 08:13:45 +02:00
Noel Grandin
964ffdc068 loplugin:virtualdead unused param in IContainerApprove 
Change-Id: I59edede149d02085125ee946994b6088c3152e7b
Reviewed-on: https://gerrit.libreoffice.org/81246
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-22 08:13:38 +02:00
Stephan Bergmann
20c6dfde1d There doesn't need to be a TemplateSpecializationType here 
On both macOS (libc++) and Windows (MSVC standard library),
compilerplugins/clang/test/getstr.cxx failed four tests without this fix:

> error: 'error' diagnostics expected but not seen:
>   File compilerplugins/clang/test/getstr.cxx Line 29: suspicious use of 'getStr' on an object of type 'rtl::OUStringBuffer'; the result is implicitly cast to a void pointer in a call of 'operator <<' [loplugin:getstr]
>   File compilerplugins/clang/test/getstr.cxx Line 30: directly use object of type 'S' (aka 'rtl::OString') in a call of 'operator <<', instead of calling 'getStr' first [loplugin:getstr]
>   File compilerplugins/clang/test/getstr.cxx Line 34: suspicious use of 'getStr' on an object of type 'rtl::OUStringBuffer'; the result is implicitly cast to a void pointer in a call of 'operator <<' [loplugin:getstr]
>   File compilerplugins/clang/test/getstr.cxx Line 35: directly use object of type 'rtl::OString' in a call of 'operator <<', instead of calling 'getStr' first [loplugin:getstr]

Change-Id: I65406d3d84bb5a89df44c8fd665b6e38d19f38c7
Reviewed-on: https://gerrit.libreoffice.org/81266
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-10-22 07:18:49 +02:00
Stephan Bergmann
61dc9b6aab Make loplugin:stringcostant find some misuses of OUStringBuffer::append 
...like the one manually found at 06845c14a17146b0ec50dd3704b6af9ee13927bc "This
should have become a UTF-16 string literal".  (No further misuses were found
across the code base.)

Change-Id: I0b604bdaaa38bd9248440ff7bd7bf0545fc6426a
Reviewed-on: https://gerrit.libreoffice.org/81250
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-10-21 20:05:49 +02:00
Noel Grandin
5dcee37fc4 loplugin:virtualdead unused param in IControlActionListener 
Change-Id: I2ce8df6a9a1ac2e6d6c5de08b32fb671bf10cd17
Reviewed-on: https://gerrit.libreoffice.org/81244
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 19:32:13 +02:00
Noel Grandin
501233bf55 loplugin:virtualdead unused param in OTableRowView 
Change-Id: Ice8d68284800e12af3e334722cc6109a1614e335
Reviewed-on: https://gerrit.libreoffice.org/81243
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 19:31:47 +02:00
Noel Grandin
1acc7c2fe7 loplugin:virtualdead unused params in forms 
Change-Id: Iac26ba57443060474f4f33c4f449a69eca8c1063
Reviewed-on: https://gerrit.libreoffice.org/81236
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 18:13:44 +02:00
Noel Grandin
f0f9d986e3 loplugin:virtualdead unused param in SvtFileDialog_Base 
Change-Id: Id10c6df2a9d00f19dc1dc314515fedbe90918f66
Reviewed-on: https://gerrit.libreoffice.org/81235
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 18:12:52 +02:00
Noel Grandin
13012b3cfe loplugin:virtualdead unused param in EditEngine::FieldClicked 
Change-Id: Iffe075960308d5058cb7535e9216caa37aabe0c5
Reviewed-on: https://gerrit.libreoffice.org/81232
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 14:47:48 +02:00
Noel Grandin
3f2babb8aa loplugin:virtualdead unused param in UnknownAttrToken 
Change-Id: Iccf88b919cfc40419271e6f18d101027ef2bb9df
Reviewed-on: https://gerrit.libreoffice.org/81218
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 14:47:26 +02:00
Noel Grandin
5968c5b1f7 loplugin:virtualdead unused param in ProcessClientAnchor2 
Change-Id: Ic766fcc1bfd33d891edc1da87e1b35a8efba169a
Reviewed-on: https://gerrit.libreoffice.org/81217
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 14:46:37 +02:00
Noel Grandin
0c1ab11c9f loplugin:virtualdead unused param in SfxObjectShell::FillClass 
and since I notice that the two call sites also don't care about
pShortTypeName, remove that too

Change-Id: I4649fc4c134c1113555b9dedb53499ce39d17132
Reviewed-on: https://gerrit.libreoffice.org/81213
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 13:06:49 +02:00
Noel Grandin
bbe6bc271a loplugin:virtualdead unused param in SfxStatusListener::StateChanged 
Change-Id: Ic467490ddd1b0762bfa61878c4026afb53b02743
Reviewed-on: https://gerrit.libreoffice.org/81212
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 13:06:38 +02:00
Noel Grandin
855b30cf70 loplugin:deadvirtual unused param in ItemUpdateReceiverInterface 
Change-Id: I3db5a456a259a97dc9bdf6be0d478177bac05215
Reviewed-on: https://gerrit.libreoffice.org/81186
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 10:56:13 +02:00
Noel Grandin
729989d485 loplugin:virtualdead unused param in TitleBar::PaintDecoration 
Change-Id: I3dd8ee6492be1a4b3d1032c4d50cc01111d748cb
Reviewed-on: https://gerrit.libreoffice.org/81185
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 10:00:23 +02:00
Noel Grandin
67d5fbe0d0 loplugin:virtualdead unused param in ITableRenderer 
Change-Id: I008ff69494af305485a022def72a14a04b26a19e
Reviewed-on: https://gerrit.libreoffice.org/81183
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 10:00:09 +02:00
Noel Grandin
4a20922e0e loplugin:virtualdead unused param in ThumbnailViewItem::calculateItemsPosition 
Change-Id: I8db99a3672e3603a25ee1f6ca4741a02b73c9516
Reviewed-on: https://gerrit.libreoffice.org/81184
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 08:33:22 +02:00
Noel Grandin
2302674d6c loplugin:virtualdead unused param in FmXDisposeListener::disposing 
Change-Id: I2189f0a35b03bc8192ab91cd63b210f303f5d3e6
Reviewed-on: https://gerrit.libreoffice.org/81182
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 08:32:53 +02:00
Noel Grandin
defd2cb025 loplugin:virtualdead unused param in SdrHdl::onHelpRequest 
Change-Id: I3d75755bd6fd7f3168725c53fd8ce571a938fa37
Reviewed-on: https://gerrit.libreoffice.org/81181
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 08:32:39 +02:00
Noel Grandin
d5ec8bc929 loplugin:virtualdead unused param in GetSdrRepeatComment 
Change-Id: I0a27d1a200e8af50adf98de2c5ba7d3c7e199b00
Reviewed-on: https://gerrit.libreoffice.org/81180
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 08:32:27 +02:00
Noel Grandin
e8939b098b loplugin:virtualdead unused param in CreateSvxFormatCellsDialog 
Change-Id: I8455c10d62ae8c3c3e6e543301f8c69a1189456a
Reviewed-on: https://gerrit.libreoffice.org/81179
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 08:32:18 +02:00
Noel Grandin
fec35bf15d loplugin:virtualdead unused param in Task::UpdateMinPeriod 
Change-Id: Ie24f56fed811b3b317d6c20e15289e7cecfb738d
Reviewed-on: https://gerrit.libreoffice.org/81157
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-20 21:54:00 +02:00
Noel Grandin
fb74f7b663 loplugin:virtualdead unused param in SvListView::ModelIsMoving 
Change-Id: I83af14bb3a29cb8a4a36f714ac2fb91687f13996
Reviewed-on: https://gerrit.libreoffice.org/81156
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-20 21:53:47 +02:00
Noel Grandin
8e4b0329dd loplugin:virtualdead unused param in RedlineAdjustStartNodeCursor 
Change-Id: Ic8eaad705b0cf8289035f7eee3ad01439fc24ee7
Reviewed-on: https://gerrit.libreoffice.org/81155
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-20 20:09:37 +02:00
Noel Grandin
1db6a4c78f loplugin:virtualdead unused param in XMLEventContextFactory::CreateContext 
Change-Id: I6fda2e04724d69fd218ffc85f9881b429714e63b
Reviewed-on: https://gerrit.libreoffice.org/81154
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-20 20:09:23 +02:00
Noel Grandin
b6f1995566 loplugin:unusedfields 
Change-Id: I7dd5fc3d53df63fd2ee2caa71586f0f5e13f187e
Reviewed-on: https://gerrit.libreoffice.org/81078
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-19 11:17:20 +02:00
Noel Grandin
74f938bb10 loplugin:unusedmethods 
Change-Id: I95e63105654952d12c1dfd62f51593de114be569
Reviewed-on: https://gerrit.libreoffice.org/81077
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-19 07:59:43 +02:00
Noel Grandin
b98cb40d97 loplugin:virtualdead unused param in ValueGetter::processValue 
Change-Id: Id2b514b0892f8d7cf93fe3c5884e8d89a6f0a7b1
Reviewed-on: https://gerrit.libreoffice.org/81076
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-19 07:59:26 +02:00
Noel Grandin
0d416965a6 loplugin:virtualdead unused param in sd::View::AcceptDrop 
Change-Id: I51aceb8a1f908cf89a0b8b6d0e58755fc4374862
Reviewed-on: https://gerrit.libreoffice.org/81075
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-19 07:59:11 +02:00
Noel Grandin
0093834e33 loplugin:virtualdead unused param in ViewClipboard::DetermineInsertPosition 
Change-Id: Iad1a4dbd603e9258e8835e7ab534cd74f4882968
Reviewed-on: https://gerrit.libreoffice.org/81074
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-19 07:58:56 +02:00
Noel Grandin
7837447287 loplugin:virtualdead unused param in sd::ViewShell::UpdatePreview 
Change-Id: I1ac98096d117e3ae7c2f0be2690acef32b85fbdb
Reviewed-on: https://gerrit.libreoffice.org/81073
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-19 07:58:40 +02:00
Noel Grandin
90d9d20227 loplugin:virtualdead unused params in OGLTransitionImpl 
rename finish to cleanup to avoid conflict with already existing finish
method

Change-Id: I1036eea7e50b20c3c17d769c4094c640939d552d
Reviewed-on: https://gerrit.libreoffice.org/81072
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-19 07:58:26 +02:00
Noel Grandin
33e176552d loplugin:virtualdead unused param in Animation::prefetch 
Change-Id: I7eaf01548567ce560b0e32f222880d21b966c78d
Reviewed-on: https://gerrit.libreoffice.org/81071
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-19 07:58:04 +02:00
Noel Grandin
c66e8c7f94 loplugin:virtualdead unused params in ShapeListenerEventHandler 
Change-Id: Ied95fd01912737ba1ae73fb1fea6ddd57eb8a14d
Reviewed-on: https://gerrit.libreoffice.org/81070
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-19 07:57:51 +02:00
Stephan Bergmann
824d9394b5 Properly handle comma in CLANGFLAGS 
...which would cause an error that STRINGIFY takes only a single argument.

According to chris_wot on IRC, LLVM 6.0 on Ubuntu 18.04.3 LTS output of `llvm
--cxxflags` (as is used in configure.ac to determine what ultimately ends up in
CLANGFLAGS here) includes e.g. -Wl,--no-keep-files-mapped.

Change-Id: Iff570840fe62c2aa2d972431e610a05fe2f6922c
Reviewed-on: https://gerrit.libreoffice.org/81037
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Tested-by: Jenkins
 2019-10-18 15:32:13 +02:00
Noel Grandin
a4e9ba26d7 loplugin:virtualdead unused param in contextMenuRequested 
Change-Id: Ifc13a476da29966a2a0023226967201ecc97b444
Reviewed-on: https://gerrit.libreoffice.org/81017
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-18 14:26:33 +02:00
Noel Grandin
6c249730d5 loplugin:virtualdead unused param in IDocumentLinksAdministration::SetData 
Change-Id: I4d36b56a10266293285b9b7727f3c6bfac23a45b
Reviewed-on: https://gerrit.libreoffice.org/81016
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-18 13:39:52 +02:00
Noel Grandin
abb2fced56 lopligin:virtualdead unused params in IDocumentRedlineAccess 
Change-Id: I60b343d5e7acb6310e5a0f501f8cfb78dc4ea7a8
Reviewed-on: https://gerrit.libreoffice.org/81015
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-18 11:16:56 +02:00
Noel Grandin
2ac038e2b3 loplugin:virtualdead unused param in SwFlowFrame::ShouldBwdMoved 
Change-Id: Ife69fe8c9023682278c02d037d35d15bd015f127
Reviewed-on: https://gerrit.libreoffice.org/81014
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-18 10:30:10 +02:00
Noel Grandin
4c1ad48b42 loplugin:virtualdead unused param in SwImpBlocks::Rename 
Change-Id: Ifed3e1e89a2d67b08d96d89424e83c49160cb3fe
Reviewed-on: https://gerrit.libreoffice.org/81010
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-18 09:40:38 +02:00
Noel Grandin
ecfc368932 loplugin:virtualdead unused params in SvXMLExportItemMapper::handleElementItem 
Change-Id: Ib77a29d23d8a67fab8441d369b2ff4660c1f99bc
Reviewed-on: https://gerrit.libreoffice.org/81009
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-18 09:40:22 +02:00
Noel Grandin
933592b201 loplugin:virtualdead unused param in SvXMLImportItemMapper::handleSpecialItem 
Change-Id: Ie1a8fdafb64f6374ae9108dbb47592b044703cc9
Reviewed-on: https://gerrit.libreoffice.org/81008
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-18 09:15:42 +02:00
Noel Grandin
6fe42f2050 loplugin:virtualdead unused params in IMailDispatcherListener 
Change-Id: I0cc6a813db88efc98673400447d98e50c32bc720
Reviewed-on: https://gerrit.libreoffice.org/80962
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-18 07:25:00 +02:00
Noel Grandin
e872dbd715 loplugin:virtualdead unused param in BinaryObj::data 
Change-Id: I726745b82747f24cc93662bfb0dd381a114fde78
Reviewed-on: https://gerrit.libreoffice.org/80955
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-17 20:32:35 +02:00
Noel Grandin
45eeefb064 loplugin:virtualdead unused param in LoggedStream::lcl_info 
which means the whole method is actually unused

Change-Id: I72d33ab6e260012b82002ceae7ff9e54e2ea6349
Reviewed-on: https://gerrit.libreoffice.org/80953
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-17 19:02:54 +02:00
Noel Grandin
caf8bf17ff loplugin:virtualdead unusedparam in LoggedTable::lcl_entry 
Change-Id: I45c7330b3803f21165714c6140fac46a6592db9b
Reviewed-on: https://gerrit.libreoffice.org/80952
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-17 18:17:06 +02:00
Noel Grandin
3ebbb15024 loplugin:buffereadd find stuff involving adding *StringBuffer 
and create conversion methods on *StringBuffer to make this work

Change-Id: I3cf5ee3e139826168894b46eff8ee4bcde00cb7e
Reviewed-on: https://gerrit.libreoffice.org/80949
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-17 18:16:28 +02:00
Noel Grandin
18d8ba49dc loplugin:virtualdead dead propertygroup functionality 
ever since it was introduced in

    commit d09dd8986436f17717443823ef18bd8552fdf408
    Date:   Wed Sep 15 13:55:34 2010 +0200
dba34a: export/import min-/max-/default-/value for date/time as
XML-Schema conformant strings

looks like classic over-engineering

Change-Id: Ia4e4b65cfe92f522dee238a54a37db01f691750e
Reviewed-on: https://gerrit.libreoffice.org/80951
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-17 16:53:59 +02:00