434442 Commits

Author SHA1 Message Date
Gabor Kelemen
756d7d7073 tdf#42949 Fix IWYU warnings in sd/source/ui/[a-c]*/*cxx
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I75bb860272e23ebc04912295b0ce4f2c8fe540b7
Reviewed-on: https://gerrit.libreoffice.org/68604
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-07 14:12:31 +01:00
Julien Nabet
67d1708684 tdf#121686: fix assert in SvxAutoCorrect::FnChgToEnEmDash (editeng)
See https://bugs.documentfoundation.org/attachment.cgi?id=149773

Change-Id: I1696984a8df1b38a359a8177a5f3670526d2696e
Reviewed-on: https://gerrit.libreoffice.org/68832
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-07 13:28:39 +01:00
Ashod Nakashian
0d8c670797 build: support disabling poppler
This adds --enable-poppler configure option.
Poppler can be enabled/disabled by setting this
parameter to yes or no.

Change-Id: I42ba2d27de7b5014d28523394310616d20073b71
Reviewed-on: https://gerrit.libreoffice.org/68602
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/68842
Tested-by: Jenkins
2019-03-07 11:43:25 +01:00
Lior Kaplan
cac705fe8e Update git submodules
* Update dictionaries from branch 'master'
  - tdf#117389 Make sure all comments also ends with #
    
    Change-Id: I68f513c0ad8b63b416608f8e221450622ef10c2d
    
  - tdf#117389 Remove empty line, update total number
    
    Change-Id: I4f492ab621d5a41466f55e79e86eeda5c7da1e52
    
  - substantive rework of af_ZA hunspell
    
    Change-Id: I873d6135e65089e5905b5c650428b4d9ad7fa4c6
2019-03-07 11:33:33 +01:00
Michael Stahl
dfdb7f9fcf tdf#123637 sw_redlinehide: fix iteration in SwCursorShell::GotoNextOutline()
If nStartPos == size() and !bUseFirst.

(regression from d0e9cc832d19b622532f01580d9cf78ee0b215db)

Change-Id: I571d24ec5e9d4f2780e7c6d5c8cee09baeaffcc1
Reviewed-on: https://gerrit.libreoffice.org/68821
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-07 11:28:54 +01:00
Michael Stahl
ac7de9a54d sw_redlinehide: fix SwGetExpField ODF import
After import, SwGetExpField are empty if ShowRedlineChanges=false
because the content from the document is lost in SwGetExpField::Copy().

Example is ooo26330-3.sxw, which then asserts once fields are updated,
but that is a different problem.

(regression from 57f358f1ac4f3e05fcdf54326388ba8a19f0f2b3)

Change-Id: I1bf939d69e599919c3a5c5631091ca0a0074d139
Reviewed-on: https://gerrit.libreoffice.org/68820
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-07 11:28:42 +01:00
Lior Kaplan
0c78c85b92 Update git submodules
* Update dictionaries from branch 'master'
  - Replace : with # in comments lines
    
    Change-Id: I1bcd51d4dab501a051dd6bebe98380299390fc3b
    Reviewed-on: https://gerrit.libreoffice.org/67282
    Reviewed-by: Andras Timar <andras.timar@collabora.com>
    Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-07 11:28:24 +01:00
Lior Kaplan
1c3d62c1d4 Update git submodules
* Update dictionaries from branch 'master'
  - tdf#117389 Remove RLM/LRM from Arabic dictionary
    
    Change-Id: I002d7be2de961b7a20d48eed628ae35df0b600df
    Reviewed-on: https://gerrit.libreoffice.org/67281
    Reviewed-by: Andras Timar <andras.timar@collabora.com>
    Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-07 11:25:49 +01:00
marxin
497d068ff1 Fix LTO segfault in libtest_sw_uwriter test.
The problem was seen here:
https://bugzilla.suse.com/show_bug.cgi?id=1127857.

One needs to call SwGlobals::ensure in order to initialize
SfxApplication via SfxApplication::SetModule(SfxToolsModule::Writer.

Change-Id: I3add24b56dc44a93ad81c1b52539da821f6244fc
Reviewed-on: https://gerrit.libreoffice.org/68839
Tested-by: Jenkins
Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz>
2019-03-07 11:08:10 +01:00
Julien Nabet
684fcf2fce tdf#123547: do the same as in lcl_DrawBullet from cui/numpages.cxx
See bt https://bugs.documentfoundation.org/attachment.cgi?id=149389
It seems the method from cui/numpages.cxx takes more things into account

At least, it doesn't crash for the attachment of this tracker

Change-Id: I05ca0b019ac483890bea4acdbb695d73b660e638
Reviewed-on: https://gerrit.libreoffice.org/68033
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-07 11:00:02 +01:00
Miklos Vajna
6d5fe4dca3 CppunitTest_svtools_html: use CPPUNIT_TEST_FIXTURE()
Change-Id: Icf4d3a649c5e6a53035c2a1573a8dd7154db2edd
Reviewed-on: https://gerrit.libreoffice.org/68831
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-07 09:39:13 +01:00
Tomaž Vajngerl
723ad50fff Add width, height and margin parameters for widget part def.
For some control parts we need to provide the size or redefine
the size. Previously this was hardcoded, but this adds new
attriburtes for widget part definition:
- width, height: defines size for buttons in spinbox, the size of
  the checkbox or radiobutton
- margin-width, margin-height: increases the size (margin) of
  tab items by the specified amount

Change-Id: Ieea69b92ad21adc4f4954e7555f4d59348f5dea8
Reviewed-on: https://gerrit.libreoffice.org/68829
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07 08:35:05 +01:00
Tomaž Vajngerl
0b25b7a8b2 Make definition state attribute default to "any"
...and remove all the "any" from definition.xml

Change-Id: I8a91129c89255c83c1c2f975bf9acb710b664efc
Reviewed-on: https://gerrit.libreoffice.org/68828
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07 08:34:31 +01:00
Tomaž Vajngerl
208a689695 Update SvgRead test - add new parameters and path parsing
Change-Id: Ic19bd2167cc359eef02648fa0ebd1d858fdeaec5
Reviewed-on: https://gerrit.libreoffice.org/68827
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07 08:34:22 +01:00
andreas kainz
ba9db8d614 Sifr icon theme update
Change-Id: I63231929679377a53b85aa7e2ee5363512f23912
Reviewed-on: https://gerrit.libreoffice.org/68834
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-07 07:41:38 +01:00
Andrea Gelmini
01381db5c1 Fix typo
Change-Id: Icafc637004e219b523c862cb5fbad55a2bd4eaaf
Reviewed-on: https://gerrit.libreoffice.org/68835
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-07 07:17:23 +01:00
Noel Grandin
8b5e23eac3 log nice exception messages whereever possible
Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1
Reviewed-on: https://gerrit.libreoffice.org/68579
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-07 07:12:39 +01:00
andreas kainz
4f810905fa sync dbaccess ui files with swriter ui file structure
Change-Id: I5acecb3292c1b4ef6aa2dfdc38775ed5bb81324a
Reviewed-on: https://gerrit.libreoffice.org/68806
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06 23:05:24 +01:00
andreas kainz
9bb9189acc Sifr icon theme update
Change-Id: I6aa3d3a4dac4af5b1dbf1d23166cc2a560cd984a
Reviewed-on: https://gerrit.libreoffice.org/68808
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06 23:04:53 +01:00
Tomaž Vajngerl
6510fdfb1f Increase font size when drawing from widget definition
Change-Id: I983dde507758a42c6ce421ea970b6e5d54c5dcae
Reviewed-on: https://gerrit.libreoffice.org/68826
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 22:47:25 +01:00
Tomaž Vajngerl
0db0c1edd9 draw combobox (entire areaonly) from external svg, fix editbox
Change-Id: Iba7e5b45c4f1ac6f87cbca963bb5284ce810ebcf
Reviewed-on: https://gerrit.libreoffice.org/68825
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 22:47:10 +01:00
Jens Carl
36f9dafc79 Add XServiceInfo tests to ScDataPilotFieldObj
Change-Id: I7de8902b6857782acb5d2b3566d5768481baab51
Reviewed-on: https://gerrit.libreoffice.org/68824
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-06 21:13:53 +01:00
Jens Carl
221ae913db Move variable nMaxFieldIndex out of namespace
Change-Id: I9396abb722b24d8ee6b2d5f8fccac140a1014436
Reviewed-on: https://gerrit.libreoffice.org/68784
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-06 21:01:25 +01:00
Tomaž Vajngerl
46ada3f8e7 Draw tabs from external svg image, fixes for tabs (colors)
Change-Id: I35db7b8e36c474d2196bfae1ec4dd352e17d2a14
Reviewed-on: https://gerrit.libreoffice.org/68822
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 21:00:43 +01:00
Tomaž Vajngerl
81a504e391 Draw pushbutton from external svg image
Change-Id: I45d668636d607e09852ee0ff3144500ac03fb8cf
Reviewed-on: https://gerrit.libreoffice.org/68819
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 21:00:21 +01:00
Tomaž Vajngerl
cddf072a62 Update drawing of spinbox from definition
Use SVG to describe the left, right spin button and the entire
spinbox widget.

Change-Id: I082ee08942fa3fa4145fd7bf53fc2cfc9fc06fd2
Reviewed-on: https://gerrit.libreoffice.org/68818
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 20:59:59 +01:00
Tomaž Vajngerl
fd57cdfc77 Support first, last tab item for the widget definition
Add "extra" parameter for the widget definition states with the
default set to "any". For tab item, the extra parameter can be
"first", "last", "middle" and "first_last" (only one). This is
needed to draw first and last tab item differently.

Change-Id: I46b6897b485b4df94ab6fe9521925c3715eaa24e
Reviewed-on: https://gerrit.libreoffice.org/68817
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 20:59:48 +01:00
Stephan Bergmann
7200b461e3 Simplify Sequence construction
Change-Id: I52ea31734f7765176e20514c5d02cb3ee5928cdb
Reviewed-on: https://gerrit.libreoffice.org/68812
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06 20:54:34 +01:00
Tomaž Vajngerl
f7ea15720d Support drawing widgets by interpreting an external SVG definition
This uses SvgDrawVisitor and draw commands to draw widgets from an
"external" SVG file. The difference to normal SVG drawing is that
the shapes are adjusted and not just resized to the widget size.
The result of such adjusted drawing is that the margins are
preserved exactly just the dimensions of the shapes is adjusted
to the desired size (if the shape bounding rectangle starts at
{5,5}, so will also when it is adjusted), also the stroke widths
are completely preserved.

This enables us to use SVG to define also for dynamic widgets,
like for example entry fields, listboxes, comboboxes,... which
vary in size - depending on the dialog definition.

Change-Id: I26fc9a37539d3675a77b48660d235a8a55b81156
Reviewed-on: https://gerrit.libreoffice.org/68816
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 19:36:03 +01:00
Stephan Bergmann
94de7c0be2 Blacklist some dialogs which won't get properly initialized
...so that at least Clang -fsanitize=implicit-signed-integer-truncation would
generate warnings for them

Change-Id: I76fd0aaa8e61784053e2b367b302fdd68c3859b4
Reviewed-on: https://gerrit.libreoffice.org/68815
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06 18:37:27 +01:00
Stephan Bergmann
7f2dd5bfb3 Pass ENABLE_DEBUG into external/zlib
Change-Id: I3aea7c64acfc933e4df901d4de349708a3331bcd
Reviewed-on: https://gerrit.libreoffice.org/68811
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06 18:36:58 +01:00
László Németh
df4f405a15 tdf#121176 DOCX track changes: same size w:del in w:ins
Instead of showing the tracked deletion as untracked
normal text, losing the original and actual text contents,
now w:del within a same size w:ins is imported as
tracked deletion correctly.

Change-Id: I7390df34f557664860a63779c5f972d5013ecc99
Reviewed-on: https://gerrit.libreoffice.org/68779
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2019-03-06 17:21:43 +01:00
Tomaž Vajngerl
8c01788708 parse more attributes in SvgDrawVisitor
- add additional parameters for DrawRectangle, DrawPath
- parse stroke width, stroke and fill color for path and rect
- parse rx, ry for rect
- use getCurrentViewPort for top-level SVG rectangle

Change-Id: Ife498bdaa721852ef2542ac5df2be0e86dfb4e62
Reviewed-on: https://gerrit.libreoffice.org/68785
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 16:37:01 +01:00
Tomaž Vajngerl
d112761291 use gfx namespace for DrawCommands
Change-Id: Ib2d97c4fee4e1bb433beeba4fb507fdc7d542af9
Reviewed-on: https://gerrit.libreoffice.org/68775
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 16:36:25 +01:00
Tomaž Vajngerl
c34f8f2233 Draw basic list{node,net,header} from the theme definition
Change-Id: I05b2cced0f99d6628a12465748820e3a87c5f3e7
Reviewed-on: https://gerrit.libreoffice.org/68774
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 16:35:53 +01:00
Tomaž Vajngerl
ddc8d51f09 Draw basic toolbar from the theme definition
Change-Id: I4d9935973bb6e46a7c5f17f914944f91a3e10a63
Reviewed-on: https://gerrit.libreoffice.org/68773
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 16:33:58 +01:00
Tomaž Vajngerl
c28104e0c2 Draw basic frame and window background from the theme definition
Change-Id: I2422650a155a874855ad4d72fa3bfd27b7d0da8a
Reviewed-on: https://gerrit.libreoffice.org/68772
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 16:33:38 +01:00
Tomaž Vajngerl
734a5cc1eb Draw basic listbox from the theme definition
Change-Id: Id3dd5aaa8b5537e5f740752cec292d6f4a44044e
Reviewed-on: https://gerrit.libreoffice.org/68771
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 16:33:22 +01:00
Tomaž Vajngerl
7894fd2b44 svgio visitor, add draw commands and create the from svg
Adds a visitor for svgio for visiting svg nodes and create something
useful from them.

Basic draw commands - a tree of draw commands (with sub-pixel
precision support) just to store a simple definition for drawing.

Adds a svg draw visitor and create draw commands from the svg
structure and expose the commands through UNO API.

Change-Id: I073e891a2cffdd76d4e3b838590e3a19c998e9bf
Reviewed-on: https://gerrit.libreoffice.org/68770
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06 16:33:06 +01:00
Caolán McNamara
de5dc664fc support large toolbar size
Change-Id: If24baee9a682006ff92e543eeb28490573b6cdec
Reviewed-on: https://gerrit.libreoffice.org/68805
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-06 15:37:33 +01:00
Caolán McNamara
930e252db3 hookup MenuButton::SetDropDown to GtkMenuButton draw-indicator
Change-Id: I556d61256bed8f607eed5a9c6e0ed3fcfd63af2c
Reviewed-on: https://gerrit.libreoffice.org/68802
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-06 15:37:20 +01:00
Stephan Bergmann
ec26772e2e Fix libtool RPATH outsmarting hack for external/librevenge
After the blind fix attempt of 490f07cf7235ab3c5dc4be13c53832e3266bd8e6 "Extend
libtool RPATH outsmarting hack to external/librevenge", appears that
<https://ci.libreoffice.org/job/lo_daily_update_gandalf/596/> also needs
runpath_var=LD_RUN_PATH to be reset.  (See also how
<https://src.fedoraproject.org/cgit/rpms/librevenge.git/tree/librevenge.spec
?id=4960d4c6c190885b20f56ce9ee1ad2ad92b87021#n46> addresses the same problem for
Fedora builds of librevenge.)

Change-Id: I5cff145605cd05a8b87360c1edc3574e3364139b
Reviewed-on: https://gerrit.libreoffice.org/68800
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06 14:25:50 +01:00
andreas kainz
7b69950a1a sync chart2 ui files with swriter ui files
Change-Id: I5c31fd0aef8d3a3e2ce4bcc6942f9cc06edff858
Reviewed-on: https://gerrit.libreoffice.org/68791
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06 12:26:32 +01:00
Noel Grandin
cfd080d00a loplugin:staticconstfield improve warning message
Change-Id: I000dff6b1b6e33e1b2c5aa337c027c1edd7b1003
Reviewed-on: https://gerrit.libreoffice.org/68795
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06 11:06:22 +01:00
Miklos Vajna
7e2a4f53a2 writerfilter: remove empty RTFPicture constructor
This is really just a reference-counted struct, not a real class.

Change-Id: Ifccd513e56632fd4df7711f7070188671b45e82d
Reviewed-on: https://gerrit.libreoffice.org/68777
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-06 09:06:03 +01:00
Stephan Bergmann
936308d3ef Introduce Int32ToSVBT32 for cases that apparently want to write a signed value
...and clean up some other (legitimate) uses of UInt32ToSVBT32 to not use a
(somewhat misleading) static_cast<long>(...)

Change-Id: Ifd0c3f771c3f6e20eef3413b9c27fd2514dc0c13
Reviewed-on: https://gerrit.libreoffice.org/68767
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06 08:28:58 +01:00
Stephan Bergmann
efcf8149b5 Record external/harfbuzz/msvc.patch as sent upstream
Change-Id: I47277272170508e9af7617e9b774bbdca05e9ec3
Reviewed-on: https://gerrit.libreoffice.org/68766
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06 08:28:42 +01:00
andreas kainz
668a3de9be sync sdraw and simpress ui files with swriter ui files
Change-Id: I321233437b573d254ca63aaf7274b54334ec066a
Reviewed-on: https://gerrit.libreoffice.org/68786
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06 08:21:02 +01:00
Samuel Mehrbrodt
0d2da0acfa tdf#123829 Respect CollapseEmptyCellPara setting when reading odf docs
Commit 56b2cf0c10d9caa01ebae1d80465e342d046a85c introduced a "feature"
which would hide an empty line after a table and only make it visible
when the cursor is in it.

So when loading an ODF doc, only enable this feature for which have the
CollapseEmptyCellPara setting set.

Change-Id: Ib4dfbbe8d45eb57547c51c7eee2f81331fc5300e
Reviewed-on: https://gerrit.libreoffice.org/68742
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-06 08:11:02 +01:00
Andrea Gelmini
3061ca82a3 Fix typo
Change-Id: I0b1c04b846ff5e6197fce59bd3c4325528169a7c
Reviewed-on: https://gerrit.libreoffice.org/68787
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-06 07:05:02 +01:00