and just use a scoped enum
Change-Id: Ie229d61866be4a03ccd93b73787b8813b9bd932d
Reviewed-on: https://gerrit.libreoffice.org/68744
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Move XPropertySet Java tests to C++ for ScDataPilotFieldObj.
Change-Id: I9fa5d153cced1aae8892d2422025dfcdcda73c69
Reviewed-on: https://gerrit.libreoffice.org/68782
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Move XNamed Java tests to C++ for ScDataPilotFieldObj.
Change-Id: Ieecd8799f56dcfa9279d4d523d470a62d9aed203
Reviewed-on: https://gerrit.libreoffice.org/68781
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
The assert in the bugreport is triggered by ScPrintFunc::CalcPages() passing
uninitialized values of nEndRow (and others). These variables apparently
get initialized only by constructors that take ScPrintState. These ctors
also set (the somewhat poorly named) bState and the call to CalcPages()
is guarded by this. However, GetPrintState() will simply create ScPrintState
filled with these uninitialized values and later on this will be used
with these ctors, so bState will be set, but nEndRow will be bogus.
Although 5217a2a0bf27e496cc429ee45dff7c239b466ae6 introduced tdf#121439,
this strange bState logic and unitialized variables has been these since
the initial commit, and the code doesn't take any precautions to check
whether the values are valid or not, so I assume this always was just lucky
enough to work and 5217a2a0bf finally triggered a problem.
Given that it's rather unclear to me how this is supposed to work properly,
just add an extra flag to both ScPrintFunc and ScPrintState marking whether
the values are set or not and make CalcPages() depends on this flag instead.
Change-Id: I0620de6562865c24f5a0edca2566b01546bf2e2b
Reviewed-on: https://gerrit.libreoffice.org/68739
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
Third token (i.e. day) would span to the end of the string
and conversion to int works just because it stops at first
non-numeric character.
Change-Id: I4f608aafadd634c312f7cfd986966f453bfca872
Reviewed-on: https://gerrit.libreoffice.org/68121
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
Also take care of handling possibly empty strings, for which
the initial 0 index would fail the comparison.
Change-Id: I280fac697554f2a4513a641ac258b1d2baf803f4
Reviewed-on: https://gerrit.libreoffice.org/68117
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
regression from...
commit 18d636063fd7be165e7888af49372a6e2b851776
Author: Caolán McNamara <caolanm@redhat.com>
Date: Mon Jun 19 09:46:31 2017 +0100
ofz: use OString instead of bare char*
this is no use to the reporter though, as the document format is
10 and 11 is the oldest the filter will open
Change-Id: I4cdfe92e37f047493a6eab95f0e8e9f5dced1a35
Reviewed-on: https://gerrit.libreoffice.org/68745
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Due to sw_redlinehide the SwTextNode::MakeFrame() is skipped on
SwTextNodes that are merged due to redlining. But then the
IgnoreStart/IgnoreEnd flags on the hints are not initialised and some
assert like assert(pHt->IsFormatIgnoreStart()) fails.
tdf90056-1.odt is an example document.
There doesn't appear to be a convenient place to initialise it per-node
as it is finished; the ODF import inserts APPEND_PARAGRAPH before
inserting the hints themselves.
So remove the initialisation from MakeFrame() and just do it in
SwReader::Read().
Change-Id: Ib33fe3033fc05bd2f5ef2ac8d059d587642ccf48
Reviewed-on: https://gerrit.libreoffice.org/68748
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
fixes a leak in the KeyList too
Change-Id: I603218ff99481bc006df329c770ea6fe6f147483
Reviewed-on: https://gerrit.libreoffice.org/68694
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
pg_config is meant for linking server extensions,
clients should use pkg-config instead to build against libpq.
This fixes build with PostgreSQL 11.
Change-Id: Ic0b5fc9cb7169f44c00a1edf7218212c360ec235
Reviewed-on: https://gerrit.libreoffice.org/68734
Tested-by: Jenkins
Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz>
should be comparing the values of the elements, not the pointers.
Regression from
commit 927447356fb7025d2b61073f525adc24643c7925
Date: Sat Sep 12 16:49:29 2015 -0600
replace boost::ptr_container with std::container<std::unique_ptr>
noticed while doing some other plugin work
Change-Id: I96230e52571e9a96e1c96f53f61bbc5afe902b31
Reviewed-on: https://gerrit.libreoffice.org/68738
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
